[Lldb-commits] [PATCH] D81516: [lldb/Test] Ensure inline tests have a unique build directory

JDevlieghere updated this revision to Diff 269713. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81516/new/ https://reviews.llvm.org/D81516 Files: lldb/packages/Python/lldbsuite/test/lldbinline.py

[Lldb-commits] [PATCH] D81516: [lldb/Test] Ensure inline tests have a unique build directory

vsk added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1750 +# (unique) test name is used instead. +inline_name = None +for attrname, attrvalue in attrs.items(): Is `inline_suffix =

[Lldb-commits] [PATCH] D81516: [lldb/Test] Ensure inline tests have a unique build directory

JDevlieghere added a comment. I discovered this because `TestBasicEntryValues.py` was failing with the reproducers. Because the paths to the binaries were the same, we'd end up with only the GNU variant of the binary in the VFS. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D81516: [lldb/Test] Ensure inline tests have a unique build directory

JDevlieghere created this revision. JDevlieghere added reviewers: labath, vsk. Herald added a subscriber: aprantl. JDevlieghere added a comment. I discovered this because `TestBasicEntryValues.py` was failing with the reproducers. Because the paths to the binaries were the same, we'd end up with

[Lldb-commits] [lldb] 7dd86c9 - [lldb/Reproducers] Skip test_remove_placeholder_add_real_module with reproducers

Author: Jonas Devlieghere Date: 2020-06-09T16:17:53-07:00 New Revision: 7dd86c9e7caa8f226e48b59caf9f0a38789ce164 URL: https://github.com/llvm/llvm-project/commit/7dd86c9e7caa8f226e48b59caf9f0a38789ce164 DIFF:

[Lldb-commits] [PATCH] D81501: [lldb/CMake] Make it possible to build against Python 2 with CMake > 3.12

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c0afacada0d: [lldb/CMake] Add LLDB_PYTHON_VERSION to use Python 2 with CMake 3.12 (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D81501: [lldb/CMake] Make it possible to build against Python 2 with CMake > 3.12

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Would be nice to remove this entirely in favour of CMake's builtin support for Python Interpeter and Libraries. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D81501: [lldb/CMake] Make it possible to build against Python 2 with CMake > 3.12

JDevlieghere added a comment. In D81501#2083359 , @compnerd wrote: > Would be nice to remove this entirely in favour of CMake's builtin support > for Python Interpeter and Libraries. It'll continue to exist to find Python and SWIG atomically, but at

[Lldb-commits] [PATCH] D81501: [lldb/CMake] Make it possible to build against Python 2 with CMake > 3.12

JDevlieghere created this revision. JDevlieghere added reviewers: compnerd, jingham, labath. JDevlieghere added a project: LLDB. Herald added a subscriber: mgorny. compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Would be nice to remove

[Lldb-commits] [lldb] 2c0afac - [lldb/CMake] Add LLDB_PYTHON_VERSION to use Python 2 with CMake > 3.12

Author: Jonas Devlieghere Date: 2020-06-09T14:11:11-07:00 New Revision: 2c0afacada0d1488bc88b1211203ea4fdb0a23e8 URL: https://github.com/llvm/llvm-project/commit/2c0afacada0d1488bc88b1211203ea4fdb0a23e8 DIFF:

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGfac5d05eb75f: [lldb] Fix and enable Windows minidump tests (authored by jarin). Changed prior to commit: https://reviews.llvm.org/D81465?vs=269609=269649#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham. This replaces the (only) call to `llvm::sys::fs::openFileForWrite` with `FileSystem::Open`. This guarantees that we include log files in the reproducers. Repository: rLLDB LLDB

[Lldb-commits] [lldb] fac5d05 - [lldb] Fix and enable Windows minidump tests

Author: Jaroslav Sevcik Date: 2020-06-09T20:03:44Z New Revision: fac5d05eb75fab163dc316859fa5e7d255b98f7c URL: https://github.com/llvm/llvm-project/commit/fac5d05eb75fab163dc316859fa5e7d255b98f7c DIFF: https://github.com/llvm/llvm-project/commit/fac5d05eb75fab163dc316859fa5e7d255b98f7c.diff

[Lldb-commits] [lldb] 6c5c4a2 - [lldb/Reproducers] Also collect ::open and ::fopen

Author: Jonas Devlieghere Date: 2020-06-09T11:59:02-07:00 New Revision: 6c5c4a2a50e1fcdd94c0288008af65c544a96452 URL: https://github.com/llvm/llvm-project/commit/6c5c4a2a50e1fcdd94c0288008af65c544a96452 DIFF:

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

jarin updated this revision to Diff 269609. jarin added a comment. Added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81465/new/ https://reviews.llvm.org/D81465 Files: lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py Index:

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

This revision was automatically updated to reflect the committed changes. Closed by commit rGde019b88dd58: [lldb/Interpreter] Support color in CommandReturnObject (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81058/new/

[Lldb-commits] [lldb] de019b8 - [lldb/Interpreter] Support color in CommandReturnObject

Author: Jonas Devlieghere Date: 2020-06-09T10:45:45-07:00 New Revision: de019b88dd5804ec996fe8c12cddcc6feb13afa1 URL: https://github.com/llvm/llvm-project/commit/de019b88dd5804ec996fe8c12cddcc6feb13afa1 DIFF:

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

JDevlieghere updated this revision to Diff 269576. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Update ctors in lldb-test and unit test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81058/new/ https://reviews.llvm.org/D81058 Files:

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

JDevlieghere updated this revision to Diff 269573. JDevlieghere added a comment. - Remove default value for color in CommandReturnObject. - Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81058/new/ https://reviews.llvm.org/D81058 Files:

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/Stream.h:402-403 +bool has_colors() const override { return true; } + uint64_t current_pos() const override { labath wrote: > This

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for getting back to this. I think this is a good workaround for the problem (maybe it would be good to make a note of that in the comment). The `fullpath` implementation should be

[Lldb-commits] [lldb] 70a2188 - [lldb] Test compatibility between a class type from a member function expr and its original version

Author: Raphael Isemann Date: 2020-06-09T15:48:00+02:00 New Revision: 70a21887f7bd0b38e7c0676d8b25cc8a9980e009 URL: https://github.com/llvm/llvm-project/commit/70a21887f7bd0b38e7c0676d8b25cc8a9980e009 DIFF:

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. jarin edited the summary of this revision. SBFileSpec.fullpath always uses the forward slash to join the directory with the base name. This causes mismatches when

[Lldb-commits] [PATCH] D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rGfd31e60b8ded: [nfc] [lldb] Reduce GetAttributess depth parameter usage (authored by jankratochvil). Changed prior to commit:

[Lldb-commits] [PATCH] D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

jankratochvil marked 5 inline comments as done. jankratochvil added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_TAG_GNU_call_site-DW_AT_low_pc.s:46 + callb +int3 + ret labath wrote: > This is formatted strangely. Tab

[Lldb-commits] [PATCH] D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rG4515d35f5c9e: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC (authored by jankratochvil). Changed prior to commit:

[Lldb-commits] [PATCH] D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage

jankratochvil marked 4 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:733 DWARFAttributes attributes; - GetAttributes(cu, attributes); + GetAttributes(cu, attributes, 0 /* curr_depth

[Lldb-commits] [lldb] 4515d35 - [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

Author: Jan Kratochvil Date: 2020-06-09T13:41:41+02:00 New Revision: 4515d35f5c9e2bdcdbcb9fe9028d4a84871958c5 URL: https://github.com/llvm/llvm-project/commit/4515d35f5c9e2bdcdbcb9fe9028d4a84871958c5 DIFF:

[Lldb-commits] [lldb] fd31e60 - [nfc] [lldb] Reduce GetAttributes's depth parameter usage

Author: Jan Kratochvil Date: 2020-06-09T13:41:06+02:00 New Revision: fd31e60b8ded16754f484b51c2e5f8da05ad8331 URL: https://github.com/llvm/llvm-project/commit/fd31e60b8ded16754f484b51c2e5f8da05ad8331 DIFF:

[Lldb-commits] [lldb] 17798c6 - [lldb] Fix -Wmissing-field-initializers in StackFrameList

Author: Pavel Labath Date: 2020-06-09T11:58:08+02:00 New Revision: 17798c60bcc284e45529d6afde11bf59ffc549c8 URL: https://github.com/llvm/llvm-project/commit/17798c60bcc284e45529d6afde11bf59ffc549c8 DIFF: https://github.com/llvm/llvm-project/commit/17798c60bcc284e45529d6afde11bf59ffc549c8.diff

[Lldb-commits] [PATCH] D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.h:113 - size_t GetAttributes(DWARFAttributes , uint32_t depth = 0) const; + size_t

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

labath added a comment. I think this looks good now. All that's now left is a test case. I think it should be possible to test this in a number of ways: - CommandReturnObject unittest - a shell test which forces `use-color` to true - a python test which forces `use-color` to true - a pexpect

[Lldb-commits] [PATCH] D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:733 DWARFAttributes attributes; - GetAttributes(cu, attributes); + GetAttributes(cu,