[Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

dblaikie created this revision. dblaikie added a reviewer: labath. dblaikie requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. gcc already produces debug info with this form -freorder-block-and-part

[Lldb-commits] [PATCH] D94064: lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms

dblaikie created this revision. dblaikie added a reviewer: labath. dblaikie requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Finishing out the support (to the best of my knowledge/based on current testing running the whole check-lldb with a

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat created this revision. Herald added a subscriber: arphaman. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add unscoped enumeration members to the "globals" manual dwarf index. This effectively makes them discoverable as global

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat updated this revision to Diff 314558. werat added a comment. Herald added a subscriber: JDevlieghere. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94077/new/ https://reviews.llvm.org/D94077 Files: lldb/source/Plugins/Expres

[Lldb-commits] [PATCH] D94084: [lldb][ARM/AArch64] Update disasm flags to latest v8.7a ISA

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add optional memory tagging extension on AArch64. Use isAArch64() instead of listing th

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat added a comment. @labath @jankratochvil ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92643/new/ https://reviews.llvm.org/D92643 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

balazske added a comment. The problem is reproduced and fixed in D94067 . It is caused by import of default template arguments indirectly, because that import causes lot of other things to be imported. And the import of default arguments happens in a incomplete

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

balazske added a comment. There are still problems related to import type argument default values: If there are forward declarations of the same template, the "inheritedness" of these arguments (in AST) is not set correctly and the default arguments can appear at more places instead of at only

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

JDevlieghere added a comment. Your argument is correct because the interactive script interpreter always belongs to a single debugger. That being said, I don't like this for a few reasons: - LLDB supports multiple debuggers and the relationship between the script interpreter and the debugger a

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 updated this revision to Diff 314641. augusto2112 added a comment. Herald added a subscriber: dang. Adds support to 'vAttachOrWait', as well as the 'waitfor-interval' and 'waitfor-duration' flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 marked an inline comment as done. augusto2112 added a comment. @clayborg I've added support for the 'waitfor-interval' and 'waitfor-duration' flags. Yesterday I thought they existed in macOS, but now I'm not so sure, as I couldn't find them on "Options.td". They were added in 2009, s

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. Question: why does lldb queries if vAttachOrWait is supported, but not vAttachWait? Does it make sense to keep this query? Or should I remove it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93895/new/ https://reviews

[Lldb-commits] [lldb] c82beab - [lldb] Add timers to Reproducer::Keep and Reproducer::Discard

Author: Jonas Devlieghere Date: 2021-01-05T09:54:31-08:00 New Revision: c82beaba319657d93a62523a65f8969aad9ecab1 URL: https://github.com/llvm/llvm-project/commit/c82beaba319657d93a62523a65f8969aad9ecab1 DIFF: https://github.com/llvm/llvm-project/commit/c82beaba319657d93a62523a65f8969aad9ecab1.d

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

JDevlieghere added inline comments. Comment at: lldb/bindings/lua/lua-wrapper.swig:25-29 + auto extra_args = [&]() -> llvm::Optional { + if (extra_args_impl == nullptr) + return {}; + return lldb::SBStructuredData(extra_args_impl); + } (); I

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

shafik added a comment. We can have unscoped enums in namespace and class scope and the enumerators won't leak out from those scopes. Thus we can have shadowing going on e.g.: #include enum GEnum {eOne=2,}; namespace A { enum AEnum {eOne=0,}; void g() {std::cout << eOne;

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

clayborg added a comment. In D93895#2479845 , @augusto2112 wrote: > Question: why does lldb queries if vAttachOrWait is supported, but not > vAttachWait? Does it make sense to keep this query? Or should I remove it? "vAttachOrWait" allows you to attach t

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. > So it might be nice to add support for vAttachOrWait, along with the query > packet, in this patch if you have the time? Hi @clayborg, I saw that that implementing vAttachOrWait was already 90% done, so I did just that :) The current patch as-is supports vAttachOr

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

clayborg added a comment. In D93895#2480324 , @augusto2112 wrote: >> So it might be nice to add support for vAttachOrWait, along with the query >> packet, in this patch if you have the time? > > Hi @clayborg, I saw that implementing vAttachOrWait was alre

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

clayborg added a comment. Another option would be to have lldb-server check for environment variables for default values for --waitfor-interval and --waitfor-duration. If they are set, they become the new default values. Of course a user can launch the lldb-server manually with the options set

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. > Here lies the problem that I mentioned above. I would like to avoid having to > launch lldb-server with any arguments so that we continue to work with older > lldb-servers. > So maybe we just rely on defaults for now and avoid having to add any new > arguments

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

clayborg added a comment. In D93895#2480554 , @augusto2112 wrote: >> Here lies the problem that I mentioned above. I would like to avoid having >> to launch lldb-server with any arguments so that we continue to work with >> older lldb-servers. > > > >> S

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

augusto2112 added a comment. I think I get your point. If we pass the extra options in the packet, the validation on older lldb-server versions will reject the message. > Another option would be to have lldb-server check for environment variables > for default values for --waitfor-interval and

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

clayborg added a comment. In D93895#2480578 , @augusto2112 wrote: > I think I get your point. If we pass the extra options in the packet, the > validation on older lldb-server versions will reject the message. > >> Another option would be to have lldb-ser

[Lldb-commits] [PATCH] D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header.

jgorbe added a comment. Thanks for accepting the patch! (and sorry for the late reply, I was on vacation). I'll commit this now :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93444/new/ https://reviews.llvm.org/D93444 __

[Lldb-commits] [PATCH] D94136: [lldb] Make ModuleList iterable (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. Add begin and end iterators to the ModuleList so we can use range-based for loops. https://reviews.llvm.org/D94136 Files: lldb/include/l

[Lldb-commits] [PATCH] D94136: [lldb] Make ModuleList iterable (NFC)

dblaikie added inline comments. Comment at: lldb/include/lldb/Core/ModuleList.h:70 +class ModuleIterator +: public std::iterator { +public: FWIW, std::iterator is deprecated since C++17 - probably best not to add new uses of it. (I think the idea is that the

[Lldb-commits] [lldb] a39b198 - Make DWARFUnit use the dwo_id from the DWARF5 CU header.

Author: Jorge Gorbe Moya Date: 2021-01-05T16:40:37-08:00 New Revision: a39b19821b6b8c6b4ae853f6b6a88128275ea2c7 URL: https://github.com/llvm/llvm-project/commit/a39b19821b6b8c6b4ae853f6b6a88128275ea2c7 DIFF: https://github.com/llvm/llvm-project/commit/a39b19821b6b8c6b4ae853f6b6a88128275ea2c7.di

[Lldb-commits] [PATCH] D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa39b19821b6b: Make DWARFUnit use the dwo_id from the DWARF5 CU header. (authored by jgorbe). Changed prior to commit: https://reviews.llvm.org/D93

[Lldb-commits] [PATCH] D94136: [lldb] Make ModuleList iterable (NFC)

JDevlieghere updated this revision to Diff 314755. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Use `iterator_facade_base` as suggested by @dblaikie. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94136/new/ https://reviews.llvm.org/D94136 Files: lldb/i

[Lldb-commits] [PATCH] D94136: [lldb] Make ModuleList iterable (NFC)

dblaikie added inline comments. Comment at: lldb/include/lldb/Core/ModuleList.h:71 +: public llvm::iterator_facade_base< + ModuleIterator, std::bidirectional_iterator_tag, lldb::ModuleSP> { +public: On the fence, but this could be a random access ite

[Lldb-commits] [PATCH] D94136: [lldb] Make ModuleList iterable (NFC)

JDevlieghere updated this revision to Diff 314767. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Address Dave's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94136/new/ https://reviews.llvm.org/D94136 Files: lldb/include/lldb/Core/ModuleList.h

[Lldb-commits] [PATCH] D94136: [lldb] Make ModuleList iterable (NFC)

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me with a few minor cleanups. Comment at: lldb/include/lldb/Core/ModuleList.h:73-74 +public: + explicit ModuleIterator(const ModuleList *module_list, size_

[Lldb-commits] [PATCH] D94136: [lldb] Make ModuleList iterable (NFC)

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/ModuleList.h:73-74 +public: + explicit ModuleIterator(const ModuleList *module_list, size_t idx); + ModuleIterator(const ModuleList *module_list); + dblaikie wrote: > Interesting choice to m

[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

vwzm228 added a comment. Herald added a subscriber: JDevlieghere. Is there any progress about such patch and D78801 ？ I have implemented the debugging feature in our Wasm VM based on https://reviews.llvm.org/D78801, and it already work to attach, set breakpoint