[Lldb-commits] [lldb] da0b62d - Revert a LIT typo fix in a RUN line

Author: Qiu Chaofan Date: 2021-10-09T11:29:44+08:00 New Revision: da0b62dfb3ca597f618b1f88226b440bc7ca3960 URL: https://github.com/llvm/llvm-project/commit/da0b62dfb3ca597f618b1f88226b440bc7ca3960 DIFF: https://github.com/llvm/llvm-project/commit/da0b62dfb3ca597f618b1f88226b440bc7ca3960.diff

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

jingham added a comment. In D109738#3052661 , @ted wrote: > In D109738#3052624 , @jingham wrote: > >> That is clearly wrong: an address is never enough to restore a breakpoint >> from one session to the next

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

ted added a comment. In D109738#3052624 , @jingham wrote: > That is clearly wrong: an address is never enough to restore a breakpoint > from one session to the next even if you can turn ASLR off. After all, the > breakpoint could be in a dlopened

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

d-millar added a comment. That discussion is extremely helpful - gives me good context for what I need to suport. THANKS! From: lldb-commits on behalf of Jim Ingham via Phabricator via lldb-commits Sent: Friday, October 8, 2021 5:44:49 PM To:

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

d-millar added subscribers: DavidSpickett, djtodoro, HirokiImai, jingham, ZeeZeeMorin, SouraVX, serhiy.redko, vadimcn, d-millar. d-millar added a comment. That discussion is extremely helpful - gives me good context for what I need to suport. THANKS! From:

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

jingham added a comment. I realized I typed this all down a while ago but forgot to hit submit. I think I still agree with former me... In D109738#3002257 , @vadimcn wrote: > Hi Jim, > I think there's a bit of confusion going on here: > The original

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

jingham added a comment. Sounds good. When we started adding extension points for python, we made the implementations be free functions. But then over time we realized it was often more convenient if you had a object managing the callback, that way it could more easily store state over the

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar added a comment. Discussing it with developers here, they agreed with your opinion that we really really ought to do 2.  As you just noted, 3 is trickier. Java doesn't really have a REPL. It has jshell - we're not sure that counts. In any case, am up for tackling 2. Will keep

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

jingham added a comment. In D111409#3052192 , @d-millar wrote: > Just to clarify my use case: I am one of the developers for a > reverse-engineering tool called Ghidra. Part of the tool is > debugging-support to allow cross-over between dynamic and

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn added a comment. @JDevlieghere: ping.Or are you saying you wouldn't consider landing such a change at all? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109738/new/ https://reviews.llvm.org/D109738

[Lldb-commits] [PATCH] D111452: [lldb/Plugins] Replace platform-specific macro with LLVM_PRETTY_FUNCTION (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG88a941ba64a3: [lldb/Plugins] Replace platform-specific macro with LLVM_PRETTY_FUNCTION (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 88a941b - [lldb/Plugins] Replace platform-specific macro with LLVM_PRETTY_FUNCTION (NFC)

Author: Med Ismail Bennani Date: 2021-10-08T20:50:45+02:00 New Revision: 88a941ba64a3824e1a6bac178034e4fce548f6cb URL: https://github.com/llvm/llvm-project/commit/88a941ba64a3824e1a6bac178034e4fce548f6cb DIFF:

[Lldb-commits] [PATCH] D111452: [lldb/Plugins] Replace platform-specific macro with LLVM_PRETTY_FUNCTION (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111452/new/ https://reviews.llvm.org/D111452

[Lldb-commits] [PATCH] D111452: [lldb/Plugins] Replace platform-specific macro with LLVM_PRETTY_FUNCTION (NFC)

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch refactors Scripted Process and Scripted Thread related classes to use LLVM_PRETTY_FUNCTION instead of the compiler

Re: [Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

Just to clarify my use case: I am one of the developers for a reverse-engineering tool called Ghidra. Part of the tool is debugging-support to allow cross-over between dynamic and static analysis. We currently support windbg/kd, the gcc MI2 interface, and direct Java debugging. I have a

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

jingham added a comment. Support for a scripting language in lldb has three distinct pieces. 1. Making the SB API's available to the scripting languages 2. Adding all the callbacks so the scripting language can be used for breakpoint callbacks, data formatters, etc. 3. Adding a REPL for that

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar added a comment. Ah, OK, after more digging, I realize I have probably provided only half of what you would like for this commit. My primary intention was to expose the SB API so I could make calls from Java into it, but for it to be, in some sense, a full-fledged member of the API,

Re: [Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

I'm not sure I understand your testing strategy, in particular how it applies to the existing Lua and Python extensions. I am looking at the files in lldb/unittests/ScriptInterpreter/Lua Do you execute test from native Lua/Python environments or through C wrappers-only? You mentioned a bot -

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar updated this revision to Diff 378288. d-millar added a comment. FIx for potential conflicts with master. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111409/new/ https://reviews.llvm.org/D111409 Files: lldb/bindings/java/java-typemaps.swig

[Lldb-commits] [PATCH] D111399: [lldb] Make char[N] formatters respect the end of the array (PR44649)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, but maybe give the test comment a FIXME. Comment at: lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:39 + //%

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar updated this revision to Diff 378282. d-millar added a comment. Another (hopefully cleaner) attempt. If the addition of SBTraceOptions in lldb/source/API/CMakelists.txt conflicts, please feel free to delete it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

mib added a comment. In D107585#3051607 , @stella.stamenova wrote: > This broke the windows lldb bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/10836 This should be fixed with f94c9af6227f49c5da5bf1c9f97fdf887d26774c

[Lldb-commits] [lldb] f94c9af - [lldb] Fix windows build failure due to undefined macro

Author: Med Ismail Bennani Date: 2021-10-08T18:27:21+02:00 New Revision: f94c9af6227f49c5da5bf1c9f97fdf887d26774c URL: https://github.com/llvm/llvm-project/commit/f94c9af6227f49c5da5bf1c9f97fdf887d26774c DIFF:

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

mib added a comment. In D111409#3051556 , @d-millar wrote: > Hmmm, well, have tried running "git clang-format" with a few different > invocations, but seem to always get "No modified files to format." > Suggestions? I was confused by the `patch`

[Lldb-commits] [PATCH] D111435: [lldb] [DynamicRegisterInfo] Support setting from vector

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. Add an overload of DynamicRegisterInfo::SetRegisterInfo() that accepts a std::vector as an argument. This moves the conversion from DRI::Register to

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

mib added a comment. In D107585#3051607 , @stella.stamenova wrote: > This broke the windows lldb bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/10836

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

stella.stamenova added a comment. This broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/10836 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107585/new/ https://reviews.llvm.org/D107585

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar added a comment. Hmmm, well, have tried running "git clang-format" with a few different invocations, but seem to always get "No modified files to format." Suggestions? From: David Millar via Phabricator Sent: Friday, October 8, 2021 11:33:37 AM To:

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

ljmf00 updated this revision to Diff 378255. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110578/new/ https://reviews.llvm.org/D110578 Files: lldb/include/lldb/Core/Mangled.h lldb/source/Core/Mangled.cpp lldb/source/Symbol/Symtab.cpp

Re: [Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

Merde - I followed you instructions but forgot to run clang-format. Give me a minute From: Raphael Isemann via Phabricator Sent: Friday, October 8, 2021 11:24:10 AM To: David Millar; anoro...@apple.com; fallk...@yahoo.com; kkle...@redhat.com;

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar updated this revision to Diff 378237. d-millar added a comment. supplying a better patch file Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111409/new/ https://reviews.llvm.org/D111409 Files: lldb/bindings/java/CMakeLists.txt patch Index: patch

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

teemperor added a comment. No problem, first time using Phabricator is always a bit confusing. You can just do a `git diff -U99 > ~/java-patch.diff`, click the "Update Diff" button on the top right of this website and then select *just* this diff file that contains your changes.

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

mib added a comment. In D111409#3051140 , @d-millar wrote: > Am obviously brand new to your process and a bit of an old dog when it comes > to learning new tricks. Would you prefer I make a new submission with the > -U99 diff? Also, am more than

Re: [Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

Am obviously brand new to your process and a bit of an old dog when it comes to learning new tricks. Would you prefer I make a new submission with the -U99 diff? Also, am more than willing to help with the Java tests if that would be useful. From:

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

teemperor added a comment. In D111409#3051110 , @d-millar wrote: > Apologies for the inclusion of that last file "patch" - that is the "git diff > -U999" result, should that be useful. You can just upload that diff file and Phabricator will display

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar added a comment. Apologies for the inclusion of that last file "patch" - that is the "git diff -U999" result, should that be useful. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111409/new/ https://reviews.llvm.org/D111409

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar created this revision. d-millar added a reviewer: LLDB. Herald added subscribers: teemperor, mgorny. d-millar requested review of this revision. The patch include files necessary to extend the Scripting Bridge API with Java. The edits follow the existing patterns for Python and Lua.

[Lldb-commits] [PATCH] D111408: [lldb] [DynamicRegisterInfo] Remove non-const GetRegisterInfoAtIndex()

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. Herald added a subscriber: arphaman. mgorny requested review of this revision. https://reviews.llvm.org/D111408 Files: lldb/include/lldb/Target/DynamicRegisterInfo.h

[Lldb-commits] [lldb] 815c87f - [lldb/test] Disable TestScriptedProcess.py unless Darwin

Author: Med Ismail Bennani Date: 2021-10-08T15:19:54+02:00 New Revision: 815c87fbe20a66d28e4d09af89a39cb39270dcf0 URL: https://github.com/llvm/llvm-project/commit/815c87fbe20a66d28e4d09af89a39cb39270dcf0 DIFF:

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa758c9f7204c: [lldb/Plugins] Add memory region support in ScriptedProcess (authored by mib). Changed prior to commit:

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59d8dd79e1f9: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess (authored by mib). Changed prior to commit:

[Lldb-commits] [lldb] a758c9f - [lldb/Plugins] Add memory region support in ScriptedProcess

Author: Med Ismail Bennani Date: 2021-10-08T14:54:07+02:00 New Revision: a758c9f7204c41d8791e76d24f9bc4791534f1b8 URL: https://github.com/llvm/llvm-project/commit/a758c9f7204c41d8791e76d24f9bc4791534f1b8 DIFF:

[Lldb-commits] [lldb] 59d8dd7 - [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

Author: Med Ismail Bennani Date: 2021-10-08T14:54:07+02:00 New Revision: 59d8dd79e1f9dead2dc2756e139073083e487228 URL: https://github.com/llvm/llvm-project/commit/59d8dd79e1f9dead2dc2756e139073083e487228 DIFF:

[Lldb-commits] [PATCH] D111402: [lldb] [test] Use secondary pty end for testing Terminal

This revision was automatically updated to reflect the committed changes. Closed by commit rG71fd5a735ec2: [lldb] [test] Use secondary pty end for testing Terminal (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 71fd5a7 - [lldb] [test] Use secondary pty end for testing Terminal

Author: Michał Górny Date: 2021-10-08T14:42:47+02:00 New Revision: 71fd5a735ec2f30105249dc367754a604ad00308 URL: https://github.com/llvm/llvm-project/commit/71fd5a735ec2f30105249dc367754a604ad00308 DIFF: https://github.com/llvm/llvm-project/commit/71fd5a735ec2f30105249dc367754a604ad00308.diff

[Lldb-commits] [PATCH] D111402: [lldb] [test] Use secondary pty end for testing Terminal

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. If Green Dragon was still with us this would make it happy (and green), so LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111402/new/ https://reviews.llvm.org/D111402

[Lldb-commits] [PATCH] D111402: [lldb] [test] Use secondary pty end for testing Terminal

mgorny created this revision. mgorny added reviewers: teemperor, labath, krytarowski, emaste. mgorny requested review of this revision. Open and use the secondary end of a pty for testing Terminal properties in order to fix the tests on Darwin. While at it, streamline getting the fd and Terminal

[Lldb-commits] [PATCH] D111399: [lldb] Make char[N] formatters respect the end of the array (PR44649)

labath added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:42-43 +//% self.expect_var_path("a.data", summary='"FOOB"') +// Should this be "FO\0B" instead? +//% self.expect_var_path("b.data", summary='"FO"') }

[Lldb-commits] [PATCH] D111399: [lldb] Make char[N] formatters respect the end of the array (PR44649)

labath created this revision. labath added reviewers: teemperor, jingham. labath requested review of this revision. Herald added a project: LLDB. I believe this is a more natural behavior, and it also matches what gdb does. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111399

[Lldb-commits] [PATCH] D111396: [lldb] [ConnectionFileDescriptorPosix] Combine m_read_sp & m_write_sp

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. Combine m_read_sp and m_write_sp into a single m_io_sp. In all currently existing code paths, they are pointing to the same object anyway.

[Lldb-commits] [PATCH] D111321: [lldb] [ConnectionFileDescriptorPosix] Refactor scheme matching

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b46a4134385: [lldb] [ConnectionFileDescriptorPosix] Refactor scheme matching (authored by mgorny). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [lldb] 4b46a41 - [lldb] [ConnectionFileDescriptorPosix] Refactor scheme matching

Author: Michał Górny Date: 2021-10-08T11:47:57+02:00 New Revision: 4b46a4134385eda6449e93ad124f9b2685b25bb2 URL: https://github.com/llvm/llvm-project/commit/4b46a4134385eda6449e93ad124f9b2685b25bb2 DIFF: https://github.com/llvm/llvm-project/commit/4b46a4134385eda6449e93ad124f9b2685b25bb2.diff

[Lldb-commits] [PATCH] D111314: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcb0e687faeb: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] dcb0e68 - [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile

Author: Michał Górny Date: 2021-10-08T11:26:29+02:00 New Revision: dcb0e687faebb8b8c31f61a0deb8c583125ffc72 URL: https://github.com/llvm/llvm-project/commit/dcb0e687faebb8b8c31f61a0deb8c583125ffc72 DIFF: https://github.com/llvm/llvm-project/commit/dcb0e687faebb8b8c31f61a0deb8c583125ffc72.diff

[Lldb-commits] [lldb] f4145c0 - [lldb/gdb-remote] Refactor ReadExtFeature

Author: Pavel Labath Date: 2021-10-08T10:43:37+02:00 New Revision: f4145c074cb81441f2e4a965f618f9949fa4f071 URL: https://github.com/llvm/llvm-project/commit/f4145c074cb81441f2e4a965f618f9949fa4f071 DIFF: https://github.com/llvm/llvm-project/commit/f4145c074cb81441f2e4a965f618f9949fa4f071.diff

[Lldb-commits] [lldb] 3d7161e - [lldb] Remove shared_ptr from some global Properties objects

Author: Pavel Labath Date: 2021-10-08T10:43:37+02:00 New Revision: 3d7161e3c14c25a60a3c03aa4c07a1dc4e35511b URL: https://github.com/llvm/llvm-project/commit/3d7161e3c14c25a60a3c03aa4c07a1dc4e35511b DIFF: https://github.com/llvm/llvm-project/commit/3d7161e3c14c25a60a3c03aa4c07a1dc4e35511b.diff

[Lldb-commits] [PATCH] D111314: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile

labath added a comment. In D111314#3050392 , @mgorny wrote: > In D111314#3050383 , @labath wrote: > >> At one point these didn't use to be shared pointers so we couldn't copy them >> like this, though I am still

[Lldb-commits] [PATCH] D111321: [lldb] [ConnectionFileDescriptorPosix] Refactor scheme matching

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. thanks Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:142-143 + auto method = + llvm::StringSwitch>(scheme) +

[Lldb-commits] [PATCH] D111314: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile

mgorny added a comment. In D111314#3050383 , @labath wrote: > At one point these didn't use to be shared pointers so we couldn't copy them > like this, though I am still unclear as to why we need two of them in the > first place. Actually, I've asked

[Lldb-commits] [PATCH] D111314: [lldb] [ConnectionFileDescriptorPosix] Use a single NativeFile

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. At one point these didn't use to be shared pointers so we couldn't copy them like this, though I am still unclear as to why we need two of them in the first place. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D111387: [NFC] [Clang] Remove pre-computed complex float types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00c0ce0655da: [NFC] [Clang] Remove pre-computed complex float types (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 00c0ce0 - [NFC] [Clang] Remove pre-computed complex float types

Author: Qiu Chaofan Date: 2021-10-08T15:52:16+08:00 New Revision: 00c0ce0655da804c2ffb1a2a807052298032acc6 URL: https://github.com/llvm/llvm-project/commit/00c0ce0655da804c2ffb1a2a807052298032acc6 DIFF: https://github.com/llvm/llvm-project/commit/00c0ce0655da804c2ffb1a2a807052298032acc6.diff

[Lldb-commits] [PATCH] D111387: [NFC] [Clang] Remove pre-computed complex float types

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Would be nice to have the motivation for this in the commit message (IIUC this is based on the suggestion from D109948

[Lldb-commits] [PATCH] D111387: [NFC] [Clang] Remove pre-computed complex float types

qiucf created this revision. qiucf added reviewers: rjmccall, teemperor. qiucf requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111387 Files: