[Lldb-commits] [PATCH] D124113: [lldb] Adjust libc++ string formatter for changes in D123580

shafik added a comment. Thank you, the names make a lot more sense to me but I am not sure why this was originally used either. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:648 + ValueObjectSP location_sp = +

[Lldb-commits] [lldb] e3cd8fe - [LLDB] Skip TestCrashDuringStep.py AArch64/Windows

Author: Muhammad Omair Javaid Date: 2022-04-21T05:10:37+05:00 New Revision: e3cd8fedcac31a037a38889abace9e0d0205c451 URL: https://github.com/llvm/llvm-project/commit/e3cd8fedcac31a037a38889abace9e0d0205c451 DIFF:

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

clayborg added a comment. I might suggest we rename things like suggested in my inline comment, and then have the "SymbolFile.h" class just include the extra needed header file? Many of the changes in this diff would just go away. I am not a fan of the SymbolFileActual class nor having to

[Lldb-commits] [PATCH] D124113: [lldb] Adjust libc++ string formatter for changes in D123580

philnik added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:658 + if (!using_bitmasks) +capacity *= 2; if (size == LLDB_INVALID_OFFSET || capacity == LLDB_INVALID_OFFSET || This should only be done if the string is in the

[Lldb-commits] [lldb] 5341b5f - [LLDB] Update inspect getargspec to getfullargspec

Author: Muhammad Omair Javaid Date: 2022-04-21T01:33:26+05:00 New Revision: 5341b5f8d3cec9a38867bc4745fd680946300b87 URL: https://github.com/llvm/llvm-project/commit/5341b5f8d3cec9a38867bc4745fd680946300b87 DIFF:

[Lldb-commits] [PATCH] D121786: [LLDB] Update inspect getargspec to getfullargspec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5341b5f8d3ce: [LLDB] Update inspect getargspec to getfullargspec (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D124113: [lldb] Adjust libc++ string formatter for changes in D123580

labath created this revision. labath added reviewers: shafik, JDevlieghere, philnik. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. The code needs more TLC, but for now I've tried making only the changes that are necessary to get the tests

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 423974. yinghuitan added a comment. Rebase on top of https://reviews.llvm.org/D124110 Rename test file name to avoid conflict Added a new totalModuleCountHasDebugInfo statistics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, JDevlieghere. Herald added a subscriber: mgorny. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a

[Lldb-commits] [PATCH] D124061: [LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of order.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fa2734690ff: [LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of… (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D124061?vs=423800=423957#toc

[Lldb-commits] [lldb] 2fa2734 - [LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of order.

Author: Zequan Wu Date: 2022-04-20T10:33:00-07:00 New Revision: 2fa2734690ff6debf2d678dc9f94fa14e0cbd227 URL: https://github.com/llvm/llvm-project/commit/2fa2734690ff6debf2d678dc9f94fa14e0cbd227 DIFF: https://github.com/llvm/llvm-project/commit/2fa2734690ff6debf2d678dc9f94fa14e0cbd227.diff

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

philnik added inline comments. Comment at: libcxx/utils/gdb/libcxx/printers.py:192 class StdStringPrinter(object): """Print a std::string.""" labath wrote: > philnik wrote: > > dblaikie wrote: > > > philnik wrote: > > > > jgorbe wrote: > > > > > Mordante

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

philnik updated this revision to Diff 423841. philnik added a comment. - Try to fix Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123580/new/ https://reviews.llvm.org/D123580 Files: libcxx/include/string

[Lldb-commits] [PATCH] D121876: [BOLT][DWARF] Implement monolithic DWARF5.

DavidSpickett added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s:17 -# RUN: %clang_host -o %t %s \ +# RUN: %clang_host -gdwarf-4 -o %t %s \ # RUN:

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

labath added inline comments. Comment at: libcxx/utils/gdb/libcxx/printers.py:192 class StdStringPrinter(object): """Print a std::string.""" philnik wrote: > dblaikie wrote: > > philnik wrote: > > > jgorbe wrote: > > > > Mordante wrote: > > > > > philnik

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added a comment. Thank you to everyone for the great feedback! In D123957#3459975 , @xbolva00 wrote: > Can you please add link to RFC to commit message? Good call, I added that when landing. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG009048ab314f: Update the developer policy to mention release notes (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceCursor.h:265 +class TraceEventsUtils { +public: nit: maybe this will change in the future to where this will have data and instance members, but if not, consider just using a namespace

[Lldb-commits] [PATCH] D124064: [NFC][trace] simplify the instruction dumper

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. two very minor comments, but looks good - I'm sure you already have, but be sure to run the dumper unittest test to ensure the output didn't change unexpectedly as a result some minor

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D123340: Applying clang-tidy modernize-use-override over LLDB

labath accepted this revision. labath added a comment. Yeah, I suppose we can do that. If this turns out to be more widespread, then I'd rather disable the tidy check (or perhaps the clang warning) for the unittest files instead. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D124061: [LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of order.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. seems reasonable Comment at: lldb/test/Shell/SymbolFile/NativePDB/local-variables-registers.s:247-248 .Ltmp24: - .cv_def_range.Ltmp0 .Lfunc_end0, subfield_reg,