[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp:584 +triple.setArchName("arm64"); +target_arch.SetTriple(triple); +target.SetArchitecture(target_arch, /*set_platform=*/false,

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

aprantl added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp:584 +triple.setArchName("arm64"); +target_arch.SetTriple(triple); +target.SetArchitecture(target_arch, /*set_platform=*/false,

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2670b92a254: Fix a bug in lldb-dotest that was uncovered by setting no value for… (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] a2670b9 - Fix a bug in lldb-dotest that was uncovered by setting no value for dotest_args_str.

Author: Jim Ingham Date: 2022-08-31T18:00:18-07:00 New Revision: a2670b92a2542a9bb889db81ba0cf5a21b3240ee URL: https://github.com/llvm/llvm-project/commit/a2670b92a2542a9bb889db81ba0cf5a21b3240ee DIFF: https://github.com/llvm/llvm-project/commit/a2670b92a2542a9bb889db81ba0cf5a21b3240ee.diff

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks, that makes more sense! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133075/new/ https://reviews.llvm.org/D133075

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

jingham added a comment. Actually, I confused myself because I still had the other fix in place. G... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133075/new/ https://reviews.llvm.org/D133075 ___

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

jingham updated this revision to Diff 457138. jingham added a comment. This one actually works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133075/new/ https://reviews.llvm.org/D133075 Files: lldb/utils/lldb-dotest/lldb-dotest.in Index:

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

jingham added a comment. In D133075#3762872 , @jingham wrote: > In D133075#3762869 , @aprantl wrote: > >> Interesting, I would have expected `array.extend([])` be a noop? > > Me too. Too bad the Python folks

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

jingham added a comment. In D133075#3762869 , @aprantl wrote: > Interesting, I would have expected `array.extend([])` be a noop? Me too. Too bad the Python folks don't check with us more often... Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

jingham added a comment. Or really, we split the string, resulting in an empty array, and apparently `cmd.extend([])` adds an empty argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133075/new/ https://reviews.llvm.org/D133075

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

aprantl added a comment. Interesting, I would have expected `array.extend([])` be a noop? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133075/new/ https://reviews.llvm.org/D133075 ___ lldb-commits

[Lldb-commits] [PATCH] D133075: Fix lldb-dotest when dotest_args_str is empty

jingham created this revision. jingham added reviewers: JDevlieghere, kastiglione, aprantl, labath. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When - after substitution - the dotest_args_str is

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp:584 +triple.setArchName("arm64"); +target_arch.SetTriple(triple); +target.SetArchitecture(target_arch, /*set_platform=*/false,

[Lldb-commits] [lldb] c7511b4 - [lldb] Correctly add runtime test dependencies

Author: Jonas Devlieghere Date: 2022-08-31T16:37:35-07:00 New Revision: c7511b4ecf45c174c43d9177b843f15e2f3bd68b URL: https://github.com/llvm/llvm-project/commit/c7511b4ecf45c174c43d9177b843f15e2f3bd68b DIFF:

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

mib added inline comments. Comment at: lldb/include/lldb/Target/Target.h:1012 /// + /// \param[in] set_platform + /// If true, arch_spec is merged with the current typo ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133069/new/

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

aprantl created this revision. aprantl added reviewers: JDevlieghere, jasonmolenda. Herald added subscribers: omjavaid, kristof.beyls. Herald added a project: All. aprantl requested review of this revision. On arm64e-capable Apple platforms, the system libraries are always arm64e, but

[Lldb-commits] [PATCH] D133045: Partial fix for handling backticks in commands and aliases

hawkinsw added a comment. Sorry if these comments are not helpful! Everything looks great! Comment at: lldb/source/Interpreter/Options.cpp:1026 +} else + option_to_insert = CommandInterpreter::g_no_argument; + Question: Could we drop the final `else`

[Lldb-commits] [PATCH] D133046: [lldb] Make the `rumtimes` target a test dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rGf328922f55fe: [lldb] Make the rumtimes target a test dependency (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f328922 - [lldb] Make the rumtimes target a test dependency

Author: Jonas Devlieghere Date: 2022-08-31T14:25:07-07:00 New Revision: f328922f55fe62a587a3ec0cd7253861cadba85e URL: https://github.com/llvm/llvm-project/commit/f328922f55fe62a587a3ec0cd7253861cadba85e DIFF:

[Lldb-commits] [PATCH] D133046: [lldb] Make the `rumtimes` target a test dependency

jingham accepted this revision. jingham added a comment. This is needed or the parts of the lldb testsuite that rely on the libcxx & libcxxabi will fail when you do `ninja check-lldb`. Thanks for fixing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133046/new/

[Lldb-commits] [PATCH] D133045: Partial fix for handling backticks in commands and aliases

jingham added a comment. The other bit of this patch was a cleanup I made as I was understanding the alias parsing where we were using specific tokens in the parsed alias, but the tokens were ad hoc strings, so I replaced them with constants. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D133046: [lldb] Make the `rumtimes` target a test dependency

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133046/new/ https://reviews.llvm.org/D133046 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D133046: [lldb] Make the `rumtimes` target a test dependency

JDevlieghere created this revision. JDevlieghere added reviewers: fdeazeve, jingham. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. Make the `rumtimes` target a test dependency https://reviews.llvm.org/D133046 Files:

[Lldb-commits] [PATCH] D133045: Partial fix for handling backticks in commands and aliases

jingham created this revision. jingham added reviewers: JDevlieghere, clayborg. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. At present, backtick

[Lldb-commits] [PATCH] D133038: Add GetSourceMap public API

jingham added a comment. I'm a little sad that we don't yet have a way to read the current value of a setting into an SBStructuredData, so we do this piecemeal instead. But that's a bigger project, so if you need this now, it doesn't seem fair to block you on that. We should really name the

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a

[Lldb-commits] [PATCH] D133038: Add GetSourceMap public API

yinghuitan updated this revision to Diff 457046. yinghuitan added a comment. Herald added a subscriber: JDevlieghere. Re-diff with clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files:

[Lldb-commits] [PATCH] D133038: Add GetSourceMap public API

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new SBTarget::GetSourceMap() API

[Lldb-commits] [PATCH] D133024: [LLDB] Simplify cmake for instruction emulation unit tests

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. If the tests work without the corresponding llvm targets, then yea, ship it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133024/new/

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

avogelsgesang added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:246-248 + DataExtractor data(_addr, sizeof(promise_addr), + process_sp->GetByteOrder(), + process_sp->GetAddressByteSize());

[Lldb-commits] [PATCH] D133024: [LLDB] Simplify cmake for instruction emulation unit tests

DavidSpickett created this revision. Herald added subscribers: luke957, s.egerton, simoncook, kristof.beyls, mgorny. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, pcwang-thead. Herald added a project: LLDB. I got suspicious

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

labath added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:246-248 + DataExtractor data(_addr, sizeof(promise_addr), + process_sp->GetByteOrder(), + process_sp->GetAddressByteSize());

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

labath added a comment. In D131160#3751959 , @mgorny wrote: > In that case, is there something more I should do about this patch or are you > going to take over from here? It wasn't clear to me whether you intend to finish this patch (and I was

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

labath added a comment. In D132940#3761082 , @fdeazeve wrote: > In D132940#3761038 , @labath wrote: > >>> Cross-platform (such as API/macosx/macCatalyst and API/tools/lldb-server). >> >> What makes these two

[Lldb-commits] [PATCH] D132578: [lldb] [Core] Use thread for Communication::Write() as well

labath added a comment. In D132578#3751968 , @mgorny wrote: > Well, back when working on the async thread, you've indicated that it's a bad > idea to read from one thread while writing from another, so I've basically > focused on getting to the point

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

avogelsgesang added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:246-248 + DataExtractor data(_addr, sizeof(promise_addr), + process_sp->GetByteOrder(), + process_sp->GetAddressByteSize());

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added a comment. In D132940#3761038 , @labath wrote: >> Cross-platform (such as API/macosx/macCatalyst and API/tools/lldb-server). > > What makes these two tests special? These two tests are _always_ building binaries for Mac Catalyst

[Lldb-commits] [PATCH] D132577: [lldb] [Core] Pass error/status from Communication::ReadThread()

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/unittests/Core/CommunicationTest.cpp:19-20 +#include +#include +#include #include I guess these two are not used anymore.

[Lldb-commits] [PATCH] D132283: [lldb] [Core] Reimplement Communication::ReadThread using MainLoop

labath added inline comments. Comment at: lldb/source/Core/Communication.cpp:427 // Notify the read thread. - m_connection_sp->InterruptRead(); mgorny wrote: > labath wrote: > > Have you considered putting this code (some version of it) inside > >

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

labath added a comment. In D132954#3758856 , @dmlary wrote: > I'm looking for any suggestions of how to test this. I can create a simple > object file with the needed relocation types with yaml2obj, but I don't see > an easy way to get lldb to apply

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

labath added a comment. > Cross-platform (such as API/macosx/macCatalyst and API/tools/lldb-server). I find this statement fairly surprising. One should be able to run ~all tests in a "cross-platform" manner (i.e. where the test architecture is different than lldb (host) arch). What makes

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

labath added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:246-248 + DataExtractor data(_addr, sizeof(promise_addr), + process_sp->GetByteOrder(), + process_sp->GetAddressByteSize());

[Lldb-commits] [PATCH] D133002: [LLDB] Make API tests to run using MSYS tools

labath accepted this revision. labath added a comment. Seems reasonable. BTW, these days, I don't think anybody is invoking `make` directly from the command line, so it would be fine (maybe even desirable) to move some of this logic into python code -- particularly if it makes windows

[Lldb-commits] [PATCH] D133011: [LLDB] Make build.py use uname to set platform

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133011/new/ https://reviews.llvm.org/D133011

[Lldb-commits] [PATCH] D133011: [LLDB] Make build.py use uname to set platform

omjavaid created this revision. Herald added a project: All. omjavaid requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch makes build helper script build.py to use platform.uname for machine/architecture detection. Visual studio

[Lldb-commits] [PATCH] D133002: [LLDB] Make API tests to run using MSYS tools

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, this looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133002/new/ https://reviews.llvm.org/D133002

[Lldb-commits] [PATCH] D133002: [LLDB] Make API tests to run using MSYS tools

omjavaid created this revision. Herald added a project: All. omjavaid requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. MSYS 'uname' on windows returns "MSYS_NT*" instead of windows32 and also MSYS 'pwd' returns non-windows path string. This