[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py:197 +# FIXME: under C++ rules this should call A::B::func() since we imported namespace 'A' +self.expect("expr B::func()", error=True, substrs=["no member named

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Michael137 added a comment. In D147436#4241975 , @aprantl wrote: > Just out of curiosity: > > namespace A { > namespace B { > namespace C { > struct Bar {}; > } > } > } > > namespace B { > namespace C { > struct Foo {}; > } > }

[Lldb-commits] [PATCH] D147362: [lldb] Add Clang module import logging

aprantl added a comment. This looks great, and I think this should also be easy to test? I think we have many other tests that write out a logfile and FileCheck the result. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147362/new/

[Lldb-commits] [PATCH] D147385: [lldb] Add fixits for "frame variable"

aprantl added a comment. That looks like a nice quality of life improvement! Personally I would lean towards replicating the expr behavior, though I don't know how much work that would be. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147385/new/

[Lldb-commits] [PATCH] D143061: [lldb][Language] Add more language types

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Well, I guess we'll have to revisit this for DWARF 6 split of language names and versions anyway Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

aprantl added a comment. Just out of curiosity: namespace A { namespace B { namespace C { struct Bar {}; } } } namespace B { namespace C { struct Foo {}; } } Does this work? (lldb) expr C::Foo f Comment at:

[Lldb-commits] [PATCH] D147482: [lldb] Add an overload to SetModuleLoadAddress that takes an unsigned value

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Currently, `SBTarget::SetModuleLoadAddress` cannot accept the large slides needed to load images in high memory. This function should

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

JDevlieghere added a comment. > Be handy to mark this abandoned when you get a chance Augusto had already abandoned it when he wrote that reply, maybe you're looking at a different patch or stale tab? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

dblaikie added a comment. In D147292#4238834 , @augusto2112 wrote: > In D147292#4238820 , @JDevlieghere > wrote: > >> There seems to be overlap in the code added in this patch and D146679 >>

[Lldb-commits] [PATCH] D147462: Use kernel's global variable indicating how many bits are used in addressing when loading Darwin xnu kernel

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b092714c304: Using global variable in xnu kernel, set # of addressable bits (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 8b09271 - Using global variable in xnu kernel, set # of addressable bits

Author: Jason Molenda Date: 2023-04-03T13:49:51-07:00 New Revision: 8b092714c304defb00876a01995af3b114dadc92 URL: https://github.com/llvm/llvm-project/commit/8b092714c304defb00876a01995af3b114dadc92 DIFF: https://github.com/llvm/llvm-project/commit/8b092714c304defb00876a01995af3b114dadc92.diff

[Lldb-commits] [PATCH] D147462: Use kernel's global variable indicating how many bits are used in addressing when loading Darwin xnu kernel

jasonmolenda added a comment. Yeah, I agree that messing with the global setting of addressable bits here is not ideal, but at this point in time the fact that we probably have an un-set/invalid value means it won't make things worse. Comment at:

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe538c6fc3048: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided. (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e538c6f - [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

Author: walter erquinigo Date: 2023-04-03T15:41:02-05:00 New Revision: e538c6fc3048e1fb1a58da879275d6804186856e URL: https://github.com/llvm/llvm-project/commit/e538c6fc3048e1fb1a58da879275d6804186856e DIFF:

[Lldb-commits] [PATCH] D147462: Use kernel's global variable indicating how many bits are used in addressing when loading Darwin xnu kernel

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. I would still prefer to not change the global state, but after speaking to Jason offline, that might be better tackled when we unify the current Process/Target bifurcation.

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace updated this revision to Diff 510588. wallace added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 Files: lldb/cmake/modules/AddLLDB.cmake Index:

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:175 +CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU") + target_compile_options(${name} PRIVATE "-fvisibility=default") +endif() JDevlieghere wrote: > Rather than changing the

[Lldb-commits] [PATCH] D147462: Use kernel's global variable indicating how many bits are used in addressing when loading Darwin xnu kernel

jasonmolenda updated this revision to Diff 510586. jasonmolenda added a comment. Update patch to address some of Jonas' comments. I was adding a check that the ptrsize of the architecture was 64-bit, but we don't work on 32-bit xnu kernels for a few years now; we can assume 64-bit safely. I

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

JDevlieghere added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:175 +CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU") + target_compile_options(${name} PRIVATE "-fvisibility=default") +endif() Rather than changing the compile options

[Lldb-commits] [lldb] 8c3ae74 - [lldb][NFC] Remove outdated TODO message

Author: Alex Langford Date: 2023-04-03T13:08:54-07:00 New Revision: 8c3ae74ab147cad84f6bebc6d30a6e5a309f0d9f URL: https://github.com/llvm/llvm-project/commit/8c3ae74ab147cad84f6bebc6d30a6e5a309f0d9f DIFF: https://github.com/llvm/llvm-project/commit/8c3ae74ab147cad84f6bebc6d30a6e5a309f0d9f.diff

[Lldb-commits] [PATCH] D147462: Use kernel's global variable indicating how many bits are used in addressing when loading Darwin xnu kernel

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:1093 + // don't mark those as addressable. + m_process->SetVirtualAddressableBits((wordsize * 8) - 9); + addr_t sym_addr =

[Lldb-commits] [PATCH] D147462: Use kernel's global variable indicating how many bits are used in addressing when loading Darwin xnu kernel

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:1087 + if (symbol && wordsize == 8) { +if (symbol->GetByteSizeIsValid()) { + // Mark all bits as addressable so we don't strip any

[Lldb-commits] [PATCH] D147462: Use kernel's global variable indicating how many bits are used in addressing when loading Darwin xnu kernel

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. The Darwin xnu kernel has a global variable which has the

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

rriddle accepted this revision. rriddle added a comment. This revision is now accepted and ready to land. LGTM, and makes sense to me given that downstream users often want a build of LLVM with `CMAKE_CXX_VISIBILITY_PRESET=hidden`, but lldb should still be able to build/link/work in the

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace updated this revision to Diff 510557. wallace added a comment. gate the target OS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 Files: lldb/cmake/modules/AddLLDB.cmake Index:

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:173 + if (LLDB_EXPORT_ALL_SYMBOLS) +if (CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU") + target_compile_options(${name} PRIVATE "-fvisibility=default") rriddle wrote: > Other

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

rriddle added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:173 + if (LLDB_EXPORT_ALL_SYMBOLS) +if (CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU") + target_compile_options(${name} PRIVATE "-fvisibility=default") Other places uses `if (NOT

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace updated this revision to Diff 510551. wallace added a comment. another nit... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 Files: lldb/cmake/modules/AddLLDB.cmake Index:

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace updated this revision to Diff 510550. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147453/new/ https://reviews.llvm.org/D147453 Files: lldb/cmake/modules/AddLLDB.cmake Index:

[Lldb-commits] [PATCH] D147453: [LLDB] Ensure LLDB symbols are exported in LLDB_EXPORT_ALL_SYMBOLS is provided.

wallace created this revision. wallace added a reviewer: rriddle. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If we want to export all lldb symbols (i.e LLDB_EXPORT_ALL_SYMBOLS=ON), we need to use

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Michael137 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/test/API/lang/cpp/namespace/TestNamespaceLookup.py:197 +# FIXME: under C++ rules this should call A::B::func() since we imported namespace 'A' +self.expect("expr

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Michael137 created this revision. Michael137 added reviewers: aprantl, labath. Herald added a project: All. Michael137 updated this revision to Diff 510478. Michael137 added a comment. Michael137 updated this revision to Diff 510482. Michael137 edited the summary of this revision. Michael137

[Lldb-commits] [PATCH] D143061: [lldb][Language] Add more language types

Michael137 added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:492 + eLanguageTypeAda2005 = 0x002e, + eLanguageTypeAda2012 = 0x002f, + Michael137 wrote: > Michael137 wrote: > > aprantl wrote: > > > aprantl wrote: > > > > Michael137 wrote:

[Lldb-commits] [PATCH] D143061: [lldb][Language] Add more language types

Michael137 marked an inline comment as not done. Michael137 added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:492 + eLanguageTypeAda2005 = 0x002e, + eLanguageTypeAda2012 = 0x002f, + Michael137 wrote: > aprantl wrote: > > aprantl wrote: >

[Lldb-commits] [PATCH] D143061: [lldb][Language] Add more language types

Michael137 added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:492 + eLanguageTypeAda2005 = 0x002e, + eLanguageTypeAda2012 = 0x002f, + aprantl wrote: > aprantl wrote: > > Michael137 wrote: > > > aprantl wrote: > > > > Would it make sense

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

Michael137 added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:551 case lldb::eLanguageTypeC_plus_plus_14: lang_opts.CPlusPlus11 = true; m_compiler->getHeaderSearchOpts().UseLibcxx = true; aprantl

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

Michael137 added inline comments. Comment at: lldb/source/Target/Language.cpp:272 + case eLanguageTypeC_plus_plus_17: + case eLanguageTypeC_plus_plus_20: case eLanguageTypeObjC_plus_plus: aprantl wrote: > Can you check if we already have a similar function

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett added a comment. > One concern I have is that there are no tests. I can understand that it may > be difficult to get automated tests running testing the debugging of an > architecture like MSP430 but there are things we can test to sanity test > MSP430 support Two things come to

[Lldb-commits] [PATCH] D147045: [lldb] Drop RegisterInfoInterface::GetDynamicRegisterInfo

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM I have no idea about the specific use case but less code is good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147045/new/

[Lldb-commits] [PATCH] D147300: [lldb] Fix build on older FreeBSD

DavidSpickett accepted this revision. DavidSpickett added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147300/new/ https://reviews.llvm.org/D147300 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D147425: [lldb] fix #61728 wrong parameter value display represented via DW_OP_deref and DW_OP_lt

jwnhy created this revision. jwnhy added a reviewer: JDevlieghere. Herald added a project: All. jwnhy requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch resolves an issue where a value is incorrectly displayed if it is represented