[Lldb-commits] [PATCH] D153673: [lldb][NFCI] Remove unneeded ConstString constructions for OptionValueProperties::AppendProperty

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153673/new/ https://reviews.llvm.org/D153673

[Lldb-commits] [PATCH] D153685: [lldb] Add `source cache dump` and `source cache clear` subcommand

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, clayborg, jingham, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Add two new `source` subcommands: `source cache dump` and `source cache clear`. As the name implies the first

[Lldb-commits] [PATCH] D153675: [lldb][NFCI] Remove ConstString from Process::ConfigureStructuredData

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a follow-up to

[Lldb-commits] [PATCH] D153673: [lldb][NFCI] Remove unneeded ConstString constructions for OptionValueProperties::AppendProperty

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I removed ConstString from OptionValueProperties in 643ba926c1f6

[Lldb-commits] [PATCH] D153657: Don't allow ValueObject::Cast from a smaller type to a larger

bulbazord added a comment. I think this patch is probably okay to do, but it does break a supported use case that I'm aware of: One way you can do "object oriented programming" in C is to do exactly what you're trying to prevent. Using the test, you could say that "MyStruct" is the base class

[Lldb-commits] [PATCH] D153657: Don't allow ValueObject::Cast from a smaller type to a larger

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153657/new/ https://reviews.llvm.org/D153657

[Lldb-commits] [PATCH] D153648: [lldb] Remove broken shared cache duplicate class handling

kastiglione added a comment. In D153648#898 , @jingham wrote: > and that the one that won will indeed be in that list but will not be marked > as a duplicate. All of the duplicate classes are in the duplicate list, not a single class that won. For

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

JDevlieghere added a comment. In D153644#891 , @jasonmolenda wrote: > It seems like this patch is really avoiding the sign extension of an int8_t > to int32_t in the process of being passed to printf. By casting it to > unsigned we've avoided the

[Lldb-commits] [lldb] c0045a8 - [lldb] Use format specific for unprintabe char in DumpDataExtractor

Author: Jonas Devlieghere Date: 2023-06-23T11:56:41-07:00 New Revision: c0045a8e8e0c72a0c8be3a9c333885da4d14d472 URL: https://github.com/llvm/llvm-project/commit/c0045a8e8e0c72a0c8be3a9c333885da4d14d472 DIFF:

[Lldb-commits] [PATCH] D153657: Don't allow ValueObject::Cast from a smaller type to a larger

jingham created this revision. jingham added reviewers: JDevlieghere, kastiglione, mib. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. SBValue::Cast actually allows casting from a struct type to

[Lldb-commits] [PATCH] D153648: [lldb] Remove broken shared cache duplicate class handling

jingham added a comment. There's similar code for the runtime versions 12-15 which actually looks correct. It seems to claim that the duplicate classes are all stuffed after the capacity in the classOffsets array and that the one that won will indeed be in that list but will not be marked as

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

jasonmolenda added a comment. It seems like this patch is really avoiding the sign extension of an int8_t to int32_t in the process of being passed to printf. By casting it to unsigned we've avoided the sign extension and getting the correct result, but it seems like you could have used a

[Lldb-commits] [PATCH] D153648: [lldb] Remove broken shared cache duplicate class handling

JDevlieghere added a comment. Both issues are not present in the code that does the equivalent parsing for Objective-C versions 12 through 15. Most likely I accidentally introduced these bugs when copy/pasting this for the changes in 16. I would prefer to use that rather than diverging our

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

This revision was automatically updated to reflect the committed changes. Closed by commit rG85f40fc676df: [lldb] Print unprintable characters as unsigned (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D153644?vs=533985=534020#toc

[Lldb-commits] [lldb] 85f40fc - [lldb] Print unprintable characters as unsigned

Author: Jonas Devlieghere Date: 2023-06-23T11:00:21-07:00 New Revision: 85f40fc676df65416568750f328c71758c84264a URL: https://github.com/llvm/llvm-project/commit/85f40fc676df65416568750f328c71758c84264a DIFF:

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

JDevlieghere added a comment. In D153644#679 , @bulbazord wrote: > Makes sense to me. Does it make sense to add a test case where we mix > "printable" characters with "non-printable" ones? I see you have a `\f` at > the end there, but that's a

[Lldb-commits] [PATCH] D153648: [lldb] Remove broken shared cache duplicate class handling

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, jingham, bulbazord. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The shared cache list of ObjC classes contains

[Lldb-commits] [PATCH] D153482: [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a397ecffdea: [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1a397ec - [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin

Author: Alex Langford Date: 2023-06-23T10:29:52-07:00 New Revision: 1a397ecffdea64f5a521b4aac1fa4b98723dec22 URL: https://github.com/llvm/llvm-project/commit/1a397ecffdea64f5a521b4aac1fa4b98723dec22 DIFF: https://github.com/llvm/llvm-project/commit/1a397ecffdea64f5a521b4aac1fa4b98723dec22.diff

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D153626#096 , @DavidSpickett wrote: > This assumes that the usual use case is: > > - Make a small vector. > - Resize it to what

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Makes sense to me. Does it make sense to add a test case where we mix "printable" characters with "non-printable" ones? I see you have a `\f` at the end there, but that's a special

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, DavidSpickett, bulbazord. Herald added a project: All. JDevlieghere requested review of this revision. When specifying the C-string format for dumping memory, we treat unprintable characters as signed. Whether a

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. https://github.com/llvm/llvm-project/issues/62068 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153636/new/

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes #62068. After 8d1de7b34af46a089eb5433c700419ad9b2923ee

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett added reviewers: omjavaid, JDevlieghere, labath. DavidSpickett added a comment. This assumes that the usual use case is: - Make a small vector. - Resize it to what you need. - Use the content like an array. Every case I found matched that but still, it's not the safest API ever.

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett created this revision. Herald added subscribers: ctetreau, atanasyan, jrtc27, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, alextsao1999. Herald added a project: LLDB. Previously lldb was using