[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman added a comment. In D140996#4655288 , @bolshakov-a wrote: > Sorry, but I don't know what remains to be done here. It seems that the only > important question is about ABI, but I've already answered that the changes > under discussion

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman added a comment. In D140996#4646880 , @cor3ntin wrote: > It would be nice to figure out a plan for this PR in the next few weeks, > before we get kicked out of Phab! Agreed -- @bolshakov-a are you still planning to actively work on this

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

aaron.ballman added a comment. In D158323#4614717 , @mib wrote: > Given that the bot is still red, I've reverted the patch in > dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7 > Thank you

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

aaron.ballman added a comment. In D158323#4614446 , @mib wrote: > In D158323#4614373 , @aaron.ballman > wrote: > >> In D158323#4613878 , @mib wrote: >> >>> Given we

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

aaron.ballman added a comment. In D158323#4613878 , @mib wrote: > Given we didn't receive more feedback on this, I'll land it now. If there are > other comments, we can address those after the fact. Hello! It seems the changes here have taken out the

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman added a comment. In D151683#4566907 , @eaeltsin wrote: > Hi, > > Is it a known issue, that clang doesn't compile `void foo(char *argv[] > [[maybe_unused]]) {}` ? The error is `error: 'maybe_unused' attribute cannot > be applied to types`.

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman added a comment. Herald added a subscriber: wangpc. I've not spotted any major concerns with this patch, but I did have some minor nits to look into. I'd love to hear from @rsmith and @erichkeane before signing off on this, as the changes are pretty involved and they've both done

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

aaron.ballman added inline comments. Comment at: lldb/CodeOwners.rst:7-8 +particular part of LLDB are reviewed, either by themself or by someone else. +They are also the gatekeepers for their part of LLDB, with the final word on +what goes in or not. + tonic

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM modulo nits found by others, thank you for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman added a reviewer: MaskRay. aaron.ballman added a comment. Aside from the failing precommit CI test case in C, I think this LGTM. I've added @MaskRay as the code owner for the command line option changes in case he's got concerns regarding the deprecation/removal plans.

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman added subscribers: beanz, clang-vendors. aaron.ballman added a comment. In D151683#4384017 , @erichkeane wrote: > In D151683#4382408 , @philnik wrote: > >> No. I guess, since you are asking I

[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

aaron.ballman added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1, JDevlieghere. I think this is a reasonable change -- I don't see a whole lot of value out from the include or collaboration graphs, so unless someone has strong opinions otherwise, I

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

aaron.ballman added a comment. The changes in this patch seem to have caused https://lab.llvm.org/buildbot/#/builders/clang-ppc64-aix to go down for the past 4 days -- can you revert and investigate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D146412: [NFC] Fix potential for use-after-free in DumpModuleInfoAction

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This looks much better to me, thank you! LGTM with one small nit for safety. Comment at: clang/include/clang/Frontend/FrontendActions.h:191 +

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

aaron.ballman added a comment. In D146041#4198056 , @AryanGodara wrote: > I will try to split this commit, and update on this asap (Sorry for the late > update, I have mid-sem exams going on, I haven't abandoned this issue, still > working on it). No

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman added a comment. In D140996#4150848 , @bolshakov-a wrote: >> Should this also update the status in clang/www/cxx_status.html? > > I'm not sure. There still remains an issue with template parameters of > reference type, which was tried to

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman edited reviewers, added: erichkeane, royjacobson, clang-language-wg; removed: mizvekov. aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. In D140996#4125177 , @bolshakov-a wrote: > @aaron.ballman, @rsmith,

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

aaron.ballman added a comment. In D131858#4051352 , @erichkeane wrote: > In D131858#4051336 , @aaron.ballman > wrote: > >> In D131858#4050112 , @rsmith wrote: >> >>> In

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

aaron.ballman added a comment. In D131858#4050112 , @rsmith wrote: > In D131858#3957630 , @arphaman > wrote: > >> This change has caused a failure in Clang's stage 2 CI on the green dragon >> Darwin CI: >>

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

aaron.ballman added a comment. I landed the Clang bits in 94738a5ac34283bb034b022602b9f9e93d67081f , thank you for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

aaron.ballman added a comment. In D137338#3907281 , @Rageking8 wrote: > I am ok with you guys taking the parts of this revision that you reviewed and > directly commiting them to the repo, just like how the person above did it. > This is to break the

[Lldb-commits] [PATCH] D137503: [CMake] Fix -Wstrict-prototypes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for this! If we do a 15.0.5, I think these changes should probably go into there as well (WDYT?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137503/new/

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenTBAA.cpp:341 if (const CXXRecordDecl *CXXRD = dyn_cast(RD)) { - // Handle C++ base classes. Non-virtual bases can treated a a kind of + // Handle C++ base classes. Non-virtual bases can

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

aaron.ballman added a comment. The clang parts generally LG, but I spotted a few things. Thank you for this cleanup effort! Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:467 - /// Return a matcher that that points to the same implementation, but sets

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aaron.ballman added a comment. In D137583#3917735 , @dblaikie wrote: > In D137583#3917706 , @aaron.ballman > wrote: > >>> ...we expect template params to be fully qualified when comparing them for >>> simple

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aaron.ballman added a comment. > ...we expect template params to be fully qualified when comparing them for > simple template names So lldb is not inspecting the AST, they're doing reflection (of a sort) on the pretty printed names? Or am I misunderstanding something?

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a comment. In D134878#3869947 , @mehdi_amini wrote: > From what I saw when you posted the discourse thread initially, I understand > you're targeting user-visible features, and mostly from the "toolchain" side > of the project. >

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

This revision was automatically updated to reflect the committed changes. Closed by commit rG8673444598be: Update developer policy on potentially breaking changes (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a comment. In D134878#3836840 , @aaron.ballman wrote: > Pinging reviewers from projects other than libcxx (I'm hoping to get buy-in > from someone on the LLVM side of things; lldb would be nice as well). I'll be landing this later

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a comment. Pinging reviewers from projects other than libcxx (I'm hoping to get buy-in from someone on the LLVM side of things; lldb would be nice as well). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/ https://reviews.llvm.org/D134878

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:129 + + People interested in joining the vendors group can do so by clicking the + "Join Project" link on the vendor's "Members" page in Phabricator. Mordante wrote: > I didn't

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman updated this revision to Diff 463949. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Applying review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/ https://reviews.llvm.org/D134878 Files:

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:140 + +* After the change has been committed to the repository, the potentially + disruptive changes described in the release notes should be posted to the ldionne wrote: > I wonder

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a reviewer: JDevlieghere. aaron.ballman added a comment. Adding someone from lldb as a review for awareness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/ https://reviews.llvm.org/D134878

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a subscriber: mehdi_amini. aaron.ballman added a comment. Note: I would love to add a vendors group to Phabricator for LLVM and lldb (and any other project we think has vendors), but this requires admin privileges to do. @mehdi_amini, is this something you could help out

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman created this revision. aaron.ballman added reviewers: rnk, lattner, ldionne, rjmccall, Mordante, tahonermann, bruno, tonic. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: LLVM. We've recently had issues appropriately notifying

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3710340 , @MaskRay wrote: > In D130689#3710291 , @aaron.ballman > wrote: > >> In D130689#3710281 , @royjacobson >> wrote: >>

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3710281 , @royjacobson wrote: > In D130689#3709834 , @thieta wrote: > >> In D130689#3709742 , >> @aaron.ballman wrote: >> >>>

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706424 , @aaron.ballman wrote: > In D130689#3706377 , @thieta wrote: > >> In D130689#3706336 , >> @aaron.ballman wrote: >>

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706377 , @thieta wrote: > In D130689#3706336 , @aaron.ballman > wrote: > >> That's the only reason this hasn't been reverted already. Landing sweeping >> changes on a

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706303 , @thieta wrote: > In D130689#3706263 , @aaron.ballman > wrote: > >> > > > >> Something odd is going on here and we might want to consider a revert of >> this

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706276 , @barannikov88 wrote: > In D130689#3706263 , @aaron.ballman > wrote: > >> The failures I am getting are the same as what's shown by the sanitizer bot >> for

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706200 , @thieta wrote: > In D130689#3706199 , @cor3ntin > wrote: > >> Trying to read the logs,, notably >>

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3705131 , @royjacobson wrote: > This seems to have been more disruptive than expected, since an existing > CMakeCache.txt can make LLVM compile in previous C++14 configuration. This > seems to make some of the

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added a comment. Thank you to everyone for the great feedback! In D123957#3459975 , @xbolva00 wrote: > Can you please add link to RFC to commit message? Good call, I added that when landing. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG009048ab314f: Update the developer policy to mention release notes (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman updated this revision to Diff 423683. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. - Made it more clear that adding a release note is discretionary rather than mandatory - Clarified that bug fix release notes

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added a comment. In D123957#3459557 , @lattner wrote: > This is awesome, I agree completely we should curate release notes better. > That said, I think this should make it more clear that there is a "difference > in kind" between

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:195 +* Adding, removing, or regrouping a diagnostic. +* Fixing a bug (please link to the issue fixed in the bug database). +* Adding or removing an optimization. nikic wrote: > I

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added a subscriber: xbolva00. aaron.ballman added a comment. In D123957#3458354 , @hans wrote: > If it's possible, maybe this could be worded in a way that strongly suggests > the release notes should ideally be updated in the same patch

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman updated this revision to Diff 423594. aaron.ballman added a comment. Something went funny during a rebase, so this is the full update, not just changes since last time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 Files:

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman updated this revision to Diff 423593. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updating based on review feedback. Fixed some grammar issues, added a bullet for fixing bugs, modified the bullet about diagnostics to include regrouping under a

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman created this revision. aaron.ballman added a reviewer: lattner. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: LLVM. As a project, Clang has gotten negative public feedback about our lack of communicating changes to users.

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. In D121078#3400810 , @SimplyDanny wrote: > @tonic, can you please have another look? If @tonic has any additional feedback, we can handle it post-commit at this point. I've gone ahead and committed this on your behalf in

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. In D121078#3373081 , @SimplyDanny wrote: > I'm happy that you found a reasonable compromise. I like it too. ;) > > Now, I ask you to help me a little bit with the workflow and the test > failures. The review comments are

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman accepted this revision. aaron.ballman added a comment. In D121078#3368424 , @tonic wrote: > In D121078#3367950 , @aaron.ballman > wrote: > >> I've added comments to the few places I'd like to see a

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In D121078#3367289 , @tonic wrote: > In D121078#3366825 , @aaron.ballman > wrote: >

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. In D121078#3366025 , @tonic wrote: > In D121078#3365542 , @SimplyDanny > wrote: > >> In D121078#3363856 , >> @aaron.ballman wrote: >> >>>

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. I think we need to retain *some* references to the existing mailing list archives. The migration to Discourse worked fairly well, but there were still data migration issues. For example: https://discourse.llvm.org/t/memory-barrier-problem/57493

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

aaron.ballman added a comment. Herald added a subscriber: JDevlieghere. In D114639#3273831 , @RKSimon wrote: > In D114639#3273761 , > @stella.stamenova wrote: > >> Can we update the lldb instructions as part of

[Lldb-commits] [PATCH] D107528: [llvm][clang][NFC] updates inline licence info

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. There are some spurious whitespace changes that should be dropped, but otherwise, this LGTM. Thank you for the cleanup! Comment at:

[Lldb-commits] [PATCH] D103842: NFC: .clang-tidy: Inherit configs from parents to improve maintainability

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103842/new/ https://reviews.llvm.org/D103842 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm.org/D96807 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

aaron.ballman added a comment. Thank you for working on this! In general, I like the change. Comment at: clang/lib/AST/TypePrinter.cpp:1308 +} else if ((isa(D) && cast(D)->isAnonymousStructOrUnion()) || +isa(D)) { OS << "anonymous"; I think

[Lldb-commits] [PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:237 +std::string Val = HNOption.General.lookup(Opt.first); +if (Val.empty()) { + HNOption.General.insert({Opt.first, Opt.second.str()});

[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from minor nits, this seems reasonable to me, LG! Comment at: clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:16 #include

[Lldb-commits] [PATCH] D75406: Avoid including FileManager.h from SourceManager.h

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D75279: Avoid SourceManager.h include in RawCommentList.h, add missing incs

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75279/new/ https://reviews.llvm.org/D75279 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D73589: Improve help text for (lldb) target symbols add

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73589/new/ https://reviews.llvm.org/D73589 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

aaron.ballman added inline comments. Comment at: cfe/trunk/lib/AST/Mangle.cpp:127 +// do not add a "\01" prefix. +if (!ALA->getIsLiteralLabel() || ALA->getLabel().startswith("llvm.")) { + Out << ALA->getLabel(); Sorry to dredge up an old review, but

[Lldb-commits] [PATCH] D71857: Fixes -Wrange-loop-analysis warnings

aaron.ballman added a comment. It seems like some of the deductions are not spelling out the qualifiers or pointer/references explicitly in some cases, at least from my spot-checking. Can you go back through this patch to make sure we're getting those correct? Comment at:

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71857/new/ https://reviews.llvm.org/D71857 ___