Author: Kamil Rytarowski
Date: 2020-09-10T15:49:15+02:00
New Revision: 52f42720b26a32c9dffc9331841415442f784700
URL:
https://github.com/llvm/llvm-project/commit/52f42720b26a32c9dffc9331841415442f784700
DIFF:
https://github.com/llvm/llvm-project/commit/52f42720b26a32c9dffc9331841415442f784700.di
Author: Kamil Rytarowski
Date: 2020-02-09T18:02:07+01:00
New Revision: 273f638384d69f71838978001bf2f542d472b5f9
URL:
https://github.com/llvm/llvm-project/commit/273f638384d69f71838978001bf2f542d472b5f9
DIFF:
https://github.com/llvm/llvm-project/commit/273f638384d69f71838978001bf2f542d472b5f9.di
Author: Kamil Rytarowski
Date: 2020-02-09T15:01:17+01:00
New Revision: 5a285f207e109221572a0aabc83f2bce521322bd
URL:
https://github.com/llvm/llvm-project/commit/5a285f207e109221572a0aabc83f2bce521322bd
DIFF:
https://github.com/llvm/llvm-project/commit/5a285f207e109221572a0aabc83f2bce521322bd.di
Author: Kamil Rytarowski
Date: 2020-02-09T15:01:17+01:00
New Revision: 0ea4d18a288bf2a4010632f841b421e1bdc5072a
URL:
https://github.com/llvm/llvm-project/commit/0ea4d18a288bf2a4010632f841b421e1bdc5072a
DIFF:
https://github.com/llvm/llvm-project/commit/0ea4d18a288bf2a4010632f841b421e1bdc5072a.di
Author: kamil
Date: Sun Nov 4 08:53:16 2018
New Revision: 346100
URL: http://llvm.org/viewvc/llvm-project?rev=346100&view=rev
Log:
Fix NetBSD build after "Move path resolution logic out of FileSpec"
D53915
Modified:
lldb/trunk/source/Host/netbsd/Host.cpp
lldb/trunk/source/Host/netbsd/Ho
Author: kamil
Date: Mon Feb 5 09:12:23 2018
New Revision: 324251
URL: http://llvm.org/viewvc/llvm-project?rev=324251&view=rev
Log:
Sync PlatformNetBSD.cpp with Linux
Summary:
Various changes in logging from log->Printf() to generic LLDB_LOG().
Sponsored by
Reviewers: labath, joerg
Reviewed B
Author: kamil
Date: Mon Feb 5 05:16:22 2018
New Revision: 324234
URL: http://llvm.org/viewvc/llvm-project?rev=324234&view=rev
Log:
Fix a crash in *NetBSD::Factory::Launch
Summary:
We cannot call process_up->SetState() inside
the NativeProcessNetBSD::Factory::Launch
function because it triggers a
Author: kamil
Date: Tue Jun 20 08:51:06 2017
New Revision: 305794
URL: http://llvm.org/viewvc/llvm-project?rev=305794&view=rev
Log:
Correct syntax mistake hidden in assert(3)
wait_status cannot be compared with WaitStatus::Stop,
go for wait_status.type.
Modified:
lldb/trunk/source/Plugins/Pr
Do you offer shell account? I don't have Linux and/or s390x to debug it.
On 29.05.2017 17:17, Ulrich Weigand via lldb-commits wrote:
> Hello,
>
> It appears this commit broke the
> EditlineTestFixture.EditlineReceivesSingleLineText
> unit test on s390x-linux. The test now simply hangs (hanging t
Author: kamil
Date: Thu May 25 15:12:30 2017
New Revision: 303907
URL: http://llvm.org/viewvc/llvm-project?rev=303907&view=rev
Log:
Fix bug #28898
lldb: libedit produces garbled, unusable input on Linux
Apply patch from Christos Zoulas, upstream libedit developer.
It has been tested on NetBSD/amd
Author: kamil
Date: Wed May 24 18:59:50 2017
New Revision: 303823
URL: http://llvm.org/viewvc/llvm-project?rev=303823&view=rev
Log:
Correct compiler warnings and Debug build of the NetBSD target
Correct files present only in the NetBSD build.
Modified:
lldb/trunk/source/Plugins/Process/NetBS
Author: kamil
Date: Thu Apr 27 19:29:54 2017
New Revision: 301603
URL: http://llvm.org/viewvc/llvm-project?rev=301603&view=rev
Log:
Resurrect the standalone build of LLDB
Switch includes "llvm/Config/config.h" to "llvm/Config/llvm-config.h".
Tested on NetBSD 7.99.70 amd64
Modified:
lldb/tru
Thanks, I will give it a try!
On 27.04.2017 17:59, Zachary Turner wrote:
> In case it's not obvious, note the space in the command I said to run.
> `git-clang-format` has a dash, and when you run `git clang-format`
> (with a space), it will run the file with the dash.
>
> On Thu, Apr 27, 2017 at
Thanks! I'm working on this, I will test new code soon and submit to review.
On 20.04.2017 15:51, Zachary Turner wrote:
> Note that getAsInteger returns false on success, so be careful!
> On Thu, Apr 20, 2017 at 6:09 AM Pavel Labath via Phabricator
> mailto:revi...@reviews.llvm.org>> wrote:
>
>
Author: kamil
Date: Thu Apr 20 11:35:36 2017
New Revision: 300853
URL: http://llvm.org/viewvc/llvm-project?rev=300853&view=rev
Log:
Resurrect LLDB Standalone build on NetBSD
Include CheckIncludeFile for check_include_file() in CMake.
Detect in CMake.
This header is available on NetBSD.
Modifie
Author: kamil
Date: Tue Apr 18 07:53:35 2017
New Revision: 300548
URL: http://llvm.org/viewvc/llvm-project?rev=300548&view=rev
Log:
Introduce FPR and Debug Registers/NetBSD/amd64 support
Summary:
This code offers Debug Registers (80386) model in LLDB/amd64.
This is initial support and has one is
Right,
This patch happened to does not fully work for me (NetBSD-CORE@ switches
were skipped), I will be back to it once I will get my current efforts
done on watchpoints and fpr.
Thank you for the initial scratch!
On 11.04.2017 17:14, Zachary Turner wrote:
> Just to be clear, this patch was onl
Author: kamil
Date: Fri Apr 7 11:45:36 2017
New Revision: 299783
URL: http://llvm.org/viewvc/llvm-project?rev=299783&view=rev
Log:
Correct environ parsing on NetBSD
Summary:
This replaces old code in Host::GetEnvironment for NetBSD
with the version from Linux. This makes parsing environment
vari
Author: kamil
Date: Thu Mar 30 15:25:29 2017
New Revision: 299109
URL: http://llvm.org/viewvc/llvm-project?rev=299109&view=rev
Log:
Battery of NetBSD support improvements
Summary:
Include initial support for:
- single step mode (PT_STEP)
- single step trap handling (TRAP_TRACE)
- exec() trap (
Author: kamil
Date: Wed Mar 29 14:52:24 2017
New Revision: 299023
URL: http://llvm.org/viewvc/llvm-project?rev=299023&view=rev
Log:
Add NetBSD path for Debugging Information in Separate Files
Summary:
NetBSD stores debug information files in the `/usr/libdata/debug` path.
This change fixes debug
Author: kamil
Date: Tue Mar 28 20:10:21 2017
New Revision: 298970
URL: http://llvm.org/viewvc/llvm-project?rev=298970&view=rev
Log:
Remove dead include from the NetBSD code.
Modified:
lldb/trunk/source/Host/netbsd/Host.cpp
Modified: lldb/trunk/source/Host/netbsd/Host.cpp
URL:
http://llvm.o
Author: kamil
Date: Tue Mar 28 17:43:17 2017
New Revision: 298953
URL: http://llvm.org/viewvc/llvm-project?rev=298953&view=rev
Log:
Add support for tracing hello-world application on NetBSD
Summary:
This patch is a stripped down from features a NetBSD process
code (patch is kept under 2k LOC). Th
Author: kamil
Date: Sun Mar 26 10:34:57 2017
New Revision: 298810
URL: http://llvm.org/viewvc/llvm-project?rev=298810&view=rev
Log:
[LLDB] OpenBSD support
Summary:
Add basic OpenBSD support. This is enough to be able to analyze core dumps for
OpenBSD/amd64, OpenBSD/arm, OpenBSD/arm64 and OpenBSD
Author: kamil
Date: Wed Mar 22 12:24:37 2017
New Revision: 298524
URL: http://llvm.org/viewvc/llvm-project?rev=298524&view=rev
Log:
Reuse appropriate Launch and Attach on NetBSD
Summary:
NetBSD ships with NativeProcessNetBSD inherited from NativeProcessProtocol.
Link Plugins/Process/gdb-remote
Author: kamil
Date: Tue Mar 21 12:39:15 2017
New Revision: 298409
URL: http://llvm.org/viewvc/llvm-project?rev=298409&view=rev
Log:
Create instance of DynamicLoaderPOSIXDYLD on NetBSD
Summary:
NetBSD is a modern ELF UNIX-like system.
There is requires DynamicLoaderPOSIXDYLD e.g. for ELF AUXV rea
Author: kamil
Date: Tue Mar 21 12:30:47 2017
New Revision: 298408
URL: http://llvm.org/viewvc/llvm-project?rev=298408&view=rev
Log:
Add stub for PluginProcessNetBSD
Summary:
This is the base for introduction of further features to support Process
Tracing on NetBSD, in local and remote setup.
Th
Author: kamil
Date: Tue Mar 21 12:27:59 2017
New Revision: 298407
URL: http://llvm.org/viewvc/llvm-project?rev=298407&view=rev
Log:
Enable AUXV and QPassSignals in gdb-remote for NetBSD
Summary:
NetBSD is an ELF platform and it uses Elf Auxiliary Vector like Linux and other
modern BSDs.
While t
Author: kamil
Date: Tue Mar 21 12:26:55 2017
New Revision: 298406
URL: http://llvm.org/viewvc/llvm-project?rev=298406&view=rev
Log:
Enable ProcessPOSIXLog on NetBSD
Summary:
NetBSD can share the same logging functionality with Linux and FreeBSD.
Sponsored by
Reviewers: labath, emaste, joerg,
Author: kamil
Date: Tue Mar 21 12:25:47 2017
New Revision: 298405
URL: http://llvm.org/viewvc/llvm-project?rev=298405&view=rev
Log:
Add NetBSD case in Entry::Type::ThreadID
Summary:
NetBSD native threads are printed as 64-bit unsigned integers.
The underlying system type of a thread identity is
Author: kamil
Date: Mon Feb 27 11:52:48 2017
New Revision: 296360
URL: http://llvm.org/viewvc/llvm-project?rev=296360&view=rev
Log:
Support NetBSD Thread ID in lldb-server tests
Summary:
Native Thread ID is retrieved with _lwp_self() on NetBSD.
The returned value is of type int32_t, but for cons
Author: kamil
Date: Thu Feb 23 19:53:45 2017
New Revision: 296071
URL: http://llvm.org/viewvc/llvm-project?rev=296071&view=rev
Log:
Introduce support for Debug Registers in RegisterContextNetBSD_x86_64
Summary:
NetBSD 7.99.62 introduced Debug Registers interface similar to the FreeBSD one.
This i
Author: kamil
Date: Thu Feb 23 19:51:38 2017
New Revision: 296070
URL: http://llvm.org/viewvc/llvm-project?rev=296070&view=rev
Log:
Switch NetBSD from paccept(2) to accept4(2)
Summary:
NetBSD 8.0 will ship with accept4(2) in libc wrapping paccept(2).
This change reduces needless difference with
Author: kamil
Date: Thu Feb 16 19:58:30 2017
New Revision: 295400
URL: http://llvm.org/viewvc/llvm-project?rev=295400&view=rev
Log:
Add myself to CODE_OWNERS.txt for NetBSD
Modified:
lldb/trunk/CODE_OWNERS.txt
Modified: lldb/trunk/CODE_OWNERS.txt
URL:
http://llvm.org/viewvc/llvm-project/lld
Author: kamil
Date: Mon Feb 6 11:55:02 2017
New Revision: 294202
URL: http://llvm.org/viewvc/llvm-project?rev=294202&view=rev
Log:
Switch std::call_once to llvm::call_once
Summary:
The std::call_once implementation in libstdc++ has problems on few systems:
NetBSD, OpenBSD and Linux PPC. LLVM sh
Author: kamil
Date: Sun Feb 5 15:32:38 2017
New Revision: 294145
URL: http://llvm.org/viewvc/llvm-project?rev=294145&view=rev
Log:
Synchronize PlatformNetBSD with Linux
Summary:
Update the code to the new world code.
These changes are needed for remote process plugin.
Sponsored by
Reviewers:
Author: kamil
Date: Fri Feb 3 18:20:24 2017
New Revision: 294071
URL: http://llvm.org/viewvc/llvm-project?rev=294071&view=rev
Log:
Install six.py conditionally
Summary:
The current version of LLDB installs six.py into global python library
directory. This approach produces conflicts downstream
Author: kamil
Date: Thu Feb 2 09:05:56 2017
New Revision: 293895
URL: http://llvm.org/viewvc/llvm-project?rev=293895&view=rev
Log:
Fix multi-process-driver.cpp build on NetBSD
Summary:
Include for strcmp(3) and memset(3).
Sponsored by
Reviewers: joerg, clayborg, emaste, labath
Reviewed By:
Author: kamil
Date: Wed Feb 1 10:02:55 2017
New Revision: 293774
URL: http://llvm.org/viewvc/llvm-project?rev=293774&view=rev
Log:
Do not pass non-POD type variables through variadic function
Summary:
Cannot pass object of non-POD type 'const CMIUtilString' through variadic
function.
This beha
Author: kamil
Date: Wed Feb 1 08:35:08 2017
New Revision: 293770
URL: http://llvm.org/viewvc/llvm-project?rev=293770&view=rev
Log:
Document that LaunchProcessPosixSpawn is used on NetBSD
No functional change.
Sponsored by
Modified:
lldb/trunk/source/Host/common/Host.cpp
Modified: lldb/tr
Author: kamil
Date: Wed Feb 1 08:30:40 2017
New Revision: 293768
URL: http://llvm.org/viewvc/llvm-project?rev=293768&view=rev
Log:
Transform ProcessLauncherLinux to ProcessLauncherPosixFork
Summary:
Use ProcessLauncherPosixFork in Linux and NetBSD.
Changes to ProcessLauncherLinux:
- Limit pers
Author: kamil
Date: Tue Jan 31 07:38:42 2017
New Revision: 293625
URL: http://llvm.org/viewvc/llvm-project?rev=293625&view=rev
Log:
Add NetBSD support in Host::GetCurrentThreadID
Summary:
To retrieve the native thread ID there must be called _lwp_self().
Sponsored by
Reviewers: joerg, clayborg
Author: kamil
Date: Sat Jan 28 14:04:53 2017
New Revision: 293392
URL: http://llvm.org/viewvc/llvm-project?rev=293392&view=rev
Log:
Switch HostInfoNetBSD::GetProgramFileSpec to sysctl(7)
Summary:
Remove dependency on the proc (/proc) filesystem, which is optional.
KERN_PROC_PATHNAME is available
Author: kamil
Date: Sat Jan 28 14:01:53 2017
New Revision: 293391
URL: http://llvm.org/viewvc/llvm-project?rev=293391&view=rev
Log:
Recognize Real-Time Signals on NetBSD
Summary:
Real-Time Signals are available in NetBSD-current and will land NetBSD 8.0.
Older stable versions of NetBSD will not b
On 24.10.2016 20:38, Ed Maste wrote:
> On 24 October 2016 at 06:26, Pavel Labath wrote:
>>
>> It's not my place to tell you how to work, but I'd recommend a
>> different approach to this. If you base your work on the current
>> FreeBSD in-process plugin, then when you get around to actually
>> imp
krytarowski added a comment.
I just scrolled the discussion so it's not really started. Thanks.
My plan is to work on ptrace(2) for about a month.
Then I will take the FreeBSD code as it is and port to NetBSD trying to make it
functional. This is difficult part as there is everywhere OS specifi
krytarowski added a comment.
@emaste What's the status of remote debugging on FreeBSD?
Repository:
rL LLVM
https://reviews.llvm.org/D25756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
krytarowski added a comment.
NetBSD is still focused on amd64-only port.
I start a funded project November 1st on getting x86 process plugin to work.
More details here:
http://blog.netbsd.org/tnf/entry/funded_contract_2016_2017
Estimated time is 4 months full-time.
However there every help is
krytarowski added a comment.
I think it's possible to specify `-DLLVM_CONFIG:PATH` option, if that does the
job.
Repository:
rL LLVM
https://reviews.llvm.org/D25830
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
krytarowski added a comment.
Looks fine, thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D25680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
This change makes sense for stand-alone builds, but if it's possible to remove
branching in this CMake file - please go for it.
https://reviews.llvm.org/D25668
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
krytarowski added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:414
+
+find_package(Backtrace REQUIRED)
tfiala wrote:
> Hi Sylvestre!
>
> It's hard to tell without more context, but it looks like this location has
> most/all configurations going t
Author: kamil
Date: Tue Sep 20 17:26:29 2016
New Revision: 282032
URL: http://llvm.org/viewvc/llvm-project?rev=282032&view=rev
Log:
Unbreak the NetBSD build after recent changes
Similar to r281922 "Try to fix freebsd and android builds."
Replace .AppendArgument(cstr) with .AppendArgument(llvm::S
krytarowski added a subscriber: krytarowski.
krytarowski added a comment.
There are no debug registers supported right now on NetBSD and I was forced to
duplicate the code. It's on TODO and I prefer to streamline the kernel.
Repository:
rL LLVM
https://reviews.llvm.org/D24694
krytarowski added a comment.
In https://reviews.llvm.org/D23883#539471, @mgorny wrote:
> In https://reviews.llvm.org/D23883#539442, @krytarowski wrote:
>
> > It looks good. Remaining TODO for standalone builds:
> >
> > - sanitize six.py usage (it's installed into system-wide directory, where
> >
krytarowski added a comment.
It looks good. Remaining TODO for standalone builds:
- sanitize six.py usage (it's installed into system-wide directory, where
standard py-six lands)
- bump cmake_minimum_required(VERSION 2.8.12.2) to 3.4.3 in
cmake/modules/LLDBStandalone.cmake
Final bits for Windo
On NetBSD /usr/share/misc/style says:
/*
* Kernel include files come first.
*/
#include /* first, */
#include /* next, */
#include /* and then the rest, */
#include /* sorted lexicographically. */
#include
#include /* Non-local incl
krytarowski added a subscriber: krytarowski.
Comment at: cmake/LLDBDependencies.cmake:168
@@ -167,3 +167,3 @@
# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+if ((CMAKE_SYSTEM_N
krytarowski added a comment.
In https://reviews.llvm.org/D23881#525420, @mgorny wrote:
> In https://reviews.llvm.org/D23881#525411, @krytarowski wrote:
>
> > In https://reviews.llvm.org/D23881#525405, @mgorny wrote:
> >
> > > In https://reviews.llvm.org/D23881#525401, @krytarowski wrote:
> > >
>
krytarowski abandoned this revision.
krytarowski added a comment.
Will be addressed in LLVM/Clang.
Repository:
rL LLVM
https://reviews.llvm.org/D22999
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
krytarowski added a comment.
In https://reviews.llvm.org/D23881#525405, @mgorny wrote:
> In https://reviews.llvm.org/D23881#525401, @krytarowski wrote:
>
> > The proper way to fix it is to install CheckAtomic from LLVM/Clang.
> >
> > See https://reviews.llvm.org/D22999
>
>
> Wasn't that rejected?
krytarowski added a comment.
The proper way to fix it is to install CheckAtomic from LLVM/Clang.
See https://reviews.llvm.org/D22999
Repository:
rL LLVM
https://reviews.llvm.org/D23881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
krytarowski added a subscriber: joerg.
krytarowski added a comment.
Looks OK for NetBSD. @joerg are you fine with this?
https://reviews.llvm.org/D23830
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
krytarowski added a comment.
In https://reviews.llvm.org/D23830#524039, @labath wrote:
> @krytarowski: I thought I'd switch netbsd as well, as all the other platforms
> are doing it already. However, if you want to stick with the system demangler
> by default, I can easily change it to OFF ...
krytarowski added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D22999
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
In https://reviews.llvm.org/D22999#501999, @tberghammer wrote:
> I think it is a bad idea to duplicate the CheckAtomic.cmake file from LLVM as
> the 2 copy will diverge over time and cause extra maintenance cost. What do
> you think about trying to change LLVM to in
krytarowski created this revision.
krytarowski added reviewers: labath, zturner.
krytarowski added subscribers: lldb-commits, llvm-commits, joerg.
krytarowski set the repository for this revision to rL LLVM.
LLVM doesn't install "CheckAtomic" cmake file, so add it locally.
Bump required CMake vers
krytarowski abandoned this revision.
krytarowski added a comment.
It no longer builds due to mutex refactoring. Remove as it will need to be
redone for remote debugging.
Repository:
rL LLVM
http://reviews.llvm.org/D20274
___
lldb-commits mailing
krytarowski added a comment.
NetBSD is using newer libstdc++.
#include
std::set s = std::set(std::allocator());
int main() { return 0; }
Compiles (I need to specify the -std=c++11 option) and runs.
I will try it out in the context of LLDB CMake scripts.
http://reviews.llvm.org/D20671
krytarowski accepted this revision.
krytarowski added a comment.
It works for me.
Repository:
rL LLVM
http://reviews.llvm.org/D20344
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
krytarowski added a comment.
I'm going to test it now.
Repository:
rL LLVM
http://reviews.llvm.org/D20344
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
> Does remote debugging interest you?
Yes.
However, on the other hand it's low priority for me right now. I will rebase to
FreeBSD once I will get improved system support in ptrace(2) and functional
process/core instrumentation.
Repository:
rL LLVM
http://rev
krytarowski added a comment.
There is `Mutex::` used in my code. And it's going to be removed soon.
http://reviews.llvm.org/D20278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a subscriber: krytarowski.
krytarowski added a comment.
Looks good, however could we merge firstly Plugins/Process/NetBSD
http://reviews.llvm.org/D20274 ? Otherwise I will need to keep syncing my patch
forever for generic changes.
Thanks!
http://reviews.llvm.org/D20278
__
krytarowski abandoned this revision.
krytarowski added a comment.
I'm giving up on LLDB in NetBSD-7.0, I'm working on upcoming NetBSD-8.0.
Repository:
rL LLVM
http://reviews.llvm.org/D20224
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
krytarowski created this revision.
krytarowski added reviewers: joerg, emaste, clayborg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
NetBSD 7.0 ships with too old libstdc++ and it lacks .
It's no longer true in the current version --
krytarowski resigned from this revision.
krytarowski removed a reviewer: krytarowski.
krytarowski added a comment.
This patch looks dead -- no activity.
Repository:
rL LLVM
http://reviews.llvm.org/D14182
___
lldb-commits mailing list
lldb-commits
Author: kamil
Date: Thu May 12 14:49:17 2016
New Revision: 269332
URL: http://llvm.org/viewvc/llvm-project?rev=269332&view=rev
Log:
Add CMake bits necessary for standalone build
Summary: Developed on NetBSD with pkgsrc.
Reviewers: zturner, labath
Subscribers: jevinskie, zturner, tfiala, Eugene.
Author: kamil
Date: Thu May 12 14:46:08 2016
New Revision: 269330
URL: http://llvm.org/viewvc/llvm-project?rev=269330&view=rev
Log:
Turn on LLDB_EDITLINE_USE_WCHAR on NetBSD
Summary: The editline(3) library in NetBSD is by default internally wide.
Reviewers: clayborg, emaste
Subscribers: joerg,
krytarowski added a comment.
@Eugene.Zelenko do you agree with this patch and what @labath wrote?
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
krytarowski removed rL LLVM as the repository for this revision.
krytarowski updated this revision to Diff 57011.
http://reviews.llvm.org/D20188
Files:
include/lldb/Host/Editline.h
Index: include/lldb/Host/Editline.h
===
--- inclu
krytarowski added a comment.
I changed the string to "some platforms".
http://reviews.llvm.org/D20188
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski created this revision.
krytarowski added reviewers: emaste, clayborg.
krytarowski added subscribers: lldb-commits, joerg.
krytarowski set the repository for this revision to rL LLVM.
The editline(3) library in NetBSD is by default internally wide.
Repository:
rL LLVM
http://reviews
krytarowski added a comment.
In http://reviews.llvm.org/D15067#427814, @Eugene.Zelenko wrote:
> I would like to see implemented my comment about LLVM_CONFIG and
> find_program().
Could you first push this to clang? I don't want to drift from clang myself.
Repository:
rL LLVM
http://review
krytarowski added a comment.
Updated. Can I commit it this way as it is?
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski retitled this revision from "Design building out of sources" to
"Add CMake bits necessary for standalone build".
krytarowski updated this revision to Diff 56970.
Repository:
rL LLVM
http://reviews.llvm.org/D15067
Files:
cmake/modules/LLDBStandalone.cmake
scripts/CMakeLists.txt
krytarowski added a comment.
In http://reviews.llvm.org/D15067#419964, @labath wrote:
> Good question. I don't really have an opinion on that... Is it just that
> single line? (this would be simpler if you uploaded the final version :) ).
> If it just that single line, then I think it's fine. I
krytarowski added a comment.
I'm going to test NetBSD.
http://reviews.llvm.org/D20106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
In http://reviews.llvm.org/D15067#419632, @labath wrote:
> Looks good.
Thanks!
Are you accepting it with the patch in `scripts/CMakeLists.txt` as noted in the
comment?
Repository:
rL LLVM
http://reviews.llvm.org/D15067
_
krytarowski added inline comments.
Comment at: cmake/modules/LLDBStandalone.cmake:85
@@ -63,3 +84,3 @@
if (PYTHON_EXECUTABLE STREQUAL "")
set(Python_ADDITIONAL_VERSIONS 3.5 3.4 3.3 3.2 3.1 3.0 2.7 2.6 2.5)
When I am including conditionally `include(FindP
krytarowski added a comment.
please take a look @zturner @labath
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski updated this revision to Diff 55742.
krytarowski added a comment.
Revamp the patch and reduce it only to the CMake part.
Leave regex code for later.
Repository:
rL LLVM
http://reviews.llvm.org/D15067
Files:
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/LLDBStandalon
krytarowski abandoned this revision.
krytarowski added a comment.
This change will be merged into http://reviews.llvm.org/D15067
Repository:
rL LLVM
http://reviews.llvm.org/D19772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
Author: kamil
Date: Sun May 1 05:23:24 2016
New Revision: 268191
URL: http://llvm.org/viewvc/llvm-project?rev=268191&view=rev
Log:
Fix NetBSD build with CMake 3.5.2
Summary:
Building HEAD of LLDB fails in linking against DebugInfoPDB. It also prints the
following warning:
```
CMake Warning (de
krytarowski added a comment.
Thanks, since it has been accepted. I will commit it and move to LLDBStandalone.
Repository:
rL LLVM
http://reviews.llvm.org/D19685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
krytarowski added a comment.
Great! I think I will close
In http://reviews.llvm.org/D19772#417952, @zturner wrote:
> I'm not sure anyone else uses the standalone build, so as long as the
> changes you're making are confined to LLDBStandalone, it should be fine
Thanks!
I think I can close thi
krytarowski added a comment.
If the change should go to LLDBStandalone.cmake -- can I just put there in one
go all the bits for standalone builds?
--- cmake/modules/LLDBStandalone.cmake.orig 2016-04-27 00:55:49.0
+
+++ cmake/modules/LLDBStandalone.cmake
@@ -2,61 +2,82 @@
krytarowski added a comment.
I'm using standalone build, it may be the reason why this value isn't inherited.
Repository:
rL LLVM
http://reviews.llvm.org/D19772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
krytarowski added a comment.
In http://reviews.llvm.org/D19685#417919, @zturner wrote:
> Ahh ok. Well setting it to 2.8.12 is still fine, if that fixes the problem
> with no other changes then that seems like the best fix.
No other changes are needed.
Repository:
rL LLVM
http://reviews.l
krytarowski added a comment.
In http://reviews.llvm.org/D19772#417922, @zturner wrote:
> Don't we already call FindPythonInterp from somewhere else in the LLDB's
> CMake files?
$ git grep FindPythonInterp
cmake/modules/LLDBStandalone.cmake:include(FindPythonInterp)
scripts/Python/m
krytarowski added a comment.
In http://reviews.llvm.org/D19685#417911, @zturner wrote:
> Can't you just remove that line and let it inherit the minimum version from
> LLVM?
It doesn't work.
CMake Warning (dev) in CMakeLists.txt:
No cmake_minimum_required command is present. A line of c
1 - 100 of 274 matches
Mail list logo
