[Lldb-commits] [lldb] 52f4272 - [lldb] [netbsd] Avoid comparison of signed and unsigned integers

2020-09-10 Thread Kamil Rytarowski via lldb-commits
Author: Kamil Rytarowski Date: 2020-09-10T15:49:15+02:00 New Revision: 52f42720b26a32c9dffc9331841415442f784700 URL: https://github.com/llvm/llvm-project/commit/52f42720b26a32c9dffc9331841415442f784700 DIFF:

[Lldb-commits] [lldb] 273f638 - [LLDB] [doc] Document NetBSD status and sort OSs alphabetically

2020-02-09 Thread Kamil Rytarowski via lldb-commits
Author: Kamil Rytarowski Date: 2020-02-09T18:02:07+01:00 New Revision: 273f638384d69f71838978001bf2f542d472b5f9 URL: https://github.com/llvm/llvm-project/commit/273f638384d69f71838978001bf2f542d472b5f9 DIFF:

[Lldb-commits] [lldb] 5a285f2 - [LLDB] [doc] Remove note about libpanel(3) and NetBSD

2020-02-09 Thread Kamil Rytarowski via lldb-commits
Author: Kamil Rytarowski Date: 2020-02-09T15:01:17+01:00 New Revision: 5a285f207e109221572a0aabc83f2bce521322bd URL: https://github.com/llvm/llvm-project/commit/5a285f207e109221572a0aabc83f2bce521322bd DIFF:

[Lldb-commits] [lldb] 0ea4d18 - [LLDB] [doc] Update the current status of pkgsrc (NetBSD) building

2020-02-09 Thread Kamil Rytarowski via lldb-commits
Author: Kamil Rytarowski Date: 2020-02-09T15:01:17+01:00 New Revision: 0ea4d18a288bf2a4010632f841b421e1bdc5072a URL: https://github.com/llvm/llvm-project/commit/0ea4d18a288bf2a4010632f841b421e1bdc5072a DIFF:

[Lldb-commits] [lldb] r346100 - Fix NetBSD build after "Move path resolution logic out of FileSpec"

2018-11-04 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Sun Nov 4 08:53:16 2018 New Revision: 346100 URL: http://llvm.org/viewvc/llvm-project?rev=346100=rev Log: Fix NetBSD build after "Move path resolution logic out of FileSpec" D53915 Modified: lldb/trunk/source/Host/netbsd/Host.cpp

[Lldb-commits] [lldb] r324251 - Sync PlatformNetBSD.cpp with Linux

2018-02-05 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Mon Feb 5 09:12:23 2018 New Revision: 324251 URL: http://llvm.org/viewvc/llvm-project?rev=324251=rev Log: Sync PlatformNetBSD.cpp with Linux Summary: Various changes in logging from log->Printf() to generic LLDB_LOG(). Sponsored by Reviewers: labath, joerg Reviewed By:

[Lldb-commits] [lldb] r324234 - Fix a crash in *NetBSD::Factory::Launch

2018-02-05 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Mon Feb 5 05:16:22 2018 New Revision: 324234 URL: http://llvm.org/viewvc/llvm-project?rev=324234=rev Log: Fix a crash in *NetBSD::Factory::Launch Summary: We cannot call process_up->SetState() inside the NativeProcessNetBSD::Factory::Launch function because it triggers a

[Lldb-commits] [lldb] r305794 - Correct syntax mistake hidden in assert(3)

2017-06-20 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Tue Jun 20 08:51:06 2017 New Revision: 305794 URL: http://llvm.org/viewvc/llvm-project?rev=305794=rev Log: Correct syntax mistake hidden in assert(3) wait_status cannot be compared with WaitStatus::Stop, go for wait_status.type. Modified:

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

2017-05-29 Thread Kamil Rytarowski via lldb-commits
Do you offer shell account? I don't have Linux and/or s390x to debug it. On 29.05.2017 17:17, Ulrich Weigand via lldb-commits wrote: > Hello, > > It appears this commit broke the > EditlineTestFixture.EditlineReceivesSingleLineText > unit test on s390x-linux. The test now simply hangs (hanging

[Lldb-commits] [lldb] r303907 - Fix bug #28898

2017-05-25 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Thu May 25 15:12:30 2017 New Revision: 303907 URL: http://llvm.org/viewvc/llvm-project?rev=303907=rev Log: Fix bug #28898 lldb: libedit produces garbled, unusable input on Linux Apply patch from Christos Zoulas, upstream libedit developer. It has been tested on NetBSD/amd64.

[Lldb-commits] [lldb] r303823 - Correct compiler warnings and Debug build of the NetBSD target

2017-05-24 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Wed May 24 18:59:50 2017 New Revision: 303823 URL: http://llvm.org/viewvc/llvm-project?rev=303823=rev Log: Correct compiler warnings and Debug build of the NetBSD target Correct files present only in the NetBSD build. Modified:

Re: [Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

2017-04-27 Thread Kamil Rytarowski via lldb-commits
Thanks, I will give it a try! On 27.04.2017 17:59, Zachary Turner wrote: > In case it's not obvious, note the space in the command I said to run. > `git-clang-format` has a dash, and when you run `git clang-format` > (with a space), it will run the file with the dash. > > On Thu, Apr 27, 2017

Re: [Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

2017-04-21 Thread Kamil Rytarowski via lldb-commits
Thanks! I'm working on this, I will test new code soon and submit to review. On 20.04.2017 15:51, Zachary Turner wrote: > Note that getAsInteger returns false on success, so be careful! > On Thu, Apr 20, 2017 at 6:09 AM Pavel Labath via Phabricator >

[Lldb-commits] [lldb] r300853 - Resurrect LLDB Standalone build on NetBSD

2017-04-20 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Thu Apr 20 11:35:36 2017 New Revision: 300853 URL: http://llvm.org/viewvc/llvm-project?rev=300853=rev Log: Resurrect LLDB Standalone build on NetBSD Include CheckIncludeFile for check_include_file() in CMake. Detect in CMake. This header is available on NetBSD. Modified:

[Lldb-commits] [lldb] r300548 - Introduce FPR and Debug Registers/NetBSD/amd64 support

2017-04-18 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Tue Apr 18 07:53:35 2017 New Revision: 300548 URL: http://llvm.org/viewvc/llvm-project?rev=300548=rev Log: Introduce FPR and Debug Registers/NetBSD/amd64 support Summary: This code offers Debug Registers (80386) model in LLDB/amd64. This is initial support and has one issue

Re: [Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-11 Thread Kamil Rytarowski via lldb-commits
Right, This patch happened to does not fully work for me (NetBSD-CORE@ switches were skipped), I will be back to it once I will get my current efforts done on watchpoints and fpr. Thank you for the initial scratch! On 11.04.2017 17:14, Zachary Turner wrote: > Just to be clear, this patch was

[Lldb-commits] [lldb] r299783 - Correct environ parsing on NetBSD

2017-04-07 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Fri Apr 7 11:45:36 2017 New Revision: 299783 URL: http://llvm.org/viewvc/llvm-project?rev=299783=rev Log: Correct environ parsing on NetBSD Summary: This replaces old code in Host::GetEnvironment for NetBSD with the version from Linux. This makes parsing environment

[Lldb-commits] [lldb] r299109 - Battery of NetBSD support improvements

2017-03-30 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Thu Mar 30 15:25:29 2017 New Revision: 299109 URL: http://llvm.org/viewvc/llvm-project?rev=299109=rev Log: Battery of NetBSD support improvements Summary: Include initial support for: - single step mode (PT_STEP) - single step trap handling (TRAP_TRACE) - exec() trap

[Lldb-commits] [lldb] r299023 - Add NetBSD path for Debugging Information in Separate Files

2017-03-29 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Wed Mar 29 14:52:24 2017 New Revision: 299023 URL: http://llvm.org/viewvc/llvm-project?rev=299023=rev Log: Add NetBSD path for Debugging Information in Separate Files Summary: NetBSD stores debug information files in the `/usr/libdata/debug` path. This change fixes debugging

[Lldb-commits] [lldb] r298970 - Remove dead include from the NetBSD code.

2017-03-28 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Tue Mar 28 20:10:21 2017 New Revision: 298970 URL: http://llvm.org/viewvc/llvm-project?rev=298970=rev Log: Remove dead include from the NetBSD code. Modified: lldb/trunk/source/Host/netbsd/Host.cpp Modified: lldb/trunk/source/Host/netbsd/Host.cpp URL:

[Lldb-commits] [lldb] r298953 - Add support for tracing hello-world application on NetBSD

2017-03-28 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Tue Mar 28 17:43:17 2017 New Revision: 298953 URL: http://llvm.org/viewvc/llvm-project?rev=298953=rev Log: Add support for tracing hello-world application on NetBSD Summary: This patch is a stripped down from features a NetBSD process code (patch is kept under 2k LOC). This

[Lldb-commits] [lldb] r298810 - [LLDB] OpenBSD support

2017-03-26 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Sun Mar 26 10:34:57 2017 New Revision: 298810 URL: http://llvm.org/viewvc/llvm-project?rev=298810=rev Log: [LLDB] OpenBSD support Summary: Add basic OpenBSD support. This is enough to be able to analyze core dumps for OpenBSD/amd64, OpenBSD/arm, OpenBSD/arm64 and

[Lldb-commits] [lldb] r298409 - Create instance of DynamicLoaderPOSIXDYLD on NetBSD

2017-03-21 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Tue Mar 21 12:39:15 2017 New Revision: 298409 URL: http://llvm.org/viewvc/llvm-project?rev=298409=rev Log: Create instance of DynamicLoaderPOSIXDYLD on NetBSD Summary: NetBSD is a modern ELF UNIX-like system. There is requires DynamicLoaderPOSIXDYLD e.g. for ELF AUXV reading

[Lldb-commits] [lldb] r298408 - Add stub for PluginProcessNetBSD

2017-03-21 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Tue Mar 21 12:30:47 2017 New Revision: 298408 URL: http://llvm.org/viewvc/llvm-project?rev=298408=rev Log: Add stub for PluginProcessNetBSD Summary: This is the base for introduction of further features to support Process Tracing on NetBSD, in local and remote setup. This

[Lldb-commits] [lldb] r298407 - Enable AUXV and QPassSignals in gdb-remote for NetBSD

2017-03-21 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Tue Mar 21 12:27:59 2017 New Revision: 298407 URL: http://llvm.org/viewvc/llvm-project?rev=298407=rev Log: Enable AUXV and QPassSignals in gdb-remote for NetBSD Summary: NetBSD is an ELF platform and it uses Elf Auxiliary Vector like Linux and other modern BSDs. While there

[Lldb-commits] [lldb] r298405 - Add NetBSD case in Entry::Type::ThreadID

2017-03-21 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Tue Mar 21 12:25:47 2017 New Revision: 298405 URL: http://llvm.org/viewvc/llvm-project?rev=298405=rev Log: Add NetBSD case in Entry::Type::ThreadID Summary: NetBSD native threads are printed as 64-bit unsigned integers. The underlying system type of a thread identity is

[Lldb-commits] [lldb] r296360 - Support NetBSD Thread ID in lldb-server tests

2017-02-27 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Mon Feb 27 11:52:48 2017 New Revision: 296360 URL: http://llvm.org/viewvc/llvm-project?rev=296360=rev Log: Support NetBSD Thread ID in lldb-server tests Summary: Native Thread ID is retrieved with _lwp_self() on NetBSD. The returned value is of type int32_t, but for

[Lldb-commits] [lldb] r296071 - Introduce support for Debug Registers in RegisterContextNetBSD_x86_64

2017-02-23 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Thu Feb 23 19:53:45 2017 New Revision: 296071 URL: http://llvm.org/viewvc/llvm-project?rev=296071=rev Log: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64 Summary: NetBSD 7.99.62 introduced Debug Registers interface similar to the FreeBSD one. This

[Lldb-commits] [lldb] r296070 - Switch NetBSD from paccept(2) to accept4(2)

2017-02-23 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Thu Feb 23 19:51:38 2017 New Revision: 296070 URL: http://llvm.org/viewvc/llvm-project?rev=296070=rev Log: Switch NetBSD from paccept(2) to accept4(2) Summary: NetBSD 8.0 will ship with accept4(2) in libc wrapping paccept(2). This change reduces needless difference with

[Lldb-commits] [lldb] r295400 - Add myself to CODE_OWNERS.txt for NetBSD

2017-02-16 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Thu Feb 16 19:58:30 2017 New Revision: 295400 URL: http://llvm.org/viewvc/llvm-project?rev=295400=rev Log: Add myself to CODE_OWNERS.txt for NetBSD Modified: lldb/trunk/CODE_OWNERS.txt Modified: lldb/trunk/CODE_OWNERS.txt URL:

[Lldb-commits] [lldb] r294202 - Switch std::call_once to llvm::call_once

2017-02-06 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Mon Feb 6 11:55:02 2017 New Revision: 294202 URL: http://llvm.org/viewvc/llvm-project?rev=294202=rev Log: Switch std::call_once to llvm::call_once Summary: The std::call_once implementation in libstdc++ has problems on few systems: NetBSD, OpenBSD and Linux PPC. LLVM ships

[Lldb-commits] [lldb] r294145 - Synchronize PlatformNetBSD with Linux

2017-02-05 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Sun Feb 5 15:32:38 2017 New Revision: 294145 URL: http://llvm.org/viewvc/llvm-project?rev=294145=rev Log: Synchronize PlatformNetBSD with Linux Summary: Update the code to the new world code. These changes are needed for remote process plugin. Sponsored by Reviewers:

[Lldb-commits] [lldb] r294071 - Install six.py conditionally

2017-02-03 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Fri Feb 3 18:20:24 2017 New Revision: 294071 URL: http://llvm.org/viewvc/llvm-project?rev=294071=rev Log: Install six.py conditionally Summary: The current version of LLDB installs six.py into global python library directory. This approach produces conflicts downstream with

[Lldb-commits] [lldb] r293895 - Fix multi-process-driver.cpp build on NetBSD

2017-02-02 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Thu Feb 2 09:05:56 2017 New Revision: 293895 URL: http://llvm.org/viewvc/llvm-project?rev=293895=rev Log: Fix multi-process-driver.cpp build on NetBSD Summary: Include for strcmp(3) and memset(3). Sponsored by Reviewers: joerg, clayborg, emaste, labath Reviewed By:

[Lldb-commits] [lldb] r293774 - Do not pass non-POD type variables through variadic function

2017-02-01 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Wed Feb 1 10:02:55 2017 New Revision: 293774 URL: http://llvm.org/viewvc/llvm-project?rev=293774=rev Log: Do not pass non-POD type variables through variadic function Summary: Cannot pass object of non-POD type 'const CMIUtilString' through variadic function. This behavior

[Lldb-commits] [lldb] r293770 - Document that LaunchProcessPosixSpawn is used on NetBSD

2017-02-01 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Wed Feb 1 08:35:08 2017 New Revision: 293770 URL: http://llvm.org/viewvc/llvm-project?rev=293770=rev Log: Document that LaunchProcessPosixSpawn is used on NetBSD No functional change. Sponsored by Modified: lldb/trunk/source/Host/common/Host.cpp Modified:

[Lldb-commits] [lldb] r293768 - Transform ProcessLauncherLinux to ProcessLauncherPosixFork

2017-02-01 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Wed Feb 1 08:30:40 2017 New Revision: 293768 URL: http://llvm.org/viewvc/llvm-project?rev=293768=rev Log: Transform ProcessLauncherLinux to ProcessLauncherPosixFork Summary: Use ProcessLauncherPosixFork in Linux and NetBSD. Changes to ProcessLauncherLinux: - Limit

[Lldb-commits] [lldb] r293625 - Add NetBSD support in Host::GetCurrentThreadID

2017-01-31 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Tue Jan 31 07:38:42 2017 New Revision: 293625 URL: http://llvm.org/viewvc/llvm-project?rev=293625=rev Log: Add NetBSD support in Host::GetCurrentThreadID Summary: To retrieve the native thread ID there must be called _lwp_self(). Sponsored by Reviewers: joerg, clayborg,

[Lldb-commits] [lldb] r293392 - Switch HostInfoNetBSD::GetProgramFileSpec to sysctl(7)

2017-01-28 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Sat Jan 28 14:04:53 2017 New Revision: 293392 URL: http://llvm.org/viewvc/llvm-project?rev=293392=rev Log: Switch HostInfoNetBSD::GetProgramFileSpec to sysctl(7) Summary: Remove dependency on the proc (/proc) filesystem, which is optional. KERN_PROC_PATHNAME is available in

[Lldb-commits] [lldb] r293391 - Recognize Real-Time Signals on NetBSD

2017-01-28 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Sat Jan 28 14:01:53 2017 New Revision: 293391 URL: http://llvm.org/viewvc/llvm-project?rev=293391=rev Log: Recognize Real-Time Signals on NetBSD Summary: Real-Time Signals are available in NetBSD-current and will land NetBSD 8.0. Older stable versions of NetBSD will not be

Re: [Lldb-commits] LLGS for Free/NetBSD (was: Re: [PATCH] D25756: FreeBSD ARM support for software single step.)

2016-10-24 Thread Kamil Rytarowski via lldb-commits
On 24.10.2016 20:38, Ed Maste wrote: > On 24 October 2016 at 06:26, Pavel Labath wrote: >> >> It's not my place to tell you how to work, but I'd recommend a >> different approach to this. If you base your work on the current >> FreeBSD in-process plugin, then when you get

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

2016-10-21 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. I just scrolled the discussion so it's not really started. Thanks. My plan is to work on ptrace(2) for about a month. Then I will take the FreeBSD code as it is and port to NetBSD trying to make it functional. This is difficult part as there is everywhere OS

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

2016-10-21 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. NetBSD is still focused on amd64-only port. I start a funded project November 1st on getting x86 process plugin to work. More details here: http://blog.netbsd.org/tnf/entry/funded_contract_2016_2017 Estimated time is 4 months full-time. However there every help

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

2016-10-20 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. I think it's possible to specify `-DLLVM_CONFIG:PATH` option, if that does the job. Repository: rL LLVM https://reviews.llvm.org/D25830 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25680: [cmake] Make dependencies of lldb libraries private, take 2

2016-10-18 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Looks fine, thanks. Repository: rL LLVM https://reviews.llvm.org/D25680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

2016-10-17 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. This change makes sense for stand-alone builds, but if it's possible to remove branching in this CMake file - please go for it. https://reviews.llvm.org/D25668 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

2016-10-11 Thread Kamil Rytarowski via lldb-commits
krytarowski added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:414 + +find_package(Backtrace REQUIRED) tfiala wrote: > Hi Sylvestre! > > It's hard to tell without more context, but it looks like this location has > most/all configurations going

[Lldb-commits] [lldb] r282032 - Unbreak the NetBSD build after recent changes

2016-09-20 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Tue Sep 20 17:26:29 2016 New Revision: 282032 URL: http://llvm.org/viewvc/llvm-project?rev=282032=rev Log: Unbreak the NetBSD build after recent changes Similar to r281922 "Try to fix freebsd and android builds." Replace .AppendArgument(cstr) with

Re: [Lldb-commits] [PATCH] D23883: Remove MIUtilParse (no longer used)

2016-09-11 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In https://reviews.llvm.org/D23883#539471, @mgorny wrote: > In https://reviews.llvm.org/D23883#539442, @krytarowski wrote: > > > It looks good. Remaining TODO for standalone builds: > > > > - sanitize six.py usage (it's installed into system-wide directory, where >

Re: [Lldb-commits] [PATCH] D23883: Remove MIUtilParse (no longer used)

2016-09-10 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. It looks good. Remaining TODO for standalone builds: - sanitize six.py usage (it's installed into system-wide directory, where standard py-six lands) - bump cmake_minimum_required(VERSION 2.8.12.2) to 3.4.3 in cmake/modules/LLDBStandalone.cmake Final bits for

Re: [Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

2016-09-06 Thread Kamil Rytarowski via lldb-commits
On NetBSD /usr/share/misc/style says:   /*  * Kernel include files come first.  */ #include          /* first, */ #include          /*   next, */ #include          /*   and then the rest, */ #include         /*   sorted lexicographically.  */ #include #include           /* Non-local

Re: [Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

2016-08-29 Thread Kamil Rytarowski via lldb-commits
krytarowski added a subscriber: krytarowski. Comment at: cmake/LLDBDependencies.cmake:168 @@ -167,3 +167,3 @@ # On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc. -if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD") +if

Re: [Lldb-commits] [PATCH] D23881: [LLDB] [cmake]: Add local module directory to search path for standalone build

2016-08-25 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In https://reviews.llvm.org/D23881#525420, @mgorny wrote: > In https://reviews.llvm.org/D23881#525411, @krytarowski wrote: > > > In https://reviews.llvm.org/D23881#525405, @mgorny wrote: > > > > > In https://reviews.llvm.org/D23881#525401, @krytarowski wrote: > > > >

Re: [Lldb-commits] [PATCH] D22999: Resurrect standalone build

2016-08-25 Thread Kamil Rytarowski via lldb-commits
krytarowski abandoned this revision. krytarowski added a comment. Will be addressed in LLVM/Clang. Repository: rL LLVM https://reviews.llvm.org/D22999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D23881: [LLDB] [cmake]: Add local module directory to search path for standalone build

2016-08-25 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In https://reviews.llvm.org/D23881#525405, @mgorny wrote: > In https://reviews.llvm.org/D23881#525401, @krytarowski wrote: > > > The proper way to fix it is to install CheckAtomic from LLVM/Clang. > > > > See https://reviews.llvm.org/D22999 > > > Wasn't that

Re: [Lldb-commits] [PATCH] D23830: Add cmake option to choose whether to use the builtin demangler

2016-08-25 Thread Kamil Rytarowski via lldb-commits
krytarowski added a subscriber: joerg. krytarowski added a comment. Looks OK for NetBSD. @joerg are you fine with this? https://reviews.llvm.org/D23830 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D23830: Add cmake option to choose whether to use the builtin demangler

2016-08-24 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In https://reviews.llvm.org/D23830#524039, @labath wrote: > @krytarowski: I thought I'd switch netbsd as well, as all the other platforms > are doing it already. However, if you want to stick with the system demangler > by default, I can easily change it to OFF ...

Re: [Lldb-commits] [PATCH] D22999: Resurrect standalone build

2016-08-08 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D22999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22999: Resurrect standalone build

2016-08-01 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In https://reviews.llvm.org/D22999#501999, @tberghammer wrote: > I think it is a bad idea to duplicate the CheckAtomic.cmake file from LLVM as > the 2 copy will diverge over time and cause extra maintenance cost. What do > you think about trying to change LLVM to

[Lldb-commits] [PATCH] D22999: Resurrect standalone build

2016-07-31 Thread Kamil Rytarowski via lldb-commits
krytarowski created this revision. krytarowski added reviewers: labath, zturner. krytarowski added subscribers: lldb-commits, llvm-commits, joerg. krytarowski set the repository for this revision to rL LLVM. LLVM doesn't install "CheckAtomic" cmake file, so add it locally. Bump required CMake

Re: [Lldb-commits] [PATCH] D20274: Add preliminary bits for Plugins/Process/NetBSD

2016-05-26 Thread Kamil Rytarowski via lldb-commits
krytarowski abandoned this revision. krytarowski added a comment. It no longer builds due to mutex refactoring. Remove as it will need to be redone for remote debugging. Repository: rL LLVM http://reviews.llvm.org/D20274 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D20344: [LLDB] Fix standalone LLDB build when LLVM/Clang were built with LLVM_INSTALL_TOOLCHAIN_ONLY=ON

2016-05-18 Thread Kamil Rytarowski via lldb-commits
krytarowski accepted this revision. krytarowski added a comment. It works for me. Repository: rL LLVM http://reviews.llvm.org/D20344 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D20274: Add preliminary bits for Plugins/Process/NetBSD

2016-05-16 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. > Does remote debugging interest you? Yes. However, on the other hand it's low priority for me right now. I will rebase to FreeBSD once I will get improved system support in ptrace(2) and functional process/core instrumentation. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-16 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. There is `Mutex::` used in my code. And it's going to be removed soon. http://reviews.llvm.org/D20278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D20224: Unbreak build on NetBSD-7.0

2016-05-12 Thread Kamil Rytarowski via lldb-commits
krytarowski created this revision. krytarowski added reviewers: joerg, emaste, clayborg. krytarowski added a subscriber: lldb-commits. krytarowski set the repository for this revision to rL LLVM. NetBSD 7.0 ships with too old libstdc++ and it lacks . It's no longer true in the current version --

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

2016-05-12 Thread Kamil Rytarowski via lldb-commits
krytarowski resigned from this revision. krytarowski removed a reviewer: krytarowski. krytarowski added a comment. This patch looks dead -- no activity. Repository: rL LLVM http://reviews.llvm.org/D14182 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

2016-05-12 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. @Eugene.Zelenko do you agree with this patch and what @labath wrote? Repository: rL LLVM http://reviews.llvm.org/D15067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D20188: Turn on LLDB_EDITLINE_USE_WCHAR on NetBSD

2016-05-11 Thread Kamil Rytarowski via lldb-commits
krytarowski created this revision. krytarowski added reviewers: emaste, clayborg. krytarowski added subscribers: lldb-commits, joerg. krytarowski set the repository for this revision to rL LLVM. The editline(3) library in NetBSD is by default internally wide. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

2016-05-11 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Updated. Can I commit it this way as it is? Repository: rL LLVM http://reviews.llvm.org/D15067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

2016-05-11 Thread Kamil Rytarowski via lldb-commits
krytarowski retitled this revision from "Design building out of sources" to "Add CMake bits necessary for standalone build". krytarowski updated this revision to Diff 56970. Repository: rL LLVM http://reviews.llvm.org/D15067 Files: cmake/modules/LLDBStandalone.cmake

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

2016-05-11 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D15067#419964, @labath wrote: > Good question. I don't really have an opinion on that... Is it just that > single line? (this would be simpler if you uploaded the final version :) ). > If it just that single line, then I think it's fine.

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

2016-05-03 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D15067#419632, @labath wrote: > Looks good. Thanks! Are you accepting it with the patch in `scripts/CMakeLists.txt` as noted in the comment? Repository: rL LLVM http://reviews.llvm.org/D15067

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

2016-05-01 Thread Kamil Rytarowski via lldb-commits
krytarowski added inline comments. Comment at: cmake/modules/LLDBStandalone.cmake:85 @@ -63,3 +84,3 @@ if (PYTHON_EXECUTABLE STREQUAL "") set(Python_ADDITIONAL_VERSIONS 3.5 3.4 3.3 3.2 3.1 3.0 2.7 2.6 2.5) When I am including conditionally

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

2016-05-01 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. please take a look @zturner @labath Repository: rL LLVM http://reviews.llvm.org/D15067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

2016-05-01 Thread Kamil Rytarowski via lldb-commits
krytarowski updated this revision to Diff 55742. krytarowski added a comment. Revamp the patch and reduce it only to the CMake part. Leave regex code for later. Repository: rL LLVM http://reviews.llvm.org/D15067 Files: cmake/modules/LLDBStandalone.cmake Index:

[Lldb-commits] [lldb] r268191 - Fix NetBSD build with CMake 3.5.2

2016-05-01 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Sun May 1 05:23:24 2016 New Revision: 268191 URL: http://llvm.org/viewvc/llvm-project?rev=268191=rev Log: Fix NetBSD build with CMake 3.5.2 Summary: Building HEAD of LLDB fails in linking against DebugInfoPDB. It also prints the following warning: ``` CMake Warning (dev)

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-05-01 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thanks, since it has been accepted. I will commit it and move to LLDBStandalone. Repository: rL LLVM http://reviews.llvm.org/D19685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. If the change should go to LLDBStandalone.cmake -- can I just put there in one go all the bits for standalone builds? --- cmake/modules/LLDBStandalone.cmake.orig 2016-04-27 00:55:49.0 + +++ cmake/modules/LLDBStandalone.cmake @@ -2,61 +2,82 @@

[Lldb-commits] [PATCH] D19772: Detect Python's executable on NetBSD

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski created this revision. krytarowski added reviewers: emaste, labath, zturner. krytarowski added subscribers: lldb-commits, joerg. krytarowski set the repository for this revision to rL LLVM. NetBSD ships with pkgsrc that installs versioned Python executables with suffix, like:

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski updated this revision to Diff 55729. krytarowski added a comment. Set minimal required CMake to 2.8.12.2 - fixes build on NetBSD with CMake 3.5.2 Repository: rL LLVM http://reviews.llvm.org/D19685 Files: CMakeLists.txt cmake/modules/LLDBStandalone.cmake Index:

Re: [Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

2016-04-30 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D19685#417896, @zturner wrote: > I don't think we should be adding more CMake hacks in lldb when llvm is > supposed to handle this. Why don't the existing lines work? I don't know. Perhaps because LLVM and Clang requires newer cmake than

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

2016-03-02 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D17724#366479, @clayborg wrote: > Our current consistent way of parsing options is to use getopt_long() > everywhere. Actually with usage of `getopt_long_only()` which is unportable. http://reviews.llvm.org/D17724

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

2016-02-09 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Just in case someone will be quicker, new version against revamped CMake dirs is in pkgsrc-wip/lldb-git Repository: rL LLVM http://reviews.llvm.org/D15067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D16818: [lldb/NetBSD] Remove dead function. Unbreak the build with -Werror

2016-02-04 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Feel free to land it. http://reviews.llvm.org/D16818 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-02-01 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thank you very much! You made this patch possible. Repository: rL LLVM http://reviews.llvm.org/D16508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r259462 - NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-02-01 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Mon Feb 1 21:47:44 2016 New Revision: 259462 URL: http://llvm.org/viewvc/llvm-project?rev=259462=rev Log: NetBSD: Define initial RegisterContextNetBSD_x86_64 Summary: Add basic support, i386 version will be added later. Reviewers: emaste, joerg, clayborg, tfiala

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-31 Thread Kamil Rytarowski via lldb-commits
krytarowski updated this revision to Diff 46489. krytarowski added a comment. Revamped version. Changes: - change type of registers from int64_t to uint64_t, - remove unsupported debug x86 registers, - model UserArea after mcontext_t Patch building tested. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-28 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thank you @clayborg and @tfiala I'm processing your feedback. In case of further questions I will let you know. Your answers make the things more clear. Repository: rL LLVM http://reviews.llvm.org/D16508 ___

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-26 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thank you @clayborg for your notes. I'm planning to submit new version in the coming days. Repository: rL LLVM http://reviews.llvm.org/D16508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-24 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. It looks like UserArea will need to map this structure: typedef struct { __gregset_t __gregs; __greg_t_mc_tlsbase; __fpregset_t__fpregs; } mcontext_t; - src/sys/arch/amd64/include/mcontext.h

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-23 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. I had difficulties with this code, as each platform implements it differently. What is DBG? What should be there? What is UserArea? What should be there? Repository: rL LLVM http://reviews.llvm.org/D16508 ___

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

2016-01-23 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. For the reference, I hold on with pushing this forward, till I will get significantly larger coverage with tests on my platform. I keep this patch locally for local development. Repository: rL LLVM http://reviews.llvm.org/D15067

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-23 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. NetBSD currently doesn't support debug registers. Repository: rL LLVM http://reviews.llvm.org/D16508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15566: Patch cmake to allow detection of python 2.7.9+

2015-12-16 Thread Kamil Rytarowski via lldb-commits
krytarowski added a subscriber: krytarowski. krytarowski added a comment. In http://reviews.llvm.org/D15566#311998, @zturner wrote: > Where did you get this version of Python? I don't see anything wrong with > this patch, but I'm a little curious what this + means I think a patched version.

Re: [Lldb-commits] Buildbot numbers for week of 12/06/2015 - 12/12/2015

2015-12-16 Thread Kamil Rytarowski via lldb-commits
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 15.12.2015 20:23, Galina Kistanova via lldb-commits wrote: > Hello everyone, > > Below are some buildbot numbers for the last week of 12/06/2015 - > 12/12/2015. > > Thanks > > Galina > > > > Top 10 fastest builders(not docs): > >

Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

2015-12-14 Thread Kamil Rytarowski via lldb-commits
krytarowski added inline comments. Comment at: source/Target/UnixSignals.cpp:66 @@ -64,4 +65,3 @@ case llvm::Triple::FreeBSD: case llvm::Triple::OpenBSD: return std::make_shared(); emaste wrote: > Not part of your change, but just

Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

2015-12-14 Thread Kamil Rytarowski via lldb-commits
krytarowski updated this revision to Diff 42800. krytarowski added a comment. Improve abc order of source files Repository: rL LLVM http://reviews.llvm.org/D15482 Files: source/Plugins/Process/Utility/CMakeLists.txt source/Plugins/Process/Utility/NetBSDSignals.cpp

Re: [Lldb-commits] [lldb] r255592 - Welcome to NetBSD signals

2015-12-14 Thread Kamil Rytarowski via lldb-commits
ldb-commits >>> <lldb-commits@lists.llvm.org> wrote: >>> >>> On Mon, Dec 14, 2015 at 4:50 PM, Kamil Rytarowski via >>> lldb-commits <lldb-commits@lists.llvm.org> wrote: >>>> Author: kamil Date: Mon Dec 14 18:50:19 2015 New Revision: >>>>

Re: [Lldb-commits] [PATCH] D15482: Welcome to NetBSD signals

2015-12-14 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thank you. After fixing the order I'm going to land this diff. Comment at: source/Plugins/Process/Utility/CMakeLists.txt:6 @@ -5,2 +5,3 @@ FreeBSDSignals.cpp + NetBSDSignals.cpp GDBRemoteSignals.cpp emaste wrote: > Should

[Lldb-commits] [lldb] r255592 - Welcome to NetBSD signals

2015-12-14 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Mon Dec 14 18:50:19 2015 New Revision: 255592 URL: http://llvm.org/viewvc/llvm-project?rev=255592=rev Log: Welcome to NetBSD signals Summary: Signals 1-32 are matching the default UNIX platform. There are platform specific ones above 32. From the `/usr/include/sys/signal.h`

  1   2   >