[Lldb-commits] [PATCH] D97205: [lldb][NFC] Don't inherit from UserID in ValueObject

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. ValueObject inherits from UserID which is just a bad idea: - The inheritance gives ValueObject some member

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. You can use `expect_var_path` to test `frame var` (LLDB calls the frame var input "expressions paths", hence the `_path` suffix). That way you can test all of these things for

[Lldb-commits] [PATCH] D96947: [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

teemperor added a comment. Also I'm going to clean the existing error messages from redundant newlines in a separate NFC commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96947/new/ https://reviews.llvm.org/D96947 ___ lldb-commits

[Lldb-commits] [PATCH] D96947: [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

teemperor added a comment. FWIW, I am very interested in finding out how we can over-engineer this. I do believe there is potential to let tablegen generate the error message strings which then could also check the new lines for us. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D96947: [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. The current API for printing errors/warnings/messages from LLDB commands sometimes adds newlines behind the

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor updated this revision to Diff 324551. teemperor added a comment. - Also clarify error message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96939/new/ https://reviews.llvm.org/D96939 Files: lldb/source/Commands/CommandObjectTarget.cpp Index:

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor added a comment. In D96939#2570831 , @jasonmolenda wrote: > In D96939#2570830 , @teemperor wrote: > >> What about: >> >> error: Couldn't recognise core file format of . >> note: If the file is a core

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor added a comment. In D96939#2570810 , @jasonmolenda wrote: > I mean, I'm also fine with suggesting that the file might be compressed, > because this is a REAL common source of an unrecognized core file format. > But also we can more clearly

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:431 + result.AppendMessage( + "Note: If the passed file is a compressed file archive containing" + " a core file, you first need to manually extract the

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor updated this revision to Diff 324546. teemperor added a comment. - Made `note:` lower case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96939/new/ https://reviews.llvm.org/D96939 Files: lldb/source/Commands/CommandObjectTarget.cpp Index:

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Core files are frequently compressed in some compressed archive and users aren't aware that LLDB can't extract

[Lldb-commits] [PATCH] D96861: [lldb][NFC] Delete deleted const char* overloads of SetValueFromString

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bcc03767e44: [lldb][NFC] Delete deleted const char* overloads of SetValueFromString (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

teemperor added inline comments. Comment at: lldb/unittests/Interpreter/TestOptionValue.cpp:173 + // Trigger the callback second time. + file_list_copy_ptr->SetValueFromString(llvm::StringRef("0 another/path"), +

[Lldb-commits] [PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

teemperor added a comment. LGTM. Regarding the LLDB example: Given that the LLDB API is in theory not bound to the semantics a specific language, I think one can argue that `IsAnonymousType` could also return true for unnamed classes. The use case that triggered this whole discussion was

[Lldb-commits] [PATCH] D96795: [FileCollector] Fix that the file system case-sensitivity check was inverted

This revision was automatically updated to reflect the committed changes. Closed by commit rGf88b502d9bc7: [FileCollector] Fix that the file system case-sensitivity check was inverted (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

teemperor added a comment. In D96427#2555251 , @JDevlieghere wrote: > LGTM. I'm surprised the `dsymutil` one slipped through the cracks, we have a > bot that should (?) be testing this configuration: >

[Lldb-commits] [PATCH] D96550: Fix LLDB_LOG calls to use correct formatting

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96550/new/ https://reviews.llvm.org/D96550 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D96556: [lldb] Let TestPExpectTest test the right test class

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c118831a37a: [lldb] Let TestPExpectTest test the right test class (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

teemperor added a comment. This LGTM module the unrelated changes in that one file. A third pair of eyes probably won't hurt, so I'll give the others a change to look over this before I accept, but otherwise I'll just accept tomorrow. (Btw, if you intend to cherry-pick this into swift/main for

[Lldb-commits] [PATCH] D91723: [lldb] Fix that running a top level expression without a process fails with a cryptic error

This revision was automatically updated to reflect the committed changes. Closed by commit rG71536fd03108: [lldb] Fix that running a top level expression without a process fails with a… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D94307: [lldb] Don't emit a warning when using Objective-C getters in expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG19b4d3ce27d5: [lldb] Dont emit a warning when using Objective-C getters in expressions (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to

[Lldb-commits] [PATCH] D95185: lldb: repair the standalone build for Windows

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. (I'm very sorry for the delay, that slipped out of my review queue.) Wouldn't changing this logic to an explicit `get_target_property` call break the multi-config projects

[Lldb-commits] [PATCH] D96366: Remove uneeded CopyType from BlockPointerSyntheticFrontEnd

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: lldb/test/API/lang/c/blocks/main.c:10 + + return z; +} 4 spaces indentation instead of 3 (2 would probably be better,

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

teemperor accepted this revision. teemperor added a comment. Don't see any change that looks wrong from scrolling over this, so LGTM Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/atomic/TestLibCxxAtomic.py:59 -

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

teemperor added a comment. In D95813#2535209 , @JDevlieghere wrote: > Cool, I was under the impression @teemperor had already done something > similar, but I must be misremembering. I ran one big regex that got most of the Equal/Less/Bigger than, but I

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

teemperor added a comment. I reverted D95761 (see Jim's comment), so you can just re-add your old test. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92164/new/ https://reviews.llvm.org/D92164 ___

[Lldb-commits] [PATCH] D95761: [lldb] Use current execution context in SBDebugger

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG754ab803b8dc: [lldb] Use current execution context in SBDebugger (authored by werat, committed by teemperor). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D95761: [lldb] Use current execution context in SBDebugger

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95761/new/ https://reviews.llvm.org/D95761

[Lldb-commits] [PATCH] D95686: [lldb/API] Expose Module::IsLoadedInTarget() to SB API (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. some minor things in the comments, otherwise LGTM Comment at: lldb/bindings/interface/SBTarget.i:946 + +:param module: `SBModule` that should be loaded in this

[Lldb-commits] [PATCH] D95686: [lldb/API] Expose Module::IsLoadedInTarget() to SB API (NFC)

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Wouldn't it make more sense to give `SBTarget` a `IsLoaded` function? The function reads more like "please check if this target is loaded" which doesn't make sense. I get that

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

teemperor added a comment. Not sure why we even run the DSYM variant if the test disables building DSYM. I just made this a no-debug-info-test in 060b51e0524aed6b6cc452baa8eb6d663a580eee which gets it running again on the

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

teemperor added a comment. This is breaking the ` functionalities/archives/TestBSDArchives.py` test on macOS. It seems the MAKE_DSYM flag somehow looses its effect when the dsym version of the test is running (and then we fail generating a dsym without input files):

[Lldb-commits] [PATCH] D95096: [lldb][import-std-module] Do some basic file checks before trying to import a module

This revision was automatically updated to reflect the committed changes. Closed by commit rG99b7b41edf4f: [lldb][import-std-module] Do some basic file checks before trying to import a… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior

[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95059/new/ https://reviews.llvm.org/D95059

[Lldb-commits] [PATCH] D94967: [lldb][docs] Filter out 'thisown' attribute and inheritance boilerplate

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c69ff4b03ab: [lldb][docs] Filter out thisown attribute and inheritance boilerplate (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D94991: [lldb][docs] Remove -webkit-hyphens in table cells so that table widths are correct on Safari

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fce3b240b6b: [lldb][docs] Remove -webkit-hyphens in table cells so that table widths are… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D94900: [lldb][docs] Update .htaccess to redirect from old SB API documentation to new one

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f8099509030: [lldb][docs] Update .htaccess to redirect from old SB API documentation to new… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D94959: [lldb][docs] Add a doc page for enums and constants

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cae8b33297b: [lldb][docs] Add a doc page for enums and constants (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D94917: [lldb] Fix crash in "help memory read"

teemperor added a comment. From what I understand this means D91378 is no longer necessary. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94917/new/ https://reviews.llvm.org/D94917

[Lldb-commits] [PATCH] D94899: [lldb][docs] Use 'any' as the default role in LLDB's sphinx project

This revision was automatically updated to reflect the committed changes. Closed by commit rGa58aceffad61: [lldb][docs] Use any as the default role in LLDBs sphinx project (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference

teemperor added a comment. In D94489#2503662 , @tschuett wrote: > There is no syntax highlighting for Python in sphinx? The code in > https://lldb.llvm.org/python_api/lldb.SBDebugger.html#lldb.SBDebugger > is hard to read. > > Even the line breaks between

[Lldb-commits] [PATCH] D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference

This revision was automatically updated to reflect the committed changes. Closed by commit rGbab121a1b66e: [lldb][docs] Use sphinx instead of epydoc to generate LLDBs Python reference (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D94244: [lldb] Bump the required SWIG version to 3

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM modulo the warning messages still referencing 2 instead of 3. Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:20 else() message(STATUS "SWIG 2 or

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93421/new/ https://reviews.llvm.org/D93421 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Some comments about that this still prints 255, but otherwise this is looking good. (For the others: We agreed offline that adding the missing type checking for BOOL is out

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

teemperor added a comment. I just realized that I got the char sign also mixed up. It's an `unsigned char` in LLDB, so the 255 is wrong (But I believe our char signedness handling is not correct in any C language). But the fact that we don't print YES/NO for that bitfield is right (just the

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think the proper fix here is to warn about BOOL bitfields with size 1 if BOOL is a typedef for signed char. I can make a Clang warning for that. I guess on the LLDB side we

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

teemperor added a comment. In D93421#2459853 , @labath wrote: > This seems suspicious to me, on a couple of levels. You claim that BOOL is an > unsigned type, but the apple documentation > says

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

teemperor added a comment. Whether BOOL is `signed char` or `bool` is apparently depending on the architecture (???). See `ClangExpressionSourceCode::GetText`, Clang's `__OBJC_BOOL_IS_BOOL` macro and then there is also some preprocessor shenanigans for non-Clang ObjC (?) in the `objc.h` header

[Lldb-commits] [PATCH] D93382: [lldb] Unify the two CreateTypedef implementations in TypeSystemClang

This revision was automatically updated to reflect the committed changes. Closed by commit rG722247c8124a: [lldb] Unify the two CreateTypedef implementations in TypeSystemClang (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D92759: [lldb] Introduce separate scratch ASTs for debug info types and types imported from C++ modules.

This revision was automatically updated to reflect the committed changes. Closed by commit rG47e7ecdd7d36: [lldb] Introduce separate scratch ASTs for debug info types and types imported… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior

[Lldb-commits] [PATCH] D92757: [lldb] Remove assumption from Clang-based data formatters that their types are in the scratch AST

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG839e84527789: [lldb] Remove assumption from Clang-based data formatters that their types are… (authored by teemperor).

[Lldb-commits] [PATCH] D92772: [lldb] Fix that symbols.clang-modules-cache-path is never initialized

This revision was automatically updated to reflect the committed changes. Closed by commit rG208e3f5d9b6c: [lldb] Fix that symbols.clang-modules-cache-path is never initialized (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D92784: [lldb] Allow LLDB to automatically retry a failed expression with an import std C++ module

This revision was automatically updated to reflect the committed changes. Closed by commit rG958608285eb4: [lldb] Allow LLDB to automatically retry a failed expression with an imported… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D92908: [lldb] Kill the inferior instead of detaching during test suite runs

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. I assume that's the result of investigating Vedant's zombie generation script? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92908/new/

[Lldb-commits] [PATCH] D92498: [lldb] Remove LLDB session dir and just store test traces in the respective test build directory

This revision was automatically updated to reflect the committed changes. Closed by commit rGe97b991eef63: [lldb] Remove LLDB session dir and just store test traces in the respective… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D92513: [lldb] Return the original path when tilde expansion fails.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks, I do féél this ameliorates the current behavióúr CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92513/new/ https://reviews.llvm.org/D92513

[Lldb-commits] [PATCH] D92510: [lldb] set created function decl to public access in TypeSystemClang

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. D85993 was trying to do the same thing and contains some explanation why I think this isn't a good solution. TL;DR is that functions in a

[Lldb-commits] [PATCH] D92425: [lldb] Don't reject empty or unnamed template parameter packs

teemperor added a comment. In D92425#2428844 , @stella.stamenova wrote: > This caused failures on the Windows lldb buildbot: > > http://lab.llvm.org:8011/#/builders/83/builds/1294 > > Tests have to have unique names, so the two new added tests that use

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

teemperor added a comment. In D92103#2428139 , @martong wrote: > Hey Raphael, thanks for looking into the CTU crash! > > I also had a look and I could reproduce that on Linux Ubuntu 18.04 with GCC > 7. I think the discrepancy stems from GCC's libstdc++

[Lldb-commits] [PATCH] D92425: [lldb] Don't reject empty or unnamed template parameter packs

This revision was automatically updated to reflect the committed changes. Closed by commit rGc526426f5cba: [lldb] Dont reject empty or unnamed template parameter packs (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

teemperor added a comment. @gamesh411 I recreated the setup you listed (thanks for that btw) but for me this works just fine. I assume the crash happens in a class template from one of the external libraries. It probably works for me because I don't have the same library version as you have,

[Lldb-commits] [PATCH] D92311: [lldb] Always include template arguments that have their default value in the internal type name

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0e7bbeb5455: [lldb] Always include template arguments that have their default value in the… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

teemperor added reviewers: labath, jankratochvil. teemperor added a comment. Not sure who's the right person to review the SymbolFileDWARF.cpp/ManualDWARFIndex.cpp, but Pavel/Jan touched that not too long ago. (D81471 might also be an interested patch for

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f6c856bb5ae: [ASTImporter] Import the default argument of TemplateTypeParmDecl (authored by teemperor). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Changed

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

teemperor added inline comments. Herald added a subscriber: JDevlieghere. Comment at: clang/lib/AST/ASTImporter.cpp:5161 - // FIXME: Import default argument and constraint expression. + // FIXME: Import constraint expression. martong wrote: > I wonder

[Lldb-commits] [PATCH] D91801: [lldb] Fix incorrect error handling in GDBRemoteCommunicationClient::SendGetSupportedTraceType

teemperor added a comment. From what understand this is Linux exclusive feature at the moment, and the command test itself is testing the command but missing the edge case of testing this against a running process. Not sure if it's worth starting a process just to test that the command still

[Lldb-commits] [PATCH] D91801: [lldb] Fix incorrect error handling in GDBRemoteCommunicationClient::SendGetSupportedTraceType

This revision was automatically updated to reflect the committed changes. Closed by commit rG47b7138b484b: [lldb] Fix incorrect error handling in GDBRemoteCommunicationClient… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D91699: [lldb][NFC] Don't let Process inherit from UserID

This revision was automatically updated to reflect the committed changes. Closed by commit rGccd9091d4a2f: [lldb][NFC] Dont let Process inherit from UserID (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D82770: [lldb] Add support for using variables with C++ keywords names in non-C++ expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8350ce79d16: [lldb] Add support for using variables with C++ keywords names in non-C++… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Yeah I don't think this revision is to blame as just disabling the code here doesn't bring back the backtraces. Doesn't explain what happened to them, but that's probably on me to

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

teemperor added a comment. +1 to what Jonas said. You can reproduce this by just adding an `abort();` call at the start of `CommandInterpreter::HandleCommand` and then for example like the `TestApropos.py` test. > If the LLDB process that this calls crashes, it shouldn't affect that. LLDB is

[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

teemperor added a comment. I'm late to the party, but I actually don't think this is a good change as it disables the normal LLDB backtraces. The current test errors we see on Green Dragon look now like this: Assertion failed: (size() >= N && "Dropping more elements than exist"), function

[Lldb-commits] [PATCH] D89305: [lldb] Replace TestAbortExitCode with a debugserver specific test

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4b08ccb8794: [lldb] Replace TestAbortExitCode with a debugserver specific test (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D91118: Fix handling of bit-fields in a union

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91118/new/ https://reviews.llvm.org/D91118 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D90450: [lldb] Add expect_var_path to test variable path results

This revision was automatically updated to reflect the committed changes. Closed by commit rGd85cc03c9c4c: [lldb] Add expect_var_path to test variable path results (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D91206: [lldb] Switch expect to runCmd in TestRecursiveTypes (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I don't think we should re-add the bogus `RUN_SUCCEEDED` messages here. `self.runCmd("print tpi")` is undocumented, but still better than wrong documentation. Beside that this LGTM,

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. A few comments, but otherwise this seems good. Comment at: lldb/include/lldb/Target/Language.h:214 + virtual llvm::StringRef NilReferenceSummaryString() {

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

teemperor added a comment. In D91193#2386832 , @kastiglione wrote: > @teemperor maybe? Do you mean validation should go in `runCmd`? Or do you > mean something else? I meant that to my knowledge command execution where the only expectation is that they

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

teemperor added a comment. Isn't that what we use `runCmd` for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D91155: [lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server substitution

teemperor closed this revision. teemperor added a comment. Added the disallow in rG7211604220ae Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91155/new/

[Lldb-commits] [PATCH] D91118: Fix handling of bit-fields in a union

teemperor added a comment. Should we maybe check that the offset is 0 instead of skipping the sanity check? Otherwise this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91118/new/ https://reviews.llvm.org/D91118 ___ lldb-commits

[Lldb-commits] [PATCH] D91155: [lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server substitution

teemperor added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/test/Shell/helper/toolchain.py:65-68 ToolSubst('%platformserver', command=FindTool('lldb-server'), extra_args=['platform'],

[Lldb-commits] [PATCH] D91155: [lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server substitution

This revision was automatically updated to reflect the committed changes. Closed by commit rGc50faf5c9d7c: [lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D91056: [lldb] [test] Skip ObjC-based tests via 'objc' category

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. Thanks for cleaning this up, it's really appreciated! Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:839 +def checkObjcSupport(): +from . import

[Lldb-commits] [PATCH] D91065: [lldb] [test] Rename '.categories' to 'categories'

teemperor accepted this revision. teemperor added a subscriber: JDevlieghere. teemperor added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91065/new/ https://reviews.llvm.org/D91065

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

teemperor added a comment. Actually that might not work for testing remote platforms that support Obj-C from non-ObjC hosts, so I guess we have to check if we're on Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91003/new/

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

teemperor added a comment. In D91003#2381885 , @mgorny wrote: > In D91003#2381881 , @labath wrote: > >> If we put all of the objc tests into objc-specific directories (it looks >> like most of them are there

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

teemperor added a comment. In D91003#2380921 , @mgorny wrote: > In D91003#2380907 , @teemperor wrote: > >> Given that these are all Objective-C tests, this LGTM. >> >> (Out of scope for this patch, but it would

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Given that these are all Objective-C tests, this LGTM. (Out of scope for this patch, but it would probably be cleaner if we replace all the skipUnlessDarwin uses because of Obj-C with a

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

teemperor added a comment. Just to clarify: This only a dependency in the downstream Swift branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90857/new/ https://reviews.llvm.org/D90857 ___

[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lldb/source/Core/Debugger.cpp:685 - m_dummy_target_sp = m_target_list.GetDummyTarget(*this); + { +ArchSpec

[Lldb-commits] [PATCH] D89694: [lldb] Add Apple simulator platforms to lldbplatform.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG26a8e8502b59: [lldb] Add Apple simulator platforms to lldbplatform.py (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D89695: [lldb] Skip TestChangeProcessGroup on watchOS/tvOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG239f488fd692: [lldb] Skip TestChangeProcessGroup on watchOS/tvOS (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D89302: [lldb] Also Catch invalid calls to TestPExpectTest's expect()

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f84b59a4cf9: [lldb] Also Catch invalid calls to TestPExpectTests expect() (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D83180: Set generic error in SBError SetErrorToGenericError

teemperor resigned from this revision. teemperor added a comment. Herald added a reviewer: JDevlieghere. D90151 landed and addressed/tested this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83180/new/

[Lldb-commits] [PATCH] D90151: Fix SBError::SetErrorToGenericError

This revision was automatically updated to reflect the committed changes. Closed by commit rG206e8d890503: Fix SBError::SetErrorToGenericError (authored by werat, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90151/new/

[Lldb-commits] [PATCH] D90151: Fix SBError::SetErrorToGenericError

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks! I assume you don't have commit access, so I'll land this for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90151/new/ https://reviews.llvm.org/D90151

[Lldb-commits] [PATCH] D90151: Fix SBError::SetErrorToGenericError

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Could you add a test for this? This should be enough: diff --git a/lldb/test/API/python_api/sberror/TestSBError.py b/lldb/test/API/python_api/sberror/TestSBError.py new

[Lldb-commits] [PATCH] D89236: [lldb] Fix bitfield "frame var" for pointers (pr47743)

teemperor accepted this revision. teemperor added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89236/new/ https://reviews.llvm.org/D89236 ___ lldb-commits mailing list

<    1   2   3   4   5   6   7   8   9   10   >