[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. Added some comments on the new code. Also we should be able to see these spaces in the pexpect output, so I guess we should be able to test this too? To make this special case less fragile to test, you can make a new subtest in the Test case by just defining a new

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. In D81001#2189008 , @gedatsu217 wrote: >> Also could you rebase the diff here when you have time (e.g., regenerate the >> diff from you changes on top of the latest master commit)? It no longer >> applies at the moment without

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. In D81001#218 , @gedatsu217 wrote: > Although I thought of how to clear all the following characters, I did not > come up with it. So, I will try to fill the space. Should I add how many > spaces? If I add too many spaces,

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. I'm not hitting the same bug here, but I do hit a different bug. If I have a autosuggestion and then type another character that causes a shorter autosuggestion to display, then the old text of the autosuggestion is not deleted from the terminal. For example: >

[Lldb-commits] [PATCH] D84505: [lldb] Don't use static locals for return value storage in some *AsCString functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4a0844248d4: [lldb] Dont use static locals for return value storage in some *AsCString… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D83767: [lldb] Use the basename of the Python test for the log name instead of the class name

teemperor planned changes to this revision. teemperor added a comment. Got reverted, so back to my TODO queue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83767/new/ https://reviews.llvm.org/D83767

[Lldb-commits] [PATCH] D84528: [lldb][NFC] Use a StringRef for AddRegexCommand::AddRegexCommand parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rG432241955e03: [lldb][NFC] Use a StringRef for AddRegexCommand::AddRegexCommand parameters (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D84530: [lldb] Modernize away some snprintf calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb203e026847: [lldb] Modernize away some snprintf calls (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

teemperor accepted this revision. teemperor added a comment. I'm still not sure how this can happen or how this could be tested, but this patch seems reasonable. Also it seems we usually do nullptr checks on GetSyntheticChildAtOffset results, so at least it would be consistent if we do it here

[Lldb-commits] [PATCH] D84530: [lldb] Modernize away some snprintf calls

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: JDevlieghere. Repository: rLLDB LLDB https://reviews.llvm.org/D84530 Files: lldb/source/Commands/CommandObjectProcess.cpp lldb/source/Core/Communication.cpp lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D84528: [lldb][NFC] Use a StringRef for AddRegexCommand::AddRegexCommand parameters

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: JDevlieghere. This way we can get rid of this 1024 char buffer workaround. Repository: rLLDB LLDB https://reviews.llvm.org/D84528 Files: lldb/include/lldb/Interpreter/CommandObjectRegexCommand.h

[Lldb-commits] [PATCH] D84475: [lldb] Inform every language runtime of the modified modules

teemperor added a comment. (Mea culpa, I thought the Swift recognizers would be as trivial to fix as the upstream ones) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84475/new/ https://reviews.llvm.org/D84475 ___

[Lldb-commits] [PATCH] D84440: [llb] Remove the user-defined copy-ctor in ConstString

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Btw, this might spawn a bunch of warnings about unused ConstString variables (I remember I did a similar change locally to find unused ConstStrings some time ago) as the compiler maybe

[Lldb-commits] [PATCH] D84017: [lldb] Make socket_packet_pump.py work in Python3

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a3a821c68a1: [lldb] Make socket_packet_pump.py work in Python3 (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D84296: [lldb][NFC] Remove FormatMap

This revision was automatically updated to reflect the committed changes. Closed by commit rG77ae06b8c6c7: [lldb][NFC] Remove FormatMap (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D84404: [lldb] Make deleting frame recognizers actually work

This revision was automatically updated to reflect the committed changes. Closed by commit rG5477fbc29446: [lldb] Make deleting frame recognizers actually work (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D84307: [lldb/interpreter] Move the history subcommand to session (NFCI)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. The patch itself is fine, so let's ship it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84307/new/ https://reviews.llvm.org/D84307

[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

teemperor added a comment. I think Davide's point is that it's not clear what motivated this change and why this doesn't have a regression test. I'm also a bit confused by the description ("We saw a crash recently that looks related to we had good ValueObjectSP for some Cocoa summary

[Lldb-commits] [PATCH] D84307: [lldb/interpreter] Move the history subcommand to session (NFCI)

teemperor added a subscriber: jingham. teemperor added a comment. Isn't `session` just concerned with the *current* LLDB session? LLDB's command history is only spanning the current session at the moment, but I always thought that's more of a bug and not a feature (In fact one of my GSoC

[Lldb-commits] [PATCH] D84307: [lldb/interpreter] Move the history subcommand to session (NFCI)

teemperor added a reviewer: jingham. teemperor removed a subscriber: jingham. teemperor added a comment. (Phab send the whole thing when I pressed enter) I added Jim who might have more insights on the design rationale here, but IMHO this seems like an improvement. Repository: rG LLVM

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

teemperor added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4092 TypeSystemClang::GetArrayElementType(lldb::opaque_compiler_type_t type, - uint64_t *stride) { if (type) { So we

[Lldb-commits] [PATCH] D84267: Thread ExecutionContextScope through GetByteSize where possible (NFC-ish)

teemperor added inline comments. Comment at: lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp:461 if (type_flags & eTypeIsInteger) { -const size_t byte_size = compiler_type.GetByteSize(nullptr).getValueOr(0); +const size_t byte_size =

[Lldb-commits] [PATCH] D84151: [lldb] Unify type name matching in FormattersContainer

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b0de5756ccc: [lldb] Unify type name matching in FormattersContainer (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D84154: [lldb] Remove FormattersContainer's name member

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c15426d7c62: [lldb] Remove FormattersContainers name member (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D84015: [lldb] Remove orphaned modules in a loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG139e2a3f7b27: [lldb] Remove orphaned modules in a loop (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. > The test looks wrong to me. If the feature is supposed to be off by default, > then how can it test anything without first turning the feature on? Either > the feature isn't

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. This now looks good to me. I'll give the others a chance to take a look too but beside that I think this is ready to go IMHO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/ https://reviews.llvm.org/D81001

[Lldb-commits] [PATCH] D83757: [lldb] Store StackFrameRecognizers in the target instead of a global list

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b7c9eae6dca: [lldb] Store StackFrameRecognizers in the target instead of a global list (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D80724: [lldb] Only set the executable module for a target once

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG16926115ed28: [lldb] Only set the executable module for a target once (authored by teemperor). Herald added a project:

[Lldb-commits] [PATCH] D83876: [lldb] Add SBModule::ClearCachedModules and clear modules after each test run

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/bindings/interface/SBModule.i:365 +static void +ClearCachedModules(); + JDevlieghere wrote: > teemperor wrote: > > JDevlieghere wrote: > > > Maybe we should

[Lldb-commits] [PATCH] D83876: [lldb] Add SBModule::ClearCachedModules and clear modules after each test run

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/bindings/interface/SBModule.i:365 +static void +ClearCachedModules(); + JDevlieghere wrote: > Maybe we should call this `ClearAllocatedModules` for consistency

[Lldb-commits] [PATCH] D83876: [lldb] Add SBModule::ClearCachedModules and clear modules after each test run

teemperor updated this revision to Diff 278407. teemperor retitled this revision from "[lldb] Clean orphaned modules in Debugger::Destroy" to "[lldb] Add SBModule::ClearCachedModules and clear modules after each test run". teemperor edited the summary of this revision. teemperor added a comment.

[Lldb-commits] [PATCH] D83876: [lldb] Clean orphaned modules in Debugger::Destroy

teemperor added a comment. In D83876#2153709 , @jingham wrote: > We certainly don't want to clear the shared module cache when the Debugger or > the SBDebugger is destroyed. Most IDE's that use LLDB as a library use a > debugger per debugging session,

[Lldb-commits] [PATCH] D83876: [lldb] Clean orphaned modules in Debugger::Destroy

teemperor planned changes to this revision. teemperor added a comment. I'm actually thinking that this maybe should go into the SBDebugger::Destroy functions. This way we also get all lldb::ModuleSP instances that are freed by the Debugger destructor. Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [PATCH] D83876: [lldb] Clean orphaned modules in Debugger::Destroy

teemperor created this revision. teemperor added reviewers: JDevlieghere, labath, LLDB. Right now the only places in the SB API where lldb:: ModuleSP instances are destroyed are in SBDebugger::MemoryPressureDetected (where it's just attempted but not guaranteed) and in SBDebugger::DeleteTarget.

[Lldb-commits] [PATCH] D83767: [lldb] Use the basename of the Python test for the log name instead of the class name

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. Well, on Windows the file name is for some reason always "lldbsuite.test.lldbtest" so I reverted this for now. Open for suggestions. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

teemperor accepted this revision. teemperor added a comment. I think your comment got broken by Phabricator. I actually think the old code was fine. It's a generic bug that also applies to `Decltype` (which is already implemented), so someone just has to fix the whole function in a follow up

[Lldb-commits] [PATCH] D83388: [lldb] Make expect_expr fall back to the dummy target if no target is selected

This revision was automatically updated to reflect the committed changes. Closed by commit rG10fd550d308d: [lldb] Make expect_expr fall back to the dummy target if no target is selected (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D83767: [lldb] Use the basename of the Python test for the log name instead of the class name

This revision was automatically updated to reflect the committed changes. Closed by commit rG29aab9b5c748: [lldb] Use the basename of the Python test for the log name instead of the… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This could cause that `RemoveWrappingTypes` goes into an infinite loop under some situations. Usually this function is reserved for types that are always 'sugar', but

[Lldb-commits] [PATCH] D83217: [lldb][formatters] Add support for printing NSConstantDate and fix distantPast value

This revision was automatically updated to reflect the committed changes. Closed by commit rG001c78de35cc: [lldb][formatters] Add support for printing NSConstantDate and fix distantPast… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This seems to resolve the -Wodr build issues from what I can see, so LGTM. I guess the next step is drawing straws to see who has to refactor this code into something readable...

[Lldb-commits] [PATCH] D83787: [lldb/Test] Always set the cleanupSubprocesses tear down hook

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83787/new/ https://reviews.llvm.org/D83787 ___

[Lldb-commits] [PATCH] D83662: [lldb] Refactor character printing in DumpDataExtractor

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f51ceea1f98: [lldb] Refactor character printing in DumpDataExtractor (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added inline comments. Comment at: lldb/source/Host/common/Editline.cpp:1017 + el_insertstr(m_editline, to_add.c_str()); + return CC_REFRESH; +} gedatsu217 wrote: > teemperor wrote: > > gedatsu217 wrote: > > > teemperor wrote:

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Sorry this is taking so long, but I think beside one minor change this only needs some testing and then it's ready. So the way I would like to see this tested would be with a

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

teemperor added a comment. (Also the commit description should be updated again). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83433/new/ https://reviews.llvm.org/D83433 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

teemperor added a comment. So for the test case that this fixes I get: x i 8 f1 b15 12 (DWARF 0x0) f2 b4 13 (DWARF 0x7) f3 b4 14 (DWARF 0x3) For the 2/4/4 bitfield case I get: x i 8 f1 b2 12 (DWARF 0x0) f2 b4 12 (DWARF 0x2) f3 b4 12 (DWARF 0x6) Anyway, Adrian's and Jim's point

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Yeah I got confused by the description. So, do we need to do any work at all with the bitfields offsets? With this patch we just keep adding them with whatever bogus bit-offset we get

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

teemperor added a comment. I think I'm really out of the loop how this is supposed to work. From what I understand in the description it says we (=Clang when emitting DWARF?) is not generating offsets, but my DWARF dump of the test clearly has offsets (but they are clearly wrong).

[Lldb-commits] [PATCH] D83496: [Reproducers] Add --reproducer-no-generate-on-signal to avoid installing the signal handler.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83496/new/ https://reviews.llvm.org/D83496 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 ___

[Lldb-commits] [PATCH] D82732: WIP: Use SB APIs in CommandObjects

teemperor added inline comments. Comment at: lldb/include/lldb/API/SBBreakpoint.h:142 + + lldb::BreakpointSP GetSP() const; + I assume this is WIP code and we already told you that, but we can't expose the internal `lldb_private::*` classes (or their

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

teemperor added a comment. I think we are talking about different things. My question was why is this a 'Shell' test (like, a test in the `Shell` directory that uses FileCheck) and not a test in the `API` directory (using Python). An 'API' test could use the proper expression testing tools.

[Lldb-commits] [PATCH] D83221: [lldb] Always round down in NSDate's formatter to match NSDate's builtin format

This revision was automatically updated to reflect the committed changes. Closed by commit rG5814255e1a7d: [lldb] Always round down in NSDates formatter to match NSDates builtin format (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

teemperor added a comment. In D83008#2131796 , @tschuett wrote: > You could try: > > clangxx_host -Xclang -fdump-record-layouts %p/Inputs/layout.cpp -emit-llvm > -o /dev/null > > > You could commit the record layouts without your fix to show the

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for tracking this down, this is a really nasty bug... The fix itself is obviously fine, but I think I'm out of the loop regarding the testing strategy. We talked about

[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

This revision was automatically updated to reflect the committed changes. Closed by commit rG3faec833760f: [lldb] Fix missing characters when autocompleting LLDB commands in REPL (authored by poya, committed by teemperor). Changed prior to commit:

[Lldb-commits] [PATCH] D82616: Improve the detection of iOS/tvOS/watchOS simulator binaries in debugserver and lldb

teemperor added a comment. I guess this is breaking the Green Dragon tests as it's in the blame list: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/22121/ Failing Tests: lldb-api.tools/lldb-server.TestAppleSimulatorOSType.py lldb-api.tools/lldb-server.TestGdbRemoteAttach.py

[Lldb-commits] [PATCH] D82297: [lldb] Replace StringConvert with llvm::to_integer when parsing integer values in CommandObjects

This revision was automatically updated to reflect the committed changes. Closed by commit rG9010cef2af0a: [lldb] Replace StringConvert with llvm::to_integer when parsing integer values… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM beside the `_check_type` check always passing as discussed on IRC. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81561/new/

[Lldb-commits] [PATCH] D82879: [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM with some minor nits. Comment at: lldb/include/lldb/API/SBBreakpoint.h:108 + SBError AddNameWithErrorHandling(const char *new_name); + I wish

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Beside some minor things this LGTM. Comment at: lldb/source/Utility/Scalar.cpp:864 case e_uint512: -return static_cast( -

[Lldb-commits] [PATCH] D81241: [lldb] Tab completion for `frame recognizer delete`

This revision was automatically updated to reflect the committed changes. Closed by commit rGc37d25f0d1e0: [lldb] Tab completion for `frame recognizer delete` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D81177: [lldb] Tab completion for `frame select`

This revision was automatically updated to reflect the committed changes. Closed by commit rG80eb42281feb: [lldb] Tab completion for `frame select` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D81749: [lldb][NFC] Remove ImportInProgress lock in ClangASTSource

This revision was automatically updated to reflect the committed changes. Closed by commit rG502773d74341: [lldb][NFC] Remove ImportInProgress lock in ClangASTSource (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D82759: [lldb/Test] Introduce "assertSuccess"

teemperor accepted this revision. teemperor added a comment. LGTM, thanks! Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2537 +def assertSuccess(self, obj, msg=None): +if not obj.Success(): +error = obj.GetCString()

[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/source/Expression/REPL.cpp:460 sub_result.GetMatches(matches); +// Prepend command prefix that was excluded in the completion

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. Just a quick comment while I look into how we can test this code. Comment at: lldb/source/Host/common/Editline.cpp:1017 + el_insertstr(m_editline, to_add.c_str()); + return CC_REFRESH; +} If I understand the

[Lldb-commits] [PATCH] D82537: [lldb] Deduplicate copy-pasted TypeSystemMap::GetTypeSystemForLanguage

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: JDevlieghere. There are two implementations for `TypeSystemMap::GetTypeSystemForLanguage` which are both identical beside one taking a `Module` and one taking a `Target` (and then passing that argument

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. In D81001#2107102 , @gedatsu217 wrote: > Change the name and return of the function( bool UseAutosuggestion() -> void > SetShowAutosuggestion (bool) ) (ll. 1447 in Editline.cpp and ll.194 in > Editline.h). > int -> size_t

[Lldb-commits] [PATCH] D82382: [lldb][NFC] Replace most uses of StringConvert in LLDB with LLVM's to_integer

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1508 // thread in big endian hex -tid = StringConvert::ToUInt64(value.c_str(), LLDB_INVALID_THREAD_ID, 16); -if (tid

[Lldb-commits] [PATCH] D82382: [lldb][NFC] Replace most uses of StringConvert in LLDB with LLVM's to_integer

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: JDevlieghere, abidh. teemperor edited the summary of this revision. This replaces most uses of LLDB's own String to int/float conversion implementation with LLVM's to_integer. The only remaining code in

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. This is already looking quite reasonable, I think we're getting closer to something we can merge. In D81001#2096702 , @gedatsu217 wrote: > Implementation all ascii characters for TypedCharacter. > Making m_use_autosuggestion

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

teemperor added a comment. The only remaining issue with the LLDB expression part is that now that `SetFloatingInitializerForVariable` is based on the D81471 version it no longer makes the member variable a `constexpr`. Int/Enum members with initialisers can

[Lldb-commits] [PATCH] D82297: [lldb] Replace StringConvert with llvm::to_integer when parsing integer values in CommandObjects

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: JDevlieghere, abidh. This replaces the current use of LLDB's own `StringConvert` with LLVM's `to_integer` which has a less error-prone API and doesn't use special 'error values' to designate parsing

[Lldb-commits] [PATCH] D82175: [lldb] Replace std::isprint/isspace with llvm's locale-independent version

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5eaa2afe2a9: [lldb] Replace std::isprint/isspace with llvms locale-independent version (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D81729: [lldb] Fix that SIGWINCH crashes IOHandlerEditline when we are not using the editline backend

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe18df3d23fe: [lldb] Fix that SIGWINCH crashes IOHandlerEditline when we are not using the… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D82109: [lldb] Reactivate Objective-C++ plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG8340fbb9c7bc: [lldb] Reactivate Objective-C++ plugin (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

teemperor added a comment. You might also be interested in D81471 which is a very similar patch but for DWARF and only focused on static const integer/enum data members. One thing I'm curious about is how this is solving (or if it's even supposed to solve)

[Lldb-commits] [PATCH] D81898: [lldb/Python] Fix the infinitely looping prompt bug

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, but some documentation would be nice. Comment at: lldb/source/Interpreter/embedded_interpreter.py:77 +line = sys.stdin.readline() +if not line: +

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added inline comments. Comment at: lldb/source/Core/Debugger.cpp:349 +bool Debugger::GetUseAutosuggestion() const { + const uint32_t idx = ePropertyShowAutosuggestion; gedatsu217 wrote: > teemperor wrote: > > You declared the function, but you don't

[Lldb-commits] [PATCH] D81783: [lldb] Remove indentation before help output.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81783/new/ https://reviews.llvm.org/D81783 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D81654: [lldb] Don't print IRForTarget errors directly to the console

This revision was automatically updated to reflect the committed changes. Closed by commit rG91728b9172bf: [lldb] Dont print IRForTarget errors directly to the console (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a reviewer: LLDB. teemperor added a subscriber: lldb-commits. teemperor added a comment. I think this is ready to get a review from the rest. I'll add the other LLDB folks to the review. Comment at: lldb/include/lldb/Host/Editline.h:377 void

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think the approach here makes sense. The only issue I see is how we get the complete replacement type (see the inline comment). There is the issue if having an artificial

[Lldb-commits] [PATCH] D80997: [lldb] Fix a crash in PlatformAppleSimulator::GetCoreSimulatorPath when Xcode developer directory can't be found

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc0f09804886: [lldb] Fix a crash in PlatformAppleSimulator::GetCoreSimulatorPath when Xcode… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D81453: [lldb] Replace the LEB128 decoding logic in LLDB's DataExtractor with calls to LLVM's LEB128 implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb9d93f4d593: [lldb] Replace the LEB128 decoding logic in LLDBs DataExtractor with calls to… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D80775: [lldb] tab completion for `command script delete'

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e8f304f5ea5: [lldb] tab completion for `command script delete (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

teemperor added inline comments. Comment at: lldb/include/lldb/Utility/Stream.h:417 +write(colorcode, len); + } + return *this; teemperor wrote: > Nit: This can all be `PutCString(colorcode)` (which handles the nullptr check > and the strlen).

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. That was also on my list but it seems you beat me to it. I couldn't resist some smaller nit-picks but otherwise this LGTM beside that. Comment at:

[Lldb-commits] [PATCH] D81032: [lldb/Test] Don't print 'command invoked'

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Your patches continue to bring me joy and happiness. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81032/new/ https://reviews.llvm.org/D81032

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. In D81001#2068925 , @labath wrote: > Thanks for the explanation Raphael. This makes more sense now, though I am > still not very clear on the distinction between "completions" and > "suggestions". The fish tutorial mentions

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. @labath Just to get you into the loop: This is for a GSoC project that is about implementing the autosuggestions similar to what fish shell is providing. It's not really about actually invoking any completion logic (even though that might be an option in the future),

[Lldb-commits] [PATCH] D80990: [lldb] Fix sizeof() in Scalar::operator=()

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Could you add a unit test for this? See the`ScalarTest.cpp` for the other Scalar tests. Beside that this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D80793: [lldb][NFC] Make ClangExpressionSourceCode's wrapping logic more consistent

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b37c5b56058: [lldb][NFC] Make ClangExpressionSourceCodes wrapping logic more consistent (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D80789: [lldb] Pass -fPIC flag even when DYLIB_ONLY is set

This revision was automatically updated to reflect the committed changes. teemperor marked an inline comment as done. Closed by commit rGfd0ab3b3eb88: [lldb] Pass -fPIC flag even when DYLIB_ONLY is set (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D80292: [lldb] Make order of completions for expressions deterministic and sorted by Clang's priority values.

This revision was automatically updated to reflect the committed changes. Closed by commit rG74a51753a6c2: [lldb] Make order of completions for expressions deterministic and sorted by… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D79929: [lldb] Tab completion for process plugin name

This revision was automatically updated to reflect the committed changes. Closed by commit rG763bc2305797: [lldb] Tab completion for process plugin name (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D80447: [lldb] Fix a potential bug that may cause assert failure in CommandObject::CheckRequirements

This revision was automatically updated to reflect the committed changes. Closed by commit rG18bb1f106702: [lldb] Fix a potential bug that may cause assert failure in CommandObject… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

<    2   3   4   5   6   7   8   9   10   11   >