[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

rnk added a comment. This still feels a bit messy and I don't totally understand how it all fits together, but I'm super supportive of getting rid of the inline asm diagnostic handler and standardizing on DiagnosticHandler/DiagnosticInfo. Comment at: llvm/include/llvm/MC/MCCo

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

rnk added a comment. In D99426#2653725 , @MaskRay wrote: > This touches a lot of files. I am a bit worried that it would not be easy for > a contributor to know OF_TextWithCRLF is needed to make SystemZ happy. Right, we need to separate text-ness for Sys

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when completing CXXRecordDecl

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:492 if (pr.isPointerToMember()) { MemberPointerInfo mpi = pr.getMemberInfo(); GetOrCreateType(mpi.ContainingType); I think you want to make code c

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when creating pointer type that is a pointer to member.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks! Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:840 +spelling = +clang::MSInheritanceAttr::Spelling::Keyword_multiple_inheritance

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1754 + m_ast.getASTContext(), + clang::MSInheritanceAttr::Spelling::Keyword_unspecified_inheritance)); +} I'm concerned that this isn't real

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1754 + m_ast.getASTContext(), + clang::MSInheritanceAttr::Spelling::Keyword_unspecified_inheritance)); +} mstorsjo wrote: > rnk wrote: > > I

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:843-846 +std::map offset_to_size; +// Get the size of each fields if it's udt. +if (!FindMembersSize::GetMemberSizesForUdt(result.type, index.tpi(), 0, +

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

rnk accepted this revision. rnk added a comment. Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130796/new/ https://reviews.llvm.org/D130796 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1198 clang::DeclContext *parent = GetParentDeclContext(PdbSymUid(func_id)); if (!parent) Should the check be done before GetParentDeclContext or be done insi

[Lldb-commits] [PATCH] D133461: [LLDB][NativePDB] Set block address range.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133461/new/ https://reviews.llvm.org/D133461 ___ lldb-

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:681 +auto &ts = llvm::cast(*ct.GetTypeSystem()); +ts.GetMetadata(&tag)->SetIsForcefullyCompleted(); + } Is this what we do for DWARF? The same k

[Lldb-commits] [PATCH] D125844: [LLDB][NativePDB] Check for missing type info to avoid crash.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125844/new/ https://reviews.llvm.org/D125844 ___ lldb-

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

rnk added a comment. @labath, ping, I see you just got back from vacation and this is a lot of code, but any high level design feedback would be helpful to know if this is the right direction. Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:180 if (!Loc) - re

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

rnk added a comment. I see. We should give that constant materialization a location. It looks like it is coming from a phi node. The IR looks like this: %6 = icmp ne i32 %5, 0, !dbg !11 br i1 %6, label %7, label %10, !dbg !12 7:; preds

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, modulo ifdef adjustment Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3125-3126 } else { // FIXME: Currently this only emits the global variables in the I

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

rnk added a comment. I will take a look and try to reland this, since I requested the assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79447/new/ https://reviews.llvm.org/D79447 ___ lldb-commits m

[Lldb-commits] [PATCH] D110885: [NFC][AttributeList] Replace index_begin/end with an iterator

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/include/llvm/IR/Attributes.h:854 - /// Use these to iterate over the valid attribute indices. - unsigned index_begin() const { return AttributeList::Funct

[Lldb-commits] [PATCH] D110885: [NFC][AttributeList] Replace index_begin/end with an iterator

rnk added a comment. I had another idle thought on this matter: The unsigned overflow here really isn't that weird. It's the same thing as iterating over the range [-1, 0, `#args+1`]. We could update all these APIs to traffic in plain signed ints, and then there would be no wrapping, just norma

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

rnk accepted this revision. rnk added a comment. lgtm This flag seems reasonable. Microsoft's UnDecorateName API has quite a few of these kinds of things: https://docs.microsoft.com/en-us/windows/win32/api/dbghelp/nf-dbghelp-undecoratesymbolname I don't think it makes sense to implement them al

[Lldb-commits] [PATCH] D111454: Move TargetRegistry.(h|cpp) from Support to MC

rnk added a comment. Thanks for the review! I uploaded it a bit quickly because I wanted to kick off Bazel presubmit testing, since I haven't replicated that locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111454/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1019 + if (parent->isRecord()) { +struct ProcessOneMethodRecord : public TypeVisitorCallbacks { + ProcessOneMethodRecord(PdbIndex &m_index, TypeSystemClang &m_clang, --

[Lldb-commits] [PATCH] D119044: Add a case for Rust in LLDB's PDB reader

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119044/new/ https://reviews.llvm.org/D119044 ___ lldb-

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1123 + + PdbTypeSymId func_id(inline_site.Inlinee, true); + if (clang::Decl *decl = TryGetDecl(func_id)) Please add a comment about what the inlinee is, and what t

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1124 + // Inlinee is the id index to the function id record that is inlined. + PdbTypeSymId func_id(inline_site.Inlinee, true); + // Look up the function decl by the id index to s

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

rnk added a comment. I think the code to implement this is fine, but before we add this complexity to lit, I just wanted to know if other folks who work on the LLDB test suite are on board and want to use this approach to abstract over building apps for different targets. I see @stella.stamenov

[Lldb-commits] [PATCH] D34236: Delete ProcessLauncherPosix

rnk added a comment. `posix_spawn` is considered the preferred, efficient, canonical way to launch processes on Mac. Are you sure you want to remove support for it? https://reviews.llvm.org/D34236 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

rnk added a comment. I think there's an issue with the whole idea of dropping .debug_info from objects without live sections. Consider: // a.cpp int main() { return f(); } // b.cpp struct Foo { int x, y; }; int f() { volatile Foo var; var.x = 13; var.y = 42;

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

rnk added a comment. There's another use case worth considering here, which is -fmodules-debuginfo. In that situation, a standalone object file is emitted that contains nothing but DWARF .debug_info sections, and the object is fed to the linker. If the linker drops it with --gc-sections, it's n

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

rnk added a comment. You broke my build. =/ I got this output: CMake Error at C:/src/llvm-project/lldb/cmake/modules/LLDBConfig.cmake:201 (message): Found incompatible Python interpreter (3.7.3) and Python libraries () I'll mess with it a bit I guess. Repository: rL LLVM CHANGES SINC

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

rnk added a comment. In D64812#1588055 , @rnk wrote: > You broke my build. =/ I got this output: > > CMake Error at C:/src/llvm-project/lldb/cmake/modules/LLDBConfig.cmake:201 > (message): > Found incompatible Python interpreter (3.7.3) and Python l

[Lldb-commits] [PATCH] D64536: Adding inline comments to code view type records

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, sorry this fell out of my inbox. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64536/new/ https://reviews.llvm.org/D64536 ___

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

rnk added a comment. I still think this concern applies: https://reviews.llvm.org/D64417#1576675 I'm not sure how to track down an 19.11 release to test if we can pass std::aligned_storage values through function calls on x86. We might be better off raising the minimum to 19.14, which is a more

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I have concerns that some of the patches that you landed prior to this will cause issues with old versions of MSVC, but in isolation, this is fine, and if anyone complains, we can address it on a ca

[Lldb-commits] [PATCH] D65826: Add support for deterministically linked binaries on macOS to lldb.

rnk added a comment. Code seems fine, I think this is probably the right fix, but this probably deserves a test along the lines of what's in the commit message. I'm not familiar with LLDB's test suite, so I can't give much guidance there. Let's see if @JDevlieghere has input. Repository: rL

[Lldb-commits] [PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:81 +set(LLVM_APPEND_VC_REV "@LLVM_APPEND_VC_REV@") + This here should make the standalone build configs w

[Lldb-commits] [PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk updated this revision to Diff 240050. rnk added a comment. This revision is now accepted and ready to land. - Move things around while retaining API compatibility for getParents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71313/new/ https://r

[Lldb-commits] [PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk added a comment. I think I can land this version, but I'll wait until tomorrow so I'll be around to debug fallout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71313/new/ https://reviews.llvm.org/D71313

[Lldb-commits] [PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a81daaa8b58: [AST] Split parent map traversal logic into ParentMapContext.h (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D71313?vs=240050&id=240283#toc Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D74010: Fix BroadcasterManager::RemoveListener to really remove the listener

rnk created this revision. rnk added reviewers: JDevlieghere, amccarth. Herald added a project: LLDB. This appears to be a real bug caught by -Wunused-value. std::find_if doesn't modify the underlying collection, it just returns an iterator pointing to the matching element. Repository: rG LLVM

[Lldb-commits] [PATCH] D74010: Fix BroadcasterManager::RemoveListener to really remove the listener

This revision was automatically updated to reflect the committed changes. Closed by commit rG50d2d33b8ef5: Fix BroadcasterManager::RemoveListener to really remove the listener (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74010/new

[Lldb-commits] [PATCH] D75279: Avoid SourceManager.h include in RawCommentList.h, add missing incs

rnk created this revision. rnk added reviewers: aaron.ballman, hans. Herald added a reviewer: teemperor. Herald added subscribers: lldb-commits, arphaman. Herald added projects: clang, LLDB. SourceManager.h includes FileManager.h, which is expensive due to dependencies on LLVM FS headers. Remove

[Lldb-commits] [PATCH] D75279: Avoid SourceManager.h include in RawCommentList.h, add missing incs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG86565c130942: Avoid SourceManager.h include in RawCommentList.h, add missing incs (authored by rnk). Repository: rG LLV

[Lldb-commits] [PATCH] D75406: Avoid including FileManager.h from SourceManager.h

rnk updated this revision to Diff 247479. rnk added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - fixes on Linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 Files:

[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk created this revision. rnk added reviewers: aaron.ballman, hans. Herald added projects: clang, LLDB. Herald added a subscriber: lldb-commits. Module.h takes 86ms to parse, mostly parsing the class itself. Avoid it if possible. ASTContext.h depends on ExternalASTSource.h. A few NFC changes wer

[Lldb-commits] [PATCH] D75406: Avoid including FileManager.h from SourceManager.h

rnk added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk added a comment. In D75784#1910688 , @aprantl wrote: > This will no doubt also need some patches to the Swift compiler, but given > the NFC-ness this hopefully should be fine. True. I could leave behind a typedef for the ASTSourceDescriptor if it ma

[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk added a comment. Thanks! In D75784#1917181 , @aprantl wrote: > To avoid bot breakage, I would recommend testing -DLLVM_ENABLE_MODULES=1 > stage2 build works before landing this, as it is notoriously sensitive to > header reshuffling. Good idea, I

[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

This revision was automatically updated to reflect the committed changes. rnk marked an inline comment as done. Closed by commit rGc915cb957dc3: Avoid including Module.h from ExternalASTSource.h (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D75406: Avoid including FileManager.h from SourceManager.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGe08464fb4504: Avoid including FileManager.h from SourceManager.h (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D75406?vs=247479&id=249752#toc Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193191. rnk marked 2 inline comments as done. rnk added a comment. Herald added subscribers: lldb-commits, cfe-commits, kadircet, arphaman, jkorous. Herald added projects: clang, LLDB. - fix one lldb usage Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193388. rnk marked 4 inline comments as done. rnk added a comment. - Add RecordPrefix ctor, remove all dummy RecordLen assignments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193390. rnk marked an inline comment as done. rnk added a comment. - one more change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 Files: lld/COFF/PDB.cpp lldb/source

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CVRecord.h:29 +/// Carrying the size separately instead of trusting the size stored in the +/// record prefix provides some extra safety and flexibility. template class CVRecord { agane

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk marked 2 inline comments as done. rnk added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193526. rnk added a comment. - final updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60018/new/ https://reviews.llvm.org/D60018 Files: lld/COFF/PDB.cpp lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordC

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

This revision was automatically updated to reflect the committed changes. Closed by commit rLLD357658: [codeview] Remove Type member from CVRecord (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60018?vs=193526&id=193633#toc Repository: rLLD LLVM Linker

[Lldb-commits] [PATCH] D61292: Include inlined functions when figuring out a contiguous address range

rnk added a comment. I think TestLineEntry.cpp didn't get added to the commit, so I removed it in r360076 to try to fix the build. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61292/new/ https://reviews.llvm.org/D61292

[Lldb-commits] [PATCH] D70281: Fix -Wunused-result warnings in LLDB

rnk created this revision. rnk added a reviewer: amccarth. Herald added a project: LLDB. Three uses of try_lock intentionally ignore the result. Make that explicit with a void cast. Add what appears to be a missing return in the clang expression parser code. It's a functional change, but presumab

[Lldb-commits] [PATCH] D70281: Fix -Wunused-result warnings in LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d23764dddc2: Fix -Wunused-result warnings in LLDB (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D70281?vs=229421&id=229667#toc Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D70442: [LLDB] Force message formatting to English

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70442/new/ https://reviews.llvm.org/D70442 ___ lldb-

[Lldb-commits] [PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk created this revision. rnk added reviewers: bkramer, klimek, rsmith. Herald added subscribers: lldb-commits, kbarton, mgorny, nemanjai. Herald added projects: clang, LLDB. The only part of ASTContext.h that requires most AST types to be complete is the parent map. Nothing in Clang proper uses

[Lldb-commits] [PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk planned changes to this revision. rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:653 template DynTypedNodeList getParents(const NodeT &Node) { return getParents(ast_type_traits::DynTypedNode::create(N

[Lldb-commits] [PATCH] D152189: [LLDB][PDB] Fix age field in UUID in PDB file.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Wow. Well, I'm not going to argue otherwise. :) lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152189/new/ https://reviews.llvm.org/D152189

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

rnk added a comment. Right, so `cantFail` must be an assertions-only check. That's not great. These deserialization APIs have really, really bad ergonomics and could use a lot of improvement if you want to look into that. It would be really nice if, for example, this worked more like dyn_cast.

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

rnk added a comment. @Michael137, are you comfortable approving this, or can you reroute to a reviewer who can help us with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 _

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

rnk added a comment. Following the direction of the DWARF plugin sounds good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134066/new/ https://reviews.llvm.org/D134066 ___ lldb-commits mailing lis