[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

sammccall added a comment. In D112374#3657640 , @mizvekov wrote: > In general, I would not expect external tools to care about the shape of the > AST. I would expect the type API would be used in a way where we ignore a > type sugar node we have no

[Lldb-commits] [PATCH] D125012: [clang] createInvocationFromCommandLine -> createInvocation, delete former. NFC

sammccall added a comment. Sorry, bad merge and this broke everything. Fixed in f44552ab387b9087fb815251064782f8fb60e643 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125012/new/ https://reviews.llvm.org/D125012

[Lldb-commits] [PATCH] D125012: [clang] createInvocationFromCommandLine -> createInvocation, delete former. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG499d0b96cb52: [clang] createInvocationFromCommandLine - createInvocation, delete former. NFC (authored by sammccall). Changed prior to commit:

[Lldb-commits] [PATCH] D125012: [clang] createInvocationFromCommandLine -> createInvocation, delete former. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. (Followup from

[Lldb-commits] [PATCH] D121746: Use lit_config.substitute instead of foo % lit_config.params everywhere

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75acad41bcd6: Use lit_config.substitute instead of foo % lit_config.params everywhere (authored by sammccall). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D121746: Use lit_config.substitute instead of foo % lit_config.params everywhere

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a reviewer: bollu. Herald added subscribers: ayermolo, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb,

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall added a comment. In D114251#3197713 , @davrec wrote: > One other thought: can we add diagnostic notes using this new information, > e.g. This sounds plausible, though I didn't want to extend the scope of this patch further. I'm also not sure

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1600db19d63: [AST] Add UsingType: a sugar type for types found via UsingDecl (authored by sammccall). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 395434. sammccall added a comment. Herald added a reviewer: shafik. Fix ASTImporter, add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114251/new/ https://reviews.llvm.org/D114251 Files:

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394806. sammccall added a comment. Fix serialization (found with msan) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114251/new/ https://reviews.llvm.org/D114251 Files:

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394780. sammccall added a comment. Make hasDeclaration look through UsingType, and throughUsingDecl work on UsingType too. This is more ergonomic, more similar to existing behavior that matchers rely on, and similar in spirit to DeclRefExpr. Repository:

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall added a comment. Having done some out-of-tree testing, it seems this silently breaks enough ASTMatchers that it'll be hard to get it to stick. (We don't strictly need to block on out-of-tree failures, but I'm pretty sure a lot of stuff in-tree is broken too, and the out-of-tree users

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394666. sammccall added a comment. TypePrinter prints UsingTypes with their underlying qualifiers by default. Fix qualifier bug in QualTypeNames Add a bit more detail to AST dump (UsingShadow) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394648. sammccall added a comment. Fix QualTypeNames bug that showed up in external testing. (Now covered by a unittest added separately) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114251/new/

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394553. sammccall marked an inline comment as done. sammccall added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. update lldb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92417eaf3329: [CodeCompletion] Signature help for braced constructor calls (authored by sammccall). Changed prior to commit:

[Lldb-commits] [PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

sammccall added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:995 /// \param NumCandidates the number of overload candidates void ProcessOverloadCandidates(Sema , unsigned CurrentArg,

[Lldb-commits] [PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

sammccall updated this revision to Diff 396362. sammccall added a comment. Fix clangd tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116317/new/ https://reviews.llvm.org/D116317 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[Lldb-commits] [PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

sammccall updated this revision to Diff 396325. sammccall edited the summary of this revision. sammccall added a comment. Herald added subscribers: JDevlieghere, ilya-biryukov. Revert some unintended changes, clean up tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

sammccall updated this revision to Diff 396324. sammccall added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix lldb build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116317/new/

[Lldb-commits] [PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

sammccall updated this revision to Diff 293892. sammccall added a comment. This was landed as 4 commits, this diff is all 4 as committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88103/new/ https://reviews.llvm.org/D88103 Files:

[Lldb-commits] [PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa69b608063e: [JSON] Add error reporting to fromJSON and ObjectMapper (authored by sammccall). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

sammccall added a comment. Mostly LG, just a couple of possible logic bugs. Apologies, I was out on vacation and hoped someone else would see this. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:650 + bool Fallthrough() const { return ExternalFSValidWD &&

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

sammccall added a comment. BTW, This approach does look much better to me, it fits well into the VFS abstraction and I'd argue is fixing a bug in RedirectingFileSystem. We do need to be careful about introducing new bugs, though. (or avoid the generality and just implement the parts LLDB needs,

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

sammccall added a subscriber: benlangmuir. sammccall added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1051 std::error_code RedirectingFileSystem::setCurrentWorkingDirectory(const Twine ) { + // Don't change the working directory if the path doesn't

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding working directories in a VFS mapping.

sammccall added a comment. (I replied by email, it seems phabricator doesn't pick it up.) In D65677#1649731 , @JDevlieghere wrote: > In D65677#1649329 , @sammccall wrote: > > > In D65677#1649291

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding working directories in a VFS mapping.

sammccall added a comment. In D65677#1649291 , @JDevlieghere wrote: > In D65677#1648506 , @sammccall wrote: > > > In D65677#1627576 , @JDevlieghere > > wrote: > > > > >

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding working directories in a VFS mapping.

sammccall added a comment. In D65677#1627576 , @JDevlieghere wrote: > After some brainstorming I've identified a few other approaches that should > better reflect the transience of the current working directory: > > - We can modify the VFS to have a

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

sammccall added a comment. > I'd like to know if you tried other approaches and why they failed. +1. In particular, what goes wrong if you try to make the working directory a sibling of VFS (within the reproducer container) rather than a child of it (within shared infrastructure)?

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. Oops, didn't mean to mark as accepted. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. It seems conceptually a little strange to have the working directory be part of a serialized "FS", as it's fundamentally a property of a process and only transiently a property of the

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall added a comment. Thanks @rupprecht! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/ https://reviews.llvm.org/D65397 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall added a comment. In D65397#1604416 , @labath wrote: > I am not sure about the consistency argument (on the other CL), as it seems > to me that most/all llvm .inc files *which are produced by tblgen" are > included by via just their bare names.

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall updated this revision to Diff 212167. sammccall added a comment. Fix one straggler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/ https://reviews.llvm.org/D65397 Files: lldb/source/Core/CMakeLists.txt

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall updated this revision to Diff 212166. sammccall added a comment. Herald added a subscriber: mgorny. Herald added a reviewer: jdoerfert. Give the files distinct names instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall created this revision. sammccall added reviewers: JDevlieghere, labath, chandlerc. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. labath added a comment. I am not sure about the consistency argument (on the other CL), as it seems to me that most/all llvm .inc

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

sammccall added subscribers: chandlerc, sammccall. sammccall added inline comments. Comment at: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:77 +#define LLDB_PROPERTIES_dynamicloaderdarwinkernel +#include "Properties.inc" +};

[Lldb-commits] [PATCH] D60871: [CodeComplete] Remove obsolete isOutputBinary().

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358696: [CodeComplete] Remove obsolete isOutputBinary(). (authored by sammccall, committed by ). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: