[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

jingham added a comment. In D109738#3054058 , @vadimcn wrote: >> Is it possible to get your IDE to record the module & the address? > > I don't control the definition of the protocol (FWIW it's Microsoft's Debug > Adapter Protocol), but I'll look into

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn added a comment. > Is it possible to get your IDE to record the module & the address? I don't control the definition of the protocol (FWIW it's Microsoft's Debug Adapter Protocol), but I'll look into that, maybe there's a way to sneak in extra information. In which case, what is the

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

jingham added a comment. In D109738#3052661 , @ted wrote: > In D109738#3052624 , @jingham wrote: > >> That is clearly wrong: an address is never enough to restore a breakpoint >> from one session to the next

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

ted added a comment. In D109738#3052624 , @jingham wrote: > That is clearly wrong: an address is never enough to restore a breakpoint > from one session to the next even if you can turn ASLR off. After all, the > breakpoint could be in a dlopened

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

d-millar added a comment. That discussion is extremely helpful - gives me good context for what I need to suport. THANKS! From: lldb-commits on behalf of Jim Ingham via Phabricator via lldb-commits Sent: Friday, October 8, 2021 5:44:49 PM To:

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

d-millar added subscribers: DavidSpickett, djtodoro, HirokiImai, jingham, ZeeZeeMorin, SouraVX, serhiy.redko, vadimcn, d-millar. d-millar added a comment. That discussion is extremely helpful - gives me good context for what I need to suport. THANKS! From:

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

jingham added a comment. I realized I typed this all down a while ago but forgot to hit submit. I think I still agree with former me... In D109738#3002257 , @vadimcn wrote: > Hi Jim, > I think there's a bit of confusion going on here: > The original

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn added a comment. @JDevlieghere: ping.Or are you saying you wouldn't consider landing such a change at all? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109738/new/ https://reviews.llvm.org/D109738

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

ted added a comment. In D109738#3000608 , @jingham wrote: > BTW, do you know what change made this stop working? https://github.com/llvm-mirror/lldb/commit/43793406 in the old multirepo. In the monorepo, it's

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn added a comment. Hi Jim, I think there's a bit of confusion going on here: The original bug was opened by Ted Woodward, and I think his scenario was motivated by embedded debugging. He also provided that example with a breakpoint being set in main. I've rediscovered this bug

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

jingham added a comment. In D109738#3001122 , @vadimcn wrote: >> In the future, can you generate patches with context (i.e. pass -U to >> "git diff" or "git show"), it's a lot easier to read patches with context. > > Sure thing, will do. > > This

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn updated this revision to Diff 372636. vadimcn added a comment. Added patch context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109738/new/ https://reviews.llvm.org/D109738 Files: lldb/source/Breakpoint/BreakpointResolverAddress.cpp

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn added a comment. > In the future, can you generate patches with context (i.e. pass -U to > "git diff" or "git show"), it's a lot easier to read patches with context. Sure thing, will do. This doesn't seem like the right solution to the problem to me. The way > address breakpoints

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

jingham added a comment. BTW, do you know what change made this stop working? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109738/new/ https://reviews.llvm.org/D109738 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. In the future, can you generate patches with context (i.e. pass -U to "git diff" or "git show"), it's a lot easier to read patches with context. This doesn't seem like the

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

ted added a comment. I created the original bug because a change made LLDB stop working on address breakpoints if they were created before the program is run. Setting a breakpoint on an address is a typical case with embedded applications, especially if you want to debug startup code. I took

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn created this revision. vadimcn added a reviewer: jingham. vadimcn added a project: LLDB. Herald added a subscriber: JDevlieghere. vadimcn requested review of this revision. Herald added a subscriber: lldb-commits. Setting an address breakpoint unconditionally creates a location, however