This revision was automatically updated to reflect the committed changes.
Closed by commit rG46be5faaf034: [lldb/Fuzzer] Add command interpreter fuzzer
for LLDB (authored by cassanova).
Changed prior to commit:
https://reviews.llvm.org/D128292?vs=439158=439163#toc
Repository:
rG LLVM Github
mib accepted this revision.
mib added a comment.
Ship it!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128292/new/
https://reviews.llvm.org/D128292
___
lldb-commits mailing list
cassanova updated this revision to Diff 439158.
cassanova added a comment.
Added a subdirectory to the top-level build directory. This directory will hold
directories for the artifacts of various fuzzers. Also corrected a typo in the
command interpreter CMakeLists file.
Repository:
rG LLVM
mib added inline comments.
Comment at:
lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:17
+
+ # This will create a directory specifially for the fuzzer's artifacts, go to
that
+ # directory and run the fuzzer from there. When the fuzzer exits the input
cassanova updated this revision to Diff 439111.
cassanova added a comment.
Updated CMakeLists file to save fuzzer artifacts (the files that the fuzzer
writes when an input causes the program being fuzzed to fail) to a directory in
the user's build directory, instead of saving them in the user's
mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128292/new/
https://reviews.llvm.org/D128292
___
cassanova updated this revision to Diff 439021.
cassanova added a comment.
Updated ASCII header to work with 80-column limit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128292/new/
https://reviews.llvm.org/D128292
Files:
cassanova added inline comments.
Comment at:
lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:39
+ SBCommandReturnObject ro = SBCommandReturnObject();
+ SBCommandInterpreter thisinterpreter = debugger.GetCommandInterpreter();
+
cassanova updated this revision to Diff 438839.
cassanova added a comment.
Sorted subdirectories alphabetically in top-level CMakeLists file.
Removed lldbfuzzer link library in command interpreter CMakeLists file.
Fixed ASCII art in command interpreter source file, renamed `thisinterpreter`
to
mib added inline comments.
Comment at:
lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:39
+ SBCommandReturnObject ro = SBCommandReturnObject();
+ SBCommandInterpreter thisinterpreter = debugger.GetCommandInterpreter();
+
cassanova added inline comments.
Comment at:
lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:15
+liblldb
+lldbFuzzerUtils
+)
JDevlieghere wrote:
> I don't think this used any longer.
Ok, I can remove this library.
mib added inline comments.
Comment at:
lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:39
+ SBCommandReturnObject ro = SBCommandReturnObject();
+ SBCommandInterpreter thisinterpreter = debugger.GetCommandInterpreter();
+
mib added inline comments.
Comment at:
lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:39
+ SBCommandReturnObject ro = SBCommandReturnObject();
+ SBCommandInterpreter thisinterpreter = debugger.GetCommandInterpreter();
+
JDevlieghere added inline comments.
Comment at: lldb/tools/lldb-fuzzer/CMakeLists.txt:1-2
add_subdirectory(lldb-target-fuzzer)
+add_subdirectory(lldb-commandinterpreter-fuzzer)
add_subdirectory(utils)
nit: I'd sort these alphabetically
cassanova updated this revision to Diff 438810.
cassanova added a comment.
Removed ObjectYAML link component from CMakeLists file, changed fuzzer
invocation to use a relative path for the dictionary file, removed line that
sets a breakpoint in the fuzzer's LLDB process.
CHANGES SINCE LAST
cassanova added inline comments.
Comment at:
lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:3
+ Support
+ ObjectYAML
+ )
JDevlieghere wrote:
> I assume we don't need this anymore if we're using the dummy target?
Yes this isn't necessary
JDevlieghere added inline comments.
Comment at:
lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:3
+ Support
+ ObjectYAML
+ )
I assume we don't need this anymore if we're using the dummy target?
Comment at:
cassanova created this revision.
cassanova added reviewers: JDevlieghere, mib.
cassanova added a project: LLDB.
Herald added a subscriber: mgorny.
Herald added a project: All.
cassanova requested review of this revision.
Herald added a subscriber: lldb-commits.
This adds a command interpreter
18 matches
Mail list logo
