Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-20 Thread Eugene Leviant via lldb-commits
evgeny777 updated this revision to Diff 37888. evgeny777 added a comment. Update according to suggestions from granata.enrico http://reviews.llvm.org/D13799 Files: test/tools/lldb-mi/data/TestMiData.py test/tools/lldb-mi/symbol/TestMiSymbol.py tools/lldb-mi/MICmnLLDBDebugger.cpp

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-20 Thread Hafiz Abid Qadeer via lldb-commits
abidh accepted this revision. abidh added a comment. This revision is now accepted and ready to land. Apart from some inline comments, looks ok to me. Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:839 @@ +838,3 @@ +// Return: MIstatus::success - Functionality succeeded. +//

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-19 Thread Eugene Leviant via lldb-commits
evgeny777 updated this revision to Diff 37733. evgeny777 added a comment. Review updated to reflect Enrico comments regarding signed/unsigned char. Now all character types are evaluated as ASCII code (signed or unsigned) + value. Additional method introduced to SBValue to check if type is

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-19 Thread Eugene Leviant via lldb-commits
evgeny777 added inline comments. Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:126 @@ -125,12 +125,3 @@ { -if (m_bHandleCharType && IsCharType()) -{ -vwrValue = GetSimpleValueChar(); -return MIstatus::success; -} -

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-19 Thread Hafiz Abid Qadeer via lldb-commits
abidh added a comment. Please also indicate if a revision is dependent on some other revisions that has not yet been committed as this one is on http://reviews.llvm.org/D13657. Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:126 @@ -125,12 +125,3 @@ { -if

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-19 Thread Eugene Leviant via lldb-commits
evgeny777 added inline comments. Comment at: include/lldb/API/SBValue.h:372 @@ +371,3 @@ +bool +IsIntegerType(bool& is_signed); + granata.enrico wrote: > Greg pointed me to SBType::GetBasicType() - this will return to you one of > > ``` >

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-19 Thread Enrico Granata via lldb-commits
granata.enrico added inline comments. Comment at: include/lldb/API/SBValue.h:372 @@ +371,3 @@ +bool +IsIntegerType(bool& is_signed); + Greg pointed me to SBType::GetBasicType() - this will return to you one of ``` eBasicTypeSignedChar,

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-16 Thread Enrico Granata via lldb-commits
granata.enrico added inline comments. Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:37 @@ +36,3 @@ +return false; +stream.Printf("%d %s", (int)value.GetValueAsSigned(), value.GetValue()); +return true; I would definitely not stop the revision

Re: [Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-16 Thread Enrico Granata via lldb-commits
granata.enrico added inline comments. Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:835 @@ +834,3 @@ + +if (!MI_add_summary(miCategory, "char", MI_char_summary_provider, +lldb::eTypeOptionHideValue | lldb::eTypeOptionSkipPointers))

[Lldb-commits] [PATCH] D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

2015-10-16 Thread Eugene Leviant via lldb-commits
evgeny777 created this revision. evgeny777 added reviewers: granata.enrico, ki.stfu, abidh. evgeny777 added subscribers: lldb-commits, KLapshin. Current revision do not use lldb type summaries for simple types with no children (like function pointers). So this patch makes MI use lldb type