[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Michael137 added a comment. In D138558#3963732 , @labath wrote: > You may want to check that this kind of automatic dereferencing does not send > lldb into a tailspin if the printed data structure is recursive. I know we > had problems like that with

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

labath added a comment. You may want to check that this kind of automatic dereferencing does not send lldb into a tailspin if the printed data structure is recursive. I know we had problems like that with smart pointer pretty printers. I'd try some code like: #include #include

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxRangesRefView.cpp:36 + lldb::ValueObjectSP GetChildAtIndex(size_t idx) override { +// Since we only have a single child, return it +assert(idx == 0); To be very

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rG77b220524541: [lldb][DataFormatter] Add std::ranges::ref_view formatter (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138558/new/

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Michael137 marked an inline comment as done. Michael137 added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxRangesRefView.cpp:41 +private: + lldb::ValueObjectSP m_range_sp = nullptr; ///< Pointer to the dereferenced +

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Michael137 updated this revision to Diff 478929. Michael137 added a comment. - Move short definitions inline - Fix doxygen comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138558/new/ https://reviews.llvm.org/D138558 Files:

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Small nitpicks, otherwise good! Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxRangesRefView.cpp:41 +private: + lldb::ValueObjectSP m_range_sp = nullptr; ///<

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Michael137 updated this revision to Diff 477440. Michael137 added a comment. - Clean up test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138558/new/ https://reviews.llvm.org/D138558 Files: lldb/source/Plugins/Language/CPlusPlus/CMakeLists.txt

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Michael137 updated this revision to Diff 477439. Michael137 added a comment. - Use typedef in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138558/new/ https://reviews.llvm.org/D138558 Files:

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Michael137 created this revision. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a formatter for `std::ranges::ref_view`. It simply holds a `T*`, so all this formatter does is