kastiglione added a comment.
@jgorbe thanks for reporting. I have a fix for the missing space, I will look
into the cause of the double space and fix that as well. I'll do this today.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146783/new/
jgorbe added a comment.
I just noticed a minor aesthetic problem with the input of `dwim-print` when
using data formatters. There are some spacing adjustments in this commit but
I'm not sure if they are the actual cause (please let me know if you'd prefer
me to file a bug instead).
You can
This revision was automatically updated to reflect the committed changes.
Closed by commit rG23349d83a98f: [lldb] Add ability to hide the root name of a
value (authored by kastiglione).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146783/new/
kastiglione added inline comments.
Comment at: lldb/source/DataFormatters/ValueObjectPrinter.cpp:278
- if (!m_options.m_hide_name) {
+ if (ShowName()) {
if (m_options.m_flat_output)
jgorbe wrote:
> This method name reads like a command, rather than a
kastiglione updated this revision to Diff 508173.
kastiglione added a comment.
Rename ShowName to ShouldShowName
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146783/new/
https://reviews.llvm.org/D146783
Files:
jgorbe added a comment.
I've tried building lldb with this patch applied and it fixes the problem I
saw. Thanks for the quick fix!
I'm not very familiar with the code so I'd appreciate if someone else gives
their LGTM too but the changes look reasonable to me (just one small nit I've
kastiglione created this revision.
kastiglione added reviewers: aprantl, jingham, jgorbe.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
When printing a value, allow the root value's name to be
