[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2d32ddcec82: [lldb] Sink StreamFile into lldbHost (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157460/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

bulbazord updated this revision to Diff 548828. bulbazord added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157460/new/ https://reviews.llvm.org/D157460 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/Stream

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

mib accepted this revision. mib added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" bulbazord wrote: > mib wrote: > > bulbazord

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

bulbazord added inline comments. Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" mib wrote: > bulbazord wrote: > > mib wrote: > > > Do we really need this header ? We could forward declare FileSP

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

mib added inline comments. Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" bulbazord wrote: > mib wrote: > > Do we really need this header ? We could forward declare FileSP do avoid > > having t

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

bulbazord added a comment. In D157460#4571772 , @mib wrote: > Shouldn't this be next to the other `Stream` class in `lldbUtility` ? `lldbUtility` is the lowest layer and does not depend on anything in `lldbHost`. That being said, `StreamFile` uses `File

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

mib added a comment. Shouldn't this be next to the other `Stream` class in `lldbUtility` ? Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" Do we really need this header ? We could forward decla

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. StreamFile subclasses Stream (from lldbUtility) and