[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan added a comment. In D62772#1526824 , @compnerd wrote: > This should get the build working again, so lets get this fixed, we can > improve it later Thanks, committed the fix to unblock build. For WoA(ARM32) which is not supported, I meant LLVM Co

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

This revision was automatically updated to reflect the committed changes. Closed by commit rL362349: [COFF, ARM64] Fix CodeView API change for getRegisterNames (authored by TomTan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This should get the build working again, so lets get this fixed, we can improve it later Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan marked an inline comment as done. TomTan added inline comments. Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:29 + llvm::codeview::CPUType cpu_type; + if (arch_type == llvm::Triple::ArchType::aarch64) { +cpu_type = llvm::codeview

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan updated this revision to Diff 202614. TomTan added a comment. Change to switch/case based on comment. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62772/new/ https://reviews.llvm.org/D62772 Files: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDW

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan marked an inline comment as done. TomTan added inline comments. Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:29 + llvm::codeview::CPUType cpu_type; + if (arch_type == llvm::Triple::ArchType::aarch64) { +cpu_type = llvm::codeview

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:29 + llvm::codeview::CPUType cpu_type; + if (arch_type == llvm::Triple

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

aganea added inline comments. Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:29 + llvm::codeview::CPUType cpu_type; + if (arch_type == llvm::Triple::ArchType::aarch64) { +cpu_type = llvm::codeview::CPUType::ARM64; Should

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

jankratochvil added a comment. D62771 does address the same. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62772/new/ https://reviews.llvm.org/D62772 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan added a comment. In D62772#1526145 , @mgorny wrote: > Are you sure this triple → CPUType mapping belongs in each consumer? Maybe > it'd be better to have something inside LLVM, so that we wouldn't have to > keep this up-to-date in all the places.

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan updated this revision to Diff 202540. TomTan edited the summary of this revision. TomTan added a comment. Update variable naming to be consistent with current file. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62772/new/ https://reviews.llvm.org/D62772

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

mgorny added a reviewer: labath. mgorny added a comment. Are you sure this triple → CPUType mapping belongs in each consumer? Maybe it'd be better to have something inside LLVM, so that we wouldn't have to keep this up-to-date in all the places. Maybe `getRegisterNames()` overload that takes a

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan created this revision. TomTan added reviewers: efriedma, rnk, mgorny, mstorsjo. TomTan added a project: LLDB. Herald added subscribers: lldb-commits, kristof.beyls. Change rL362280 (https://reviews.llvm.org/rL362280) changed CodeView API getRegisterNames