[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

This revision was automatically updated to reflect the committed changes. Closed by commit rG91e94a7015f1: [LLDB][Formatters] Re-enable std::function formatter with fixes to improve non… (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

shafik updated this revision to Diff 228923. shafik added a comment. Applying clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69913/new/ https://reviews.llvm.org/D69913 Files: lldb/include/lldb/Symbol/CompileUnit.h lldb/packages/Python/lldbsuite/test/functionalities/dat

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

shafik marked an inline comment as done. shafik added a comment. In D69913#1739579 , @jingham wrote: > Why not have the FindFunctions lambda take a FunctionSP? It would be easy to > get the Function name out of the function in the lambda, and that would

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

shafik updated this revision to Diff 228774. shafik added a comment. - Adjust comment - matching_lambda argument is now `FunctionSP` to match `ForeachFunction` signature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69913/new/ https://reviews.llvm.org/D69913 Files: lldb/include/lld

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/CompileUnit.h:169 + /// \param[in] matching_lambda + /// A predicate used to evaluate each function name. + /// This doesn't explain what the bool return does. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

jingham added a comment. Why not have the FindFunctions lambda take a FunctionSP? It would be easy to get the Function name out of the function in the lambda, and that would make the function more general (and also match what the Foreach does... CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

shafik added a comment. @aprantl you will want to take a second look at this, I did some major refactoring. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69913/new/ https://reviews.llvm.org/D69913 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

shafik updated this revision to Diff 228533. shafik marked 6 inline comments as done. shafik added a comment. After updating branch the stepping test started failing. It was failing because the __invoke case was subtly broken in this patch. Fixing that case opened up a lot of refactoring opportu

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Seems fine otherwise, I think. Comment at: include/lldb/Symbol/CompileUnit.h:174 + lldb::FunctionSP + FindFunction(llvm::function_ref matching_lambda); + ---

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

aprantl added inline comments. Comment at: include/lldb/Symbol/CompileUnit.h:172 + /// \return + /// The FunctionSP containing the first matching entry. + lldb::FunctionSP Document what does the bool return value do? Comment at: source/Plu

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

friss added inline comments. Comment at: source/Symbol/CompileUnit.cpp:101 + // m_functions_by_uid is filled in lazily but we need all the entries. + symbol_file->ParseFunctions(*this); + friss wrote: > This seems pretty expensive. Can we Force the parsing of t

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

friss added inline comments. Comment at: source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp:274 + vtable_first_entry_resolved.CalculateSymbolContextCompileUnit(); + llvm::StringRef name_to_use = func_to_match; + bool is_lambda = contains_lambda_identifier(name

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

shafik created this revision. shafik added reviewers: jasonmolenda, aam, jingham. Herald added a subscriber: christof. This PR depends on D67111 Performance issues lead to the libc++ std::function formatter to be disabled. We addressed some of those performance