This revision was automatically updated to reflect the committed changes.
Closed by commit rG7e825abd5704: Repair support for launching ios/tv/watch
simulator binaries through platform (authored by aprantl).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D81980?
vsk accepted this revision.
vsk added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:135
+ ifeq "$(TRIPLE_ENV)" ""
+ CODESIGN := codesign
+
aprantl updated this revision to Diff 271877.
aprantl marked an inline comment as done.
aprantl added a comment.
Simplify version detection.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81980/new/
https://reviews.llvm.org/D81980
Files:
lldb/packages/Python/lldbsuite/test/make/Makefi
aprantl updated this revision to Diff 271878.
aprantl added a comment.
Actually update the patch and not the diff from my previous patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81980/new/
https://reviews.llvm.org/D81980
Files:
lldb/packages/Python/lldbsuite/test/dotest.py
ll
aprantl marked an inline comment as done.
aprantl added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:135
+ ifeq "$(TRIPLE_ENV)" ""
+ CODESIGN := codesign
+ endif
vsk added a comment.
Generally this looks really nice!
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:135
+ ifeq "$(TRIPLE_ENV)" ""
+ CODESIGN := codesign
+ endif
If
aprantl updated this revision to Diff 271425.
aprantl added a comment.
Fix fallout from the Makefile.rules change by adapting a handful of manually
written Makefiles.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81980/new/
https://reviews.llvm.org/D81980
Files:
lldb/packages/Python
aprantl updated this revision to Diff 271393.
aprantl added a comment.
Fix decorator usage.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81980/new/
https://reviews.llvm.org/D81980
Files:
lldb/packages/Python/lldbsuite/test/dotest.py
lldb/packages/Python/lldbsuite/test/dotest_args.
aprantl created this revision.
aprantl added reviewers: friss, jasonmolenda, jingham.
and delete a bunch (but not all) redundant code. If you compare the remaining
implementations of Platform*Simulator.cpp, there is still an obvious leftover
cleanup task.
Specifically, this patch
- removes SDK
