Merged,
Thanks,
Maxim.
On 06/24/15 20:15, Bill Fischofer wrote:
On Tue, Jun 23, 2015 at 6:57 AM, Stuart Haslam
stuart.has...@linaro.org mailto:stuart.has...@linaro.org wrote:
Signed-off-by: Stuart Haslam stuart.has...@linaro.org
mailto:stuart.has...@linaro.org
Reviewed-by: Bill
Thanks,
Petri, please review API change.
Maxim.
On 06/25/15 12:05, hongbo.zh...@freescale.com wrote:
From: Hongbo Zhang hongbo.zh...@linaro.org
The current API of getting CPU frequency is really ambiguous.
CPU has its max frequency, and if enabled, the current frequency may be
scaled from
Anders, please take a look at this changes.
Thanks,
Maxim.
On 06/22/15 13:06, Nicolas Morey-Chaisemartin wrote:
Add $(EXEEXT) to all binary generated so platform can easily configure
the binaries extension and use the LOG_COMPILER features of automake.
This should have no visible effect unless
With the validation tests being moved, I don't think this on applies anymore. I
have another on ready to submit if you are interested
On 06/29/2015 03:03 PM, Maxim Uvarov wrote:
Anders, please take a look at this changes.
Thanks,
Maxim.
On 06/22/15 13:06, Nicolas Morey-Chaisemartin wrote:
Renaming of things which may be, one day, exported in a lib.
This renaming is important, as it creates consistency between test
symbols, which is needed if things get eventually exported in the lib.
Also, tests are often created from other tests: Fixing the first exemples
will help geting future
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/Makefile.am | 2 ++
test/validation/odp_packet.c | 15 +--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am
index
Please resend this patch in text format. Not in html. Use git
format-patch command.
Thank you,
Maxim.
On 06/24/15 19:40, Ola Liljedahl wrote:
On 24 June 2015 at 18:36, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
The set_next_free() checks if timer
https://bugs.linaro.org/show_bug.cgi?id=1632
--- Comment #2 from Stuart Haslam stuart.has...@linaro.org ---
Patch posted, awaiting review - https://patches.opendataplane.org/patch/1848/
--
You are receiving this mail because:
You are the assignee for the
since v1: use CU_ASSERT_PTR_NOT_NULL(x) to please check-patch
Packet tests now go through the same modification as pktio,
and gets finally called from the platform side.
To be applied on top of validation: pool tests moved to platform side
Christophe Milard (5):
validation: own main in
Module packet now gets its own directory and create its own lib
(currentely only containing its executable)
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
configure.ac | 1 +
test/validation/.gitignore| 1 -
Merged!
Thanks,
Maxim.
On 06/25/15 16:29, Ola Liljedahl wrote:
On 25 June 2015 at 15:01, Nicolas Morey-Chaisemartin nmo...@kalray.eu
mailto:nmo...@kalray.eu wrote:
odp_buffer_hdr_t was:
/* size: 136, cachelines: 3, members: 15 */
/* sum members: 124, holes: 3, sum
packet_main is now ran from the platform side.
As packet tests do not have
any platform dependency, the call to the platform agnostic tests is
performed directly in the Makefele.am (TESTS).
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
platform/linux-generic/test/Makefile.am
To please check-patch as much as possible before the
file gets moved (and rechecked by check-odp)
Note: braces are required in if/then/else with CU_ASSERT macro.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/odp_packet.c | 48
Merged,
Thanks,
Maxim.
On 06/11/15 13:00, Stuart Haslam wrote:
The test generates UDP packets with the source and destination port numbers
set to 0 and source and destination IP addresses of 0.0.0.0, which is
likely to cause them to be dropped and the test failing. Fix this by
correctly
On Wed, Jun 24, 2015 at 01:51:37PM +0200, Christophe Milard wrote:
Two new functions are introduced in odp_cunit_common.c:
odp_cunit_register_global_init() is to be used to register test
executable init function (overloading the default ODP init performed).
odp_cunit_register_global_term() is
On Wed, Jun 24, 2015 at 06:51:30PM +0200, Christophe Milard wrote:
Module init now create its own lib
(currentely only containing its executables)
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
configure.ac | 1 +
test/validation/.gitignore
On Wed, Jun 24, 2015 at 06:51:27PM +0200, Christophe Milard wrote:
To be applied on top of validation: tests for random moved to plt side
and also once validation: new functions to register hooks is applied.
init tests now go through the same modification as pktio,
and gets finally called
On Thu, Jun 25, 2015 at 12:50:29PM +0200, Christophe Milard wrote:
Queue tests now go through the same modification as pktio,
and gets finally called from the platform side.
Christophe Milard (5):
validation: own main in odp_queue.c
validation: renaming in odp_queue.c
validation:
On Fri, Jun 26, 2015 at 05:01:46PM +0200, Christophe Milard wrote:
removed from directory buffer. The file is not compiled nor
included.
Looks like this was accidentally missing from;
https://lists.linaro.org/pipermail/lng-odp/2015-February/009290.html
As v1 of that patch did drop this
On 29 June 2015 at 12:22, Stuart Haslam stuart.has...@linaro.org wrote:
On Wed, Jun 24, 2015 at 06:51:30PM +0200, Christophe Milard wrote:
Module init now create its own lib
(currentely only containing its executables)
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
On 29 June 2015 at 12:25, Stuart Haslam stuart.has...@linaro.org wrote:
On Fri, Jun 26, 2015 at 01:09:39PM +0200, Christophe Milard wrote:
To please check-patch as much as possible before the
file gets moved (and rechecked by check-odp)
Note that CU_ASSERT (xxx != NULL) cannot be written
Two new functions are introduced in odp_cunit_common.c:
odp_cunit_register_global_init() is to be used to register test
executable init function (overloading the default ODP init performed).
odp_cunit_register_global_term() is to be used to register test
executable terminason function (overloading
Petri, please review that change.
queue_destroy_finalize(qe) calls odp_buffer_free(buf) if queue is
QUEUE_STATUS_DESTROYED.
So that that case there will be double free of that buffer.
Thanks,
Maxim.
On 06/22/15 11:19, Nicolas Morey-Chaisemartin wrote:
Ping
On 06/15/2015 03:30 PM,
On 29 June 2015 at 12:22, Stuart Haslam stuart.has...@linaro.org wrote:
On Wed, Jun 24, 2015 at 01:51:37PM +0200, Christophe Milard wrote:
Two new functions are introduced in odp_cunit_common.c:
odp_cunit_register_global_init() is to be used to register test
executable init function
-Original Message-
From: ext Zoltan Kiss [mailto:zoltan.k...@linaro.org]
Sent: Monday, June 22, 2015 7:53 PM
To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [API-NEXT PATCH v3 3/9] packet_io: release unsent
packets after odp_pktio_send()
This is timely. I'll add it to the agenda for tomorrow's ODP call.
On Mon, Jun 29, 2015 at 9:43 AM, Radu-Andrei Bulie radu.bu...@freescale.com
wrote:
Hi,
There are two items I would like to discuss:
1. I have sent an email regarding the schedule tests issues (this
could be a
Add $(EXEEXT) to all binary generated so platform can easily configure
the binaries extension and use the LOG_COMPILER features of automake.
This should have no visible effect unless EXEEXT is set by the configure
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
Updated to apply on
Renaming of things which may be, one day, exported in a lib.
This renaming is important, as it creates consistency between test
symbols, which is needed if things get eventually exported in the lib.
Also, tests are often created from other tests: Fixing the first exemples
will help geting future
Hi,
There are two items I would like to discuss:
1. I have sent an email regarding the schedule tests issues (this could
be a general issue)
To relieve from a search on the mailing list I will paste the content (and make
a resumee):
I have some observations regarding the odp_scheduler
Module random now gets its own directory and create its own lib
(currentely only containing its executable)
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
Reviewed-by: Stuart Haslam stuart.has...@linaro.org
---
configure.ac | 1 +
random_main is now ran from the platform side.
As random tests do not have
any platform dependency, the call to the platform agnostic tests is
performed directly in the Makefele.am (TESTS).
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
Reviewed-by: Stuart Haslam
Applied.
Looks like something wrong was with my set up. First time I saw ndsp
and br in this email.
Thanks Anders to double checking that patch can be applied!
Maxim.
On 06/24/15 19:40, Ola Liljedahl wrote:
On 24 June 2015 at 18:36, Ivan Khoronzhuk ivan.khoronz...@linaro.org
On 2015-06-29 15:11, Nicolas Morey-Chaisemartin wrote:
With the validation tests being moved, I don't think this on applies anymore.
I have another on ready to submit if you are interested
I like your changes, please resend it.
Cheers,
Anders
On 06/29/2015 03:03 PM, Maxim Uvarov wrote:
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
Reviewed-by: Stuart Haslam stuart.has...@linaro.org
---
test/validation/Makefile.am | 2 ++
test/validation/odp_random.c | 15 +--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git
Renaming of things which may be, one day, exported in a lib.
This renaming is important, as it creates consistency between test
symbols, which is needed if things get eventually exported in the lib.
Also, tests are often created from other tests: Fixing the first exemples
will help geting future
queue_main is now ran from the platform side.
As queue tests do not have
any platform dependency, the call to the platform agnostic tests is
performed directly in the Makefele.am (TESTS).
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
Reviewed-by: Stuart Haslam
So that check-patch does not yell too much in next move.
2 warnings requiring extra blank lines are left.
As the original writer of this code, I am not sure these would
increase redibility...
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
Reviewed-by: Stuart Haslam
since v1: removed a useless remaining definition from validation/Makefile.am
To be applied on top of patch for system
(moving time to module system called from plt side).
Tests for random now go through the same modification as pktio,
and gets finally called from the platform side.
Christophe
since V1: rebased.
To be applied on top of: validation: init tests moved to platform side
Queue tests now go through the same modification as pktio,
and gets finally called from the platform side.
Christophe Milard (5):
validation: own main in odp_queue.c
validation: renaming in odp_queue.c
Module queue now gets its own directory and create its own lib
(currentely only containing its executable)
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
Reviewed-by: Stuart Haslam stuart.has...@linaro.org
---
configure.ac | 1 +
On 2015-06-29 16:53, Nicolas Morey-Chaisemartin wrote:
Add $(EXEEXT) to all binary generated so platform can easily configure
the binaries extension and use the LOG_COMPILER features of automake.
This should have no visible effect unless EXEEXT is set by the configure
Signed-off-by: Nicolas
We have the same kind of issue with our port.
We don't want (more precisely cannot for the moment) more than a thread per
core.
The way we handled it is by tweaking the implementation of cpu_count and the
default_mask to ignore the first core (which is running the main).
It would make sense to
I'm fine with this but why should it only be for this test and not all of them?
On 06/29/2015 06:09 PM, Maxim Uvarov wrote:
Use first cpu as control thread to run workers. And
all other cpus for workers run with pthread_create.
If needed to run something on current core it has to be
run
Radu-Andrei,
we also needed to limit number of workers for dpdk:
https://lists.linaro.org/pipermail/lng-odp-dpdk/2015-June/000844.html
I will send this patch to main mailing list.
Maxim.
On 06/29/15 17:44, Bill Fischofer wrote:
This is timely. I'll add it to the agenda for tomorrow's ODP
Merged,
thanks,
Maxim.
On 06/29/15 18:52, Anders Roxell wrote:
On 2015-06-29 16:53, Nicolas Morey-Chaisemartin wrote:
Add $(EXEEXT) to all binary generated so platform can easily configure
the binaries extension and use the LOG_COMPILER features of automake.
This should have no visible effect
On 06/29/15 19:05, Nicolas Morey-Chaisemartin wrote:
We have the same kind of issue with our port.
We don't want (more precisely cannot for the moment) more than a thread per
core.
The way we handled it is by tweaking the implementation of cpu_count and the
default_mask to ignore the first
As soon as we have Christophes test framework migration to platform calling
of the tests in we should consider a point release.
The rational is the need that the ODP-DPDK implementation has for this work.
ODP-DPDK currently has a platform specific limitation when running make
check vs running
On 06/29/15 19:32, Nicolas Morey-Chaisemartin wrote:
I'm fine with this but why should it only be for this test and not all of them?
Do you have that problem in others tests? Which one?
Maxim.
On 06/29/2015 06:09 PM, Maxim Uvarov wrote:
Use first cpu as control thread to run workers. And
On 29 June 2015 at 13:20, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 06/29/15 20:13, Mike Holmes wrote:
As soon as we have Christophes test framework migration to platform
calling of the tests in we should consider a point release.
The rational is the need that the ODP-DPDK
Merged,
Thanks.
Maxim.
On 06/18/15 22:32, Bill Fischofer wrote:
On Thu, Jun 18, 2015 at 11:59 AM, Benoît Ganne bga...@kalray.eu
mailto:bga...@kalray.eu wrote:
Signed-off-by: Benoît Ganne bga...@kalray.eu
mailto:bga...@kalray.eu
Reviewed-by: Bill Fischofer
On 06/29/15 20:13, Mike Holmes wrote:
As soon as we have Christophes test framework migration to platform
calling of the tests in we should consider a point release.
The rational is the need that the ODP-DPDK implementation has for this
work.
ODP-DPDK currently has a platform specific
Hi,
So you say instead of returning I should use an ODP_ABORT()?
Zoli
On 09/06/15 14:46, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Although implementation (linux-generic) is using the API calls, it can do short cuts e.g.
ensure that queue_enq will never fail (abort instead of fail) and
This touches include/odp/api so the subject must include API-NEXT
On 25 June 2015 at 05:05, hongbo.zh...@freescale.com wrote:
From: Hongbo Zhang hongbo.zh...@linaro.org
This patch add API to return the current frequency of the CPU on which
the thread is running.
Only x86 platform is
Perhaps we can use the Tuesday ODP Jira planning meeting to also do a quick
review of outstanding patches and their review status (similar to
Thursday's bug meeting)?
Again, I think Jenkins would help here, if only as a management tool to
track what's outstanding and to assign review
Need to send this with API-NEXT in the subject because it touches
include/odp/api
AND in the subject, make it a patch series for the two separate ideas AND
is a warning that you tried to do more than one thing in a patch.
Also you added a new API to API-NEXT with an implementation but you did
Yes, one of those butlers. :)
On Mon, Jun 29, 2015 at 4:05 PM, Mike Holmes mike.hol...@linaro.org wrote:
On 29 June 2015 at 16:55, Bill Fischofer bill.fischo...@linaro.org
wrote:
Perhaps we can use the Tuesday ODP Jira planning meeting to also do a
quick review of outstanding patches and
Current API definition does not state this was instantaneous frequency, jut
that it is in HZ, it needs to now say this is the max frequency
http://docs.opendataplane.org/master/linux-generic-doxygen-html/group__odp__ver__abt__log__dbg.html#ga135b9f3168549a9d043fe0a1b8f8ae08
On 25 June 2015 at
On 29 June 2015 at 16:55, Bill Fischofer bill.fischo...@linaro.org wrote:
Perhaps we can use the Tuesday ODP Jira planning meeting to also do a
quick review of outstanding patches and their review status (similar to
Thursday's bug meeting)?
We could take time for both, lets try it, but
Small patch series to:
- remove the basic socket support as it doesn't seem to be used anymore
- support segmented packets in socket MMSG mode.
The first and third patches are quite straight forward.
The second has more to discuss:
* I'm not fully happy the way we compute the max packet size
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
test/validation/pktio/pktio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c
index 5911ca7..fea40aa 100644
--- a/test/validation/pktio/pktio.c
+++
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
example/generator/odp_generator.c | 1 -
example/packet/odp_pktio.c | 1 -
.../linux-generic/include/odp_packet_io_internal.h | 3 +-
platform/linux-generic/odp_packet_io.c |
Fixes bug #1670
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
platform/linux-generic/odp_packet_socket.c | 95 +-
1 file changed, 79 insertions(+), 16 deletions(-)
diff --git a/platform/linux-generic/odp_packet_socket.c
62 matches
Mail list logo
