Re: [lng-odp] [PATCHv2] linux-generic: check return codes in odp_pktio_term_global

2015-11-09 Thread Maxim Uvarov
Merged, Maxim. On 11/06/2015 11:44, Nicolas Morey-Chaisemartin wrote: Reviewed-by: Nicolas Morey-Chaisemartin On 11/05/2015 04:58 PM, Maxim Uvarov wrote: According to API odp_pktio_close() can be called only for stopped pktio. So in odp_pktio_term_global try to stop it

[lng-odp] [API-NEXT PATCH v3 1/6] api: crypto: move enums from platform types to odp and rename to fit the API format

2015-11-09 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- example/ipsec/odp_ipsec_cache.c| 2 +- example/ipsec/odp_ipsec_cache.h| 4 +- example/ipsec/odp_ipsec_misc.h | 4 +- include/odp/api/crypto.h

Re: [lng-odp] [API-NEXT PATCH v7 2/6] example: generator: compare ticks instead of ns in loop

2015-11-09 Thread Ivan Khoronzhuk
On 09.11.15 15:09, Maxim Uvarov wrote: after that patch that scheduler fails: FAIL: ../../../test/validation/scheduler/scheduler_main for arm64. Maxim. Could you please point what exactly failed? On 11/05/2015 18:33, Ivan Khoronzhuk wrote: It's more accurate to compare ticks instead

[lng-odp] [API-NEXT PATCH v3 4/6] example: ipsec: add support for HMAC-SHA-256-128

2015-11-09 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- example/ipsec/odp_ipsec.c| 2 +- example/ipsec/odp_ipsec_misc.h | 8 ++-- example/ipsec/odp_ipsec_sa_db.c | 4 example/ipsec/odp_ipsec_stream.c | 3 ++- 4 files changed, 13 insertions(+), 4 deletions(-) diff

Re: [lng-odp] [API-NEXT PATCH v7 2/6] example: generator: compare ticks instead of ns in loop

2015-11-09 Thread Maxim Uvarov
after that patch that scheduler fails: FAIL: ../../../test/validation/scheduler/scheduler_main for arm64. Maxim. On 11/05/2015 18:33, Ivan Khoronzhuk wrote: It's more accurate to compare ticks instead of ns in each iteration, so calculate wait range before entering the loop. Signed-off-by:

[lng-odp] [API-NEXT PATCH v3 6/6] validation: crypto: add test for AES128 CBC

2015-11-09 Thread Nicolas Morey-Chaisemartin
Test reference vectors from RFC3602 Signed-off-by: Nicolas Morey-Chaisemartin --- test/validation/crypto/crypto.h | 4 + test/validation/crypto/odp_crypto_test_inp.c | 135 ++- test/validation/crypto/test_vectors.h| 67

[lng-odp] [API-NEXT PATCH v3 5/6] crypto: add AES128-CBC encrypt/decrypt methods

2015-11-09 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- include/odp/api/crypto.h | 2 + .../linux-generic/include/odp_crypto_internal.h| 4 + platform/linux-generic/odp_crypto.c| 89 ++ 3 files changed, 95 insertions(+)

Re: [lng-odp] [API-NEXT PATCH v7 2/6] example: generator: compare ticks instead of ns in loop

2015-11-09 Thread Maxim Uvarov
On 11/09/2015 16:09, Maxim Uvarov wrote: after that patch that scheduler fails: FAIL: ../../../test/validation/scheduler/scheduler_main for arm64. Maxim. brrr, that changes for generator. Interesting... Maxim. On 11/05/2015 18:33, Ivan Khoronzhuk wrote: It's more accurate to compare

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

2015-11-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #17 from Bill Fischofer --- That's strange since the locking logic wasn't changed in this patch. Still using the lock hierarchy suggested by Nicolas. I'll do some digging while on my flight this morning. --

Re: [lng-odp] [API-NEXT PATCH v7 2/6] example: generator: compare ticks instead of ns in loop

2015-11-09 Thread Ivan Khoronzhuk
On 09.11.15 15:29, Ivan Khoronzhuk wrote: On 09.11.15 15:09, Maxim Uvarov wrote: after that patch that scheduler fails: FAIL: ../../../test/validation/scheduler/scheduler_main for arm64. Maxim. Also, pat attention that for ARM64 the time API is based on cycle API that is not accurate

[lng-odp] [API-NEXT PATCH v3 2/6] api: crypto: add HMAC-SHA-256-128 support

2015-11-09 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- include/odp/api/crypto.h | 2 + .../linux-generic/include/odp_crypto_internal.h| 4 + platform/linux-generic/odp_crypto.c| 89 ++ 3 files changed, 95 insertions(+)

Re: [lng-odp] [API-NEXT PATCH v7 2/6] example: generator: compare ticks instead of ns in loop

2015-11-09 Thread Ivan Khoronzhuk
Or issue can be that you forgot to revert patch you currently incorrectly applied. "[lng-odp] [API-NEXT PATCH] api: cpu: change order of arguments for diff function" The right order is: "[lng-odp] [API-NEXT PATCH v7 0/6] api: time: unbind CPU cycles from time API" series. (don't forget v8 of

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

2015-11-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #16 from Carl Wallen --- I can also get a deadlock with only two queues: one ordered and one of any type (atomic, parallel or ordered) when run on two or more cores. It seems that the deadlock is there even when

Re: [lng-odp] [API-NEXTv2 1/4] crypto: move enums from platform types to odp and rename to fit the API format

2015-11-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi, For all patches that modify API files (include/odp/api/xxx.h), patch naming should be: "[API-NEXT PATCH v2 1/4] api: crypto: ... " So, words "PATCH" and "api:" are missing from the mail subject / git log entry. > -Original Message- > From: lng-odp

Re: [lng-odp] [API-NEXT PATCH v7 2/6] example: generator: compare ticks instead of ns in loop

2015-11-09 Thread Ivan Khoronzhuk
On 09.11.15 15:12, Maxim Uvarov wrote: On 11/09/2015 16:09, Maxim Uvarov wrote: after that patch that scheduler fails: FAIL: ../../../test/validation/scheduler/scheduler_main for arm64. Maxim. brrr, that changes for generator. Interesting... Maxim. Interesting, maybe it was after 3/6

[lng-odp] [API-NEXT PATCH v3 0/6] Add HMAC-SHA-256-128 and AES128 CBC support

2015-11-09 Thread Nicolas Morey-Chaisemartin
The first patch is a cleanup suggested by Petri. All the crypto enums are moved from linux-generic back to ODP API, and renamed (odp__t) Following patches add support for the new HMAC function, then a validation test and finally support in odp-ipsec And then same things for AES128 v3: *

[lng-odp] [API-NEXT PATCHv3 7/8] linux-generic: schedule: allow order to be ignored for internal use

2015-11-09 Thread Bill Fischofer
When a schedulable queue transitions from QUEUE_STATUS_NOTSCHED to QUEUE_STATUS_SCHED, the scheduler makes it ready by adding it to one of the scheduler's internal queues. This enqueue operation should not participate in any current ordered context to avoid potential deadlock. This patch

[lng-odp] [API-NEXT PATCHv3 6/8] linux-generic: queue: streamline and correct release_order() routine

2015-11-09 Thread Bill Fischofer
Resolve the corner case of releasing order for an order that still has events on the reorder queue. This also allows the reorder_complete() routine to be streamlined. This patch resolves Bug https://bugs.linaro.org/show_bug.cgi?id=1879 Signed-off-by: Bill Fischofer

[lng-odp] [API-NEXT PATCHv3 5/8] linux-generic: queue: streamline reorder_deq() routine

2015-11-09 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_queue_internal.h | 16 ++--- platform/linux-generic/odp_queue.c | 27 ++ 2 files changed, 19 insertions(+), 24 deletions(-) diff --git

[lng-odp] [API-NEXT PATCHv3 8/8] validation: schedule: add chaos test

2015-11-09 Thread Bill Fischofer
Add a "chaos" test variant to the scheduler CUnit tests. This test stresses the scheduler by circulating events among parallel, atomic, and ordered queues to verify that the scheduler can handle arbitrary looping paths without deadlock. Suggested-by: Carl Wallen

[lng-odp] [API-NEXT PATCHv3 3/8] linux-generic: queue: add ordered_queue_enq() routine - part 1

2015-11-09 Thread Bill Fischofer
Add the new ordered_queue_enq() internal routine. This is done in two parts to make the diffs easier to follow. Part 1 adds the new routine while Part 2 replaces queue_enq() to use it. Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_queue_internal.h

[lng-odp] [API-NEXT PATCHv3 4/8] linux-generic: queue: add ordered_queue_enq() routine - part 2

2015-11-09 Thread Bill Fischofer
Restructure queue_enq() to streamline it while using the new ordered_queue_enq() routine to handle ordered queues. This change is made in two parts to make the diffs easier to follow. Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_queue.c | 134

[lng-odp] [API-NEXT PATCHv3 2/8] linux-generic: queue: add utility functions for restructure

2015-11-09 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_queue_internal.h | 44 ++ platform/linux-generic/odp_queue.c | 7 2 files changed, 51 insertions(+) diff --git

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

2015-11-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #21 from Bill Fischofer --- v3 of Patch series beginning http://patches.opendataplane.org/patch/3682/ posted that resolves the deadlock issue identified by Carl. This latest issue arises because the scheduler

Re: [lng-odp] [ODP-DPDK] odp_generator ":PMD requires >32 buffers burst"

2015-11-09 Thread Zoltan Kiss
Hi Nicolas, The issue about QUEUE_MULTI_MAX being 8 will disappear when you start using DPDK 2.2. The ixgbe driver lowered the requirement for minimum receive batch size to 4. I'll push the patches for 2.2 support on ODP-DPDK probably tomorrow, if nothing objects on the patches. Regards,

Re: [lng-odp] ODP Mini Summit

2015-11-09 Thread David Rusling
Nice one David On Mon, 9 Nov 2015 18:25 Bob Monkman wrote: > > The shirts look great for OPNFV Design Summit, showing group sponsor > including ODP! > Bob > Sent from my HTC > > > -- > > -- IMPORTANT NOTICE: The contents of this email and any

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

2015-11-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #18 from Carl Wallen --- Created attachment 398 --> https://bugs.linaro.org/attachment.cgi?id=398=edit ODP basic queue test Added odp_queue_test.c to show a failing test case where ODP ordered queues deadlock.

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

2015-11-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #19 from Bill Fischofer --- Thanks. I was actually working on adding a test like you described to the main scheduler CUnit test. I'll try to repro the bug with your test and merge any additional details into

Re: [lng-odp] [API-NEXT PATCH v3 5/6] crypto: add AES128-CBC encrypt/decrypt methods

2015-11-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
Subject / git log entry misses "api:" api: crypto: add AES128-CBC encrypt/decrypt methods Also, the typo in the first patch could be corrected at the same time (maybe you missed the same comment from v2). See under. Patch 1/6: diff --git a/include/odp/api/crypto.h

Re: [lng-odp] [API-NEXT PATCH v3 5/6] crypto: add AES128-CBC encrypt/decrypt methods

2015-11-09 Thread Nicolas Morey-Chaisemartin
On 11/09/2015 04:18 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Subject / git log entry misses "api:" > > api: crypto: add AES128-CBC encrypt/decrypt methods Grmbl. Missed one again. > > > Also, the typo in the first patch could be corrected at the same time (maybe > you missed the same

Re: [lng-odp] [API-NEXT PATCHv3 0/8] Ordered Queue Bug Fixes

2015-11-09 Thread Wallen, Carl (Nokia - FI/Espoo)
Patch set: Reviewed-by: Carl Wallen -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Bill Fischofer Sent: Tuesday, November 10, 2015 6:20 AM To: lng-odp@lists.linaro.org Subject: [lng-odp] [API-NEXT PATCHv3 0/8] Ordered

Re: [lng-odp] Runtime inlining

2015-11-09 Thread Maxim Uvarov
JIT like lua might also not work because you need to rewrite OVS to support it. I don't think that it will be accepted. And it looks like it's problem in OVS, not in ODP. I.e. OVS should allow to use library functions for fast path (where inlines are critical). I.e. not just call

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

2015-11-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #22 from Carl Wallen --- Thanks Bill, v3 of the patch series seems to work fine. -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

[lng-odp] [API-NEXT PATCHv3 0/8] Ordered Queue Bug Fixes

2015-11-09 Thread Bill Fischofer
Changes for v3 -- Resolves deadlock issue identified by Carl Wallen -- Adds a "chaos" test to the scheduler CUnit suite to verify the above Changes for v2 -- Remove unused routine get_sched_sync() as part of part 1 of of this series This series cleans up the implementation of ordered queues and

[lng-odp] [API-NEXT PATCHv3 1/8] linux-generic: schedule: move ordered lock routines to odp_schedule.c

2015-11-09 Thread Bill Fischofer
Move the odp_schedule_order_lock() and odp_schedule_order_unlock() routines from odp_queue.c to odp_schedule.c Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_queue.c| 31 platform/linux-generic/odp_schedule.c | 45

Re: [lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple pktio input queues

2015-11-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
We need a clean way to create lock-free N input and output queues for packet IO. Lock-free here means that application use one rx/tx pair only from one thread. This is what many server applications need (== those currently using DPDK) – they don’t necessarily need classification, scheduler, TM,

Re: [lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple pktio input queues

2015-11-09 Thread Bill Fischofer
Lock-free is a reference to how an implementation might choose to implement an ODP queue. Better to speak in terms of use cases and let the implementation decide how to most efficiently realize them. As currently specified, all ODP queues are by default designed to be multi-producer /

[lng-odp] [API-NEXT PATCH 1/5] linux-generic: sockets: implement pktio statistics counters

2015-11-09 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov --- platform/linux-generic/Makefile.am | 1 + .../linux-generic/include/odp_packet_io_internal.h | 9 +++ platform/linux-generic/odp_packet_io.c | 53 + platform/linux-generic/pktio/socket.c

[lng-odp] [API-NEXT PATCH 0/5] pktio statistics counters

2015-11-09 Thread Maxim Uvarov
Initial version of implementation pktio statistics counters. ***Did not test netmap, it it should be the same sysfs netdev counters. Best regards, Maxim. Maxim Uvarov (5): linux-generic: sockets: implement pktio statistics counters linux-generic: pktio loop: implement statistics counters

[lng-odp] [API-NEXT PATCH 4/5] linux-generic: pktio netmap: implement statistics counters

2015-11-09 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov --- platform/linux-generic/pktio/netmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/platform/linux-generic/pktio/netmap.c b/platform/linux-generic/pktio/netmap.c index 794c82e..3d03ef2 100644 ---

[lng-odp] [API-NEXT PATCH 5/5] validation: implement pktio statistics counters

2015-11-09 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov --- test/validation/pktio/pktio.c | 130 ++ 1 file changed, 130 insertions(+) diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index 6320b77..c591c94 100644 ---

[lng-odp] [API-NEXT PATCH 3/5] linux-generic: pcap: implement pktio statistics counters

2015-11-09 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov --- platform/linux-generic/pktio/pcap.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/pktio/pcap.c b/platform/linux-generic/pktio/pcap.c index 0817bf5..34cd73c 100644

[lng-odp] [API-NEXT PATCH 2/5] linux-generic: pktio loop: implement statistics counters

2015-11-09 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov --- platform/linux-generic/pktio/loop.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/platform/linux-generic/pktio/loop.c b/platform/linux-generic/pktio/loop.c index ce19add..ec65fd4

Re: [lng-odp] [API-NEXT PATCHv2 0/6] Ordered Queue Bug Fixes

2015-11-09 Thread Maxim Uvarov
On 11/09/2015 12:48, Bill Fischofer wrote: It's on API-NEXT because that's where Maxim merged the earlier patches relating to this issue. They can be cherry-picked to master once they are reviewed. On Mon, Nov 9, 2015 at 3:43 AM, Savolainen, Petri (Nokia - FI/Espoo)

Re: [lng-odp] Runtime inlining

2015-11-09 Thread Jim Wilson
On Fri, Nov 6, 2015 at 6:48 AM, Zoltan Kiss wrote: > I've checked link time optimization (-flto), but it only helps with static > linking. Is there any way to keep the ODP application and platform > implementation binaries in separate files while having the performance >

Re: [lng-odp] Runtime inlining

2015-11-09 Thread Jim Wilson
On Mon, Nov 9, 2015 at 2:39 PM, Bill Fischofer wrote: > The IO Visor project appears to be doing something like this with LLVM and > JIT constructs to dynamically insert code into the kernel in a > platform-independent manner. Perhaps we can leverage that technology?

Re: [lng-odp] [API-NEXT PATCHv4 0/5] helper: add table module

2015-11-09 Thread huanggaoyang
I didn't find those doxygen warnings when perform the build.sh check, maybe I still haven't gotten the right way. I'll try again and fix all warnings in next patch. 在 2015/11/7 0:42, Mike Holmes 写道: Hi Huanggaoyang I may have missed a post from you that fixes this already, but you may want

Re: [lng-odp] [API-NEXT PATCH] api: sync: update spec and add odp_sync_loads

2015-11-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: EXT Nicolas Morey-Chaisemartin [mailto:nmo...@kalray.eu] Sent: Thursday, November 05, 2015 6:23 PM To: Savolainen, Petri (Nokia - FI/Espoo); Bill Fischofer Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH] api: sync: update spec and add odp_sync_loads On 11/05/2015 04:54

Re: [lng-odp] [API-NEXT PATCHv2 0/6] Ordered Queue Bug Fixes

2015-11-09 Thread Bill Fischofer
It's on API-NEXT because that's where Maxim merged the earlier patches relating to this issue. They can be cherry-picked to master once they are reviewed. On Mon, Nov 9, 2015 at 3:43 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Why this series is on api-next

Re: [lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple pktio input queues

2015-11-09 Thread Bala Manoharan
The existing Classification infra structure supports this behaviour of hashing after classification we have CoS API to allocate the packet to a queue group. The only missing API definition is a mechanism to configure header fields to be taken for hashing on CoS to distribute the packets to the

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

2015-11-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #14 from Carl Wallen --- (In reply to Bill Fischofer from comment #13) > Can you say what the application is doing, or provide a test case that > illustrates the issue? I have the same test case as before: "In my

Re: [lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple pktio input queues

2015-11-09 Thread Alexandru Badicioiu
On 9 November 2015 at 12:26, Bala Manoharan wrote: > The existing Classification infra structure supports this behaviour of > hashing after classification we have CoS API to allocate the packet to > a queue group. The only missing API definition is a mechanism to >

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

2015-11-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #15 from Bill Fischofer --- OK, which one of these do you believe is deadlocking? Also, this sounds like something that should be added to the schedule.c CUnit test. Can you post a patch for that or share your

Re: [lng-odp] [API-NEXT PATCH 0/3] retrieve queue information

2015-11-09 Thread Wallen, Carl (Nokia - FI/Espoo)
The main use case for this was to add functionality to retrieve the queue name, but since get_name() is not fast path functionality it was expanded into odp_queue_info() to also retrieve other info and provide symmetry with the existing odp_pool_info(), odp_timer_pool_info(), odp_shm_info()

Re: [lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple pktio input queues

2015-11-09 Thread Bala Manoharan
IMO, I believe it is more cleaner to create a bit-mask of different header fields so that the user can create a mask of fields to be used for calculating the hashing and it can be separate function configured on the CoS. But this is a discussion we can have once we conclude that we use hashing

Re: [lng-odp] Runtime inlining

2015-11-09 Thread Bill Fischofer
Adding Grant Likely to this chain as it relates to the broader subject of portable ABIs that we've been discussing. On Mon, Nov 9, 2015 at 4:48 PM, Jim Wilson wrote: > On Mon, Nov 9, 2015 at 2:39 PM, Bill Fischofer > wrote: > > The IO Visor

Re: [lng-odp] Runtime inlining

2015-11-09 Thread Bill Fischofer
The IO Visor project appears to be doing something like this with LLVM and JIT constructs to dynamically insert code into the kernel in a platform-independent manner. Perhaps we can leverage that technology? Bill On Mon, Nov 9, 2015 at 4:33 PM, Jim Wilson

Re: [lng-odp] [API-NEXT PATCHv2 3/6] linux-generic: queue: add ordered_queue_enq() routine - part 1

2015-11-09 Thread Bill Fischofer
It is necessary, and illustrates one of the complexities of ordered queuing. Consider the following sequence with QOrigin having current order 4: Thread A (Order 4)Thread B (Order 5) enq (Q, b1) enq(Q, a1) release_order()

Re: [lng-odp] [API-NEXT PATCHv2 3/6] linux-generic: queue: add ordered_queue_enq() routine - part 1

2015-11-09 Thread Nicolas Morey-Chaisemartin
You're right. In my mind order was linked to the buffer,not the thread meaning A would have enq b1 too. On 11/09/2015 11:05 AM, Bill Fischofer wrote: > It is necessary, and illustrates one of the complexities of ordered queuing. > Consider the following sequence with QOrigin having current

Re: [lng-odp] [API-NEXT PATCHv2 3/6] linux-generic: queue: add ordered_queue_enq() routine - part 1

2015-11-09 Thread Bill Fischofer
There's a surprising amount of subtlety involved in ordered queues, which is one of the reasons they're such a powerful primitive to have. On Mon, Nov 9, 2015 at 4:10 AM, Nicolas Morey-Chaisemartin wrote: > You're right. In my mind order was linked to the buffer,not the

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

2015-11-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #13 from Bill Fischofer --- Can you say what the application is doing, or provide a test case that illustrates the issue? -- You are receiving this mail because: You are on the CC list for the

Re: [lng-odp] [API-NEXT PATCHv2 2/6] linux-generic: queue: add utility functions for restructure

2015-11-09 Thread Nicolas Morey-Chaisemartin
On 11/08/2015 09:42 PM, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer > --- > .../linux-generic/include/odp_queue_internal.h | 44 > ++ > platform/linux-generic/odp_queue.c | 7 > 2 files changed, 51

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

2015-11-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #12 from Carl Wallen --- (In reply to Bill Fischofer from comment #11) > Patch series http://patches.opendataplane.org/patch/3661/ through > http://patches.opendataplane.org/patch/3666/ posted to fully resolve this >

Re: [lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple pktio input queues

2015-11-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: EXT Bala Manoharan [mailto:bala.manoha...@linaro.org] > Sent: Friday, November 06, 2015 7:54 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: LNG ODP Mailman List > Subject: Re: [lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple > pktio input queues

Re: [lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple pktio input queues

2015-11-09 Thread Alexandru Badicioiu
CoS concept can be easily extended to implement hashing instead of classification. Instead of a single queue a CoS can have multiple queues and the packet fields used for hashing can be specified by the already defined PMR terms (enum odp_pmr_term) with a val_sz set to 0. Packets arriving at such

Re: [lng-odp] [API-NEXT PATCHv2 0/6] Ordered Queue Bug Fixes

2015-11-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
Why this series is on api-next branch? It does not change the API, and any bug fixes are urgently needed on master. -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > EXT Bill Fischofer > Sent: Sunday, November 08, 2015 10:42 PM > To:

Re: [lng-odp] [API-NEXT PATCHv2 3/6] linux-generic: queue: add ordered_queue_enq() routine - part 1

2015-11-09 Thread Nicolas Morey-Chaisemartin
On 11/08/2015 09:42 PM, Bill Fischofer wrote: > Add the new ordered_queue_enq() internal routine. This is done in two > parts to make the diffs easier to follow. Part 1 adds the new routine > while Part 2 replaces queue_enq() to use it. > > Signed-off-by: Bill Fischofer

Re: [lng-odp] [API-NEXT PATCH] api: cpu: change order of arguments for diff function

2015-11-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > EXT Ivan Khoronzhuk > Sent: Thursday, November 05, 2015 6:01 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCH]

Re: [lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple pktio input queues

2015-11-09 Thread Bill Fischofer
Hashing was the idea behind queue groups. A "basic" PMR puts the output on a designated queue. A "hashing" PMR distributes the results to the individual queues in a queue group. On Mon, Nov 9, 2015 at 3:43 AM, Alexandru Badicioiu < alexandru.badici...@linaro.org> wrote: > CoS concept can be

Re: [lng-odp] [API-NEXT PATCH 0/3] retrieve queue information

2015-11-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
Patch set: Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > EXT Carl Wallen > Sent: Monday, November 09, 2015 9:56 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT

Re: [lng-odp] [API-NEXT PATCH] api: cpu: change order of arguments for diff function

2015-11-09 Thread Maxim Uvarov
Merged with small rebase, please check. Maxim. On 11/09/2015 12:16, Savolainen, Petri (Nokia - FI/Espoo) wrote: Reviewed-by: Petri Savolainen -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Ivan Khoronzhuk

Re: [lng-odp] [API-NEXT PATCH] api: cpu: change order of arguments for diff function

2015-11-09 Thread Ivan Khoronzhuk
Maxim, this is based on "[lng-odp] [API-NEXT PATCH v7 0/6] api: time: unbind CPU cycles from time API" as described below. It's applied w/o conflicts. On 09.11.15 13:52, Maxim Uvarov wrote: Merged with small rebase, please check. Maxim. On 11/09/2015 12:16, Savolainen, Petri (Nokia -

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

2015-11-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #20 from Bill Fischofer --- Quick update. I've written a simplified version of your test and integrated it into the CUnit scheduler test. It runs fine most of the time but when it passes subsequent tests are