[lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

2015-12-16 Thread Balasubramanian Manoharan
class of service create function now takes pool, queue, drop policy and name as input parameters. Adds class of service parameter structure odp_cls_cos_param_t and initialization function odp_cls_cos_param_init() Signed-off-by: Balasubramanian Manoharan --- v2: additional documentation and review

[lng-odp] [API-NEXT/PATCHv2 2/6] linux-generic: classification: implement class of service create api

2015-12-16 Thread Balasubramanian Manoharan
Implements odp_cls_cos_create() and odp_cls_cos_param_init() functions Signed-off-by: Balasubramanian Manoharan --- platform/linux-generic/odp_classification.c | 31 ++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/odp_classifica

[lng-odp] [API-NEXT/PATCHv2 3/6] validation: classification: add class of service create api

2015-12-16 Thread Balasubramanian Manoharan
Replaces odp_cos_create() function with odp_cls_cos_create() function Signed-off-by: Balasubramanian Manoharan --- test/validation/classification/classification.h| 1 + .../classification/odp_classification_basic.c | 137 +++- .../classification/odp_classification_common.c |

[lng-odp] [API-NEXT/PATCHv2 4/6] example: classifier: add class of service create api

2015-12-16 Thread Balasubramanian Manoharan
Replaces odp_cos_create() function with odp_cls_cos_create() function Signed-off-by: Balasubramanian Manoharan --- example/classifier/odp_classifier.c | 42 + 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/example/classifier/odp_classifier.c

[lng-odp] [API-NEXT/PATCHv2 6/6] linux-generic: classification: rename odp_drop_e to odp_cls_drop_t

2015-12-16 Thread Balasubramanian Manoharan
changes drop policy enum name from odp_drop_e to odp_cls_drop_t Signed-off-by: Balasubramanian Manoharan --- platform/linux-generic/include/odp_classification_datamodel.h | 2 +- platform/linux-generic/odp_classification.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletio

[lng-odp] [API-NEXT/PATCHv2 5/6] api: classification: rename odp_drop_e to odp_cls_drop_t

2015-12-16 Thread Balasubramanian Manoharan
Changes drop policy enum name from odp_drop_e to odp_cls_drop_t Signed-off-by: Balasubramanian Manoharan --- include/odp/api/classification.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/odp/api/classification.h b/include/odp/api/classification.h index 4db5

[lng-odp] [PATCH v4] helper: linux: add thread type in pthread_create

2015-12-16 Thread Hemant Agrawal
The exisiting helper routine only create the worker threads. However there is a need to use the same for creating the control thread as well. e.g. CLI thread. Signed-off-by: Hemant Agrawal --- example/classifier/odp_classifier.c | 2 +- example/generator/odp_generator.c | 9 ++-

Re: [lng-odp] [API-NEXT PATCH v2 0/6] api: time: add rate and delay APIs

2015-12-16 Thread Ivan Khoronzhuk
On 16.12.15 05:30, Mike Holmes wrote: On 15 December 2015 at 07:29, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote: This series adds odp_time_local_res() and odp_time_wait() calls to time API and it's validation tests and usage. When do we start requiring that new api wor

Re: [lng-odp] [API-NEXT PATCH] api: remove ODP_DEPRECATED

2015-12-16 Thread Maxim Uvarov
To not break a build just add CFLAGS="-Wno-deprecated-declarations". That will be good check that no more deprecated function exist in the code. I.e. procedure is following functions will have ODP_DEPRECATED tag for some tome and ./configure will support -Wno-deprecated-declarations as default. A

[lng-odp] odp_cpumask_default_worker() calls from worker threads

2015-12-16 Thread Zoltan Kiss
Hi, I have a question: is it allowed to call these functions from worker threads? The current linux-generic implementation doesn't seem to support that, because it checks for the affinity of the current thread. In case of a worker it is probably restricted for one CPU. It seems to me that "how

Re: [lng-odp] [PATCH 2/2] doc: release-guide: add deprecated api section

2015-12-16 Thread Maxim Uvarov
On 12/15/2015 21:06, Mike Holmes wrote: Describe how changes to the public api are handled from release to release. Signed-off-by: Mike Holmes --- doc/process-guide/release-guide.adoc | 38 1 file changed, 38 insertions(+) diff --git a/doc/process-guide/

Re: [lng-odp] [PATCH v4] helper: linux: add thread type in pthread_create

2015-12-16 Thread Maxim Uvarov
Merged, Maxim. On 12/16/2015 12:44, Hemant Agrawal wrote: The exisiting helper routine only create the worker threads. However there is a need to use the same for creating the control thread as well. e.g. CLI thread. Signed-off-by: Hemant Agrawal --- example/classifier/odp_classifier.c

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

2015-12-16 Thread Maxim Uvarov
From meeting we decided that we want solution based on pool. Can you post that patches? We will try to help how to improve performance. Maxim. On 12/14/2015 22:30, Mike Holmes wrote: Added to Tuesday agenda On 12 December 2015 at 22:18, HePeng > wrote: Ping.

Re: [lng-odp] [API-NEXT PATCH v5 2/7] api: pktio: added multiple pktio input queues

2015-12-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] > Sent: Tuesday, December 15, 2015 9:07 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH v5 2/7] api: pktio: added multiple > pktio input queues >

[lng-odp] [API-NEXT PATCH 01/19] linux-generic: pktio: enable using PKTIO_MAX_QUEUES in pktio implementations

2015-12-16 Thread Petri Savolainen
From: Matias Elo Change include order to enable using PKTIO_MAX_QUEUES in pktio implementations. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_io_internal.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/platform/linux-generic/include/

[lng-odp] [API-NEXT PATCH 00/19] Multi-queue pktio scheduler support

2015-12-16 Thread Petri Savolainen
This patch set includes netmap implementation of the new pktio multi-queue API and scheduler integration. Netmap code is based on "netmap pktio multi queue support v2" patch series. Modifications include mainly bug fixes and performance optimizations, functionality is more or less the same (wi

[lng-odp] [API-NEXT PATCH 02/19] linux-generic: pktio: add RSS helper functions

2015-12-16 Thread Petri Savolainen
From: Matias Elo Added functions for fetching, configuring, and printing NIC RSS configurations. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_socket.h | 47 + platform/linux-generic/pktio/socket.c | 234 + 2 files changed, 281 in

[lng-odp] [API-NEXT PATCH 04/19] linux-generic: netmap: add odp_pktio_capability()

2015-12-16 Thread Petri Savolainen
From: Matias Elo Implemented odp_pktio_capability() function in netmap. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_netmap.h | 2 ++ platform/linux-generic/pktio/netmap.c | 17 - 2 files changed, 18 insertions(+), 1 deletion(-) diff --

[lng-odp] [API-NEXT PATCH 03/19] linux-generic: netmap: add odp_pktio_start()

2015-12-16 Thread Petri Savolainen
From: Matias Elo Added initial version of odp_pktio_start() to netmap. Removed unnecessary global mmap_desc variable. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_netmap.h | 2 + platform/linux-generic/pktio/netmap.c | 59 -- 2 files

[lng-odp] [API-NEXT PATCH 07/19] linux-generic: netmap: odp_pktio_recv() from all pktin queues

2015-12-16 Thread Petri Savolainen
From: Matias Elo Receive packets from all pktin queues. Improves backward compatibility. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_netmap.h | 1 + platform/linux-generic/pktio/netmap.c | 22 +- 2 files changed, 22 insertions(+), 1

[lng-odp] [API-NEXT PATCH 08/19] linux-generic: netmap: use select() instead of poll() in recv

2015-12-16 Thread Petri Savolainen
From: Matias Elo Use select() instead of poll() in recv to reduce the number of system calls. Signed-off-by: Matias Elo --- platform/linux-generic/pktio/netmap.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/platform/linux-generic/pktio/netmap.

[lng-odp] [API-NEXT PATCH 06/19] linux-generic: netmap: add functions for fetching pktio queues

2015-12-16 Thread Petri Savolainen
From: Matias Elo Added functions for fetching netmap in, pktin, and pktout queues. Signed-off-by: Matias Elo --- platform/linux-generic/pktio/netmap.c | 48 --- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/pktio/netmap.c

[lng-odp] [API-NEXT PATCH 05/19] linux-generic: netmap: add initial multi queue support

2015-12-16 Thread Petri Savolainen
From: Matias Elo Added multi queue support to netmap pktio. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_netmap.h | 34 +- platform/linux-generic/pktio/netmap.c | 422 ++--- 2 files changed, 403 insertions(+), 53 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH 09/19] linux-generic: netmap: add netmap_link_status() function

2015-12-16 Thread Petri Savolainen
From: Matias Elo Added a separate function for determining if the netmap link is up. Signed-off-by: Matias Elo --- platform/linux-generic/pktio/netmap.c | 48 +-- 1 file changed, 34 insertions(+), 14 deletions(-) diff --git a/platform/linux-generic/pktio/netmap

[lng-odp] [API-NEXT PATCH 12/19] linux-generic: netmap: fix netmap_mtu_get()

2015-12-16 Thread Petri Savolainen
From: Matias Elo Use correct MTU value for netmap. Either configured interface MTU or netmap buffer size. Whichever is smaller. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_netmap.h | 1 + platform/linux-generic/pktio/netmap.c | 18 -- 2

[lng-odp] [API-NEXT PATCH 10/19] linux-generic: netmap: add netmap_close_descriptors() function

2015-12-16 Thread Petri Savolainen
From: Matias Elo Added a separate function for closing netmap descriptors, which can be reopened using netmap_start() call. Signed-off-by: Matias Elo --- platform/linux-generic/pktio/netmap.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/platform/linux-ge

[lng-odp] [API-NEXT PATCH 11/19] linux-generic: netmap: add start()/stop() functionality

2015-12-16 Thread Petri Savolainen
From: Matias Elo Add support for starting/stopping netmap interfaces. Netmap interfaces can only be configured while in stopped state. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_netmap.h | 5 platform/linux-generic/pktio/netmap.c | 30 +++

[lng-odp] [API-NEXT PATCH 13/19] linux-generic: netmap: disable debug prints

2015-12-16 Thread Petri Savolainen
From: Matias Elo Disable printing of tens of lines of unnecessary debug info per netmap port. Signed-off-by: Matias Elo --- platform/linux-generic/pktio/netmap.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/platform/linux-generic/pktio/netmap.c b/platform/linux-generic/pktio/net

[lng-odp] [API-NEXT PATCH 16/19] test: l2fwd: use multi-queue API for scheduled queues

2015-12-16 Thread Petri Savolainen
Updates scheduled queue mode to use the new multi-queue pktio API. Signed-off-by: Petri Savolainen --- test/performance/odp_l2fwd.c | 52 ++-- 1 file changed, 31 insertions(+), 21 deletions(-) diff --git a/test/performance/odp_l2fwd.c b/test/performance/o

[lng-odp] [API-NEXT PATCH 14/19] linux-generic: pktio: added scheduler multi-queue support

2015-12-16 Thread Petri Savolainen
Added support for new multi-queue pktio API for scheduled queues. Signed-off-by: Petri Savolainen --- .../linux-generic/include/odp_packet_io_internal.h | 8 +- .../linux-generic/include/odp_schedule_internal.h | 3 +- platform/linux-generic/odp_packet_io.c | 136 +--

[lng-odp] [API-NEXT PATCH 17/19] test: l2fwd: use multiple queues in sched mode

2015-12-16 Thread Petri Savolainen
Increase number of queues from 1 to 1 per worker thread. Signed-off-by: Petri Savolainen --- test/performance/odp_l2fwd.c | 53 1 file changed, 39 insertions(+), 14 deletions(-) diff --git a/test/performance/odp_l2fwd.c b/test/performance/odp_l2fwd.c

[lng-odp] [API-NEXT PATCH 15/19] linux-generic: netmap: add scheduler multi-queue support

2015-12-16 Thread Petri Savolainen
Modified netmap pktio to support the new multi-queue pktio API with scheduled queues. Signed-off-by: Petri Savolainen --- platform/linux-generic/include/odp_packet_netmap.h | 2 - platform/linux-generic/pktio/netmap.c | 52 +- 2 files changed, 31 insertions(+),

[lng-odp] [API-NEXT PATCH 19/19] api: pktio: refine multiqueue API spec

2015-12-16 Thread Petri Savolainen
Specify explicitly that new config calls invalidate old handles and outputted queue handles are stored in 0 ... N-1. Signed-off-by: Petri Savolainen --- include/odp/api/packet_io.h | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/include/odp/api/packet_io.h b/i

[lng-odp] [API-NEXT PATCH 18/19] linux-generic: scheduler: improve pktio polling

2015-12-16 Thread Petri Savolainen
Separate packet input polling from event scheduling. A thread polls packet input only when there are no events. Packet input queue index is included into poll command queue selection. Signed-off-by: Petri Savolainen --- .../linux-generic/include/odp_schedule_internal.h | 2 +- platform/linux-

Re: [lng-odp] [API-NEXT PATCH 1/2] api: barrier: added memory barriers

2015-12-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. Waiting to be merged. From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Sunday, December 13, 2015 12:44 AM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 1/2] api: barrier: added memory barriers On Fri, Dec 11, 2015

Re: [lng-odp] [PATCH] example: timer: free resources while termination

2015-12-16 Thread Bill Fischofer
This patch doesn't appear to apply to the current master. Needs a rebase? bill@Ubuntu15:~/linaro/ivanpatch$ git am --reject ~/Mail/Incoming/Ivan/1 Applying: example: timer: free resources while termination Checking patch example/timer/odp_timer_test.c... Hunk #1 succeeded at 334 (offset 3 lines).

Re: [lng-odp] [PATCH] example: timer: free resources while termination

2015-12-16 Thread Ivan Khoronzhuk
On 16.12.15 16:26, Bill Fischofer wrote: This patch doesn't appear to apply to the current master. Needs a rebase? Probably yes, I'll rebase. bill@Ubuntu15:~/linaro/ivanpatch$ git am --reject ~/Mail/Incoming/Ivan/1 Applying: example: timer: free resources while termination Checking patch e

Re: [lng-odp] [PATCH] api: pktio link status

2015-12-16 Thread Maxim Uvarov
Merged, with requested change. Maxim. On 12/11/2015 15:52, Savolainen, Petri (Nokia - FI/Espoo) wrote: Mail subject should be: [API-NEXT PATCH] api: pktio: added link status Otherwise OK. Could you update the git log entry before merging: "api: pktio: added link status" Reviewed-by: Petri S

[lng-odp] [HELP] Question about API Classification and Traffic Manager

2015-12-16 Thread Kury Nicolas
Hi! I have some questions about Traffic Manager and Classifier. Traffic Manager: I see there is the possibility to send back the packets. Do you have any example where this would be used ? I don't really see how we can combine the different algorithms, example Strict Priority scheduling with Ba

Re: [lng-odp] [API-NEXT PATCH v5 2/7] api: pktio: added multiple pktio input queues

2015-12-16 Thread Zoltan Kiss
On 16/12/15 12:56, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] Sent: Tuesday, December 15, 2015 9:07 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT PATCH v

Re: [lng-odp] [API-NEXT PATCH 19/19] api: pktio: refine multiqueue API spec

2015-12-16 Thread Zoltan Kiss
Reviewed-by: Zoltan Kiss On 16/12/15 13:45, Petri Savolainen wrote: Specify explicitly that new config calls invalidate old handles and outputted queue handles are stored in 0 ... N-1. Signed-off-by: Petri Savolainen --- include/odp/api/packet_io.h | 14 ++ 1 file changed, 10 i

Re: [lng-odp] [HELP] Question about API Classification and Traffic Manager

2015-12-16 Thread Bala Manoharan
Hi, On 16 December 2015 at 20:22, Kury Nicolas wrote: > Hi! > > I have some questions about Traffic Manager and Classifier. > > Traffic Manager: > I see there is the possibility to send back the packets. Do you have any > example where this would be used ? I don't really see how we can combine t

[lng-odp] Pool DMA mapping

2015-12-16 Thread Christophe Milard
Hi, Following the discussion at the ARCH call, today, would it be reasonable to require that all packet pools that can be used by a NIC have to be created before the related nic pktio is opened? -This is implicitly required in RX, as the pool handle from which buffer should be allocated in RX is a

Re: [lng-odp] [API-NEXT PATCH v5 2/7] api: pktio: added multiple pktio input queues

2015-12-16 Thread Zoltan Kiss
Hi, On 16/12/15 12:56, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >>>+typedef struct odp_pktio_input_queue_param_t { > >>>+ /** Single thread per queue. Enable performance optimization when > >>each > >>>+* queue has only single user. > >>>+* 0: Queue is multi-thread sa

Re: [lng-odp] [API-NEXT PATCH 1/2] api: barrier: added memory barriers

2015-12-16 Thread Maxim Uvarov
Merged, Maxim. On 12/16/2015 16:51, Savolainen, Petri (Nokia - FI/Espoo) wrote: Ping. Waiting to be merged. *From:*EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] *Sent:* Sunday, December 13, 2015 12:44 AM *To:* Savolainen, Petri (Nokia - FI/Espoo) *Cc:* LNG ODP Mailman List *Subject:* R

Re: [lng-odp] [API-NEXT PATCH 05/19] linux-generic: netmap: add initial multi queue support

2015-12-16 Thread Zoltan Kiss
On 16/12/15 13:45, Petri Savolainen wrote: From: Matias Elo Added multi queue support to netmap pktio. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_netmap.h | 34 +- platform/linux-generic/pktio/netmap.c | 422 ++--- 2 files chang

Re: [lng-odp] Pool DMA mapping

2015-12-16 Thread Zoltan Kiss
On 16/12/15 15:39, Christophe Milard wrote: Hi, Following the discussion at the ARCH call, today, would it be reasonable to require that all packet pools that can be used by a NIC have to be created before the related nic pktio is opened? -This is implicitly required in RX, as the pool handle

Re: [lng-odp] Pool DMA mapping

2015-12-16 Thread Zoltan Kiss
On 16/12/15 16:47, Zoltan Kiss wrote: On 16/12/15 15:39, Christophe Milard wrote: Hi, Following the discussion at the ARCH call, today, would it be reasonable to require that all packet pools that can be used by a NIC have to be created before the related nic pktio is opened? -This is impli

Re: [lng-odp] [PATCH 2/2] doc: release-guide: add deprecated api section

2015-12-16 Thread Mike Holmes
On 16 December 2015 at 05:50, Maxim Uvarov wrote: > On 12/15/2015 21:06, Mike Holmes wrote: > >> Describe how changes to the public api are handled from release to >> release. >> >> Signed-off-by: Mike Holmes >> --- >> doc/process-guide/release-guide.adoc | 38 >> ++

Re: [lng-odp] [HELP] Question about API Classification and Traffic Manager

2015-12-16 Thread Kury Nicolas
Hi! I see now. Thank you very much! Nicolas De : Bala Manoharan Envoyé : mercredi 16 décembre 2015 16:23 À : Kury Nicolas Cc : lng-odp@lists.linaro.org Objet : Re: [lng-odp] [HELP] Question about API Classification and Traffic Manager Hi, On 16 Decemb

Re: [lng-odp] [PATCH 2/2] doc: release-guide: add deprecated api section

2015-12-16 Thread Maxim Uvarov
On 12/16/2015 20:22, Mike Holmes wrote: On 16 December 2015 at 05:50, Maxim Uvarov > wrote: On 12/15/2015 21:06, Mike Holmes wrote: Describe how changes to the public api are handled from release to release. Signed-off-by: Mike Hol

Re: [lng-odp] Pool DMA mapping

2015-12-16 Thread Maxim Uvarov
On 12/16/2015 19:48, Zoltan Kiss wrote: On 16/12/15 16:47, Zoltan Kiss wrote: On 16/12/15 15:39, Christophe Milard wrote: Hi, Following the discussion at the ARCH call, today, would it be reasonable to require that all packet pools that can be used by a NIC have to be created before the

Re: [lng-odp] Pool DMA mapping

2015-12-16 Thread Bill Fischofer
It's an application responsibility to ensure that a packet sent directly to a pktio is in storage that is addressable to that interface. For packets being transmitted via the traffic manager (via odp_tm_enq()) again it is the responsibility of the application to ensure that the tm system was confi

Re: [lng-odp] [PATCH v2] test: performance: add crypto test

2015-12-16 Thread Mike Holmes
with apply and build Using patch: lng-odp_PATCH_v2_test_performance_add_crypto_test.mbox Trying to apply patch Patch applied WARNING: 'Imediately' may be misspelled - perhaps 'Immediately'? #645: FILE: test/performance/odp_crypto.c:582: + print_mem("Imediately encrypted packet", mem, total:

Re: [lng-odp] [PATCHv17 04/10] helpers: remove odp_ prefix for tests source files

2015-12-16 Thread Mike Holmes
Using patch: lng-odp_PATCHv17_04-10_helpers_remove_odp_prefix_for_tests_source_files.mbox Trying to apply patch Patch applied Applying: helpers: remove odp_ prefix for tests source files /home/mike/git/check-odp/build/odp-apply/.git/rebase-apply/patch:47: indent with spaces. threa

Re: [lng-odp] [API-NEXT PATCH v2 0/6] api: time: add rate and delay APIs

2015-12-16 Thread Mike Holmes
On 16 December 2015 at 05:24, Ivan Khoronzhuk wrote: > > > On 16.12.15 05:30, Mike Holmes wrote: > >> >> On 15 December 2015 at 07:29, Ivan Khoronzhuk > > wrote: >> >> This series adds odp_time_local_res() and odp_time_wait() calls to >> time API and it'

Re: [lng-odp] [API-NEXT PATCH 00/19] Multi-queue pktio scheduler support

2015-12-16 Thread Bill Fischofer
For this series: Reviewed-and-Tested-by: Bill Fischofer On Wed, Dec 16, 2015 at 7:45 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > > This patch set includes netmap implementation of the new pktio multi-queue > API > and scheduler integration. > > Netmap code is based on "netmap pk

Re: [lng-odp] odp_cpumask_default_worker() calls from worker threads

2015-12-16 Thread Bill Fischofer
On Tue, Dec 15, 2015 at 6:58 PM, Zoltan Kiss wrote: > Hi, > > I have a question: is it allowed to call these functions from worker > threads? The current linux-generic implementation doesn't seem to support > that, because it checks for the affinity of the current thread. In case of > a worker it

Re: [lng-odp] [PATCH] linux-generic: include netmap headers with -isystem

2015-12-16 Thread Bill Fischofer
On Tue, Dec 15, 2015 at 5:18 AM, Stuart Haslam wrote: > The netmap header file has some dubious casts that generate errors when > -Wcast-qual is enabled. Include it as a system header so that the > compiler ignores those errors without having to ignore errors in our own > source files. > > Signed

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

2015-12-16 Thread Bill Fischofer
On Wed, Dec 16, 2015 at 3:28 AM, Balasubramanian Manoharan < bala.manoha...@linaro.org> wrote: > class of service create function now takes pool, queue, drop policy and > name as input parameters. > Adds class of service parameter structure odp_cls_cos_param_t and > initialization function odp_cls

Re: [lng-odp] [API-NEXT/PATCHv2 5/6] api: classification: rename odp_drop_e to odp_cls_drop_t

2015-12-16 Thread Bill Fischofer
On Wed, Dec 16, 2015 at 3:28 AM, Balasubramanian Manoharan < bala.manoha...@linaro.org> wrote: > Changes drop policy enum name from odp_drop_e to odp_cls_drop_t > > Signed-off-by: Balasubramanian Manoharan > --- > include/odp/api/classification.h | 8 > 1 file changed, 4 insertions(+),

Re: [lng-odp] [PATCH] api: packet: add detailed packet error api

2015-12-16 Thread Bill Fischofer
This should be marked API-NEXT, but assuming that can be fixed during merge... On Tue, Nov 17, 2015 at 1:06 AM, Balasubramanian Manoharan < bala.manoha...@linaro.org> wrote: > Adds api to get packet error flags for L2, L3 and L4 errors. > > Signed-off-by: Balasubramanian Manoharan > Reviewed-an

Re: [lng-odp] [PATCH v1] doc/users-guide: add cryptographic services section

2015-12-16 Thread Bill Fischofer
This needs significant expansion, but it's a worthwhile start. On Tue, Dec 15, 2015 at 6:01 AM, wrote: > From: Alexandru Badicioiu > Signed-off-by: Alexandru Badicioiu > Reviewed-by: Bill Fischofer > --- > doc/users-guide/users-guide.adoc | 21 + > 1 file changed, 21

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

2015-12-16 Thread HePeng
Hi, Maxim I will present a quick patch that will not pass the kernel style check as this one is just for evaluation. > 在 2015年12月16日,下午8:22,Maxim Uvarov 写道: > > From meeting we decided that we want solution based on pool. Can you post that > patches? We will try to help how to improve perfor

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

2015-12-16 Thread Bala Manoharan
The reason for having odp_cls_xxx is that class of service module contains class of service and packet matching rule and we need a common syntax to identify the module hence odp_cls_xxx is used as common prefix. I agree all the functions in classifier module needs to be changed to add the prefix o

Re: [lng-odp] [API-NEXT/PATCHv2 5/6] api: classification: rename odp_drop_e to odp_cls_drop_t

2015-12-16 Thread Bala Manoharan
Hi, On 17 December 2015 at 08:54, Bill Fischofer wrote: > > > On Wed, Dec 16, 2015 at 3:28 AM, Balasubramanian Manoharan > wrote: >> >> Changes drop policy enum name from odp_drop_e to odp_cls_drop_t >> >> Signed-off-by: Balasubramanian Manoharan >> --- >> include/odp/api/classification.h | 8

Re: [lng-odp] [PATCH v2] test: performance: add crypto test

2015-12-16 Thread Alexandru Badicioiu
On 17 December 2015 at 00:50, Mike Holmes wrote: > with apply and build > > Using patch: lng-odp_PATCH_v2_test_performance_add_crypto_test.mbox > Trying to apply patch > Patch applied > > WARNING: 'Imediately' may be misspelled - perhaps 'Immediately'? > #645: FILE: test/performance/odp_crypt

Re: [lng-odp] [PATCH v2] test: performance: add crypto test

2015-12-16 Thread Nicolas Morey-Chaisemartin
On 12/16/2015 11:50 PM, Mike Holmes wrote: > with apply and build > > Using patch: lng-odp_PATCH_v2_test_performance_add_crypto_test.mbox > Trying to apply patch > Patch applied > > WARNING: 'Imediately' may be misspelled - perhaps 'Immediately'? > #645: FILE: test/performance/odp_crypto.c:58

Re: [lng-odp] [PATCH v2] test: performance: add crypto test

2015-12-16 Thread Nicolas Morey-Chaisemartin
On 12/17/2015 07:51 AM, Alexandru Badicioiu wrote: > > > On 17 December 2015 at 00:50, Mike Holmes > wrote: > > with apply and build > > Using patch: lng-odp_PATCH_v2_test_performance_add_crypto_test.mbox > Trying to apply patch > Patch applied

Re: [lng-odp] [PATCH v2] test: performance: add crypto test

2015-12-16 Thread Alexandru Badicioiu
In scheduled mode there's only one thread spawn on the first CPU in the worker mask , so it's similar with poll. Alex On 17 December 2015 at 09:29, Nicolas Morey-Chaisemartin wrote: > > > On 12/17/2015 07:51 AM, Alexandru Badicioiu wrote: > > > > On 17 December 2015 at 00:50, Mike Holmes wrote