[lng-odp] [PATCHv2] linux-generic/include/odp_packet_io_internal: add visability hidden

Internal functions should not be part of symbols is visible outside the library. Suggested-by: Ricardo Salveti Signed-off-by: Anders Roxell --- .../linux-generic/include/odp_packet_io_internal.h | 23 +- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/platform

Re: [lng-odp] [PATCH] linux-generic: queue: avoid false positive when compiling with -Og

After reviewing the code again, I think the patch stands as the simplest solution to this compiler bug. Both type and handle are needed because they are cached from the queue_entry while it is locked and then referenced after it is unlocked. A direct reference the internal fields is not legal unles

Re: [lng-odp] [PATCH] linux-generic: pktio_run_tap: failure to setup tap != test fail

Merged, Maxim. On 04/07/16 10:11, Christophe Milard wrote: On 2016-04-04 23:30, Zi Shen Lim wrote: When we fail to setup tap for any reason, simply report TEST_SKIPPED and move on. It is not an actual test failure. Signed-off-by: Zi Shen Lim Reviewed-by: Christophe Milard --- platform/l

Re: [lng-odp] [API-NEXT PATCH v2 1/2] example: l2fwd_simple: add single-threaded l2fwd example

I already applied it with my review. Juha, please check that everything is ok. Maxim. On 02/23/16 01:47, Bill Fischofer wrote: I like this. Thanks for this contribution. For this series: Reviewed-and-tested-by: Bill Fischofer > On Mon, Feb 22, 2016 at 4:1

[lng-odp] [Bug 2154] ODP fails to build with GCC 5.3 (__DATE__ and __TIME__ macros, preventing reproducible builds)

https://bugs.linaro.org/show_bug.cgi?id=2154 Ricardo Salveti changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: [lng-odp] [API-NEXT PATCH 5/7] api: packet: add segment level head and tailroom

From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Friday, April 08, 2016 4:38 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 5/7] api: packet: add segment level head and tailroom On Fri, Apr 8, 2016 at 6:29 AM, Sav

Re: [lng-odp] [API-NEXT PATCH 1/3] api: pktio: add user context support for interfaces

From: EXT Bogdan Pricope [mailto:bogdan.pric...@enea.com] Sent: Friday, April 08, 2016 4:50 PM To: Bill Fischofer ; Savolainen, Petri (Nokia - FI/Espoo) Cc: lng-odp@lists.linaro.org Subject: RE: [lng-odp] [API-NEXT PATCH 1/3] api: pktio: add user context support for interfaces Hi, Our path i

Re: [lng-odp] [PATCH] linux-generic/odp_impl: removing __DATE__ and __TIME__

Merged, Maxim. On 04/07/16 18:07, Anders Roxell wrote: On 7 April 2016 at 16:59, Ricardo Salveti wrote: This is so we can get reproducible builds. Besides the library version, the string already contains the git hash, which is enough to traceback the build used. Bug-Link: https://bugs.linaro.

Re: [lng-odp] [PATCH] linux-generic: pktio: support new pktio_entry states

That was merged, Maxim. On 04/08/16 15:14, Bill Fischofer wrote: On Fri, Apr 8, 2016 at 3:13 AM, Matias Elo > wrote: Use new pktio_entry states in netmap and dpdk pktio implementations. Fixes build for both pktio types. Signed-off-by: Matias Elo mail

Re: [lng-odp] [API-NEXT PATCH 3/7] api: packet: add packet concat and split

From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Friday, April 08, 2016 4:01 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 3/7] api: packet: add packet concat and split On Fri, Apr 8, 2016 at 6:10 AM, Savolainen,

Re: [lng-odp] [API-NEXT PATCH 1/3] api: pktio: add user context support for interfaces

Hi, Our path is: pktio = odp_packet_input(pkt); ifnet = ofp_get_ifnet_pktio(pktio); (Our current workaround is to iterate through the list of interfaces to find which interface has this pktio.) You are saying: pktio_id = odp_packet_input_id(pkt); ifnet = ofp_get_ifnet_pktio_id(pktio_id); I gue

Re: [lng-odp] [API-NEXT PATCH 5/7] api: packet: add segment level head and tailroom

On Fri, Apr 8, 2016 at 6:29 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > > *From:* EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] > *Sent:* Friday, April 08, 2016 4:06 AM > *To:* Savolainen, Petri (Nokia - FI/Espoo) > *Cc:* LNG ODP Mailman List > *

Re: [lng-odp] [API-NEXT PATCH 3/7] api: packet: add packet concat and split

On Fri, Apr 8, 2016 at 6:10 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > > *From:* EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] > *Sent:* Friday, April 08, 2016 4:04 AM > *To:* Savolainen, Petri (Nokia - FI/Espoo) > *Cc:* LNG ODP Mailman List > *

Re: [lng-odp] [PATCH] linux-generic: pktio: support new pktio_entry states

On Fri, Apr 8, 2016 at 3:13 AM, Matias Elo wrote: > Use new pktio_entry states in netmap and dpdk pktio > implementations. Fixes build for both pktio types. > > Signed-off-by: Matias Elo > Reviewed-by: Bill Fischofer > --- > platform/linux-generic/include/odp_packet_dpdk.h | 1 - > platform

Re: [lng-odp] [API-NEXT PATCH 1/3] api: pktio: add user context support for interfaces

Agree, Mike, however the user guide is supposed to cover concepts and usage models rather than individual APIs. I'd rather see a general section on context management that discusses this in a more comprehensive manner and touches on all the facilities of ODP that support user contexts. It's on my

Re: [lng-odp] [API-NEXT PATCH 1/3] api: pktio: add user context support for interfaces

These are good points. Can we get OFP participation in Monday's ARCH call to discuss this? Alternately I'll put it on the agenda for Tuesday's public call. On Fri, Apr 8, 2016 at 6:57 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > I wonder what would be the HW o

Re: [lng-odp] [API-NEXT PATCH 1/3] api: pktio: add user context support for interfaces

I wonder what would be the HW offload here? Scheduler would prefetch queue context for odp_queue_t queues which may be millions, but pktio interfaces (or pktin/pktout queues) are few. Application could store/load/prefetch the context also itself before or after it polls an interface. I know th

Re: [lng-odp] [API-NEXT PATCH 7/7] api: pool: add pool capability

From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Friday, April 08, 2016 3:40 AM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 7/7] api: pool: add pool capability This patch seems orthogonal to the rest of this series.

Re: [lng-odp] [API-NEXT PATCH 1/3] api: pktio: add user context support for interfaces

Should we add something to the user-guide at the same time ? We had said a few times we wanted new apis to go beyond just having a unit test for inclusion, but that they also must come with documentation, that of course also helps the reviewer understand the use case for the new code. On 7 April

Re: [lng-odp] [openfastpath] User defined context pointer associated with pktio

Please add your review to the patch then. Thanks. On Fri, Apr 8, 2016 at 6:24 AM, Bogdan Pricope wrote: > Hi, > > > > It looks good. > > > > Thank you, > > Bogdan > > > > > > *From:* Bill Fischofer [mailto:bill.fischo...@linaro.org] > *Sent:* Thursday, April 07, 2016 2:41 PM > > *To:* Bogdan Pr

Re: [lng-odp] [API-NEXT PATCH 5/7] api: packet: add segment level head and tailroom

From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Friday, April 08, 2016 4:06 AM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 5/7] api: packet: add segment level head and tailroom I think these APIs are clearly out of

Re: [lng-odp] [openfastpath] User defined context pointer associated with pktio

Hi, It looks good. Thank you, Bogdan From: Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Thursday, April 07, 2016 2:41 PM To: Bogdan Pricope Cc: lng-odp@lists.linaro.org; openfastp...@list.openfastpath.org Subject: Re: [openfastpath] User defined context pointer associated with pktio

Re: [lng-odp] [API-NEXT PATCH 3/7] api: packet: add packet concat and split

From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Friday, April 08, 2016 4:04 AM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 3/7] api: packet: add packet concat and split I think these general segment-based operation

Re: [lng-odp] [API-NEXT PATCH 1/7] api: packet: add extend and trunc

From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Friday, April 08, 2016 3:28 AM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 1/7] api: packet: add extend and trunc I'm glad to see these patches posted to start the dis

[lng-odp] [PATCH] linux-generic: pktio: support new pktio_entry states

Use new pktio_entry states in netmap and dpdk pktio implementations. Fixes build for both pktio types. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_dpdk.h | 1 - platform/linux-generic/pktio/dpdk.c | 7 +++ platform/linux-generic/pktio/netmap.c