Re: [lng-odp] process thread and mixed mode

2016-05-16 Thread Christophe Milard
On 17 May 2016 at 02:09, Bill Fischofer wrote: > > > On Fri, May 13, 2016 at 6:32 AM, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolai...@nokia.com> wrote: > >> >> >> >> >> *From:* Christophe Milard [mailto:christophe.mil...@linaro.org] >> *Sent:* Friday, May 13, 2016 11:16 AM >> *To:* Petr

Re: [lng-odp] process thread and mixed mode

2016-05-16 Thread Maxim Uvarov
Bill, it looks reasonable, also do the same function for process as we have for threads, like odp_thread_id() and odp_thread_count(). Maxim. On 17 May 2016 at 03:09, Bill Fischofer wrote: > On Fri, May 13, 2016 at 6:32 AM, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolai...@nokia.com> wro

Re: [lng-odp] [PATCHv2] doc: users-guide: add packet marking documentation

2016-05-16 Thread Bill Fischofer
Sorry about that. Fixed. On Monday, May 16, 2016, Bala Manoharan wrote: > FYI > > @Bill: Looks like you did a reply instead of reply-all :) > > Regards, > Bala > > -- Forwarded message -- > From: Bill Fischofer > > Date: 16 May 2016 at 20:20 > Subject: Re: [PATCHv2] doc: users-gu

Re: [lng-odp] [PATCHv2] doc: users-guide: add packet marking documentation

2016-05-16 Thread Bill Fischofer
On Monday, May 16, 2016, Balasubramanian Manoharan < bala.manoha...@linaro.org> wrote: > Updates packet marking api documentation to traffic manager user guide > > Signed-off-by: Balasubramanian Manoharan > Reviewed-and-tested-by: Bill Fischofer > --- > v2: document format update > doc/users

[lng-odp] Fwd: [PATCHv2] doc: users-guide: add packet marking documentation

2016-05-16 Thread Bala Manoharan
FYI @Bill: Looks like you did a reply instead of reply-all :) Regards, Bala -- Forwarded message -- From: Bill Fischofer Date: 16 May 2016 at 20:20 Subject: Re: [PATCHv2] doc: users-guide: add packet marking documentation To: Balasubramanian Manoharan On Mon, May 16, 2016 a

Re: [lng-odp] [PATCH v4] doc: user-guide: Improve crypto section.

2016-05-16 Thread Bala Manoharan
On 17 May 2016 at 01:56, Bill Fischofer wrote: > On Mon, May 16, 2016 at 6:00 PM, Nikhil Agarwal > wrote: > >> Signed-off-by: Nikhil Agarwal >> > > Reviewed-and-tested-by: Bill Fischofer > > Reviewed-by: Balasubramanian Manoharan >> --- >> doc/users-guide/users-guide.adoc | 87 >> ++

Re: [lng-odp] "Message too long" error message with Iperf testing

2016-05-16 Thread gyanesh patra
I am using the linux-generic with ODP v1.9.0.0 I am just running Iperf with default settings. But i will try similar experiments by turning off the segment offloading on the target NIC. Thank you for the pointer. Regards, Gyanesh Patra > On May 16, 2016, at 21:21, Bill Fischofer wrote: > >

Re: [lng-odp] "Message too long" error message with Iperf testing

2016-05-16 Thread Bill Fischofer
On Mon, May 16, 2016 at 6:45 PM, gyanesh patra wrote: > I have a simple *standalone application* using ODP. It receives packets on > one interface and do a broadcasting to all other interfaces. But many a > times i see this error message when i try to calculate the throughput using > IPerf tool.

Re: [lng-odp] process thread and mixed mode

2016-05-16 Thread Bill Fischofer
On Fri, May 13, 2016 at 6:32 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > > *From:* Christophe Milard [mailto:christophe.mil...@linaro.org] > *Sent:* Friday, May 13, 2016 11:16 AM > *To:* Petri Savolainen ; Brian Brooks < > brian.bro...@linaro.org>; Bill Fi

[lng-odp] "Message too long" error message with Iperf testing

2016-05-16 Thread gyanesh patra
I have a simple *standalone application* using ODP. It receives packets on one interface and do a broadcasting to all other interfaces. But many a times i see this error message when i try to calculate the throughput using IPerf tool. pktio/socket_mmap.c:263:pkt_mmap_v2_tx():sendto(pkt m

Re: [lng-odp] [PATCH v2 5/5] linux-generic: packet: initialize only selected odp_packet_hdr_t members

2016-05-16 Thread Bill Fischofer
On Mon, May 16, 2016 at 9:25 AM, Mike Holmes wrote: > On 16 May 2016 at 05:50, Matias Elo wrote: > > > Using memset to initialize struct odp_packet_hdr_t contents > > to 0 has a significant overhead. Instead, initialize only > > the required members of the struct. > > > > Signed-off-by: Matias E

Re: [lng-odp] [PATCHv2] linux-generic: timer: remove dead 128 bit optimizations

2016-05-16 Thread Bill Fischofer
On Mon, May 16, 2016 at 4:55 PM, Ola Liljedahl wrote: > On 16 May 2016 at 23:31, Bill Fischofer wrote: > >> Thanks Ola. The original bug is that this fails compiling with clang on >> 32-bit systems and the reason is that the struct in that environment winds >> up being 24 bytes rather than 16 b

Re: [lng-odp] [PATCHv2] linux-generic: timer: remove dead 128 bit optimizations

2016-05-16 Thread Ola Liljedahl
On 16 May 2016 at 23:31, Bill Fischofer wrote: > Thanks Ola. The original bug is that this fails compiling with clang on > 32-bit systems and the reason is that the struct in that environment winds > up being 24 bytes rather than 16 bytes long, so the ODP_STATIC_ASSERT() > fails. > The timer cod

Re: [lng-odp] [PATCHv3 2/2] linux-generic: drop odp_ prefix for internal cpuinfo

2016-05-16 Thread Bill Fischofer
I just did what Matias did and built myself a 32-bit Ubuntu VM to test 32-bit stuff with. The -m32 compile option isn't quite the same and obviously missed some cases. I'm not sure how to incorporate that into check-odp. On Mon, May 16, 2016 at 10:49 AM, Mike Holmes wrote: > Bill, > > Were you

Re: [lng-odp] [PATCH 2/2] time: fix invalid casting on a 32-bit host

2016-05-16 Thread Bill Fischofer
On Mon, May 16, 2016 at 9:27 AM, Ivan Khoronzhuk wrote: > Hi Matias, > > The odp_time_local and others functions are time sensitive functions, > that's why it was decided to avoid copping as more as possible. > > The timespec is not simple "long type". Its type is arch dependent but is > always 6

Re: [lng-odp] [PATCHv2] linux-generic: timer: remove dead 128 bit optimizations

2016-05-16 Thread Bill Fischofer
Thanks Ola. The original bug is that this fails compiling with clang on 32-bit systems and the reason is that the struct in that environment winds up being 24 bytes rather than 16 bytes long, so the ODP_STATIC_ASSERT() fails. My original (simple) patch is at http://patches.opendataplane.org/patch

Re: [lng-odp] [API-NEXT PATCH v4 2/2] helper: test: add test of cuckoo hash table

2016-05-16 Thread Bill Fischofer
Applying this part shows whitespace errors: bill@Ubuntu15:~/linaro/ru$ git am ~/Mail/Incoming/Ru/2 Applying: helper: test: add test of cuckoo hash table .git/rebase-apply/patch:16: indent with spaces. table$(EXEEXT)\ warning: 1 line adds whitespace errors. Also, Linaro copyrights sh

Re: [lng-odp] [PATCHv2] linux-generic: timer: remove dead 128 bit optimizations

2016-05-16 Thread Ola Liljedahl
I disagree. The 128-bit support is important because that's the lock-free timer implementation which was the whole idea. The lock-based code is just a work-around. We should rather add support in configure to detect compiler support for the -mcx16 flag which enables 128-bit CAS on x86-64. Now when

Re: [lng-odp] [PATCH v3] doc: process-guide: convert CONTRIBUTING to asciidoc

2016-05-16 Thread Bill Fischofer
On Mon, May 16, 2016 at 11:29 AM, Mike Holmes wrote: > Converting to asciidoc allows a tidy page to be added to the online > documentation without cutting and pasting into wordpress. > Being Asccidoc a tiny amount of clutter is added to show code snippets > attractively when rendered that make it

Re: [lng-odp] [PATCHv4 1/2] linux-generic: use default huge page size

2016-05-16 Thread Bill Fischofer
For this series: Reviewed-by: Bill Fischofer wrote: > odp_shm_reserve() relays on huge page size to round up > requested size. If 1 Gb pages present than parser takes > it first as first alphabetical file name in sysfs. That > lead to issue where all allocations wants 1 GB HP. This > patch takes

Re: [lng-odp] [PATCHv2] linux-generic: timer: remove dead 128 bit optimizations

2016-05-16 Thread Bill Fischofer
On Mon, May 16, 2016 at 2:15 PM, Maxim Uvarov wrote: > Remove totally untested branch with 128 bit optimizations > for timer code. > This also fixes static assert bug: > https://bugs.linaro.org/show_bug.cgi?id=2211 > > Signed-off-by: Maxim Uvarov > Reviewed-and-tested-by: Bill Fischofer > --

Re: [lng-odp] [PATCHv4 1/3] doc: images: add packet flow overview image

2016-05-16 Thread Mike Holmes
For the series Reviewed-by: Mike Holmes On 12 May 2016 at 17:23, Bill Fischofer wrote: > From: Mike Holmes > > Signed-off-by: Mike Holmes > Signed-off-by: Bill Fischofer > --- > doc/images/packet_flow.svg | 532 > + > 1 file changed, 532 insertio

Re: [lng-odp] [PATCH v4] doc: user-guide: Improve crypto section.

2016-05-16 Thread Bill Fischofer
On Mon, May 16, 2016 at 6:00 PM, Nikhil Agarwal wrote: > Signed-off-by: Nikhil Agarwal > Reviewed-and-tested-by: Bill Fischofer > --- > doc/users-guide/users-guide.adoc | 87 > +++- > 1 file changed, 69 insertions(+), 18 deletions(-) > > diff --git a/doc/

[lng-odp] [PATCH] validation: tm: add checks for adequate cpu resources

2016-05-16 Thread Bill Fischofer
The shaper and scheduler tests require a minimum of two CPUs to run reliably. Make these tests conditional and skip them with a warning to avoid spurious failures if test is run with only a single CPU. Signed-off-by: Bill Fischofer --- test/validation/traffic_mngr/traffic_mngr.c | 36 +++

[lng-odp] [PATCHv2] linux-generic: timer: remove dead 128 bit optimizations

2016-05-16 Thread Maxim Uvarov
Remove totally untested branch with 128 bit optimizations for timer code. This also fixes static assert bug: https://bugs.linaro.org/show_bug.cgi?id=2211 Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_timer.c | 107 - 1 file changed, 107 deletions(

Re: [lng-odp] [PATCH] linux-generic: timer: remove dead 128 bit optimizations

2016-05-16 Thread Maxim Uvarov
there is one more place for #define NEED_PAD, will send v2 Maxim. On 05/16/16 22:11, Maxim Uvarov wrote: Remove totally untested branch with 128 bit optimizations for timer code. This also fixes static assert bug: https://bugs.linaro.org/show_bug.cgi?id=2211 Signed-off-by: Maxim Uvarov ---

[lng-odp] [PATCH] linux-generic: timer: remove dead 128 bit optimizations

2016-05-16 Thread Maxim Uvarov
Remove totally untested branch with 128 bit optimizations for timer code. This also fixes static assert bug: https://bugs.linaro.org/show_bug.cgi?id=2211 Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_timer.c | 104 - 1 file changed, 104 deletions(

[lng-odp] [Bug 2222] Coverity: uninitialized variables

2016-05-16 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id= Maxim Uvarov changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

Re: [lng-odp] [PATCHv2] validation: pktio: initialize pkt_seq

2016-05-16 Thread Maxim Uvarov
Merged, Maxim. On 05/13/16 16:12, Elo, Matias (Nokia - FI/Espoo) wrote: Reviewed-and-tested-by: Matias Elo -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim Uvarov Sent: Friday, May 13, 2016 3:45 PM To: lng-odp@lists.linaro.org Subject:

[lng-odp] [PATCHv4 2/2] linux-generic: drop odp_ prefix for internal cpuinfo

2016-05-16 Thread Maxim Uvarov
A little bit code clean up to drop odp_ prefix from internal things and rename huge_pages to default_huge_pages internal struct. Signed-off-by: Maxim Uvarov --- platform/linux-generic/arch/default/odp_sysinfo_parse.c | 2 +- platform/linux-generic/arch/mips64/odp_sysinfo_parse.c | 2 +- platf

[lng-odp] [PATCHv4 1/2] linux-generic: use default huge page size

2016-05-16 Thread Maxim Uvarov
odp_shm_reserve() relays on huge page size to round up requested size. If 1 Gb pages present than parser takes it first as first alphabetical file name in sysfs. That lead to issue where all allocations wants 1 GB HP. This patch takes system default huge pages which are usually 2Mb, and has to be e

[lng-odp] [PATCHv4 0/2] linux-generic: use default huge page size

2016-05-16 Thread Maxim Uvarov
v4: fix 32 build by scanning to unsigned long. v3: return uint64_t, fix parser and add debug prints. Maxim Uvarov (2): linux-generic: use default huge page size linux-generic: drop odp_ prefix for internal cpuinfo .../linux-generic/arch/default/odp_sysinfo_parse.c | 2 +- .../linux-generic/

[lng-odp] [PATCH v4] doc: user-guide: Improve crypto section.

2016-05-16 Thread Nikhil Agarwal
Signed-off-by: Nikhil Agarwal --- doc/users-guide/users-guide.adoc | 87 +++- 1 file changed, 69 insertions(+), 18 deletions(-) diff --git a/doc/users-guide/users-guide.adoc b/doc/users-guide/users-guide.adoc index 0221634..b094802 100644 --- a/doc/users-guide

[lng-odp] [PATCH v3] doc: process-guide: convert CONTRIBUTING to asciidoc

2016-05-16 Thread Mike Holmes
Converting to asciidoc allows a tidy page to be added to the online documentation without cutting and pasting into wordpress. Being Asccidoc a tiny amount of clutter is added to show code snippets attractively when rendered that make it slightly hard to read as a raw document. Signed-off-by: Mike

Re: [lng-odp] [PATCH v2] doc: process-guide: convert CONTRIBUTING to asciidoc

2016-05-16 Thread Mike Holmes
On 14 May 2016 at 13:42, Bill Fischofer wrote: > Patch still has whitespace errors: > > bill@Ubuntu15:~/linaro/mikedoc2$ git am ~/Mail/Incoming/Mike/3 > Applying: doc: process-guide: convert CONTRIBUTING to asciidoc > .git/rebase-apply/patch:133: indent with spaces. > `odp_pktio_t` > The

Re: [lng-odp] [PATCHv3 2/2] linux-generic: drop odp_ prefix for internal cpuinfo

2016-05-16 Thread Mike Holmes
Bill, Were you able to get the instructions / patch together to do a true 32bit check in check-odp ? If we are going to reject things that fail for 32bits we should describe how to recreate the test if you only have a 64 bit system. Mike On 12 May 2016 at 16:21, Bill Fischofer wrote: > Compil

Re: [lng-odp] [PATCHv6 1/2] doc: userguide: add timer/timeout state diagrams

2016-05-16 Thread Maxim Uvarov
Merged, Maxim. On 05/13/16 18:41, Christophe Milard wrote: For the series: Reviewed-by: Christophe Milard > Christophe. On 13 May 2016 at 17:01, Bill Fischofer > wrote: Signed-off-by: Bill Fischofer mailto:bill.fisc

[lng-odp] [Bug 2227] classification_main: Conditional jump or move depends on uninitialised value

2016-05-16 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2227 Bala Manoharan changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|---

Re: [lng-odp] [PATCH] validation: time: remove print and add verbose faults

2016-05-16 Thread Ivan Khoronzhuk
On 16.05.16 17:18, Maxim Uvarov wrote: On 05/16/16 17:00, Ivan Khoronzhuk wrote: Hi Maxim, I know it's a little late, but printf was here not for testing wait until. It was here to expose visually time for a second. As ODP doesn't have other accurate enough time source the printf was added to

Re: [lng-odp] [PATCH] validation: time: remove print and add verbose faults

2016-05-16 Thread Maxim Uvarov
On 05/16/16 17:00, Ivan Khoronzhuk wrote: Hi Maxim, I know it's a little late, but printf was here not for testing wait until. It was here to expose visually time for a second. As ODP doesn't have other accurate enough time source the printf was added to visually demonstrate 1 second. It allo

Re: [lng-odp] [PATCH 2/2] time: fix invalid casting on a 32-bit host

2016-05-16 Thread Ivan Khoronzhuk
Hi Matias, The odp_time_local and others functions are time sensitive functions, that's why it was decided to avoid copping as more as possible. The timespec is not simple "long type". Its type is arch dependent but is always 64bit. In case of 32 bit system it's defined as long long. The same f

Re: [lng-odp] [PATCH v2 5/5] linux-generic: packet: initialize only selected odp_packet_hdr_t members

2016-05-16 Thread Mike Holmes
On 16 May 2016 at 05:50, Matias Elo wrote: > Using memset to initialize struct odp_packet_hdr_t contents > to 0 has a significant overhead. Instead, initialize only > the required members of the struct. > > Signed-off-by: Matias Elo > --- > platform/linux-generic/include/odp_packet_internal.h |

Re: [lng-odp] Test to list of a html message

2016-05-16 Thread Mike Holmes
The box has been ticked as per the arch call, filtering has been turn on with defaults. Mailman should now convert text/html parts to plain text This conversion happens after MIME attachments have been stripped. On 16 May 2016 at 10:27, Bill Fischofer wrote: > The HTML comes through just fine

Re: [lng-odp] Test to list of a html message

2016-05-16 Thread Bill Fischofer
The HTML comes through just fine and I notice it's been auto-converted to plain text on the archives. On Mon, May 16, 2016 at 8:46 AM, Raj Murali wrote: > reply to test > > > Raj Murali > Director - Linaro Networking Group > Skype: rajmurali_s │ M: +91 98450 70135 > > Linaro.org

Re: [lng-odp] [PATCH] fix: classification: uninitialized pmr param value

2016-05-16 Thread Maxim Uvarov
On 05/14/16 20:36, Bill Fischofer wrote: short log should be linux-generic: classification: etc. Can be fixed during merge? yes, fixed and merged, Maxim. On Fri, May 13, 2016 at 6:51 AM, Balasubramanian Manoharan mailto:bala.manoha...@linaro.org>> wrote: Fix memory leaked caused by un

Re: [lng-odp] [PATCH] validation: time: remove print and add verbose faults

2016-05-16 Thread Ivan Khoronzhuk
Hi Maxim, I know it's a little late, but printf was here not for testing wait until. It was here to expose visually time for a second. As ODP doesn't have other accurate enough time source the printf was added to visually demonstrate 1 second. It allows to see if at least frequency of counter was

Re: [lng-odp] [PATCH] validation: timer: verify timer successfully allocated

2016-05-16 Thread Maxim Uvarov
Merged, Maxim. On 05/16/16 15:40, Mike Holmes wrote: On 11 May 2016 at 20:51, Bill Fischofer > wrote: Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2031 by adding a check to ensure that at least one timer is allocated before potentially div

[lng-odp] [Bug 2031] CID 157958: Integer handling issues: timer.c

2016-05-16 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2031 Maxim Uvarov changed: What|Removed |Added Resolution|--- |FIXED Status|IN_PROGRESS

Re: [lng-odp] Test to list of a html message

2016-05-16 Thread Raj Murali
reply to test Raj Murali Director - Linaro Networking Group Skype: rajmurali_s │ M: +91 98450 70135 Linaro.org *│ *Open source software for ARM SoCs On 16 May 2016 at 19:13, Mike Holmes wrote: > reply test > > On 16 May 2016 at 09:42, Mike Holmes wrote: > > > > > >

Re: [lng-odp] Test to list of a html message

2016-05-16 Thread Mike Holmes
reply test On 16 May 2016 at 09:42, Mike Holmes wrote: > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org *│ *Open source software for ARM SoCs > "Work should be fun and collaborative, the rest follows" > > > -- Mike Holmes Technical Man

[lng-odp] Test to list of a html message

2016-05-16 Thread Mike Holmes
-- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org *│ *Open source software for ARM SoCs "Work should be fun and collaborative, the rest follows" ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.

Re: [lng-odp] Fedora repo changes

2016-05-16 Thread Anders Roxell
On 11 May 2016 at 21:53, Matt Spencer wrote: > Hi Guys > > Thought I would use some down time to have a play with ODP. On a vanilla > Fedora 23 Server install, there is an issue with the current odp.repo in > that the default behaviour of ‘def’ is to gpg check the downloads. So, > following the

Re: [lng-odp] [PATCH] linux-generic: dpdk: use memset() to initialize dev_info

2016-05-16 Thread Maxim Uvarov
Merged, Maxim. On 05/15/16 00:41, Bill Fischofer wrote: On Fri, May 13, 2016 at 6:40 AM, Matias Elo > wrote: Clang build fails due to a missing field in initializer error. This is a known clang bug (https://llvm.org/bugs/show_bug.cgi?id=21689). Circum

Re: [lng-odp] [PATCH v2 0/5] pktio fast path optimization

2016-05-16 Thread Bill Fischofer
For this series: Reviewed-and-tested-by: Bill Fischofer On Mon, May 16, 2016 at 4:50 AM, Matias Elo wrote: > V2: > + Document odp_packet_hdr_t field initialization (Bill Fischover, Mike > Holmes) > + Remove unused payload_offset field from odp_packet_hdr_t > > This patch set improves pktio fas

Re: [lng-odp] [PATCH] validation: timer: verify timer successfully allocated

2016-05-16 Thread Mike Holmes
On 11 May 2016 at 20:51, Bill Fischofer wrote: > Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2031 by > adding a check to ensure that at least one timer is allocated before > potentially dividing by zero. > > Signed-off-by: Bill Fischofer > Reviewed-by: Mike Holmes > --- > test/valid

Re: [lng-odp] [PATCH] validation: timer: verify timer successfully allocated

2016-05-16 Thread Bill Fischofer
On Mon, May 16, 2016 at 7:33 AM, Mike Holmes wrote: > > On 11 May 2016 at 20:51, Bill Fischofer wrote: > >> Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2031 by >> adding a check to ensure that at least one timer is allocated before >> potentially dividing by zero. >> >> Signed-off-by: Bi

Re: [lng-odp] [PATCH] validation: timer: verify timer successfully allocated

2016-05-16 Thread Mike Holmes
On 11 May 2016 at 20:51, Bill Fischofer wrote: > Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2031 by > adding a check to ensure that at least one timer is allocated before > potentially dividing by zero. > > Signed-off-by: Bill Fischofer > --- > test/validation/timer/timer.c | 2 ++ > 1

Re: [lng-odp] lng-odp mailman settings

2016-05-16 Thread Anders Roxell
On 2016-05-16 08:27, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: Saturday, May 14, 2016 1:55 AM > To: Brian Brooks > Cc: lng-odp > Subject: Re: [lng-odp] lng-odp mailman settings > > > > On F

[lng-odp] [PATCH v2 5/5] linux-generic: packet: initialize only selected odp_packet_hdr_t members

2016-05-16 Thread Matias Elo
Using memset to initialize struct odp_packet_hdr_t contents to 0 has a significant overhead. Instead, initialize only the required members of the struct. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_internal.h | 13 + platform/linux-generic/odp_packet.c

[lng-odp] [PATCH v2 4/5] linux-generic: buffer: ifdef ipc_addr_offset member from odp_buffer_hdr_t

2016-05-16 Thread Matias Elo
Define ipc_addr_offset member of struct odp_buffer_hdr_t only if ipc pktio is enabled to reduce struct size. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_buffer_internal.h | 8 +--- platform/linux-generic/pktio/ipc.c | 13 + 2 files changed,

[lng-odp] [PATCH v2 3/5] linux-generic: packet: remove payload_offset member from odp_packet_hdr_t

2016-05-16 Thread Matias Elo
There is no way to read payload_offset in the ODP API, so don't save it. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_internal.h | 2 -- platform/linux-generic/odp_packet.c | 20 ++-- 2 files changed, 6 insertions(+), 16 deletions(-)

[lng-odp] [PATCH v2 2/5] linux-generic: packet: remove vlan_s_tag and vlan_c_tag members from odp_packet_hdr_t

2016-05-16 Thread Matias Elo
There is no way to read vlan tags in the ODP API, so don't save them. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_internal.h | 4 platform/linux-generic/odp_packet.c | 4 2 files changed, 8 deletions(-) diff --git a/platform/linux-generic/i

[lng-odp] [PATCH v2 1/5] linux-generic: packet: remove l3_protocol and l4_protocol members from odp_packet_hdr_t

2016-05-16 Thread Matias Elo
Remove unnecessary struct odp_packet_hdr_t members l3_protocol and l4_protocol to reduce struct size. l4_protocol was only used by IPsec and is now replaced by two new input flags ipsec_ah and ipsec_esp. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_classification_inlines.h |

[lng-odp] [PATCH v2 0/5] pktio fast path optimization

2016-05-16 Thread Matias Elo
V2: + Document odp_packet_hdr_t field initialization (Bill Fischover, Mike Holmes) + Remove unused payload_offset field from odp_packet_hdr_t This patch set improves pktio fast path throughput by: - Remove unnecessary members from odp_packet_hdr_t and odp_buffer_hdr_t to reduce memory usage (les

[lng-odp] [Bug 2228] ringtest: Conditional jump or move depends on uninitialised value

2016-05-16 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2228 Fathi Boudra changed: What|Removed |Added Assignee|maxim.uva...@linaro.org |yi...@linaro.org CC|

Re: [lng-odp] lng-odp mailman settings

2016-05-16 Thread Elo, Matias (Nokia - FI/Espoo)
+1 for the mandatory plain text as well. At least for us replacing Outlook as email client is not really an option and the cursed blue line makes inline replies a pain. -Matias > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Zoltan > Ki

Re: [lng-odp] lng-odp mailman settings

2016-05-16 Thread Zoltan Kiss
+1 for mandatory plain text. HTML mail is for newsletters, but as soon as you try to reply to a section of someone else's mail, it breaks down to chaos. My observation is that mail clients tend to handle it differently, and screwing up each other (and their users) in the process. And setting fon

Re: [lng-odp] lng-odp mailman settings

2016-05-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill Fischofer Sent: Saturday, May 14, 2016 1:55 AM To: Brian Brooks Cc: lng-odp Subject: Re: [lng-odp] lng-odp mailman settings On Friday, May 13, 2016, Brian Brooks mailto:brian.bro...@linaro.org>> wrote: On 05/13 10:07

Re: [lng-odp] [PATCH] doc: users-guide: add packet marking documentation

2016-05-16 Thread Bala Manoharan
Hi, I have incorporated all the comments in V2 except adding reference for IEEE802.1Q I am little skeptical about adding a wikipedia page as reference. Regards, Bala On 15 May 2016 at 03:09, Bill Fischofer wrote: > > > On Fri, May 13, 2016 at 12:23 AM, Balasubramanian Manoharan < > bala.manoha

[lng-odp] [PATCHv2] doc: users-guide: add packet marking documentation

2016-05-16 Thread Balasubramanian Manoharan
Updates packet marking api documentation to traffic manager user guide Signed-off-by: Balasubramanian Manoharan --- v2: document format update doc/users-guide/users-guide-tm.adoc | 73 + 1 file changed, 73 insertions(+) diff --git a/doc/users-guide/users-guid

Re: [lng-odp] [PATCH 4/4] linux-generic: packet: initialize only selected odp_packet_hdr_t members

2016-05-16 Thread Elo, Matias (Nokia - FI/Espoo)
From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Saturday, May 14, 2016 8:45 PM To: Mike Holmes Cc: Elo, Matias (Nokia - FI/Espoo) ; LNG ODP Mailman List Subject: Re: [lng-odp] [PATCH 4/4] linux-generic: packet: initialize only selected odp_packet_hdr_t members I agree we ca