[lng-odp] [PATCH 2/2] doc: userguide: add notes on threads and addressing scope

Expand thread section to explain rationale for threads not being ODP objects and how this relates to addressability considerations for shared resources. Signed-off-by: Bill Fischofer --- doc/users-guide/users-guide.adoc | 40 1

[lng-odp] [PATCH 1/2] doc: userguide: add section describing helpers

Signed-off-by: Bill Fischofer --- doc/users-guide/users-guide.adoc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/users-guide/users-guide.adoc b/doc/users-guide/users-guide.adoc index 62f5833..745b85f 100755 --- a/doc/users-guide/users-guide.adoc

[lng-odp] [PATCH] linux-generic: test: use one copy of pcap file

Examples should not duplicate pcap files Install the scripts and pcap file so that it can be run where it is installed after moving it to a common location in the repo Signed-off-by: Mike Holmes --- Makefile.am | 3 ++- configure.ac

Re: [lng-odp] [PATCHv2] linux-generic: timer fix odp_timer_pool_create return code

On Wed, May 18, 2016 at 9:24 AM, Maxim Uvarov wrote: > Accodring to API return code for fail case is ODP_TIMER_POOL_INVALID > and errno set event if it's defined to NULL. Also add check on pool > alloc that input parameter is not invalid. >

[lng-odp] [PATCH] doc: generate a pure application-api-guide

It should be possible to generate the pure API specification guide, this patch achieves that Copy the application guide to form a platform specific guide. The application guide is now ONLY the public specification. The new platform guide includes the additional definitions specific to odp-linux

Re: [lng-odp] [PATCH] doc: generate a pure application-api-guide

On Wed, May 18, 2016 at 3:45 PM, Mike Holmes wrote: > It should be possible to generate the pure API specification guide, this > patch achieves that > > Copy the application guide to form a platform specific guide. > The application guide is now ONLY the public

Re: [lng-odp] [PATCHv3 2/2] linux-generic: timer: fix failed static assert

On Wed, May 18, 2016 at 2:48 PM, Ola Liljedahl wrote: > On 18 May 2016 at 16:13, Maxim Uvarov wrote: > > > odp-check passed but looks like clang is not tested there, now I have > > errors: > > > Bill claimed to have tested 32- and 64-bit x86

Re: [lng-odp] [PATCH] linux-generic: timer: disable 128 bit timer optimization for clang

Maxim, I configured and built using clang and -m32 and it worked for me. clang chooses the lock-based path. This means __SIZEOF_INT128__ and __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 were not defined so the ODP atomic support for 128-bit variables was not enabled. The timer code fell back to the

Re: [lng-odp] [PATCHv3 2/2] linux-generic: timer: fix failed static assert

On 18 May 2016 at 16:13, Maxim Uvarov wrote: > odp-check passed but looks like clang is not tested there, now I have > errors: > Bill claimed to have tested 32- and 64-bit x86 using gcc *and* clang? If your compiler defines __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16, then it

Re: [lng-odp] [PATCHv7 00/35] running things in process mode

On 05/17 15:04:07, Christophe Milard wrote: > Pull can be performed from the URL at the end of this cover letter > All patches sent to the list following Maxim's request. > > Since v6 > -rebased > -regrouping history, squashing patch 1 and 12; 4, 5 and 12 (Petri) > -mixed mode test removed (but

Re: [lng-odp] [PATCH] linux-generic: timer: disable 128 bit timer optimization for clang

On 05/18/16 21:45, Mike Holmes wrote: Maxim and I had a chat, I think this patch means to say, "for now clang will use non optimised code, but deeper analysis is needed to optimise with clang" yes, looks like comment under "---" was confusing. This patch is not a hack it's only routes clang

Re: [lng-odp] [PATCH] autotools: define test extensions to skip on valgrind test

Thanks, patch merged. On 05/18/16 19:40, Mike Holmes wrote: *Bug 2254* On 18 May 2016 at 12:22, Mike Holmes > wrote: On 18 May 2016 at 07:46, Maxim Uvarov

Re: [lng-odp] [PATCH] linux-generic: timer: disable 128 bit timer optimization for clang

Maxim and I had a chat, I think this patch means to say, "for now clang will use non optimised code, but deeper analysis is needed to optimise with clang" On 18 May 2016 at 14:27, Maxim Uvarov wrote: > On 05/18/16 19:48, Mike Holmes wrote: > >> >> >> On 18 May 2016 at

Re: [lng-odp] [PATCH] linux-generic: timer: disable 128 bit timer optimization for clang

On 05/18/16 19:48, Mike Holmes wrote: On 18 May 2016 at 11:56, Maxim Uvarov > wrote: On 05/18/16 18:52, Mike Holmes wrote: On 18 May 2016 at 11:15, Maxim Uvarov

Re: [lng-odp] [PATCH v2 5/5] linux-generic: packet: initialize only selected odp_packet_hdr_t members

On 18 May 2016 at 02:17, Elo, Matias (Nokia - FI/Espoo) < matias@nokia.com> wrote: > > > > > *From:* Bill Fischofer [mailto:bill.fischo...@linaro.org] > *Sent:* Tuesday, May 17, 2016 9:46 PM > *To:* Mike Holmes > *Cc:* Elo, Matias (Nokia - FI/Espoo)

Re: [lng-odp] [PATCH] linux-generic: timer: disable 128 bit timer optimization for clang

On 18 May 2016 at 11:56, Maxim Uvarov wrote: > On 05/18/16 18:52, Mike Holmes wrote: > >> >> >> On 18 May 2016 at 11:15, Maxim Uvarov maxim.uva...@linaro.org>> wrote: >> >> Fix compilation error for clang with disabling 128 bit

Re: [lng-odp] [PATCH] autotools: define test extensions to skip on valgrind test

*Bug 2254* On 18 May 2016 at 12:22, Mike Holmes wrote: > > > On 18 May 2016 at 07:46, Maxim Uvarov wrote: > >> On 05/17/16 19:02, Mike Holmes wrote: >> >>> Wait, the final result is good and matches

[lng-odp] [Bug 2254] New: check-odp: valgrind generates "No rule to make target"

https://bugs.linaro.org/show_bug.cgi?id=2254 Bug ID: 2254 Summary: check-odp: valgrind generates "No rule to make target" Product: OpenDataPlane - linux- generic reference Version: v1.10 Hardware: Other OS: Linux

Re: [lng-odp] [PATCH] autotools: define test extensions to skip on valgrind test

On 18 May 2016 at 07:46, Maxim Uvarov wrote: > On 05/17/16 19:02, Mike Holmes wrote: > >> Wait, the final result is good and matches the long report - all the .sh >> files pass but if you scroll back up I get >> >> make[5]: Leaving directory >>

Re: [lng-odp] [PATCH] linux-generic: timer: disable 128 bit timer optimization for clang

On 05/18/16 18:52, Mike Holmes wrote: On 18 May 2016 at 11:15, Maxim Uvarov > wrote: Fix compilation error for clang with disabling 128 bit optimization. In function `_odp_atomic_u128_xchg_mm': undefined reference to

Re: [lng-odp] [PATCH] linux-generic: timer: disable 128 bit timer optimization for clang

On 18 May 2016 at 11:15, Maxim Uvarov wrote: > Fix compilation error for clang with disabling 128 bit optimization. > In function `_odp_atomic_u128_xchg_mm': > undefined reference to `__atomic_exchange' > > Signed-off-by: Maxim Uvarov > --- > I

Re: [lng-odp] [PATCHv7 00/35] running things in process mode

From the call earlier I understood that we agreed to the whole series, we just need the Reviewed-by, they should all go in if reviewed unless there is a ncak that needs resloving. On 18 May 2016 at 11:18, Christophe Milard wrote: > This is, of course very strange

Re: [lng-odp] [PATCHv7 00/35] running things in process mode

This is, of course very strange to me, as the usage of the "old" functions will keep spreading, and we'll be stopping halv way done. I guess Brian can apply his review-by, as patch 11-35 are the same as v6 But if the alternative is nothing done... Christophe. On 18 May 2016 at 17:02, Maxim

[lng-odp] [PATCH] linux-generic: timer: disable 128 bit timer optimization for clang

Fix compilation error for clang with disabling 128 bit optimization. In function `_odp_atomic_u128_xchg_mm': undefined reference to `__atomic_exchange' Signed-off-by: Maxim Uvarov --- I need some quick way to make clang build happy. Clean patch can go later. Maxim.

Re: [lng-odp] [PATCHv7 00/35] running things in process mode

On 05/18/16 14:14, Savolainen, Petri (Nokia - FI/Espoo) wrote: Reviewed patches 1-10 Reviewed-by: Petri Savolainen Petri, Christophe, are you ok with merging 1-10 first, and next after that? Maxim. -Original Message- From: lng-odp

[lng-odp] [PATCHv2] linux-generic: timer fix odp_timer_pool_create return code

Accodring to API return code for fail case is ODP_TIMER_POOL_INVALID and errno set event if it's defined to NULL. Also add check on pool alloc that input parameter is not invalid. https://bugs.linaro.org/show_bug.cgi?id=2139 Signed-off-by: Maxim Uvarov --- v2: added

Re: [lng-odp] [PATCHv3 2/2] linux-generic: timer: fix failed static assert

odp-check passed but looks like clang is not tested there, now I have errors: CCLD odp_crypto ../../lib/.libs/libodp-linux.a(odp_timer.o): In function `_odp_atomic_u128_xchg_mm': /opt/Linaro/odp3.git/platform/linux-generic/./include/odp_atomic_internal.h:619: undefined reference to

[lng-odp] [Bug 2253] CID 161436: Insecure data handling: odp_system_info.c

https://bugs.linaro.org/show_bug.cgi?id=2253 Mike Holmes changed: What|Removed |Added Summary|odp_system_info.cCID|CID 161436: Insecure

[lng-odp] [Bug 2253] New: odp_system_info.cCID 161436: Insecure data handling:

https://bugs.linaro.org/show_bug.cgi?id=2253 Bug ID: 2253 Summary: odp_system_info.cCID 161436: Insecure data handling: Product: OpenDataPlane - linux- generic reference Version: v1.10 Hardware: Other OS: Linux

Re: [lng-odp] [PATCH] helper: Fixing bug in odph_udp_tcp_chksum

On 05/18/16 02:06, Khalil Blaiech wrote: Fixed bug caused by odph_process_l4_hdr returning a pointer to a memory local stack frame. Signed-off-by: Khalil Blaiech --- helper/chksum.c | 51 +-- 1 file changed, 29

Re: [lng-odp] [PATCHv3 0/2] Enhanced and fixed atomics support

Merged, Maxim. On 05/17/16 22:26, Bill Fischofer wrote: OK, please propagate my Reviewed-and-tested-by: to v3 as there are no code changes. On Tue, May 17, 2016 at 2:21 PM, Ola Liljedahl wrote: (This document/code contribution attached is provided under the terms

[lng-odp] [Bug 2211] clang fails with 32bit build for odp_timer.c

https://bugs.linaro.org/show_bug.cgi?id=2211 Maxim Uvarov changed: What|Removed |Added Resolution|--- |FIXED

Re: [lng-odp] [PATCH 1/2] example: introducing l3fwd

On 05/18/16 05:39, forrest.shi wrote: Hello everyone, Do you have any comments on this patch? Any objections? I may send out subsequent patches to add more features in. Do you prefer a final big patch or a patch set with the enhancement history about adding a new app? Welcome any feedback.

Re: [lng-odp] [PATCH 1/3] bootstrap: force autoconf update

this patchset for packages, not for odp, right? Maxim. On 02/22/16 22:18, Anders Roxell wrote: On 2016-02-22 10:17, Ricardo Salveti wrote: Since scmversion gets populated during the configure process, the only way for the cache to be updated through commits is by either running make distclean

Re: [lng-odp] [PATCH] autotools: define test extensions to skip on valgrind test

On 05/17/16 19:02, Mike Holmes wrote: Wait, the final result is good and matches the long report - all the .sh files pass but if you scroll back up I get make[5]: Leaving directory '/root/check-odp/build/odp/platform/linux-generic/test/shmem' make[5]: Entering directory

Re: [lng-odp] [PATCHv7 00/35] running things in process mode

Reviewed patches 1-10 Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Christophe Milard > Sent: Tuesday, May 17, 2016 4:04 PM > To: lng-odp@lists.linaro.org; brian.bro...@linaro.org;

Re: [lng-odp] process thread and mixed mode

On 17 May 2016 at 23:19, Bill Fischofer wrote: > > Just to summarize the discussion from earlier today with a view towards > how we move forward: > >- Because today we have threads that all share a single address space, >ODP handles and addresses derived from

Re: [lng-odp] [PATCH v2 5/5] linux-generic: packet: initialize only selected odp_packet_hdr_t members

From: Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Tuesday, May 17, 2016 9:46 PM To: Mike Holmes Cc: Elo, Matias (Nokia - FI/Espoo) ; lng-odp Subject: Re: [lng-odp] [PATCH v2 5/5] linux-generic: packet: