Re: [lng-odp] [PATCHv7 1/2] example: introducing l3fwd

2016-08-11 Thread Elo, Matias (Nokia - FI/Espoo)
Sorry for the slow review on my part. I’m currently testing the application and there seems to be something wrong with the argument parsing. With the following commands no packets are forwarded. $ sudo ./example/l3fwd/odp_l3fwd -i 0,1 -r 1.1.1.0/24,0 -r 2.2.2.0/24,1 -t 2 -d 0 or $ sudo ./example/l

Re: [lng-odp] [PATCH] doc: release-guide: add LTS details

2016-08-11 Thread Mike Holmes
On 8 August 2016 at 15:52, Bill Fischofer wrote: > As an aside, this patch and my patch to this file collide, so we need to > figure out who goes first and who gets to rebase. > > On Mon, Aug 8, 2016 at 10:34 AM, Mike Holmes > wrote: > >> Signed-off-by: Mike Holmes >> --- >> doc/process-guide/

Re: [lng-odp] [PATCH] test: performance: capture termination failures in final return code

2016-08-11 Thread Bill Fischofer
On Thu, Aug 11, 2016 at 1:15 PM, Mike Holmes wrote: > On 11 August 2016 at 13:01, Maxim Uvarov wrote: > > > I'm going to apply this patch to master. But test might fail on bug in > > term code. But I think we will have more eyes seeing this issue... > > If any objections please say asap. > > > I

Re: [lng-odp] [PATCH] test: performance: capture termination failures in final return code

2016-08-11 Thread Mike Holmes
On 11 August 2016 at 13:01, Maxim Uvarov wrote: > I'm going to apply this patch to master. But test might fail on bug in > term code. But I think we will have more eyes seeing this issue... > If any objections please say asap. I object We have stated previously that no commit may ever break ma

Re: [lng-odp] [PATCH] test: performance: capture termination failures in final return code

2016-08-11 Thread Maxim Uvarov
I'm going to apply this patch to master. But test might fail on bug in term code. But I think we will have more eyes seeing this issue... If any objections please say asap. Maxim. On 08/10/16 17:23, Bill Fischofer wrote: Accumulate return codes from resource cleanup so callers can be aware of

[lng-odp] [PATCHv2] example: odp_l2fwd place readme with symlink

2016-08-11 Thread Maxim Uvarov
odp_l2fwd is standalone application which can be used as example or as performance test. Hiding it inside performance tests might be not new users friendly way. Create symlink with small readme file for better finding it. Signed-off-by: Maxim Uvarov --- v2: add to examples.dox (alphabetical) d

Re: [lng-odp] [PATCHv7 1/2] example: introducing l3fwd

2016-08-11 Thread Mike Holmes
I CC'ed Matias, I am not sure if we can get another Member to run this on their HW ? It does not have to be perfect but I think it is likely to be ready as an example at this point. Mike On 10 August 2016 at 06:42, forrest.shi wrote: > Ping, need review and comments. Pending a bit long. > >

Re: [lng-odp] [PATCH] example: odp_l2fwd place readme with symlink

2016-08-11 Thread Mike Holmes
Why dont we do it as part of this patch, the patch says it is to make it easy to find ? We just need to make an entry in the file at a minimum, I 'd like it to be more but that moves us forward. In all example cases we need better descriptions, they have none at all in the generated doxygen. Agree

Re: [lng-odp] [PATCH] example: odp_l2fwd place readme with symlink

2016-08-11 Thread Maxim Uvarov
ok. Can we do it in separate patch for l3fwd and l2fwd together? Or I and Forest have to update our patches. Maxim. On 11 August 2016 at 17:21, Mike Holmes wrote: > We need to also add this to ~/git/odp/doc/application-api-guide/examples.dox > so that it gets seen in the application users guid

Re: [lng-odp] [PATCHv2] helper: hashtable: clean up internal functions name

2016-08-11 Thread Maxim Uvarov
ping, review is needed. Maxim. On 08/09/16 15:06, Maxim Uvarov wrote: No need for prefix for not interface local static functions. Suggested-by: Anders Roxell Signed-off-by: Maxim Uvarov --- helper/hashtable.c | 46 +++--- 1 file changed, 23 inserti

Re: [lng-odp] [PATCH] example: odp_l2fwd place readme with symlink

2016-08-11 Thread Mike Holmes
We need to also add this to ~/git/odp/doc/application-api-guide/examples.dox so that it gets seen in the application users guide if we really want to get the maximum exposure to it. On 11 August 2016 at 10:09, Maxim Uvarov wrote: > ping > > > On 07/22/16 14:05, Maxim Uvarov wrote: > >> odp_l2fwd

[lng-odp] [API-NEXT PATCHv2] helper: cuckootable: add missing return codes

2016-08-11 Thread Maxim Uvarov
add missing return codes for non void functions. Signed-off-by: Maxim Uvarov --- helper/cuckootable.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/helper/cuckootable.c b/helper/cuckootable.c index 91a73b4..b4fce6c 100644 --- a/helper/

[lng-odp] [Bug 2427] odph_cuckoo_table_create fails in CI

2016-08-11 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2427 Mike Holmes changed: What|Removed |Added Priority|High|Highest --- Comment #3 from Mike Holmes --- API

Re: [lng-odp] [PATCH] example: odp_l2fwd place readme with symlink

2016-08-11 Thread Maxim Uvarov
ping On 07/22/16 14:05, Maxim Uvarov wrote: odp_l2fwd is standalone application which can be used as example or as performance test. Hiding it inside performance tests might be not new users friendly way. Create symlink with small readme file for better finding it. Signed-off-by: Maxim Uvarov

[lng-odp] [Bug 2436] CI FAIL: pktio_ipc/pktio_ipc_run.sh

2016-08-11 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2436 Mike Holmes changed: What|Removed |Added Resolution|--- |NON REPRODUCIBLE Status|CONFIRMED

[lng-odp] [Bug 2457] odp_scheduling fails under load.

2016-08-11 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2457 --- Comment #3 from Mike Holmes --- Petri can now reproduce -- You are receiving this mail because: You are on the CC list for the bug.

[lng-odp] [Bug 2467] Traffic Mngr segfaults when compiled with clang on 32-bit systems

2016-08-11 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2467 Mike Holmes changed: What|Removed |Added Version|v1.10 |v1.10.1 CC|

[lng-odp] [Bug 2444] Can not use two PKTIOs with Traffic Manager

2016-08-11 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2444 --- Comment #6 from Bill Fischofer --- Merged. Commit ID a5d7adea4b2487b020371ac554935972ec947385 Awaiting report from Oriol that this fixes his issue. -- You are receiving this mail because: You are on the CC list for the bug.

Re: [lng-odp] [PATCH v3] linux-generic: tm: made tm thread creation more flexible

2016-08-11 Thread Maxim Uvarov
Merged, Maxim. On 08/10/16 23:16, Bill Fischofer wrote: Note: This patch now conflicts with my previous patch to fix Bug 2458. I will send a rebase of that patch to apply on top of this one as this one should be applied first. Oriole: Please test this on your system to see if it resolves Bug 24