[lng-odp] [Bug 2834] race condition in _ishm_reserve

2017-02-01 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2834 Christophe Milard changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

Re: [lng-odp] [PATCH 1/2] linux-gen: dpdk: improve pmd driver linking

2017-02-01 Thread Elo, Matias (Nokia - FI/Espoo)
> On 2 Feb 2017, at 9:25, Christophe Milard > wrote: > > hmmm... that sound promising. thanks for the update. may I ask which > libtool version you tried with (latest)? Libtool: 2.4.6 Automake: 1.15 Autoconf: 2.69 They seem to be the standard packages in ubuntu

Re: [lng-odp] [PATCH 1/2] linux-gen: dpdk: improve pmd driver linking

2017-02-01 Thread Christophe Milard
hmmm... that sound promising. thanks for the update. may I ask which libtool version you tried with (latest)? Thanks anyway! Christophe. On 2 February 2017 at 08:22, Elo, Matias (Nokia - FI/Espoo) wrote: > >> On 1 Feb 2017, at 16:01, Christophe Milard

Re: [lng-odp] [PATCH 1/2] linux-gen: dpdk: improve pmd driver linking

2017-02-01 Thread Elo, Matias (Nokia - FI/Espoo)
> On 1 Feb 2017, at 16:01, Christophe Milard > wrote: > > No, saddly. I got stuck on this. > I summed up the situation here: > https://lists.linaro.org/pipermail/lng-odp/2016-October/026120.html > ... > But if you get it to go, it is a good new: Just make sure

[lng-odp] [Bug 2865] odp helper table APIs are not documented

2017-02-01 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2865 Bill Fischofer changed: What|Removed |Added Ever confirmed|0 |1

[lng-odp] [PATCH] doc: helper: add missing doxygen for helper table functions

2017-02-01 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2865 by adding missing doxygen documentation for helper table functions Signed-off-by: Bill Fischofer --- helper/include/odp/helper/odph_cuckootable.h | 80 ++---

Re: [lng-odp] [PATCH 3/5] helper: use ABI mode for ip

2017-02-01 Thread Bill Fischofer
On Wed, Feb 1, 2017 at 7:14 AM, Mike Holmes wrote: > Signed-off-by: Mike Holmes > --- > helper/Makefile.am | 1 + > helper/include/odp/helper/ip.h | 48 + >

Re: [lng-odp] [PATCH 4/5] helper: use ABI mode for chksum

2017-02-01 Thread Bill Fischofer
On Wed, Feb 1, 2017 at 7:14 AM, Mike Holmes wrote: > Signed-off-by: Mike Holmes > --- > helper/Makefile.am | 1 + > helper/chksum.c| 4 ++ > helper/include/odp/helper/chksum.h | 59

Re: [lng-odp] [PATCH 2/5] helper: add ABI compile flag

2017-02-01 Thread Bill Fischofer
On Wed, Feb 1, 2017 at 7:14 AM, Mike Holmes wrote: > Signed-off-by: Mike Holmes > --- > configure.ac | 6 + > helper/Makefile.am | 1 + > helper/include/odp/helper/.gitignore

[lng-odp] [Bug 2852] ODP_STATIC_ASSERT() fails when used by C++

2017-02-01 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2852 --- Comment #2 from Bill Fischofer --- Patch V2 posted at http://patches.opendataplane.org/patch/8029/ -- You are receiving this mail because: You are on the CC list for the bug.

Re: [lng-odp] [PATCHv2] linux-generic: debug: enable helper use from c++ programs

2017-02-01 Thread Bill Fischofer
On Wed, Feb 1, 2017 at 1:14 PM, Brian Brooks wrote: > On 02/01 08:30:22, Bill Fischofer wrote: >> The ODP_STATIC_ASSERT() macro expands to _Static_assert(), however when >> used in C++ programs this needs to expand to static_assert(). >> >> This resolves Bug

Re: [lng-odp] [PATCHv2] linux-generic: debug: enable helper use from c++ programs

2017-02-01 Thread Brian Brooks
On 02/01 08:30:22, Bill Fischofer wrote: > The ODP_STATIC_ASSERT() macro expands to _Static_assert(), however when > used in C++ programs this needs to expand to static_assert(). > > This resolves Bug https://bugs.linaro.org/show_bug.cgi?id=2852 I applied this patch and

Re: [lng-odp] [PATCH] linux-generic: Add ARM odp_cpu_pause()

2017-02-01 Thread Brian Brooks
On 02/01 08:38:08, Mike Holmes wrote: > If this is in the API, then to be ABI compatible it must compile into the > lib and not be a static inline I would think, unless we are sure that for a > given cpu arch it will never differ which may be true. > > > On 1 February 2017 at 06:12, Bill

Re: [lng-odp] [API-NEXT PATCH 15/15] linux-gen: support older libconfig version

2017-02-01 Thread Christophe Milard
needs rebase, I think: erachmi@erachmi-ericsson:~/linaro/ODP/odp$ git am ~/incoming/lng-odp_API-NEXT_PATCH_* Applying: merge fix: platform/linux-generic/Makefile.am error: patch failed: platform/linux-generic/Makefile.am:20 error: platform/linux-generic/Makefile.am: patch does not apply Patch

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

2017-02-01 Thread Joe Savage
> > I raised question about coding style question on today’s arch call > > discussion. And agreement was: > > > > 1. variables are on top. (actually we discussed that but looks like > > forget to document.) Some exceptions acceptable if you link to 3-rd > > party code which you can not modify.

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

2017-02-01 Thread Ola Liljedahl
On 1 February 2017 at 16:19, Maxim Uvarov wrote: > On 02/01/17 13:26, Joe Savage wrote: >> Hey Maxim, >> >> I'm adding the mailing list to the CCs. >> > > sorry, looks like I pressed replay instead of replay all. > > I raised question about coding style question on

Re: [lng-odp] rstp support on odp

2017-02-01 Thread Bill Fischofer
On Wed, Feb 1, 2017 at 9:29 AM, Maxim Uvarov wrote: > I have some theoretical question to think... > > > rstp on hardware switches supported with moving port into disabled mode > where it do not accept packets but only stp packets can pass-thought to > rstp daemon app

[lng-odp] rstp support on odp

2017-02-01 Thread Maxim Uvarov
I have some theoretical question to think... rstp on hardware switches supported with moving port into disabled mode where it do not accept packets but only stp packets can pass-thought to rstp daemon app which decided which where path is shorter and disables/enables certain ports. How that app

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

2017-02-01 Thread Maxim Uvarov
On 02/01/17 13:26, Joe Savage wrote: > Hey Maxim, > > I'm adding the mailing list to the CCs. > sorry, looks like I pressed replay instead of replay all. I raised question about coding style question on today’s arch call discussion. And agreement was: 1. variables are on top. (actually we

Re: [lng-odp] ODP install error with dpdk 16.07

2017-02-01 Thread Bill Fischofer
On Wed, Feb 1, 2017 at 8:24 AM, Elo, Matias (Nokia - FI/Espoo) wrote: >> >> Thanks, Matias. For your benchmarking it would be good to get a >> comparison run without those options to better quantify the overhead >> of ABI compatibility mode. Right now we're taking

[lng-odp] [PATCHv2] linux-generic: debug: enable helper use from c++ programs

2017-02-01 Thread Bill Fischofer
The ODP_STATIC_ASSERT() macro expands to _Static_assert(), however when used in C++ programs this needs to expand to static_assert(). This resolves Bug https://bugs.linaro.org/show_bug.cgi?id=2852 Signed-off-by: Bill Fischofer --- Changes for v2: - Update C++ test

Re: [lng-odp] ODP install error with dpdk 16.07

2017-02-01 Thread Elo, Matias (Nokia - FI/Espoo)
> > Thanks, Matias. For your benchmarking it would be good to get a > comparison run without those options to better quantify the overhead > of ABI compatibility mode. Right now we're taking a strict approach to > ABI so as to minimize the coordination requirements between > implementations

Re: [lng-odp] [PATCH 1/2] linux-gen: dpdk: improve pmd driver linking

2017-02-01 Thread Christophe Milard
No, saddly. I got stuck on this. I summed up the situation here: https://lists.linaro.org/pipermail/lng-odp/2016-October/026120.html ... But if you get it to go, it is a good new: Just make sure that works on the latest libtool/autotools: Going forward is OK. If it does not work on latest, then,

Re: [lng-odp] [PATCH] linux-generic: Add ARM odp_cpu_pause()

2017-02-01 Thread Mike Holmes
If this is in the API, then to be ABI compatible it must compile into the lib and not be a static inline I would think, unless we are sure that for a given cpu arch it will never differ which may be true. On 1 February 2017 at 06:12, Bill Fischofer wrote: > On Wed,

Re: [lng-odp] [PATCH 1/2] linux-gen: dpdk: improve pmd driver linking

2017-02-01 Thread Elo, Matias (Nokia - FI/Espoo)
> > As far as I remember, some autotools version won't allow that: it will > reject it with a message saying you are not allowed to set LDD libs > withing flags (LDFLAGS)... > What autotools version are you using? > Hopefully, new ones will no longer do that, but I remember trying > different

[lng-odp] [PATCH 5/5] helper: use ABI mode for udp

2017-02-01 Thread Mike Holmes
Signed-off-by: Mike Holmes --- helper/Makefile.am | 4 +++- helper/include/odp/helper/udp.h | 13 ++-- helper/include/odp/helper/udp_inlines.h | 36 + helper/udp.c| 14

[lng-odp] [PATCH 3/5] helper: use ABI mode for ip

2017-02-01 Thread Mike Holmes
Signed-off-by: Mike Holmes --- helper/Makefile.am | 1 + helper/include/odp/helper/ip.h | 48 + helper/include/odp/helper/ip_inlines.h | 65 ++ helper/ip.c| 4

[lng-odp] [PATCH 4/5] helper: use ABI mode for chksum

2017-02-01 Thread Mike Holmes
Signed-off-by: Mike Holmes --- helper/Makefile.am | 1 + helper/chksum.c| 4 ++ helper/include/odp/helper/chksum.h | 59 ++- helper/include/odp/helper/chksum_inlines.h | 77

[lng-odp] [PATCH 1/5] helper: split out types

2017-02-01 Thread Mike Holmes
Signed-off-by: Mike Holmes --- helper/Makefile.am | 5 +- helper/include/odp/helper/chksum.h | 13 +-- helper/include/odp/helper/chksum_types.h | 45 + helper/include/odp/helper/ip.h | 136 +

[lng-odp] [PATCH 2/5] helper: add ABI compile flag

2017-02-01 Thread Mike Holmes
Signed-off-by: Mike Holmes --- configure.ac | 6 + helper/Makefile.am | 1 + helper/include/odp/helper/.gitignore | 1 + helper/include/odp/helper/static_inline.h.in | 35

[lng-odp] [PATCH 0/5] Add ABI compatibility to helper lib

2017-02-01 Thread Mike Holmes
Reusing the mechanism used for the ODP API, allow the helpers to build in ABI mode where they optionally do not use static inline in the header file. Mike Holmes (5): helper: split out types helper: add ABI compile flag helper: use ABI mode for ip helper: use ABI mode for chksum helper:

Re: [lng-odp] [PATCH 1/2] linux-gen: dpdk: improve pmd driver linking

2017-02-01 Thread Christophe Milard
On 1 February 2017 at 13:47, Matias Elo wrote: > Previously each dpdk pmd driver had to be individually referred in the odp > code to ensure proper gcc constructor linking. Using the -—whole-archive > option when linking the drivers removes this need. After this patch new >

[lng-odp] [PATCH 1/2] linux-gen: dpdk: improve pmd driver linking

2017-02-01 Thread Matias Elo
Previously each dpdk pmd driver had to be individually referred in the odp code to ensure proper gcc constructor linking. Using the -—whole-archive option when linking the drivers removes this need. After this patch new dpdk pmd drivers are automatically linked. Signed-off-by: Matias Elo

[lng-odp] [PATCH 2/2] linux-gen: dpdk: bump target dpdk version to 16.11

2017-02-01 Thread Matias Elo
Signed-off-by: Matias Elo --- DEPENDENCIES | 2 +- scripts/build-pktio-dpdk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DEPENDENCIES b/DEPENDENCIES index 574859c..6d01042 100644 --- a/DEPENDENCIES +++ b/DEPENDENCIES @@ -165,7 +165,7 @@

Re: [lng-odp] [PATCH] linux-generic: Add ARM odp_cpu_pause()

2017-02-01 Thread Bill Fischofer
On Wed, Feb 1, 2017 at 2:17 AM, Maxim Uvarov wrote: > it's abi function, has to be declared with _STATIC. For others arches also. Actually, in this case since the purpose of the call is to waste time, inlining it would be counterproductive, which is why these routines

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

2017-02-01 Thread Joe Savage
Hey Maxim, I'm adding the mailing list to the CCs. > > +#include > > +#include > > + > > +#include "odp_ipfragreass_ip.h" > > +#include "odp_ipfragreass_fragment.h" > > + > > +int fragment_ipv4_packet(odp_packet_t orig_packet, odp_packet_t *out, > > +int *out_len) > >

Re: [lng-odp] [PATCH] linux-generic: Add ARM odp_cpu_pause()

2017-02-01 Thread Maxim Uvarov
it's abi function, has to be declared with _STATIC. For others arches also. Maxim. On 1 February 2017 at 01:34, Bill Fischofer wrote: > On Thu, Jan 26, 2017 at 9:31 PM, Brian Brooks > wrote: > > Signed-off-by: Brian Brooks