Re: [lng-odp] Generic handle in ODP

2017-02-28 Thread Francois Ozog
Hi Shally, I am unsure this leads to a safe direction and here is why. Depending on the hardware, software provides either 1) a bunch of buffers where the HW will place packets (1 buffer will receive one packet) or 2) a large memory zone in which the hardware will place the packets according to

Re: [lng-odp] Generic handle in ODP

2017-02-28 Thread Maxim Uvarov
that is odp_event_t and bunch of functions to covert line odp_packet_from_event() and etc. Maxim. On 1 March 2017 at 09:41, Verma, Shally wrote: > I wanted to check if we could introduce a generic handle concept in ODP > (something like odp_handle_t carrying purpose

Re: [lng-odp] [PATCH 2/5] test: generator: send UDP packets in bursts

2017-02-28 Thread Yi He
On 13 February 2017 at 22:14, Bogdan Pricope wrote: > Signed-off-by: Bogdan Pricope > --- > example/generator/odp_generator.c | 77 +++--- > - > 1 file changed, 53 insertions(+), 24 deletions(-) > > diff

Re: [lng-odp] [PATCH 1/5] test: generator: compose sending packets from reference packet plus differences

2017-02-28 Thread Yi He
Comments on 1/5 and 2/5, other patches in this series look OK to me. On 13 February 2017 at 20:49, Bogdan Pricope wrote: > Signed-off-by: Bogdan Pricope > --- > example/generator/odp_generator.c | 131 ++ >

[lng-odp] Generic handle in ODP

2017-02-28 Thread Verma, Shally
I wanted to check if we could introduce a generic handle concept in ODP (something like odp_handle_t carrying purpose similar to void * ) which can be used for API that need to handle multiple types in one call. Ex. an API that works on both Packet and Buffer Type .Such use cases can take

Re: [lng-odp] [PATCH] As per mailing-list and meeting conversation: this patch addresses the build failure on operating systems where CPU_SETSIZE is bigger than 1024 entries.

2017-02-28 Thread Bill Fischofer
On Tue, Feb 28, 2017 at 11:55 AM, Marco Varlese wrote: > Signed-off-by: Marco Varlese > Reviewed-and-tested-by: Bill Fischofer > --- > platform/linux-generic/include/odp/api/plat/cpumask_types.h | 2 +- > 1 file

Re: [lng-odp] Compilation error of ODP on Linux x86_64 platform

2017-02-28 Thread Marco Varlese
Thanks a million Maxim! Patch submitted. On Tue, 2017-02-28 at 18:57 +0300, Maxim Uvarov wrote: > git format-patch HEAD^ > perl ./scripts/checkpatch.pl *.patch > > git send-email --to lng-odp@lists.linaro.org *.patc > > > On 28 February 2017 at 18:54, Marco Varlese

Re: [lng-odp] [PATCH] api: ipsec: make IPSEC protocol consistent with other types

2017-02-28 Thread Bill Fischofer
Thanks Andriy, We discussed this during the call and the consensus is to leave this code as-is for now. Bala was on the call, so Cavium was represented in the discussions. Regards, Bill On Tue, Feb 28, 2017 at 11:44 AM, Andriy Berestovskyy < andriy.berestovs...@cavium.com> wrote: > Hey guys, >

[lng-odp] [PATCH] As per mailing-list and meeting conversation: this patch addresses the build failure on operating systems where CPU_SETSIZE is bigger than 1024 entries.

2017-02-28 Thread Marco Varlese
Signed-off-by: Marco Varlese --- platform/linux-generic/include/odp/api/plat/cpumask_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/include/odp/api/plat/cpumask_types.h

Re: [lng-odp] [PATCH] api: ipsec: make IPSEC protocol consistent with other types

2017-02-28 Thread Andriy Berestovskyy
Hey guys, IMO having: typedef enum odp_ipsec_op_mode_t ODP_IPSEC_OP_MODE_* typedef enum odp_ipsec_dir_t ODP_IPSEC_DIR_* typedef enum odp_ipsec_mode_t ODP_IPSEC_MODE_* typedef enum odp_ipsec_tunnel_type_t ODP_IPSEC_TUNNEL_* and then: typedef enum odp_ipsec_protocol_t ODP_IPSEC_* looks like

Re: [lng-odp] Compilation error of ODP on Linux x86_64 platform

2017-02-28 Thread Maxim Uvarov
git format-patch HEAD^ perl ./scripts/checkpatch.pl *.patch git send-email --to lng-odp@lists.linaro.org *.patc On 28 February 2017 at 18:54, Marco Varlese wrote: > Hi, > I'm trying to submit the patch but without much success... > > mvarlese@linux-yk3w:~/repos> git

Re: [lng-odp] Compilation error of ODP on Linux x86_64 platform

2017-02-28 Thread Marco Varlese
Hi, I'm trying to submit the patch but without much success...  mvarlese@linux-yk3w:~/repos> git clone https://git.linaro.org/lng/odp.git mvarlese@linux-yk3w:~/repos/odp> git config --global user.name "Marco Varlese" mvarlese@linux-yk3w:~/repos/odp> git config --global user.email

[lng-odp] [Linaro/odp] 037e35: api: pktio: add parser configuration

2017-02-28 Thread GitHub
Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: 037e35f0f948a87e3daede33747177615aa3bab0 https://github.com/Linaro/odp/commit/037e35f0f948a87e3daede33747177615aa3bab0 Author: Petri Savolainen Date: 2017-02-28 (Tue, 28 Feb

[lng-odp] [Bug 2903] New: validation: add test case for PMR LD_VNI

2017-02-28 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2903 Bug ID: 2903 Summary: validation: add test case for PMR LD_VNI Product: OpenDataPlane - linux- generic reference Version: v1.10 Hardware: Other OS: Linux Status:

Re: [lng-odp] [PATCH 1/2] linux-gen: ipc: use hdr to handle conversion function

2017-02-28 Thread Maxim Uvarov
On 02/28/17 16:49, Maxim Uvarov wrote: > On 02/28/17 16:22, Savolainen, Petri (Nokia - FI/Espoo) wrote: >> >> >> From: Bill Fischofer [mailto:bill.fischo...@linaro.org] >> Sent: Tuesday, February 28, 2017 2:58 PM >> To: Savolainen, Petri (Nokia - FI/Espoo) >>

Re: [lng-odp] [PATCH 1/2] linux-gen: ipc: use hdr to handle conversion function

2017-02-28 Thread Maxim Uvarov
On 02/28/17 16:22, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Tuesday, February 28, 2017 2:58 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > > Cc: Maxim Uvarov

Re: [lng-odp] [PATCH 1/2] linux-gen: ipc: use hdr to handle conversion function

2017-02-28 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Tuesday, February 28, 2017 2:58 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: Maxim Uvarov ; lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 1/2] linux-gen:

Re: [lng-odp] [PATCH 1/2] linux-gen: ipc: use hdr to handle conversion function

2017-02-28 Thread Maxim Uvarov
On 02/28/17 15:55, Bill Fischofer wrote: > > > On Tue, Feb 28, 2017 at 1:45 AM, Savolainen, Petri (Nokia - FI/Espoo) > > wrote: > > > > > -Original Message- > > From: lng-odp

Re: [lng-odp] [PATCH 1/2] linux-gen: ipc: use hdr to handle conversion function

2017-02-28 Thread Bill Fischofer
Your series also includes TM (good catch) so it seems this need extends beyond just IPC. On Tue, Feb 28, 2017 at 6:55 AM, Bill Fischofer wrote: > > > On Tue, Feb 28, 2017 at 1:45 AM, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolai...@nokia-bell-labs.com> wrote:

Re: [lng-odp] [PATCH 1/2] linux-gen: ipc: use hdr to handle conversion function

2017-02-28 Thread Bill Fischofer
On Tue, Feb 28, 2017 at 1:45 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Maxim > > Uvarov > > Sent: Monday, February 27, 2017 6:10 PM > > To:

Re: [lng-odp] [PATCH] api: ipsec: make IPSEC protocol consistent with other types

2017-02-28 Thread Bill Fischofer
On Tue, Feb 28, 2017 at 2:22 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Bill > > Fischofer > > Sent: Monday, February 27, 2017 5:17 PM > > To:

Re: [lng-odp] Compilation error of ODP on Linux x86_64 platform

2017-02-28 Thread Bill Fischofer
I've added this topic to the agenda for today's ODP public call. Marco, if you're able to join us to provide your input to the discussion please do so. The call is at 15:00 UTC. To join just go to http://meetings.opendataplane.org. We use the BlueJeans conferencing system. Thanks. On Tue, Feb

Re: [lng-odp] Compilation error of ODP on Linux x86_64 platform

2017-02-28 Thread Maxim Uvarov
the problem is that if you compile binary on let's say ubuntu it might not work on suse with more then 1024 cpus. On 28 February 2017 at 11:52, Marco Varlese wrote: > On Tue, 2017-02-28 at 08:12 +, Savolainen, Petri (Nokia - FI/Espoo) > wrote: > > [nip] > > > /** > >

Re: [lng-odp] Compilation error of ODP on Linux x86_64 platform

2017-02-28 Thread Marco Varlese
On Tue, 2017-02-28 at 08:12 +, Savolainen, Petri (Nokia - FI/Espoo) wrote: [nip] > /** >  * @def ODP_CPUMASK_SIZE >  * Maximum cpumask size, this definition limits the number of individual CPUs >  * that can be accessed in this system. >  */ > > It cannot be removed, it's part of API. Just

Re: [lng-odp] [PATCH] api: ipsec: make IPSEC protocol consistent with other types

2017-02-28 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: Monday, February 27, 2017 5:17 PM > To: Andriy Berestovskyy > Cc: lng-odp-forward > Subject: Re: [lng-odp]

Re: [lng-odp] [API-NEXT PATCH 1/2] api: pktio: add parser configuration

2017-02-28 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. We'd like to start implementation == fix the broken lazy parsing. -Petri From: Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Thursday, February 23, 2017 3:52 PM To: Petri Savolainen Cc: lng-odp-forward Subject: Re:

Re: [lng-odp] [PATCH 1/3] helper: linux: add common linux helper file

2017-02-28 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. This needs to be merged to API next also, so that OFP can build against both branches. -Petri From: Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Wednesday, February 22, 2017 1:54 AM To: Petri Savolainen Cc: lng-odp-forward

Re: [lng-odp] Compilation error of ODP on Linux x86_64 platform

2017-02-28 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim > Uvarov > Sent: Monday, February 27, 2017 6:09 PM > To: Marco Varlese ; lng-odp@lists.linaro.org > Subject: Re: [lng-odp] Compilation error of ODP on Linux x86_64