Re: [lng-odp] [API-NEXT PATCHv3] linux-generic: pool: defer ring allocation until pool creation

On Tue, Jan 10, 2017 at 7:19 AM, Bill Fischofer <bill.fischo...@linaro.org> wrote: > On Tue, Jan 10, 2017 at 2:17 AM, Savolainen, Petri (Nokia - FI/Espoo) > <petri.savolai...@nokia-bell-labs.com> wrote: >> >> The race condition should be avoided. That can

Re: [lng-odp] [API-NEXT PATCHv3] linux-generic: pool: defer ring allocation until pool creation

ol: defer ring >> allocation until pool creation >> >> Petri, do you have objections for this patch for locked area? If not, >> than Bill can do v2 with more clean shm names. >> >> Maxim. >> >> On 12/16/16 17:08, Bill Fischofer wrote: >> > On Fri, De

Re: [lng-odp] [API-NEXT PATCH 0/5] Packet header optimizations

On Tue, Jan 10, 2017 at 2:44 AM, Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> wrote: >> -Original Message----- >> From: Bill Fischofer [mailto:bill.fischo...@linaro.org] >> Sent: Monday, January 09, 2017 11:00 PM >> To: Savol

Re: [lng-odp] [PATCHv2] example: hello: set cpu affinity from cgroup

On Mon, Jan 9, 2017 at 7:30 PM, Bill Fischofer <bill.fischo...@linaro.org> wrote: > On Mon, Jan 9, 2017 at 7:35 AM, Balakrishna Garapati > <balakrishna.garap...@linaro.org> wrote: >> This will resolve the test in ci when using cgroups. >> odp_hello app fails to set

Re: [lng-odp] [PATCHv2] example: hello: set cpu affinity from cgroup

Balakrishna Garapati <balakrishna.garap...@linaro.org> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > example/hello/odp_hello.c | 19 --- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/example/hello/odp_hello.c b/ex

Re: [lng-odp] [API-NEXT PATCH 0/5] Packet header optimizations

This series looks good, however it conflicts with the packet reference patch series since that series is adding fields to the packet header. Since the purpose here is to optimize the packet header layout based on your measurements, I suggest it follow the merge of the packet reference series so

Re: [lng-odp] [API-NEXT PATCH 4/5] validation: packet: label compare data checks

On Mon, Jan 9, 2017 at 9:16 AM, Petri Savolainen wrote: > Added labels to identify which compare data call fails. > > Signed-off-by: Petri Savolainen > --- > test/common_plat/validation/api/packet/packet.c | 35 > -

Re: [lng-odp] [API-NEXT PATCHv6 1/5] api: packet: add support for packet references

On Mon, Jan 9, 2017 at 10:08 AM, Bala Manoharan <bala.manoha...@linaro.org> wrote: > Except for the Minor documentation comment below > > Reviewed-by: Balasubramanian Manoharan <bala.manoha...@linaro.org> > > On 5 January 2017 at 20:25, Bill Fischofer <bi

[lng-odp] [API-NEXT PATCHv3] linux-generic: crypto: add openssl locking support for thread safety

Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2798 by adding OpenSSL callbacks for locking that use ticketlocks to provide thread-safety for OpenSSL calls made by ODP components such as random number generation. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- Changes

Re: [lng-odp] [API-NEXT PATCH] linux-generic: init: add openssl locking support for thread safety

On Mon, Jan 9, 2017 at 2:23 AM, Christophe Milard <christophe.mil...@linaro.org> wrote: > On 6 January 2017 at 00:57, Bill Fischofer <bill.fischo...@linaro.org> wrote: >> Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2798 by adding >> OpenSSL callbacks for l

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: init: add openssl locking support for thread safety

gt;> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill >> Fischofer >> Sent: Friday, January 06, 2017 3:54 PM >> To: lng-odp@lists.linaro.org >> Subject: [lng-odp] [API-NEXT PATCHv2] linux-generic: init: add openssl >> locking support for threa

Re: [lng-odp] [API-NEXT] linux-gen: init: avoiding segfault if cleaning files

) placed before these ODP_* > functions are initialized. > This would surely sigfault. > The call the the cleanup_files() function is hence placed after ODP_DBG and > ODP_ERR function initialization to avoid this situation. > > Signed-off-by: Christophe Milard <christophe.mil...@lina

[lng-odp] [API-NEXT PATCHv2] linux-generic: init: add openssl locking support for thread safety

Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2798 by adding OpenSSL callbacks for locking that use ticketlocks to provide thread-safety for OpenSSL calls made by ODP components such as random number generation. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- Changes

[lng-odp] [API-NEXT PATCH] linux-generic: init: add openssl locking support for thread safety

Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2798 by adding OpenSSL callbacks for locking that use ticketlocks to provide thread-safety for OpenSSL calls made by ODP components such as random number generation. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform

[lng-odp] [API-NEXT PATCHv6 5/5] doc: userguide: add user documentation for packet references

Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- doc/users-guide/users-guide-packet.adoc | 239 +++- 1 file changed, 238 insertions(+), 1 deletion(-) diff --git a/doc/users-guide/users-guide-packet.adoc b/doc/users-guide/users-guide-packet.adoc

[lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement reference apis

Implement the APIs: - odp_packet_ref_static() - odp_packet_ref() - odp_packet_ref_pkt() - odp_packet_is_ref() - odp_packet_unshared_len() This also involves functional upgrades to the existing packet manipulation APIs to work with packet references as input arguments. Signed-off-by: Bill

[lng-odp] [API-NEXT PATCHv6 3/5] validation: packet: add packet reference tests

Add validation tests for the new packet reference APIs: - odp_packet_ref_static() - odp_packet_ref() - odp_packet_ref_pkt() - odp_packet_is_ref() - odp_packet_unshared_len() Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- test/common_plat/validation/api/packet/packet.c

[lng-odp] [API-NEXT PATCHv6 1/5] api: packet: add support for packet references

, two other APIs simplify working with references odp_packet_is_ref() says whether a packet is a reference odp_packet_unshared_len() gives the sum of data lengths over all unshared packet segments. These are the only bytes of the packet that may be modified safely. Signed-off-by: Bill Fischofer

Re: [lng-odp] [API-NEXT PATCHv2] linux-gen: _ishm: fixing typos

On Wed, Dec 21, 2016 at 6:55 AM, Christophe Milard <christophe.mil...@linaro.org> wrote: > Fixing a set of iritating typos. just in comments. > > Signed-off-by: Christophe Milard <christophe.mil...@linaro.org> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.

Re: [lng-odp] [PATCH v4 1/2] test: perf: add new ordered pktio application

For this series: Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> On Wed, Jan 4, 2017 at 1:24 AM, Matias Elo <matias@nokia.com> wrote: > Add new test application for ordered queue functionality and performance > validation. The application sets sequence n

Re: [lng-odp] [PATCH 1/2] example: free reserved shared memory blocks

For this series: Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> On Wed, Jan 4, 2017 at 6:02 AM, Matias Elo <matias@nokia.com> wrote: > Previously all reserverd shared memory blocks were not freed. > > Signed-off-by: Matias Elo <matias@nok

Re: [lng-odp] [PATCH] helper: fix odph_ipv4_csum functions for L3 offset 0

On Wed, Jan 4, 2017 at 8:52 AM, Joe Savage <joe.sav...@arm.com> wrote: > Fix a bug where odph_ipv4_csum_{valid, update} would interpret an L3 > offset of zero as a sign that the packet has no L3 offset. > > Signed-off-by: Joe Savage <joe.sav...@arm.com> Reviewed-and-t

[lng-odp] [API-NEXT PATCHv5 5/5] doc: userguide: add user documentation for packet references

Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- doc/users-guide/users-guide-packet.adoc | 237 +++- 1 file changed, 236 insertions(+), 1 deletion(-) diff --git a/doc/users-guide/users-guide-packet.adoc b/doc/users-guide/users-guide-packet.adoc

[lng-odp] [API-NEXT PATCHv5 2/5] linux-generic: packet: implement reference apis

Implement the APIs: - odp_packet_ref_static() - odp_packet_ref() - odp_packet_ref_pkt() - odp_packet_is_ref() - odp_packet_unshared_len() This also involves functional upgrades to the existing packet manipulation APIs to work with packet references as input arguments. Signed-off-by: Bill

[lng-odp] [API-NEXT PATCHv5 1/5] api: packet: add support for packet references

, two other APIs simplify working with references odp_packet_is_ref() says whether a packet is a reference odp_packet_unshared_len() gives the sum of data lengths over all unshared packet segments. These are the only bytes of the packet that may be modified safely. Signed-off-by: Bill Fischofer

Re: [lng-odp] [API-NEXT PATCHv4 1/5] api: packet: add support for packet references

On Wed, Jan 4, 2017 at 6:32 AM, Bala Manoharan <bala.manoha...@linaro.org> wrote: > Regards, > Bala > > > On 3 January 2017 at 20:02, Bill Fischofer <bill.fischo...@linaro.org> wrote: >> On Tue, Jan 3, 2017 at 8:14 AM, Bala Manoharan >> <bala.manoha..

Re: [lng-odp] [PATCH v3 1/2] test: perf: add new ordered pktio application

On Thu, Dec 1, 2016 at 7:01 AM, Matias Elo wrote: > Add new test application for ordered queue functionality and performance > validation. The application sets sequence numbers to incoming packets using > ordered pktin queues and ordered context locks. After being tagged

Re: [lng-odp] [PATCH v3 2/2] test: pktio_ordered: add test script

gt; Anyway, the API should be clear on what is allowed. I guess we don't > want control characters or international characters (like öäå) in > there... do we? > > On 3 January 2017 at 13:44, Bill Fischofer <bill.fischo...@linaro.org> wrote: >> On Tue, Jan 3, 2017 at 12:51 AM, E

Re: [lng-odp] [API-NEXT PATCHv4 1/5] api: packet: add support for packet references

On Tue, Jan 3, 2017 at 8:14 AM, Bala Manoharan <bala.manoha...@linaro.org> wrote: > Regards, > Bala > > > On 2 January 2017 at 05:10, Bill Fischofer <bill.fischo...@linaro.org> wrote: >> Introduce three new APIs that support efficient sharing of portions of >&g

Re: [lng-odp] [PATCH v3 2/2] test: pktio_ordered: add test script

On Tue, Jan 3, 2017 at 12:51 AM, Elo, Matias (Nokia - FI/Espoo) wrote: > >> I see the same sort of behavior with l2fwd_simple, so I'm inclined to >> agree with you. I've verified that libpcap-dev is installed. What more >> should be needed to run these? >> > >

Re: [lng-odp] Is odp_random odpthread safe?

On Mon, Jan 2, 2017 at 11:17 AM, Christophe Milard wrote: > Hi > > I have noticed that (rarely enough to be a pain to catch) odp_shm and > odpdrv_shm sress test sigfaults. > I saw it once last week, but that was enough to worry me as the common > part between the two

Re: [lng-odp] [PATCH v3 2/2] test: pktio_ordered: add test script

I see the same sort of behavior with l2fwd_simple, so I'm inclined to agree with you. I've verified that libpcap-dev is installed. What more should be needed to run these? On Mon, Jan 2, 2017 at 6:21 AM, Elo, Matias (Nokia - FI/Espoo) wrote: > >>

[lng-odp] [API-NEXT PATCHv4 5/5] doc: userguide: add user documentation for packet references

Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- doc/users-guide/users-guide-packet.adoc | 269 +++- 1 file changed, 268 insertions(+), 1 deletion(-) diff --git a/doc/users-guide/users-guide-packet.adoc b/doc/users-guide/users-guide-packet.adoc

[lng-odp] [API-NEXT PATCHv4 2/5] linux-generic: packet: implement reference apis

-by: Bill Fischofer <bill.fischo...@linaro.org> --- .../linux-generic/include/odp_packet_internal.h| 68 ++- platform/linux-generic/odp_packet.c| 549 + 2 files changed, 510 insertions(+), 107 deletions(-) diff --git a/platform/linux-generic/i

[lng-odp] [API-NEXT PATCHv4 3/5] validation: packet: add packet reference tests

Add validation tests for the new packet reference APIs: - odp_packet_ref_static() - odp_packet_ref() - odp_packet_ref_pkt() - odp_packet_is_ref() - odp_packet_has_ref() - odp_packet_unshared_len() Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- test/common_plat/validati

[lng-odp] [API-NEXT PATCHv4 1/5] api: packet: add support for packet references

bytes of the packet that may be modified safely. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- Changes in v4: - Bug fixes - Expand validation testing to cover extensions on packets with references Changes in v3: - Rebased to latest API-NEXT - Bug fixes - Eliminate concept o

Re: [lng-odp] [PATCH v3 2/2] test: pktio_ordered: add test script

Trying to run this I get: bill@Ubuntu15:~/linaro/review/test/common_plat/performance$ ./odp_pktio_ordered_run.sh using PCAP_IN = ./udp64.pcap _ishm.c:859:_odp_ishm_reserve():No huge pages, fall back to normal pages. check: /proc/sys/vm/nr_hugepages. PKTIO: initialized loop interface. PKTIO:

Re: [lng-odp] [NEXT PATCH] changelog: summary of changes for odp v1.13.0.0

On Thu, Dec 29, 2016 at 9:33 AM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > On 12/29/16 00:57, Bill Fischofer wrote: >> Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> >> --- >> CHANGELOG | 163 >> ++

[lng-odp] [NEXT PATCH] changelog: summary of changes for odp v1.13.0.0

Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- CHANGELOG | 163 ++ 1 file changed, 163 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 17afe44..e912835 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3

[lng-odp] [NEXT PATCH] api: pktio: pktio documentation typo correction

Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/api/spec/packet_io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/odp/api/spec/packet_io.h b/include/odp/api/spec/packet_io.h index 2dabfcc..85cd6d1 100644 --- a/include/odp/ap

[lng-odp] [API-NEXT PATCHv3 5/5] doc: userguide: add user documentation for packet references

Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- doc/users-guide/users-guide-packet.adoc | 269 +++- 1 file changed, 268 insertions(+), 1 deletion(-) diff --git a/doc/users-guide/users-guide-packet.adoc b/doc/users-guide/users-guide-packet.adoc

[lng-odp] [API-NEXT PATCHv3 2/5] linux-generic: packet: implement reference apis

-by: Bill Fischofer <bill.fischo...@linaro.org> --- .../linux-generic/include/odp_packet_internal.h| 68 ++- platform/linux-generic/odp_packet.c| 484 + 2 files changed, 458 insertions(+), 94 deletions(-) diff --git a/platform/linux-generic/i

[lng-odp] [API-NEXT PATCHv3 3/5] validation: packet: add packet reference tests

Add validation tests for the new packet reference APIs: - odp_packet_ref_static() - odp_packet_ref() - odp_packet_ref_pkt() - odp_packet_is_ref() - odp_packet_has_ref() - odp_packet_unshared_len() Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- test/common_plat/validati

[lng-odp] [API-NEXT PATCHv3 1/5] api: packet: add support for packet references

bytes of the packet that may be modified safely. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/api/spec/packet.h | 190 +- 1 file changed, 189 insertions(+), 1 deletion(-) diff --git a/include/odp/api/spec/packet.h b/inclu

Re: [lng-odp] [API-NEXT PATCH] helper: remove debug on thread start

On Mon, Dec 26, 2016 at 8:10 AM, Maxim Uvarov wrote: > Message floods tests output. There is no reason for prints > of starting threads due to each application if needed can > do there own prints. > > Signed-off-by: Maxim Uvarov > --- >

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: add algorithm capabilities

d key > lengths, etc options. > > Signed-off-by: Petri Savolainen <petri.savolai...@nokia.com> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > include/odp/api/spec/ipsec.h | 40 > 1 file changed, 40 insert

Re: [lng-odp] [API-NEXT PATCH 1/7] api: packet: src and dst packet must not be the same

OK. For this series: Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> On Fri, Dec 23, 2016 at 1:56 AM, Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> wrote: > > >> -Original Message- >> From: Bill Fischofer [ma

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

On Thu, Dec 22, 2016 at 9:07 AM, Bala Manoharan <bala.manoha...@linaro.org> wrote: > On 21 December 2016 at 19:45, Bill Fischofer <bill.fischo...@linaro.org> > wrote: >> On Wed, Dec 21, 2016 at 6:42 AM, Bala Manoharan >> <bala.manoha...@linaro.org> wrote: >

Re: [lng-odp] [API-NEXT PATCH 0/7] optimize packet concat

On Thu, Dec 22, 2016 at 12:32 PM, Maxim Uvarov wrote: > checked that code compiles on that broken compiler. So it will be nice > to merge once approved. Good to know. I think the changes are good and will enable further optimization, but I'd like clarification about the

Re: [lng-odp] [API-NEXT PATCH 1/7] api: packet: src and dst packet must not be the same

On Thu, Dec 22, 2016 at 8:33 AM, Petri Savolainen wrote: > Concat and copy_from_pkt operations must be called with src and > dst packet handles which refer to the same packet. > > Signed-off-by: Petri Savolainen > --- >

Re: [lng-odp] [PATCHv2] linux-generic: packet: fix buggy compiler error

On Thu, Dec 22, 2016 at 8:13 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Mike >> Holmes >> Sent: Thursday, December 22, 2016 4:08 PM >> To: Maxim

Re: [lng-odp] [PATCHv2, 1/1] validation: pktio: fix invalid mac addr

On Thu, Dec 22, 2016 at 7:52 AM, Josep Puigdemont wrote: > On Thu, Dec 22, 2016 at 12:22:50PM +0530, Bala Manoharan wrote: >> Regards, >> Bala >> >> >> On 8 December 2016 at 21:03, Josep Puigdemont >> wrote: >> > On Thu, Nov 10, 2016 at

[lng-odp] [PATCH] test: perf: add assert since src_idx cannot be negative

Address Bug https://bugs.linaro.org/show_bug.cgi?id=2790 by adding an assert. odp_packet_input_index() only returns a negative value if the packet did not originate on an I/O interface, which is known to be false here. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> ---

Re: [lng-odp] [API-NEXT PATCH] linux-gen: schedule_sp: use ring as priority queue

Yi He had previously given his review for this patch. The subsequent side-discussion don't constitute a NAK so this should be good to merge. On Mon, Dec 19, 2016 at 4:37 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Ping. > >> -Original Message-

Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: fix buggy compiler error

On Wed, Dec 21, 2016 at 9:26 AM, Maxim Uvarov wrote: > On debian jessie gcc unable to compile current code > with error: > odp_packet.c: In function 'odp_packet_trunc_head': > odp_packet.c:314:46: error: array subscript is above array bounds > [-Werror=array-bounds] >

Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: fix buggy compiler error

I posted a patch to fix Bug 2789 but it's orthogonal to this issue. We should still see if we can come up with a compile-time-only circumvention. On Wed, Dec 21, 2016 at 12:30 PM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > On 12/21/16 19:07, Bill Fischofer wrote: >> On Wed, De

[lng-odp] [API-NEXT PATCH] linux-generic: packet: set correct tailroom on trim of multi-seg pkts

Fix Bug https://bugs.linaro.org/show_bug.cgi?id=2789 by calculating tailroom correctly when trimming multi-segment packets. Also handle head/tail push/pull operations that result in a zero-length packet correctly. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform

Re: [lng-odp] [API-NEXT PATCH] linux-generic: packet: fix buggy compiler error

On Wed, Dec 21, 2016 at 9:58 AM, Mike Holmes wrote: > On 21 December 2016 at 10:49, Maxim Uvarov wrote: > >> On 12/21/16 18:31, Mike Holmes wrote: >> > >> > >> > On 21 December 2016 at 10:26, Maxim Uvarov > >

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

On Wed, Dec 21, 2016 at 6:42 AM, Bala Manoharan <bala.manoha...@linaro.org> wrote: > Regards, > Bala > > > On 20 December 2016 at 22:35, Bill Fischofer <bill.fischo...@linaro.org> > wrote: >> On Tue, Dec 20, 2016 at 8:26 AM, Bala Manoharan >> <bala.ma

Re: [lng-odp] [API-NEXT PATCH] linux-gen: _ishm: fixing typos

On Wed, Dec 21, 2016 at 5:16 AM, Christophe Milard wrote: > Fixing a set of iritating typos. just in comments. > > Signed-off-by: Christophe Milard > --- > platform/linux-generic/_ishm.c | 24 > 1 file changed,

Re: [lng-odp] [API-NEXT PATCH v2] validation: test creating pool and timer pool with no name

On Wed, Dec 21, 2016 at 5:27 AM, Matias Elo <matias@nokia.com> wrote: > Signed-off-by: Matias Elo <matias@nokia.com> > --- > > Reviewed-by: Petri Savolainen <petri.savolai...@nokia.com> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> >

Re: [lng-odp] [API-NEXT PATCHv2 1/4] linux-gen: sched: solve ordered context inversion

For this series: Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> On Fri, Dec 9, 2016 at 4:51 AM, Yi He <yi...@linaro.org> wrote: > For ordered queue, a thread consumes events (dequeue) and > acquires its unique sequential context in two steps, non > a

Re: [lng-odp] [API-NEXT PATCH 1/3] api: unify ODP_*_NAME_LEN specifications

For Parts 1 and 2: Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> As noted in Part 3, that also looks fine but should be a separate patch since it doesn't seem to be related to the purpose of Parts 1 and 2. On Tue, Dec 20, 2016 at 7:45 AM, Matias Elo <matias@nokia.c

Re: [lng-odp] [API-NEXT PATCH 3/3] validation: test creating pool and timer pool with no name

This looks fine, but this seems to have little to do with the other parts of this patch. It should be a separate patch. On Tue, Dec 20, 2016 at 7:45 AM, Matias Elo wrote: > Signed-off-by: Matias Elo > --- > test/common_plat/validation/api/pool/pool.c

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

On Tue, Dec 20, 2016 at 8:26 AM, Bala Manoharan <bala.manoha...@linaro.org> wrote: > On 20 December 2016 at 18:26, Bill Fischofer <bill.fischo...@linaro.org> > wrote: >> On Tue, Dec 20, 2016 at 5:59 AM, Bala Manoharan >> <bala.manoha...@linaro.org> wrote: >

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

On Tue, Dec 20, 2016 at 5:59 AM, Bala Manoharan <bala.manoha...@linaro.org> wrote: > Regards, > Bala > > > On 19 December 2016 at 20:23, Bill Fischofer <bill.fischo...@linaro.org> > wrote: >> On Mon, Dec 19, 2016 at 4:06 AM, Bala Manoharan >> <bala.man

[lng-odp] [PATCH] example: l3fwd: explicitly ignore rc from parse call

odph_eth_addr_parse always returns RC == 0. Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2780 by explicitly ignoring this. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- example/l3fwd/odp_l3fwd_db.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

On Mon, Dec 19, 2016 at 1:22 PM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > On 12/19/16 19:41, Bill Fischofer wrote: >> On Mon, Dec 19, 2016 at 9:57 AM, Maxim Uvarov <maxim.uva...@linaro.org> >> wrote: >>> how about group all packet refe

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

tion. If you want to modify both independently the way you do that is create two references to the same base packet, and then both of these can have their own unique prefixes while the base packet remains read-only. > > Maxim. > > > On 11/15/16 17:44, Bill Fischofer wrote: &

Re: [lng-odp] [PATCH] example: introducing multi-threaded traffic management case

+cc Barry. Barry: would you also like to take a look at this? Thanks. On Mon, Dec 19, 2016 at 12:01 AM, wrote: > From: Xuelin Shi > > introduce a new example of traffic management with following features: > - multiple TM threads: one TM thread

Re: [lng-odp] [API-NEXT PATCHv2 1/5] api: packet: add support for packet references

On Mon, Dec 19, 2016 at 4:06 AM, Bala Manoharan <bala.manoha...@linaro.org> wrote: > Comments inline > > > On 15 November 2016 at 20:14, Bill Fischofer <bill.fischo...@linaro.org> > wrote: >> Introduce three new APIs that support efficient

Re: [lng-odp] [API-NEXT PATCH] linux-gen: pktio ipc: fix clang build

a future ARCH call post MS-1. > > Maxim. > > On 12/16/16 21:11, Bill Fischofer wrote: >> On Fri, Dec 16, 2016 at 8:27 AM, Maxim Uvarov <maxim.uva...@linaro.org> >> wrote: >>> clang is more clever on setting and not using variables, >>> so it trap

Re: [lng-odp] [API-NEXT PATCH] linux-gen: pktio ipc: fix clang build

ce. > > Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > platform/linux-generic/include/odp_buffer_internal.h | 7 +++ > platform/linux-generic/pktio/ipc.c | 7 --- >

Re: [lng-odp] RFC workaround for -m32 on old gcc

On Fri, Dec 16, 2016 at 6:44 AM, Maxim Uvarov wrote: > ping. > > Our CI still fails on 32 bit compilation. But I tested in latest Ubuntu > that 32 bits work well. So I think it's better to update CI image. I believe when I researched this a few months back I found a

Re: [lng-odp] [API-NEXT PATCHv3] linux-generic: pool: defer ring allocation until pool creation

On Fri, Dec 16, 2016 at 7:13 AM, Maxim Uvarov wrote: > On 12/16/16 11:06, Savolainen, Petri (Nokia - FI/Espoo) wrote: >>> >>> @@ -172,6 +172,7 @@ static pool_t *reserve_pool(void) >>> { >>> int i; >>> pool_t *pool; >>> +char ring_name[ODP_POOL_NAME_LEN];

Re: [lng-odp] [API-NEXT PATCHv3] linux-generic: pool: defer ring allocation until pool creation

On Fri, Dec 16, 2016 at 6:50 AM, Maxim Uvarov wrote: > On 12/16/16 11:06, Savolainen, Petri (Nokia - FI/Espoo) wrote: >>> >>> @@ -172,6 +172,7 @@ static pool_t *reserve_pool(void) >>> { >>> int i; >>> pool_t *pool; >>> +char ring_name[ODP_POOL_NAME_LEN];

Re: [lng-odp] [API-NEXT PATCHv3] linux-gen: pktio ipc: compile if ipc pktio disable with config

On Thu, Dec 15, 2016 at 12:45 PM, Maxim Uvarov wrote: > Compile all function code except places where it's lined to > external files even if ipc pktio disable with config option. > > Signed-off-by: Maxim Uvarov > --- > Bill, looks like we forgot

Re: [lng-odp] [API-NEXT PATCHv3 4/5] linux-gen: pktio ipc: make it work again

For the v3 series: Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> On Wed, Dec 14, 2016 at 1:57 PM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> > --- > .../linux-generic/include/odp

[lng-odp] [API-NEXT PATCHv3] linux-generic: pool: defer ring allocation until pool creation

://bugs.linaro.org/show_bug.cgi?id=2765 Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- Changes for v3: - Do not reference pool ring on buffer alloc/free if cache can satisfy request Changes for v2: - Reset reserved to 0 if ring allocation fails to recover properly platform/linux-g

[lng-odp] [API-NEXT PATCHv2] linux-generic: pool: defer ring allocation until pool creation

://bugs.linaro.org/show_bug.cgi?id=2765 Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- Changes for v2: - Reset reserved to 0 if ring allocation fails to recover properly platform/linux-generic/include/odp_pool_internal.h | 3 ++- platform/linux-generic/odp_pool.c

[lng-odp] [API-NEXT PATCH] linux-generic: pool: defer ring allocation until pool creation

://bugs.linaro.org/show_bug.cgi?id=2765 Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/include/odp_pool_internal.h | 3 ++- platform/linux-generic/odp_pool.c | 23 +- 2 files changed, 20 insertions(+), 6 deletions(-) diff

Re: [lng-odp] sizeof(pool_table_t) = 272M

On Wed, Dec 14, 2016 at 3:01 AM, Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> wrote: > > >> -Original Message----- >> From: Bill Fischofer [mailto:bill.fischo...@linaro.org] >> Sent: Tuesday, December 13, 2016 4:00 PM >> To:

Re: [lng-odp] [API-NEXT PATCHv2 4/6] linux-gen: pktio ipc: make it work again

v2 applies and runs fine on 64-bit systems, however when I try to run it on 32-bit systems this happens: bill@Ub16-32:~$ cd linaro/review/ bill@Ub16-32:~/linaro/review$ ulimit -c unlimited bill@Ub16-32:~/linaro/review$ cd test/linux-generic/pktio_ipc/

Re: [lng-odp] [PATCH] configure.ac: do not disable shared lib for non abi mode

On Tue, Dec 13, 2016 at 7:34 AM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > After discussion on mailing list there is case to support > shared library for non abi compatibility mode. > > Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> Reviewed-by: Bil

Re: [lng-odp] [PATCH v2] example: traffic_mgmt: use PRIu32 instead of %u

On Tue, Dec 13, 2016 at 12:34 PM, Maxim Uvarov wrote: > On 12/13/16 19:55, Nicolas Morey-Chaisemartin wrote: >> Signed-off-by: Nicolas Morey-Chaisemartin >> --- >> v2: add missing include. >> Should be applied to monarch_lts too >> >>

Re: [lng-odp] [PATCH v2] example: traffic_mgmt: use PRIu32 instead of %u

On Tue, Dec 13, 2016 at 10:55 AM, Nicolas Morey-Chaisemartin <nmo...@kalray.eu> wrote: > Signed-off-by: Nicolas Morey-Chaisemartin <nmo...@kalray.eu> Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > v2: add missing include. > Should

Re: [lng-odp] [PATCH] example: traffic_mgmt: use PRIu32 instead of %u

Sorry about that. Yes, the file is missing: #include in the #include list, then it compiles and runs fine. Nicolas, can you submit a v2? On Tue, Dec 13, 2016 at 8:51 AM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > On 12/13/16 06:41, Bill Fischofer wrote: >> On Tue, Dec 6,

Re: [lng-odp] [PATCH] example: traffic_mgmt: use PRIu32 instead of %u

On Tue, Dec 6, 2016 at 9:25 AM, Nicolas Morey-Chaisemartin <nmo...@kalray.eu> wrote: > Signed-off-by: Nicolas Morey-Chaisemartin <nmo...@kalray.eu> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > > This should be backported to monarch_lts too

[lng-odp] Canceled Event: OpenDataPlane (ODP) Public Call @ Tue Dec 27, 2016 9am - 10am (CST) (lng-odp@lists.linaro.org)

Dec 27, 2016 9am – 10am Central Time Where: http://meetings.opendataplane.org Calendar: lng-odp@lists.linaro.org Who: * Bill Fischofer - creator * rizwan.ans...@linaro.org * lng-odp@lists.linaro.org * Christophe Milard * Alexandru Badicioiu * pvandenheu...@insidesecure.com

Re: [lng-odp] [API-NEXT PATCH] linux-gen: schedule_sp: use ring as priority queue

On Mon, Dec 12, 2016 at 6:35 AM, Maxim Uvarov wrote: > On 12/08/16 14:04, Petri Savolainen wrote: >> Improve scalability by replacing lock protected linked list >> with a ring. Schedule group supported was updated also, since >> ring does not support peek of the head

Re: [lng-odp] sizeof(pool_table_t) = 272M

Max num is supposed to be the maximum architectural limit supported. This sounds like an implementation bug. The system should not reserve the maximum but should be designed to expand up to the maximum (subject to memory availability). I agree 272MB is excessive as a fixed overhead even for

[lng-odp] [API-NEXT PATCHv9 3/3] doc: userguide: expand crypto documentation to cover random apis

Clean up the crypto section of the User Guide and expand on the ODP random data APIs. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- doc/users-guide/users-guide-crypto.adoc | 93 + 1 file changed, 72 insertions(+), 21 deletions(-) diff --git

[lng-odp] [API-NEXT PATCHv9 2/3] doc: userguide: move crypto documentation to its own sub-document

Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- doc/users-guide/Makefile.am | 1 + doc/users-guide/users-guide-crypto.adoc | 71 doc/users-guide/users-guide.adoc| 72 + 3 files chang

[lng-odp] [API-NEXT PATCHv9 1/3] api: random: add explicit controls over random data

applications to generate repeatable random sequences for testing purposes Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- Changes in v9: - Remove kind parameter and expand seed to uint64_t in odp_random_test_data() - Clarify that seed variables must be thread-local Changes in v8: - C

Re: [lng-odp] [RFC/API-NEXT 1/1] api: classification: packet hashing per class of service

On Fri, Dec 9, 2016 at 9:52 PM, Bala Manoharan <bala.manoha...@linaro.org> wrote: > Regards, > Bala > > > On 10 December 2016 at 02:06, Bill Fischofer <bill.fischo...@linaro.org> > wrote: >> Is this supposed to be instead of queue groups or in additio

Re: [lng-odp] [RFC/API-NEXT 1/1] api: classification: packet hashing per class of service

Is this supposed to be instead of queue groups or in addition to queue group support? On Fri, Dec 9, 2016 at 5:54 AM, Balasubramanian Manoharan wrote: > Adds support to spread packet from a single CoS to multiple queues by > configuring hashing at CoS level. > >

Re: [lng-odp] [API-NEXT PATCHv8 1/3] api: random: add explicit controls over random data

On Fri, Dec 9, 2016 at 3:27 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> + >> +/** >> + * Generate repeatable random data for testing purposes >> + * >> + * For testing purposes it is often useful to generate "random" sequences >> that >> + * are

Re: [lng-odp] contributing to the "example" directory

This sounds like an excellent example. The goal of ODP examples is to illustrate programming techniques and API usage that may be of interest to others in either evaluating ODP and/or writing their own applications with it. As such, examples are expected to be reasonably succinct and focused, but

Re: [lng-odp] [API-NEXT PATCH v3 00/10] crypto key length capability

I'm happy with this series, but I think Bala and Nikhil should be the reviewers since we want to be sure it doesn't impact their crypto implementations. On Thu, Dec 8, 2016 at 8:05 AM, Petri Savolainen wrote: > Various cipher and authentication algorithms support

Re: [lng-odp] [API-NEXT PATCH v3 01/10] api: crypto: rename _params_t to _param_t

ompatibility, > but are deprecated. > > Signed-off-by: Petri Savolainen <petri.savolai...@nokia.com> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > include/odp/api/spec/crypto.h | 22 ++ > 1 file changed, 14 insertions(+), 8 deletion

<    4   5   6   7   8   9   10   11   12   13   >