Re: [lng-odp] [API-NEXT PATCH 0/3] _ishm: multiple blocks using identical names

2016-11-25 Thread Maxim Uvarov
Merged, Maxim. On 11/25/16 17:32, Christophe Milard wrote: ping On 9 November 2016 at 14:28, Bill Fischofer wrote: For this series: Reviewed-by: Bill Fischofer On Tue, Nov 8, 2016 at 3:49 AM, Christophe Milard wrote: NOTE: must be applied on top of: "using _ishm as north API mem allocato

Re: [lng-odp] [MONARCH PATCH] git_hash: handle git worktree

2016-11-25 Thread Maxim Uvarov
merged, Maxim. On 11/18/16 20:46, Mike Holmes wrote: On 18 November 2016 at 05:18, Nicolas Morey-Chaisemartin wrote: In git worktrees .git is a file and not a directory. This patches replaces [ -d .git ] test by [ -e .git ] so it works in both cases Signed-off-by: Nicolas Morey-Chaisemartin

Re: [lng-odp] [API-NEXT PATCHv9 00/15] using _ishm as north API mem allocator

2016-11-25 Thread Maxim Uvarov
Good catch, but not related to this patch series. Christophe On 25 November 2016 at 10:35, Maxim Uvarov wrote: I forgot to say that I see back ground process only after make check. And run single process works. On 25 November 2016 at 12:23, Christophe Milard wrote: On 24 November 2016 at

[lng-odp] [PATCH] test: linux-gen: fix termination in mmap_vlan_ins

2016-11-25 Thread Maxim Uvarov
exit variable has to be volatile to be visible from thread. Without that background process is not killed with default optimization level. Signed-off-by: Maxim Uvarov --- test/linux-generic/mmap_vlan_ins/mmap_vlan_ins.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test

[lng-odp] [PATCHv7 3/3] configure.ac update version numbers

2016-11-24 Thread Maxim Uvarov
Default is abi compat mode, all interface functions changed, so increase first number of .so Signed-off-by: Maxim Uvarov --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index b460a65..e7b8f8a 100644 --- a/configure.ac +++ b

[lng-odp] [PATCHv7 2/3] changelog: summary of changes for odp v1.12.0.0

2016-11-24 Thread Maxim Uvarov
From: Bill Fischofer Signed-off-by: Bill Fischofer Signed-off-by: Maxim Uvarov --- CHANGELOG | 177 ++ 1 file changed, 177 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 1d652a8..b125d63 100644 --- a/CHANGELOG +++ b

[lng-odp] [PATCHv7 1/3] configure.ac: disable shared library for non abi compat mode

2016-11-24 Thread Maxim Uvarov
-by: Maxim Uvarov --- configure.ac | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index be5a292..b460a65 100644 --- a/configure.ac +++ b/configure.ac @@ -241,13 +241,11 @@ ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" ODP_AB

[lng-odp] [PATCHv7 0/3] changelog: summary of changes for odp v1.12.0.0

2016-11-24 Thread Maxim Uvarov
v7: more accurate define disable option (Anders) Bill Fischofer (1): changelog: summary of changes for odp v1.12.0.0 Maxim Uvarov (2): configure.ac: disable shared library for non abi compat mode configure.ac update version numbers CHANGELOG| 177

Re: [lng-odp] [PATCHv6 1/3] configure.ac: disable shared library for non abi compat mode

2016-11-24 Thread Maxim Uvarov
On 11/24/16 23:12, Anders Roxell wrote: On 24 November 2016 at 17:03, Maxim Uvarov wrote: original configure.ac enables abi compat mode by default, even without --enable-abi-compat provided. And has broken logic to disable abi compat mode. Correct logic to build abi compat mode and option to

Re: [lng-odp] [API-NEXT PATCHv9 00/15] using _ishm as north API mem allocator

2016-11-24 Thread Maxim Uvarov
Christophe, with this patch series and without it I see odp_pktio_perf hangs in background. And it looks like accept() never pass. Interesting is that Cunit reported this test as passed and actually it's in background. Other apps looks like ok. 81../sysdeps/unix/syscall-template.S: No suc

[lng-odp] [PATCHv6 2/3] changelog: summary of changes for odp v1.12.0.0

2016-11-24 Thread Maxim Uvarov
From: Bill Fischofer Signed-off-by: Bill Fischofer Signed-off-by: Maxim Uvarov --- CHANGELOG | 177 ++ 1 file changed, 177 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 1d652a8..b125d63 100644 --- a/CHANGELOG +++ b

[lng-odp] [PATCHv6 3/3] configure.ac update version numbers

2016-11-24 Thread Maxim Uvarov
Default is abi compat mode, all interface functions changed, so increase first number of .so Signed-off-by: Maxim Uvarov --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 7cb0c7a..de634dc 100644 --- a/configure.ac +++ b

[lng-odp] [PATCHv6 1/3] configure.ac: disable shared library for non abi compat mode

2016-11-24 Thread Maxim Uvarov
-by: Maxim Uvarov --- configure.ac | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index be5a292..7cb0c7a 100644 --- a/configure.ac +++ b/configure.ac @@ -241,16 +241,19 @@ ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" ODP_AB

[lng-odp] [PATCHv6 0/3] changelog: summary of changes for odp v1.12.0.0

2016-11-24 Thread Maxim Uvarov
v6: uh, finally we agreed with .so numberding. added patch to disable shared library for non abi compat mode and corrected description for configure option. Bill Fischofer (1): changelog: summary of changes for odp v1.12.0.0 Maxim Uvarov (2): configure.ac: disable shared library for

Re: [lng-odp] [API-NEXT PATCHv8 02/15] linux-gen: init: removing possible obsolete ODP files at startup

2016-11-24 Thread Maxim Uvarov
On 11/24/16 11:24, Christophe Milard wrote: When an ODP program is killed, some odp files may remain in /tmp and the huge page mount point. As signal KILL cannot be caught, there is not much one can do to prevent that. But when an new odp session is started, all files prefixed with the opd prefix

Re: [lng-odp] [API-NEXT PATCHv8 01/15] linux-gen: _ishm: fix for alignment request matching page size

2016-11-24 Thread Maxim Uvarov
On 11/24/16 11:24, Christophe Milard wrote: There is no reason to toggle the _ODP_ISHM_SINGLE_VA flag when the alignment exactely exactly matches the page size. This just results in wasting the odp-common virtual space Signed-off-by: Christophe Milard --- platform/linux-generic/_ishm.c

Re: [lng-odp] [PATCHv5 2/2] configure.ac update version numbers

2016-11-23 Thread Maxim Uvarov
On 11/22/16 23:22, Anders Roxell wrote: On 2016-11-22 21:25, Maxim Uvarov wrote: Signed-off-by: Maxim Uvarov --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index be5a292..287e478 100644 --- a/configure.ac +++ b

Re: [lng-odp] [PATCHv4 0/2] changelog: summary of changes for odp v1.12.0.0

2016-11-22 Thread Maxim Uvarov
On 11/22/16 22:36, Mike Holmes wrote: On 22 November 2016 at 13:27, Maxim Uvarov wrote: On 11/22/16 20:14, Anders Roxell wrote: On 2016-11-22 19:04, Maxim Uvarov wrote: going to merge is very soon, any objection? Features already in monarch that should not be in the change log Hello world

Re: [lng-odp] [API-NEXT PATCHv7 00/13] using _ishm as north API mem allocator

2016-11-22 Thread Maxim Uvarov
On 11/22/16 22:07, Christophe Milard wrote: On 22 November 2016 at 16:05, Maxim Uvarov wrote: Christophe, I found 2 issues with that patches: 1. ./test/common_plat/performance/odp_sched_latency_run.sh fails _fdserver.c:275:_odp_fdserver_register_fd():FD client register: pid=17036 key=8, fd

Re: [lng-odp] [PATCHv4 0/2] changelog: summary of changes for odp v1.12.0.0

2016-11-22 Thread Maxim Uvarov
On 11/22/16 20:14, Anders Roxell wrote: On 2016-11-22 19:04, Maxim Uvarov wrote: going to merge is very soon, any objection? Features already in monarch that should not be in the change log Hello world thread local Documentation examples added l2fwd l2fwd_simple was in (1.10.1.0) Maxim

[lng-odp] [PATCHv5 2/2] configure.ac update version numbers

2016-11-22 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index be5a292..287e478 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ AC_PREREQ([2.5]) # Set correct API version

[lng-odp] [PATCHv5 1/2] changelog: summary of changes for odp v1.12.0.0

2016-11-22 Thread Maxim Uvarov
From: Bill Fischofer Signed-off-by: Bill Fischofer Signed-off-by: Maxim Uvarov --- CHANGELOG | 177 ++ 1 file changed, 177 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 1d652a8..b125d63 100644 --- a/CHANGELOG +++ b

[lng-odp] [PATCHv5 0/2] changelog: summary of changes for odp v1.12.0.0

2016-11-22 Thread Maxim Uvarov
-info.html Bill Fischofer (1): changelog: summary of changes for odp v1.12.0.0 Maxim Uvarov (1): configure.ac update version numbers CHANGELOG| 180 ++- configure.ac | 6 +- 2 files changed, 180 insertions(+), 6 deletions(-) --

Re: [lng-odp] [PATCHv4 0/2] changelog: summary of changes for odp v1.12.0.0

2016-11-22 Thread Maxim Uvarov
On 11/22/16 20:14, Anders Roxell wrote: On 2016-11-22 19:04, Maxim Uvarov wrote: going to merge is very soon, any objection? Features already in monarch that should not be in the change log Hello world thread local Documentation examples added l2fwd thanks, removed that. Implementers

Re: [lng-odp] [PATCHv4 0/2] changelog: summary of changes for odp v1.12.0.0

2016-11-22 Thread Maxim Uvarov
going to merge is very soon, any objection? Maxim. On 11/21/16 20:00, Maxim Uvarov wrote: v4: no api changes from Monarch, I removed all entries for that in previous patch. Update only 'revision' according to that link: https://www.gnu.org/software/libtool/manual/html_node/Updati

Re: [lng-odp] [PATCHv2 1/1] validation: pktio: fix invalid mac addr

2016-11-22 Thread Maxim Uvarov
going to apply this just after current dev release. Maxim. On 11/14/16 12:37, Bala Manoharan wrote: Ping. Review needed. Regards, Bala On 10 November 2016 at 19:58, Balasubramanian Manoharan wrote: Fixes https://bugs.linaro.org/show_bug.cgi?id=2496 Signed-off-by: Balasubramanian Manoharan

Re: [lng-odp] [API-NEXT PATCHv7 00/13] using _ishm as north API mem allocator

2016-11-22 Thread Maxim Uvarov
Christophe, I found 2 issues with that patches: 1. ./test/common_plat/performance/odp_sched_latency_run.sh fails _fdserver.c:275:_odp_fdserver_register_fd():FD client register: pid=17036 key=8, fd=11 _fdserver.c:459:handle_request():storing {ctx=1, key=8}->fd=13 _ishmphy.c:128:_odp_ishmphy_m

Re: [lng-odp] [API-NEXT PATCH v4 00/23] pool optimization

2016-11-22 Thread Maxim Uvarov
queue problems will be fixed once the new implementation is ready. -Petri *From:*Maxim Uvarov [mailto:maxim.uva...@linaro.org] *Sent:* Tuesday, November 22, 2016 12:27 PM *To:* Savolainen, Petri (Nokia - FI/Espoo) *Cc:* LNG ODP Mailman List *Subject:* Re: [lng-odp] [API-NEXT PATCH v4 00/23

[lng-odp] RFC workaround for -m32 on old gcc

2016-11-22 Thread Maxim Uvarov
Does somebody interested in supporting old compilers? I see for example our CI fails. Changing to memcpy() has to work. If there there is interest I will send clean patch for this. odp_schedule_ordered.c: In function ‘schedule_order_lock’: odp_schedule_ordered.c:787:1: error: unrecognizable

Re: [lng-odp] [API-NEXT PATCH v4 00/23] pool optimization

2016-11-22 Thread Maxim Uvarov
once the new implementation is ready. -Petri *From:*Maxim Uvarov [mailto:maxim.uva...@linaro.org] *Sent:* Tuesday, November 22, 2016 12:27 PM *To:* Savolainen, Petri (Nokia - FI/Espoo) *Cc:* LNG ODP Mailman List *Subject:* Re: [lng-odp] [API-NEXT PATCH v4 00/23] pool optimization Scheduler

[lng-odp] [PATCHv4 0/2] changelog: summary of changes for odp v1.12.0.0

2016-11-21 Thread Maxim Uvarov
v4: no api changes from Monarch, I removed all entries for that in previous patch. Update only 'revision' according to that link: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html Bill Fischofer (1): changelog: summary of changes for odp v1.12.0.0 Ma

[lng-odp] [PATCHv4 2/2] configure.ac update version numbers

2016-11-21 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index be5a292..287e478 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ AC_PREREQ([2.5]) # Set correct API version

[lng-odp] [PATCHv4 1/2] changelog: summary of changes for odp v1.12.0.0

2016-11-21 Thread Maxim Uvarov
From: Bill Fischofer Signed-off-by: Bill Fischofer Signed-off-by: Maxim Uvarov --- CHANGELOG | 186 ++ 1 file changed, 186 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 1d652a8..f4cce08 100644 --- a/CHANGELOG +++ b

[lng-odp] [PATCHv3 1/2] changelog: summary of changes for odp v1.12.0.0

2016-11-21 Thread Maxim Uvarov
From: Bill Fischofer Signed-off-by: Bill Fischofer Signed-off-by: Maxim Uvarov --- CHANGELOG | 211 ++ 1 file changed, 211 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 1d652a8..25d1375 100644 --- a/CHANGELOG +++ b

[lng-odp] [PATCHv3 2/2] configure.ac update version numbers

2016-11-21 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index be5a292..3880b19 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ AC_PREREQ([2.5]) # Set correct API version

[lng-odp] [PATCHv3 0/2] changelog: summary of changes for odp v1.12.0.0

2016-11-21 Thread Maxim Uvarov
Updated Bills patch to 1.12 version and alse update .so version numbers. Bill Fischofer (1): changelog: summary of changes for odp v1.12.0.0 Maxim Uvarov (1): configure.ac update version numbers CHANGELOG| 211 +++ configure.ac

Re: [lng-odp] [PATCHv2] changelog: summary of changes for odp v1.11.1.0

2016-11-19 Thread Maxim Uvarov
Anders, can you please send proposal patch for changing versions? I think it will be more easy to discuss it if we will have some working patch. I also looked to numbering issue one more time and think that it will be good to have version in both abi and not abi compact library. Our origina

Re: [lng-odp] [PATCHv2] changelog: summary of changes for odp v1.11.1.0

2016-11-18 Thread Maxim Uvarov
On 11/18/16 22:52, Anders Roxell wrote: On 18 November 2016 at 01:34, Bill Fischofer wrote: Signed-off-by: Bill Fischofer --- Changes for v2: - Changed release level to v1.11.1.0 per Mike CHANGELOG | 211 ++ 1 file changed, 211 in

Re: [lng-odp] [PATCH] travis: linux-gen: add dpdk pktio

2016-11-18 Thread Maxim Uvarov
On 11/18/16 22:29, Anders Roxell wrote: On 18 November 2016 at 14:05, Maxim Uvarov wrote: On 11/18/16 12:06, Anders Roxell wrote: On 7 November 2016 at 16:49, Maxim Uvarov wrote: Turn on linux-generic dpdk and pcap pktios with their validation tests. Signed-off-by: Maxim Uvarov

[lng-odp] [PATCH] test: tm: do lookup first then open

2016-11-18 Thread Maxim Uvarov
First tests will open pktio and all others will look up handle by name. Change order of open/lookup to not call fail opens. Signed-off-by: Maxim Uvarov --- .../validation/api/traffic_mngr/traffic_mngr.c| 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git

Re: [lng-odp] [PATCH v2] travis.yml: add coverity support

2016-11-18 Thread Maxim Uvarov
ok, let's leave that. Maybe later we will have some code in user guide also On 18 November 2016 at 22:13, Mike Holmes wrote: > I toyed with that and fell on cut and paste simple becasue I was not > able to make a variable that would span the scope. > > > On 18 November

Re: [lng-odp] [PATCH v2] travis.yml: add coverity support

2016-11-18 Thread Maxim Uvarov
On 11/18/16 21:34, Mike Holmes wrote: Enables static analysis when pushing to a branch coverity_scan on github See https://scan.coverity.com/travis_ci Signed-off-by: Mike Holmes --- v2: Include all the executables in the scan (Maxim) .travis.yml | 20 +++- 1 file changed,

Re: [lng-odp] [PATCH] travis: linux-gen: add dpdk pktio

2016-11-18 Thread Maxim Uvarov
Merged. On 11/17/16 22:56, Mike Holmes wrote: On 7 November 2016 at 10:49, Maxim Uvarov wrote: Turn on linux-generic dpdk and pcap pktios with their validation tests. Signed-off-by: Maxim Uvarov Reviewed-by: Mike Holmes We need to make this complete and add netmap pktio to cover all the

Re: [lng-odp] [PATCH] test: linux-gen: mmap_vlan_ins change bin to test programs

2016-11-18 Thread Maxim Uvarov
Merged, Maxim. On 11/18/16 19:49, Mike Holmes wrote: On 17 November 2016 at 10:44, Maxim Uvarov wrote: Generated binaries should be marked as test programs to be installed by autotools in test directory. Signed-off-by: Maxim Uvarov Reviewed-by: Mike Holmes --- test/linux-generic

Re: [lng-odp] [PATCH] changelog: summary of changes for odp v1.10.2.0

2016-11-18 Thread Maxim Uvarov
I think Monarch branch with his changelog changes has to be merged in master. Then this changes will update version to v1.11.0.0 And after that current changelog updates version to v1.11.1.0 Please see structure here: https://git.linaro.org/people/maxim.uvarov/odp.git/log/ (gitk or git log --

Re: [lng-odp] [PATCH] test: linux-gen: mmap_vlan_ins change bin to test programs

2016-11-18 Thread Maxim Uvarov
ping, please review. Maxim. On 11/17/16 18:44, Maxim Uvarov wrote: Generated binaries should be marked as test programs to be installed by autotools in test directory. Signed-off-by: Maxim Uvarov --- test/linux-generic/mmap_vlan_ins/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1

Re: [lng-odp] [PATCH] travis: linux-gen: add dpdk pktio

2016-11-18 Thread Maxim Uvarov
On 11/18/16 12:06, Anders Roxell wrote: On 7 November 2016 at 16:49, Maxim Uvarov wrote: Turn on linux-generic dpdk and pcap pktios with their validation tests. Signed-off-by: Maxim Uvarov --- .travis.yml | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff

[lng-odp] [PATCH] test: linux-gen: mmap_vlan_ins change bin to test programs

2016-11-17 Thread Maxim Uvarov
Generated binaries should be marked as test programs to be installed by autotools in test directory. Signed-off-by: Maxim Uvarov --- test/linux-generic/mmap_vlan_ins/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/linux-generic/mmap_vlan_ins/Makefile.am b

Re: [lng-odp] [API-NEXT PATCH v3 00/19] pool optimization

2016-11-17 Thread Maxim Uvarov
sometimes, most times not. It happens both at the tip of the master and api-next. -Petri -Original Message- From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Wednesday, November 16, 2016 10:03 PM To: Bill Fischofer ; Savolainen, Petri (Nokia - FI/Espoo) ; Mike Holmes Cc: lng-odp

Re: [lng-odp] [API-NEXT PATCH v3 00/19] pool optimization

2016-11-17 Thread Maxim Uvarov
our case 'pktio_main' binary rolls in infinite loop. So I would say it's different issues. Maxim. -Original Message- From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Wednesday, November 16, 2016 10:03 PM To: Bill Fischofer ; Savolainen, Petri (Nokia - FI/Espoo) ; M

Re: [lng-odp] [API-NEXT PATCH v3 00/19] pool optimization

2016-11-17 Thread Maxim Uvarov
I can not test patch by patch this series because it fails (one time it was TM, one time kernel died, other time OOM killer killed tests then hang kernel). And for all patches test/common_plat/validation/api/pktio/pktio_main hangs forever: Program received signal SIGINT, Interrupt. 0x2a

Re: [lng-odp] [API-NEXT PATCH 0/5] name argument definitions in *_create() functions

2016-11-17 Thread Maxim Uvarov
Merged, Maxim. On 11/16/16 13:43, Elo, Matias (Nokia - FI/Espoo) wrote: Ping. This patch set has been reviewed and tested. Reviewed-and-tested-by: Bill Fischofer > Reviewed-by: Petri Savolainen > On 24 Oct 2016, at 13:44,

[lng-odp] mail list issues

2016-11-16 Thread Maxim Uvarov
Hello, we have some mailing list issues. If your did not get response on some email please check that email appeared in archive: https://lists.linaro.org/pipermail/lng-odp/ If not, please send it again. I hope it will be fixed very soon. Maxim.

Re: [lng-odp] [API-NEXT PATCH v3 17/19] api: packet: added limits for packet len on alloc

2016-11-11 Thread Maxim Uvarov
On 11/11/16 13:50, Savolainen, Petri (Nokia - FI/Espoo) wrote: + /** Maximum packet length that will be allocated from + the pool. The maximum value is defined by pool + capability pkt.max_len. Use 0 for default (the +

Re: [lng-odp] [PATCH 1/2] api: crypto: Adding crypto authentication algorithm

2016-11-11 Thread Maxim Uvarov
patch has to be prefixed with API-NEXT PATCH On 11 November 2016 at 11:27, Balakrishna Garapati < balakrishna.garap...@linaro.org> wrote: > Signed-off-by: Balakrishna Garapati > --- > include/odp/api/spec/crypto.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/include/odp/api/spe

Re: [lng-odp] [API-NEXT PATCH 1/3] drv: shm: function to query for physical addresses

2016-11-10 Thread Maxim Uvarov
On 11/10/16 20:21, Christophe Milard wrote: The capability "can_getphy" is introduced and tells whether physical address queries are available. The function odpdrv_getphy() is added to query for physical address (from virtual address) Signed-off-by: Christophe Milard --- include/odp/drv/spec/

Re: [lng-odp] [API-NEXT PATCH v3 17/19] api: packet: added limits for packet len on alloc

2016-11-10 Thread Maxim Uvarov
On 11/10/16 14:07, Petri Savolainen wrote: There's no use case for application to allocate zero length packets. Application should always have some knowledge about the new packet data length before allocation. Also implementations are more efficient when a check for zero length is avoided. Also

Re: [lng-odp] [ODP] about schedule sp

2016-11-10 Thread Maxim Uvarov
Hello Xiaowen, For now we have 2 types of scheduler in linux-generic implementation. Strict priority scheduler can be compiled in with --enable-schedule-sp to configure. SP scheduler is optimized for low latency processing of high priority events (not for for throughput). Best regards, Maxim.

Re: [lng-odp] [PATCHv4] linux-generic: add vlan insertion test

2016-11-09 Thread Maxim Uvarov
Merged, Maxim. On 11/08/16 21:45, Mike Holmes wrote: On 8 November 2016 at 09:55, Maxim Uvarov <mailto:maxim.uva...@linaro.org>> wrote: linux-generic packet mmap has separate function to put back vlan tags which stripped out by linux kernel. This test is to add code cov

[lng-odp] [PATCHv4] linux-generic: add vlan insertion test

2016-11-08 Thread Maxim Uvarov
linux-generic packet mmap has separate function to put back vlan tags which stripped out by linux kernel. This test is to add code coverage for this function with receiving vlan traffic from veth device. Signed-off-by: Maxim Uvarov --- v4: add check for root test/linux-generic/Makefile.am

Re: [lng-odp] [API-NEXT PATCHv2 4/5] linux-gen: implementation of odp_load_driver function

2016-11-08 Thread Maxim Uvarov
On 11/08/16 17:15, Christophe Milard wrote: On 8 November 2016 at 15:06, Maxim Uvarov wrote: are there any system for linux-generic platform where dlopen is not supported? I think that we don't need ifdefs. Are you saying we should limit us to plain linux? including the test?? I am not s

Re: [lng-odp] [API-NEXT PATCHv2 3/5] api: init: driver load function added

2016-11-08 Thread Maxim Uvarov
On 11/08/16 17:09, Christophe Milard wrote: On 8 November 2016 at 14:56, Maxim Uvarov wrote: On 11/07/16 14:15, Christophe Milard wrote: Function added on the north API to load drivers. Signed-off-by: Christophe Milard --- include/odp/api/spec/init.h | 16 1 file

Re: [lng-odp] [API-NEXT PATCHv2 5/5] test: adding test for driver load function

2016-11-08 Thread Maxim Uvarov
On 11/07/16 14:15, Christophe Milard wrote: Trying to fix a proper structure for driver tests in the hard world of autotools: Staticaly linked drivers fails with autotools as the linker would need the "--whole-archive" option which autotools cannot handle. Trying to used ltdl lib does not seem to

Re: [lng-odp] [API-NEXT PATCHv2 4/5] linux-gen: implementation of odp_load_driver function

2016-11-08 Thread Maxim Uvarov
are there any system for linux-generic platform where dlopen is not supported? I think that we don't need ifdefs. Maxim. On 11/07/16 14:15, Christophe Milard wrote: Implementation of the driver loading function, of north API Signed-off-by: Christophe Milard --- configure.ac

Re: [lng-odp] [API-NEXT PATCHv2 3/5] api: init: driver load function added

2016-11-08 Thread Maxim Uvarov
On 11/07/16 14:15, Christophe Milard wrote: Function added on the north API to load drivers. Signed-off-by: Christophe Milard --- include/odp/api/spec/init.h | 16 1 file changed, 16 insertions(+) diff --git a/include/odp/api/spec/init.h b/include/odp/api/spec/init.h index

[lng-odp] shared odp lib and threads creation

2016-11-07 Thread Maxim Uvarov
Hello, I added basic ODP input support for Suricata here: https://github.com/muvarov/suricata and now I think how it's better to resolve things with threads. Problem is that when we did dpdk port dpdk run it's workers at early init stage. Then called function passed as call back and dpdk work

[lng-odp] [PATCH] travis: linux-gen: add dpdk pktio

2016-11-07 Thread Maxim Uvarov
Turn on linux-generic dpdk and pcap pktios with their validation tests. Signed-off-by: Maxim Uvarov --- .travis.yml | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 0d1add3..1092cd0 100644 --- a/.travis.yml +++ b

[lng-odp] [PATCH] example: packet: correct size print

2016-11-07 Thread Maxim Uvarov
looks like typo in print, delete it. Signed-off-by: Maxim Uvarov --- example/packet/pktio_run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/example/packet/pktio_run.sh b/example/packet/pktio_run.sh index 3adb2d6..fe6c505 100755 --- a/example/packet/pktio_run.sh +++ b

Re: [lng-odp] [PATCH v2 2/2] add travis.yml for gitub automation

2016-11-07 Thread Maxim Uvarov
Merged, Maxim. On 10/28/16 19:24, Mike Holmes wrote: On 28 October 2016 at 10:16, Maxim Uvarov <mailto:maxim.uva...@linaro.org>> wrote: Mike, all crypto tests failed for me. On laptop I have "Version: 1.0.1f-1ubuntu2.19" which is about the same as Travis u

Re: [lng-odp] [PATCHv2] linux-gen: crypto: fix aes gcm decryption

2016-11-07 Thread Maxim Uvarov
Merged, Maxim. On 11/04/16 19:21, Krishna Garapati wrote: Reviewed-by: Balakrishna Garapati <mailto:balakrishna.garap...@linaro.org>> /Krishna On 31 October 2016 at 15:53, Maxim Uvarov <mailto:maxim.uva...@linaro.org>> wrote: On 31 October 2016 at 17:51, Maxim Uvaro

Re: [lng-odp] [PATCHv2 1/1] validation: classification: fix TCP/UDP checksum update

2016-11-03 Thread Maxim Uvarov
ping, please review. Maxim. On 10/27/16 16:00, Balasubramanian Manoharan wrote: Fixes https://bugs.linaro.org/show_bug.cgi?id=2512 Signed-off-by: Balasubramanian Manoharan --- v2: Incorporates review comments .../api/classification/odp_classification_common.c | 14 +- .

Re: [lng-odp] [API-NEXT PATCHv6 2/5] linux-generic: packet: implement splice/reference apis

2016-11-02 Thread Maxim Uvarov
On 10/11/16 06:45, Bill Fischofer wrote: + +odp_packet_t odp_packet_ref(odp_packet_t pkt, uint32_t offset) +{ + odp_packet_t refpkt; + + if (pkt == ODP_PACKET_INVALID || offset >= odp_packet_len(pkt)) + return ODP_PACKET_INVALID; + + refpkt = odp_packet_alloc(odp_p

[lng-odp] [PATCHv3] linux-generic: add vlan insertion test

2016-11-02 Thread Maxim Uvarov
linux-generic packet mmap has separate function to put back vlan tags which stripped out by linux kernel. This test is to add code coverage for this function with receiving vlan traffic from veth device. Signed-off-by: Maxim Uvarov --- v3: - do not point from tests to examples. (Christophe

Re: [lng-odp] Deterministic Random Data in ODP

2016-11-02 Thread Maxim Uvarov
why random_r() can not be used for implementation? On 2 November 2016 at 17:27, Bill Fischofer wrote: > Background: > > The odp_random_data() API is currently being refined [1] to deprecate the > confusing use_entropy parameter in favor of an enum (odp_random_kind_t) > that specifies the kind of

Re: [lng-odp] [PATCHv2] linux-generic: add vlan insertion test

2016-11-01 Thread Maxim Uvarov
On 1 November 2016 at 12:43, Christophe Milard wrote: > On 31 October 2016 at 20:53, Maxim Uvarov wrote: > > Use vlan tagged traffic for example validation test > > to add code coverage for pkt_mmap_vlan_insert() internal > > function. > > > > Signed-off-

Re: [lng-odp] [RFC 1/4] timer: add odp_timer_pool_res()

2016-11-01 Thread Maxim Uvarov
_capabilities() to match other functions. On 25 October 2016 at 10:38, Brian Brooks wrote: > On 10/31 17:20:27, Bill Fischofer wrote: > > I've added this to tomorrow's ODP call to discuss, however some general > > comments: > > > > 1. These should be marked [RFC API-NEXT PATCH] so that Patchwor

[lng-odp] [PATCHv2] linux-generic: add vlan insertion test

2016-10-31 Thread Maxim Uvarov
Use vlan tagged traffic for example validation test to add code coverage for pkt_mmap_vlan_insert() internal function. Signed-off-by: Maxim Uvarov --- v2: update to current master. test/common_plat/validation/api/.gitignore | 1 + test/linux-generic/Makefile.am | 5 test

Re: [lng-odp] [PATCHv2] linux-gen: crypto: fix aes gcm decryption

2016-10-31 Thread Maxim Uvarov
On 31 October 2016 at 17:51, Maxim Uvarov wrote: > We should first initialize, then set up decryption > and only then push blocks for decryption. > https://bugs.linaro.org/show_bug.cgi?id=2571 > > Signed-off-by: Maxim Uvarov > --- > v2: clear reworking > > rewording

[lng-odp] [PATCHv2] linux-gen: crypto: fix aes gcm decryption

2016-10-31 Thread Maxim Uvarov
We should first initialize, then set up decryption and only then push blocks for decryption. https://bugs.linaro.org/show_bug.cgi?id=2571 Signed-off-by: Maxim Uvarov --- v2: clear reworking btw, it was tested here: https://s3.amazonaws.com/archive.travis-ci.org/jobs/171998583/log.txt

[lng-odp] [PATCH] linux-gen: crypto: fix aes gcm decryption

2016-10-31 Thread Maxim Uvarov
We should first initialize, then set up decryption also and only then push blocks for decryption. https://bugs.linaro.org/show_bug.cgi?id=2571 Signed-off-by: Max Uvarov Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [lng-odp] [PATCH v2 2/2] add travis.yml for gitub automation

2016-10-31 Thread Maxim Uvarov
will send a fix in few minutes :) Maxim. On 10/31/16 17:18, Maxim Uvarov wrote: I did test if the latest 1.1.1-dev ssl from github (master branch for today). And the same tests fail. Log is attached. Maxim. On 10/28/16 19:24, Mike Holmes wrote: On 28 October 2016 at 10:16, Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCHv6 05/13] api: shm: add flags to shm_reserve and function to find external mem

2016-10-31 Thread Maxim Uvarov
Petri, please review API patch. On 10/31/16 11:52, Christophe Milard wrote: The ODP_SHM_SINGLE_VA flag is created: when set (at odp_shm_reserve()), this flag guarantees that all ODP threads sharing this memory block will see the block at the same address (regadless of ODP thread type -pthread

Re: [lng-odp] [PATCH v2 2/2] add travis.yml for gitub automation

2016-10-28 Thread Maxim Uvarov
On 10/28/16 19:24, Mike Holmes wrote: On 28 October 2016 at 10:16, Maxim Uvarov <mailto:maxim.uva...@linaro.org>> wrote: Mike, all crypto tests failed for me. On laptop I have "Version: 1.0.1f-1ubuntu2.19" which is about the same as Travis uses. Do you

Re: [lng-odp] driver test autotools issue

2016-10-28 Thread Maxim Uvarov
On 10/28/16 16:58, Christophe Milard wrote: Hi, The ODP driver development is does not progress due to an autotool problem to which I didn't find any nice solution: INTRODUCTION: ODP will be given the possibility to "include" user space NIC drivers. By "include", I mean either staticaly linked

Re: [lng-odp] [PATCH v2 2/2] add travis.yml for gitub automation

2016-10-28 Thread Maxim Uvarov
Mike, all crypto tests failed for me. On laptop I have "Version: 1.0.1f-1ubuntu2.19" which is about the same as Travis uses. Do you see the same errors? Get:2 http://us-central1.gce.archive.ubuntu.com/ubuntu/ precise-updates/main libssl-dev amd64 1.0.1-4ubuntu5.38 [1,581 kB] Get:3 http://us

Re: [lng-odp] [PATCH] example: l3fwd: prevent possible use of uninitialised variables

2016-10-28 Thread Maxim Uvarov
Merged, Maxim. On 10/27/16 17:04, Bill Fischofer wrote: On Thu, Oct 27, 2016 at 8:42 AM, Matias Elo wrote: Fixes bug https://bugs.linaro.org/show_bug.cgi?id=2564 Signed-off-by: Matias Elo Reviewed-by: Bill Fischofer --- example/l3fwd/odp_l3fwd.c | 4 +++- 1 file changed, 3 insertio

Re: [lng-odp] [PATCH 1/2] test: perf: add new ordered pktio application

2016-10-27 Thread Maxim Uvarov
On 10/27/16 16:51, Elo, Matias (Nokia - FI/Espoo) wrote: Ping. On 11 Oct 2016, at 16:21, Matias Elo wrote: Add new test application for ordered queue functionality and performance validation. The application sets sequence numbers to incoming packets using ordered pktin queues and ordered con

Re: [lng-odp] [PATCH 1/2] test: perf: add new ordered pktio application

2016-10-27 Thread Maxim Uvarov
On 10/27/16 16:51, Elo, Matias (Nokia - FI/Espoo) wrote: + "Usage: %s OPTIONS\n" >+ " E.g. %s -i eth0,eth1 -t 1\n" >+ " In the above example,\n" >+ " eth0 will send pkts to eth1 and vice versa\n" >+ " eth2 will send pkts to eth3 and vice versa\n"

Re: [lng-odp] [PATCH] linux-generic: packet: add fall through comments to parser

2016-10-27 Thread Maxim Uvarov
On 10/27/16 10:56, Elo, Matias (Nokia - FI/Espoo) wrote: Reviewed-by: Matias Elo On 26 Oct 2016, at 15:47, Bill Fischofer wrote: Address bug https://bugs.linaro.org/show_bug.cgi?id=2565 by adding comments to the parser's switch statement to document the fact that fall through is intentional.

[lng-odp] [PATCH] linux-gen: sysinfo: check for overflow

2016-10-27 Thread Maxim Uvarov
In near future cpu mhz more likely will not overflow 64 bit value, but it makes sense to add assert for overflow check. https://bugs.linaro.org/show_bug.cgi?id=2425 Signed-off-by: Maxim Uvarov --- platform/linux-generic/arch/x86/odp_sysinfo_parse.c | 7 ++- 1 file changed, 6 insertions

Re: [lng-odp] [PATCH] linux-generic: config: add missing doxygen documentation for abi macros

2016-10-27 Thread Maxim Uvarov
Merged, Maxim. On 10/19/16 18:01, Mike Holmes wrote: On 19 October 2016 at 08:09, Bill Fischofer wrote: Fix Bug https://bugs.linaro.org/show_bug.cgi?id=2553 by adding missing doxygen documentation for the internal macros ODP_ABI_COMPAT and _STATIC. Signed-off-by: Bill Fischofer Reviewed-by:

Re: [lng-odp] [PATCH] linux-generic: fix ISO C compiling issue with -Werror=pedantic

2016-10-26 Thread Maxim Uvarov
Merged, Maxim. On 10/25/16 04:55, Bill Fischofer wrote: On Mon, Oct 24, 2016 at 2:02 AM, > wrote: From: Xuelin Shi mailto:forrest@linaro.org>> ISO C does not allow extra ‘;’ outside of a function. Signed-off-by: Xuelin Shi mailto:forrest@l

Re: [lng-odp] [PATCHv2] fix out of tree build

2016-10-26 Thread Maxim Uvarov
Merged, Maxim. On 10/26/16 00:05, Mike Holmes wrote: On 25 October 2016 at 16:28, Maxim Uvarov wrote: Commit: eebd6b0 configure: the version cannot use a script Did generation of version.h which is done in $dest_dir. Includes paths have to be corrected accordingly. Signed-off-by

[lng-odp] [PATCHv2] fix out of tree build

2016-10-25 Thread Maxim Uvarov
Commit: eebd6b0 configure: the version cannot use a script Did generation of version.h which is done in $dest_dir. Includes paths have to be corrected accordingly. Signed-off-by: Maxim Uvarov --- v2: build.sh in some combination did not pass on v1, fix it (Mike). example/Makefile.inc

[lng-odp] [PATCH] fix out of tree build

2016-10-25 Thread Maxim Uvarov
Commit: eebd6b0 configure: the version cannot use a script Did generation of version.h which is done in $dest_dir. Includes paths have to be corrected accordingly. Signed-off-by: Maxim Uvarov --- example/Makefile.inc | 3 ++- helper/Makefile.am | 1

Re: [lng-odp] [API-NEXT PATCHv2 1/3] api: dev: add device apis for numa support

2016-10-24 Thread Maxim Uvarov
On 10/24/16 22:56, Bill Fischofer wrote: Add the odp_dev_id() API used for NUMA support probably log also needs to be corrected with removing reference to NUMA. Maxim. Signed-off-by: Bill Fischofer --- Changes for v2: - Incorporate changes suggested by Petri include/odp/api/spec/dev.h |

Re: [lng-odp] [PATCH v2 1/2] configure: the version cannot use a script

2016-10-24 Thread Maxim Uvarov
first patch is merged with Brian review. Will test second patch tomorrow. Maxim. On 10/21/16 21:40, Mike Holmes wrote: Use of a script in the autotools breaks github CI Define the API version in configure and reuse it in the code Benefits: removes dependence on scripts to build removes script

Re: [lng-odp] [PATCH v3 1/5] example: l3fwd: add missing gitignores

2016-10-24 Thread Maxim Uvarov
Merged. On 10/21/16 17:31, Mike Holmes wrote: On 3 October 2016 at 07:49, Matias Elo wrote: Signed-off-by: Matias Elo Reviewed-by: Mike Holmes But I wonder if we should at some point ignore these in the root of odp/example and odp/test to save repeating them ? maybe even to global root.

Re: [lng-odp] [PATCH 1/3] linux-gen: packet: enable parsing only selected packet header layers

2016-10-24 Thread Maxim Uvarov
Merged, Maxim. On 10/24/16 14:48, Elo, Matias (Nokia - FI/Espoo) wrote: Ping. This patch set has been reviewed and tested. -Matias On 21 Sep 2016, at 22.36, Bill Fischofer mailto:bill.fischo...@linaro.org>> wrote: For this series: Reviewed-and-tested-by: Bill Fischofer mailto:bill.fischo.

Re: [lng-odp] [PATCHv3] test: skip pktio_perf tests on 1 and 2 cpus machines

2016-10-24 Thread Maxim Uvarov
Merged, Maxim. On 10/21/16 17:12, Mike Holmes wrote: On 14 October 2016 at 07:51, Maxim Uvarov wrote: Make check should skip the test instead of failing it. Test splits RX and TX cores for packet processing. Core 0 bind to control thread. So running machine should have at least 2 worker

<    4   5   6   7   8   9   10   11   12   13   >