On Aug 10 Nick said I actually really like hyphenated attributes, but I like
consistency better.. However, that doesn't imply that he is going to like
allowing '-' to appear anywhere and be stripped out. Providing aliases would
be a more sane way to do that.
Ralph
On Aug 16, 2013, at
[
https://issues.apache.org/jira/browse/LOG4J2-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory updated LOG4J2-361:
Attachment: log4j2-361.diff
Allow plugins to have hyphens in configuration files to be
For an implementation of allowing hyphens, please see the patch in
https://issues.apache.org/jira/browse/LOG4J2-361:
https://issues.apache.org/jira/secure/attachment/12598574/log4j2-361.diff
Note that there is no existing JSONConfigurationTest like there is an
XMLConfigurationTest.
Gary
On
Alright. Time to chime in I suppose, since I'm being quoted now. :-)
I like consistency. I like the same rules to apply to all parts of the
configuration. For example:
- If we decide that an element should be PascalCase, then they should ALL be
PascalCase.
- If we decide that an attribute
As an aside, the only sane way to create an XSD would be to generate it
like we generate the dat file.
Gary
On Sat, Aug 17, 2013 at 2:28 AM, Nick Williams
nicho...@nicholaswilliams.net wrote:
Alright. Time to chime in I suppose, since I'm being quoted now. :-)
I like consistency. I like
On Sat, Aug 17, 2013 at 1:41 AM, Ralph Goers ralph.go...@dslextreme.comwrote:
Yeah. StrLookup should be moved up to core.
I tried it and feels arbitrary when I look at all the subpackages and
wonder which of all the other interfaces should also be moved up.
If we had a specific .spi package
OK. In general I guess I agree with your philosophy. However, I consider
stripping/ignoring hyphens bad because then a-p-p-e-n-d-e-r-r-e-f
r-e-f=Console/ becomes valid. The ONLY reason I wanted aliases is because I
really believe users who are used to the other logging frameworks are
Or we could just make them all hyphenated, which is my preference. Then we
avoid the stripping you detest and the errors you're afraid our users will
commit. :-)
Nick
On Aug 17, 2013, at 1:38 AM, Ralph Goers wrote:
OK. In general I guess I agree with your philosophy. However, I consider
I guess what you are after is a way to make clear what are the interfaces and
classes developers can use when creating their own components. I originally
planned on those being in the main core package but I clearly didn't include
everything that could be there. Unfortunately, this is one of
Dancing angels and pin heads:
Yep, the patch I provided allows for a-p-p-e-n-d-e-r-r-e-f
r-e-f=Console/ but the point is that is allows appender-ref
ref=Console
But! the current code also allows ApPeNdeRrEf ref=Console/
How is that any better/worse, more/less confusing?
BTW, are attributes
The way I've seen this done in Java is to use a package called .spi, the
Service Provider Interface package. Internal stuff is in .internal
packages (which Eclipse uses a lot). When you import something from a
.internal package, you know you're not on solid ground. I've also seen
.impl packages,
On Aug 17, 2013, at 1:48 AM, Gary Gregory wrote:
Dancing angels and pin heads:
Yep, the patch I provided allows for a-p-p-e-n-d-e-r-r-e-f r-e-f=Console/
but the point is that is allows appender-ref ref=Console
But! the current code also allows ApPeNdeRrEf ref=Console/
A fantastic
That doesn't really help much. I find the syntax below oddly annoying. What is
strange is that I don't really mind it when there is only a single '-'
character but when there is more than one I find it irritating - especially
with size-based-triggering-policy. I can't tell you how many times I
Yup. You are correct that the mixed case does allow something just as stupid.
Yes, attributes are also case insensitive. See BaseConfiguration.getAttrValue().
Ralph
On Aug 16, 2013, at 11:48 PM, Gary Gregory wrote:
Dancing angels and pin heads:
Yep, the patch I provided allows for
On Aug 17, 2013, at 1:54 AM, Ralph Goers wrote:
That doesn't really help much. I find the syntax below oddly annoying. What
is strange is that I don't really mind it when there is only a single '-'
character but when there is more than one I find it irritating - especially
with
Well then, I suppose we could move things like Configurator and Configuration
to the core package and then move all the sub packages under internal, but
that just seems like a lot of busy work when we could just as easily declare in
a read me that everything in any sub package is internal.
On
On Aug 16, 2013, at 11:58 PM, Nick Williams wrote:
On Aug 17, 2013, at 1:54 AM, Ralph Goers wrote:
That doesn't really help much. I find the syntax below oddly annoying. What
is strange is that I don't really mind it when there is only a single '-'
character but when there is more than
On Aug 17, 2013, at 2:01 AM, Ralph Goers wrote:
On Aug 16, 2013, at 11:58 PM, Nick Williams wrote:
On Aug 17, 2013, at 1:54 AM, Ralph Goers wrote:
That doesn't really help much. I find the syntax below oddly annoying. What
is strange is that I don't really mind it when there is only
On Sat, Aug 17, 2013 at 2:59 AM, Ralph Goers ralph.go...@dslextreme.comwrote:
Well then, I suppose we could move things like Configurator and
Configuration to the core package and then move all the sub packages under
internal, but that just seems like a lot of busy work when we could just
as
On Sat, Aug 17, 2013 at 3:07 AM, Nick Williams
nicho...@nicholaswilliams.net wrote:
On Aug 17, 2013, at 2:01 AM, Ralph Goers wrote:
On Aug 16, 2013, at 11:58 PM, Nick Williams wrote:
On Aug 17, 2013, at 1:54 AM, Ralph Goers wrote:
That doesn't really help much. I find the syntax below
On Aug 17, 2013, at 2:24 AM, Gary Gregory wrote:
On Sat, Aug 17, 2013 at 3:07 AM, Nick Williams
nicho...@nicholaswilliams.net wrote:
On Aug 17, 2013, at 2:01 AM, Ralph Goers wrote:
On Aug 16, 2013, at 11:58 PM, Nick Williams wrote:
On Aug 17, 2013, at 1:54 AM, Ralph Goers wrote:
OK - so it sounds like LOG4J2-360 is going to get closed as Will not fix. I
am pretty sure LOG4J2-361 will as well.
Ralph
On Aug 16, 2013, at 11:57 PM, Ralph Goers wrote:
Yup. You are correct that the mixed case does allow something just as stupid.
Yes, attributes are also case
Yeah. That is what package-info.java is for isn't it? Today we are pretty
terse.
Ralph
On Aug 17, 2013, at 12:21 AM, Gary Gregory wrote:
On Sat, Aug 17, 2013 at 2:59 AM, Ralph Goers ralph.go...@dslextreme.com
wrote:
Well then, I suppose we could move things like Configurator and
ApPeNdeRrEf may look visually as confusing as a-p-p-e-n-d-e-r-r-e-f r-e-f,
but that is not the point.
I think the rule config files are case-insensite is much a more intuitive
rule than all hyphens are stripped from attribute and element names.
To me, the -ref extension in the appender-ref
[
https://issues.apache.org/jira/browse/LOG4J2-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Williams resolved LOG4J2-358.
--
Resolution: Fixed
Fixed in next release. You can also get the latest from trunk and compile
That's a tricky one. Well done!
(Much better than me: I'm on day two of my struggle with LOG4J2-315 and not
making much progress... :-)
On Sat, Aug 17, 2013 at 5:17 PM, Nick Williams
nicho...@nicholaswilliams.net wrote:
Solved it!
And you're never gonna believe what I learned
[
https://issues.apache.org/jira/browse/LOG4J2-315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma updated LOG4J2-315:
---
Attachment: log4j2.xml
ResultStats.java
Still struggling with this. Not sure if the
Detective Nick is one the case! :) Do those other projects use third
party line for this or roll their own?
Gary
On Aug 17, 2013, at 4:17, Nick Williams nicho...@nicholaswilliams.net wrote:
Solved it!
And you're never gonna believe what I learned tonight...(well, maybe you will)
I solved
So I think Remko and I agree that consistency is good but that there are two
cases where exceptions should be made. If I commit the change to alias those
two things is anyone so strongly against it that they would veto it? If not
then I would like to commit it.
Ralph
On Aug 17, 2013, at
Remko Popma created LOG4J2-362:
--
Summary: Add a diagram to the site that explains when to use which
jar
Key: LOG4J2-362
URL: https://issues.apache.org/jira/browse/LOG4J2-362
Project: Log4j 2
[
https://issues.apache.org/jira/browse/LOG4J2-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma updated LOG4J2-253:
---
Attachment: whichjar.png
attached whichjar.png initial version
Add a
[
https://issues.apache.org/jira/browse/LOG4J2-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma updated LOG4J2-253:
---
Attachment: (was: whichjar.png)
Add a FAQ/Troubleshooting page to the site?
[
https://issues.apache.org/jira/browse/LOG4J2-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma updated LOG4J2-253:
---
Comment: was deleted
(was: attached whichjar.png initial version)
Add a FAQ/Troubleshooting
I will support the commit. I have to admit, I do like the strictness of it. It
allows appender-ref while disallowing a-p-p-e-n-d-e-r--r-e-f, which is as
close to strict schema compliance that I think I'm going to get anyone to agree
to. :-)
But we must document the heck out of it and we must
[
https://issues.apache.org/jira/browse/LOG4J2-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma updated LOG4J2-362:
---
Attachment: whichjar.png
attached whichjar.png initial version
Add a diagram to
[
https://issues.apache.org/jira/browse/LOG4J2-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742934#comment-13742934
]
Nick Williams commented on LOG4J2-362:
--
That diagram is extremely clear and helpful,
YuCheng, LOG4J2-358 has been filed and fixed now. You can compile from trunk
immediately to get the fixes for both bugs (including LOG4J2-330, which was
fixed a few weeks ago), or you can wait for the next version to come out.
Shouldn't be to much longer now.
N
On Aug 14, 2013, at 2:10 AM,
[
https://issues.apache.org/jira/browse/LOG4J2-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742939#comment-13742939
]
Remko Popma commented on LOG4J2-362:
Ah, thanks Nick! I'll update in a few minutes.
[
https://issues.apache.org/jira/browse/LOG4J2-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma updated LOG4J2-362:
---
Attachment: whichjar-slf4j.png
attached whichjar-slf4j.png initial version
Add a
I am ok with an alias feature.
Like this?
@pluginElement(names=a, b, c)
Gary
On Aug 17, 2013, at 10:19, Ralph Goers rgo...@apache.org wrote:
So I think Remko and I agree that consistency is good but that there are
two cases where exceptions should be made. If I commit the change to alias
[
https://issues.apache.org/jira/browse/LOG4J2-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma updated LOG4J2-362:
---
Attachment: whichjar-slf4j-1.png
whichjar-1.png
attached whichjar-1.jar and
Nope.
- String name() in @Plugin (for element-mapped plugin classes) becomes String[]
names(). Annotation can be used @Plugin(names = element) for single-worders
or @Plugin(names = { elementName, element-name }) for multi-worders.
- String value() in @PluginAttr (for attribute-mapped method
Ok that's a standard use of annotations. Looks good.
Gary
On Aug 17, 2013, at 10:57, Nick Williams nicho...@nicholaswilliams.net wrote:
Nope.
- String name() in @Plugin (for element-mapped plugin classes) becomes
String[] names(). Annotation can be used @Plugin(names = element) for
[
https://issues.apache.org/jira/browse/LOG4J2-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742948#comment-13742948
]
Nick Williams commented on LOG4J2-362:
--
Looks better!
I think JIRA allows you to
[
https://issues.apache.org/jira/browse/LOG4J2-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742949#comment-13742949
]
Remko Popma edited comment on LOG4J2-362 at 8/17/13 3:07 PM:
-
[
https://issues.apache.org/jira/browse/LOG4J2-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742950#comment-13742950
]
Remko Popma commented on LOG4J2-362:
Nick, I only see Delete as possible action for
[
https://issues.apache.org/jira/browse/LOG4J2-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742955#comment-13742955
]
Nick Williams commented on LOG4J2-362:
--
There are actually several feature requests
As part of the build, a plugin database file is generated and included in
the core jar. The file is called Log4j2Plugins.dat and it is located in the
org.apache.logging.log4j.core.config.plugins package. It is in binary
format and contains all classes that define plugins that could be found
during
On Aug 17, 2013, at 10:28 AM, Remko Popma wrote:
As part of the build, a plugin database file is generated and included in the
core jar. The file is called Log4j2Plugins.dat and it is located in the
org.apache.logging.log4j.core.config.plugins package. It is in binary format
and contains
This isn't quite what I did but I can certainly change it if you think what you
have below is better. @Plugin and @PluginAttr are unchanged. @PluginAliases
allows you to specify one or more aliases as
@PluginAliases(appender-ref)
or
@PluginAliases({appender-ref, AppenderReference})
You
PluginManager uses ResolverUtil to scan. By default, it only scans for classes
in org.apache.logging.log4j.core. However, the packages attribute on the
configuration element allows you to specify more packages. In addition.
PluginManager's addPackage method can be called for other packages.
I do see the upside to how you do it, but at the same time annotating a method
parameter with BOTH annotations is going to get messy. Hmmm...
I'm not sure what I think. How important is being able to search for plugins
with aliases?
N
On Aug 17, 2013, at 10:45 AM, Ralph Goers wrote:
This
Keep in mind, I added the Log4j2Plugins.dat because classpath scanning was so
slow. This would still be done for users who create their own plugins but don't
provide a Log4j2Plugins.dat file, so finding a faster method could be
worthwhile.
Ralph
On Aug 17, 2013, at 8:44 AM, Nick Williams
I will just upload what I currently have as a patch to the Jira issue and then
you can take a look. I don't think it is all that messy myself.
Ralph
On Aug 17, 2013, at 8:52 AM, Nick Williams wrote:
I do see the upside to how you do it, but at the same time annotating a
method parameter
We should document how the PluginManager class can be used to generate the
Log42Plugins.dat file, and how the packages attribute works.
Maybe in Manual Extending Log4j Custom Plugins? That section is
currently empty...
On Sun, Aug 18, 2013 at 12:57 AM, Ralph Goers
[
https://issues.apache.org/jira/browse/LOG4J2-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ralph Goers updated LOG4J2-360:
---
Attachment: LOG4J2-360.patch
Patch to add PluginAliases annotation.
Allow Plugins
I've added it to LOG4J2-360.
Ralph
On Aug 17, 2013, at 8:59 AM, Ralph Goers wrote:
I will just upload what I currently have as a patch to the Jira issue and
then you can take a look. I don't think it is all that messy myself.
Ralph
On Aug 17, 2013, at 8:52 AM, Nick Williams wrote:
I believe both already are documented
Sent from my iPhone
On Aug 17, 2013, at 9:02 AM, Remko Popma remko.po...@gmail.com wrote:
We should document how the PluginManager class can be used to generate the
Log42Plugins.dat file, and how the packages attribute works.
Maybe in Manual Extending
Ah. Manual Plugins... I missed that.
I'd like to add something that explains how to use PluginManager to
generate the Log42Plugins.dat file without using Maven.
On Sun, Aug 18, 2013 at 1:27 AM, Ralph Goers ralph.go...@dslextreme.comwrote:
I believe both already are documented
Sent from my
Who knows enough about RFC 5424 to check on this patch?
Gary
On Fri, Aug 16, 2013 at 11:50 AM, Tibor Benke (JIRA) j...@apache.orgwrote:
[
https://issues.apache.org/jira/browse/LOG4J2-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
Tibor Benke updated
Me
Sent from my iPhone
On Aug 17, 2013, at 9:48 AM, Gary Gregory garydgreg...@gmail.com wrote:
Who knows enough about RFC 5424 to check on this patch?
Gary
On Fri, Aug 16, 2013 at 11:50 AM, Tibor Benke (JIRA) j...@apache.org wrote:
[
Umm, guys? Nobody ever put the logo contest on the homepage. No wonder
we only have one submission so far!
I don't have access to do this that I know of. Someone needs to update it ASAP!
Nick
Sent from my iPhone, so please forgive brief replies and frequent typos
smime.p7s
Description: S/MIME
62 matches
Mail list logo
