Juergen Spitzmueller wrote:
So it seems that in the crash scenario the cursor is entering the inset in
some illegal way.
No. The problem is that bv_funcs::coordOffset calls cursorPos() for all
insets. This triggers the assertion in insetcollapsable, because cursorPos()
should not be called
Alex == Alex [EMAIL PROTECTED] writes:
Alex Dear All, I would like to ask when the 1.3.7 version is going to
Alex be released?
Alex I am doing the localisation based 1.3.7.pot file. I have to
Alex complete 777 of 2806. Almost all the Qt strings are translated,
Alex but just a few for xforms.
On Mon, 2005-11-07 at 08:02 +0100, Juergen Spitzmueller wrote:
Martin Vermeer wrote:
207 BOOST_ASSERT(status() != Collapsed);
Question: why does this _normally_ not trigger an assert, even if the
inset is closed? And why does it when coming directly from a mathinset?
On Mon, 2005-11-07 at 09:44 +0100, Juergen Spitzmueller wrote:
Juergen Spitzmueller wrote:
So it seems that in the crash scenario the cursor is entering the inset in
some illegal way.
No. The problem is that bv_funcs::coordOffset calls cursorPos() for all
insets. This triggers the
Martin Vermeer wrote:
1. Don't call cursorPos() from coordOffset when the inset is not
HIGHLY_EDITABLE (which is also the case when collapsables are collapsed).
See attached patch #1.
I like this patch. Still wondering though, does it address the
underlying problem (whatever that is)? At
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Martin Vermeer wrote:
1. Don't call cursorPos() from coordOffset when the inset is not
HIGHLY_EDITABLE (which is also the case when collapsables are
collapsed). See attached patch #1.
I like this patch. Still wondering
This patch also removes my crash. :-)
Helge Hafting
Jean-Marc Lasgouttes wrote:
Juergen AFAICS yes. The problem is, as far as I can see, the invalid
Juergen call of cursorPos, which should be prohibited in any case.
I like the patch too, but what I do not like is that, as I feared
earlier, autoOpen does interact with the rest of the code in
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Jean-Marc Lasgouttes wrote: Thanks for the explanation.
And does the patch work for you?
Juergen Yes.
I committed it.
JMarc
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
Can this go in? I have a good feeling about it.
Martin Ping...
Oh, I thought it was already in. I think it can go in, but I have a
question first. Please pardon me if it has already be beaten to death,
I did not follow the various
Juergen Spitzmueller wrote:
Helge Hafting wrote:
Crash recipe 1:
1. insert-math panel
2. insert a matrix of default size using the panel
3. select the matrix using the mouse
4. insert delimiters around the matrix
5. Get this crash as you press ok in the delimiter dialog:
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
If selectionEnd is resize to go oustside an inset, the pos at top
level has to be incremented, so that the inset is in the selection.
Look at the comment in the anchor() method.
Martin OK, point taken. Better patch attached.
This looks
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen there's currently a small bug with ert labels: they don't
Juergen show the ert's content if the cursor was inside the ert while
Juergen closing it. I think this is a side-effect of the auto-open
Juergen feature. The attached patch
On Mon, 2005-11-07 at 12:34 +0100, Jean-Marc Lasgouttes wrote:
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
Can this go in? I have a good feeling about it.
Martin Ping...
Oh, I thought it was already in. I think it can go in, but I have a
question first. Please pardon me if it
On Mon, 2005-11-07 at 12:40 +0100, Jean-Marc Lasgouttes wrote:
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
If selectionEnd is resize to go oustside an inset, the pos at top
level has to be incremented, so that the inset is in the selection.
Look at the comment in the anchor()
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
Martin The patch is IMO good enough for 1.4 and we should not now
Martin spend time on refinement, though your idea is actually very
Martin good, I think.
Now, that's diplomacy! How could I say anything else than,
``apply it''? :)
JMarc
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
Also, could you update the code in drawSelection (both versions
just in case) to use directly selectionBegin/End?
Martin Like this?
Exactly. If it actually works, please commit.
JMarc
[EMAIL PROTECTED] [EMAIL PROTECTED] writes:
Dear Developers,
LATEX/LYX is used very often in science to write publications. Most of the
time there is not only one author, but two or more. Has anyone thought
about a possibility of real-time collaborative editing in LYX? This
On Mon, 2005-11-07 at 14:25 +0100, Jean-Marc Lasgouttes wrote:
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
Also, could you update the code in drawSelection (both versions
just in case) to use directly selectionBegin/End?
Martin Like this?
Exactly. If it actually works, please
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
Martin In case you wondered, yes I did try it out ;-)
It was just in case :)
JMarc
On Mon, 2005-11-07 at 15:23 +0100, Jean-Marc Lasgouttes wrote:
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
Martin In case you wondered, yes I did try it out ;-)
It was just in case :)
It's in now.
- Martin
signature.asc
Description: This is a digitally signed message part
On Mon, 2005-11-07 at 14:24 +0100, Jean-Marc Lasgouttes wrote:
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
Martin The patch is IMO good enough for 1.4 and we should not now
Martin spend time on refinement, though your idea is actually very
Martin good, I think.
Now, that's
On Thu, Nov 03, 2005 at 06:01:53PM +0200, Martin Vermeer wrote:
On Thu, 2005-11-03 at 15:07 +0100, Jean-Marc Lasgouttes wrote:
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
- do any font change (e.g. C-b) == crash
Martin No it doesn't. Not with this fix.
I understand that.
Juergen Spitzmueller wrote:
I think you should apply it.
I'll do so.
Unfortunately, it turned out that the fix had some side-effects: it breaks
coord calculation for nested math insets (e.g. grid insets), because they are
not HIGHLY_EDITABLE (why actually?).
The attached patch fixes it.
On Mon, 2005-11-07 at 14:24 +0100, Jean-Marc Lasgouttes wrote:
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
Martin The patch is IMO good enough for 1.4 and we should not now
Martin spend time on refinement, though your idea is actually very
Martin good, I think.
Now, that's
Juergen Spitzmueller wrote:
Unfortunately, it turned out that the fix had some side-effects: it breaks
coord calculation for nested math insets (e.g. grid insets), because they
are not HIGHLY_EDITABLE (why actually?).
The attached patch fixes it.
Can I apply it?
I'll be away until
On Mon, Nov 07, 2005 at 10:56:11AM +0200, Martin Vermeer wrote:
Question: shouldn't the paragraph(s) inside a collapsed inset be absent
from the paragraph cache?
In theory yes, in practice we somehow scan too often through collapsed
insets with all kind of fancy functions (setting cursor on
On Sat, Nov 05, 2005 at 08:10:39AM +0200, Martin Vermeer wrote:
On Fri, Nov 04, 2005 at 11:11:06PM +0100, Jean-Marc Lasgouttes wrote:
Martin == Martin Vermeer [EMAIL PROTECTED] writes:
Martin I don't understand this at all.
You mean what I wrote above?
I mean especially Aren't you
Attached.
BTW I saw one more near-replica of the outerFont code in text2.C.
Shouldn't we unify this stuff? This reminds me of the human genome ;-)
- Martin
Index: text2.C
===
RCS file:
I'm back!
Bug 2124: When using a \frac, the cursor always appears to the left of
the environment.
Description: When using a \frac environment, regardless of whether
typing in the upper or lower box, the cursor always appears as if the
text were to be typed before the fraction. This behaviour has
Juergen Spitzmueller wrote:
> So it seems that in the crash scenario the cursor is entering the inset in
> some illegal way.
No. The problem is that bv_funcs::coordOffset calls cursorPos() for all
insets. This triggers the assertion in insetcollapsable, because cursorPos()
should not be called
> "Alex" == Alex <[EMAIL PROTECTED]> writes:
Alex> Dear All, I would like to ask when the 1.3.7 version is going to
Alex> be released?
Alex> I am doing the localisation based 1.3.7.pot file. I have to
Alex> complete 777 of 2806. Almost all the Qt strings are translated,
Alex> but just a few
On Mon, 2005-11-07 at 08:02 +0100, Juergen Spitzmueller wrote:
> Martin Vermeer wrote:
> > 207 BOOST_ASSERT(status() != Collapsed);
> >
> > Question: why does this _normally_ not trigger an assert, even if the
> > inset is closed? And why does it when coming directly from a mathinset?
On Mon, 2005-11-07 at 09:44 +0100, Juergen Spitzmueller wrote:
> Juergen Spitzmueller wrote:
> > So it seems that in the crash scenario the cursor is entering the inset in
> > some illegal way.
>
> No. The problem is that bv_funcs::coordOffset calls cursorPos() for all
> insets. This triggers
Martin Vermeer wrote:
> > 1. Don't call cursorPos() from coordOffset when the inset is not
> > HIGHLY_EDITABLE (which is also the case when collapsables are collapsed).
> > See attached patch #1.
>
> I like this patch. Still wondering though, does it address the
> underlying problem (whatever that
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Martin Vermeer wrote:
>> > 1. Don't call cursorPos() from coordOffset when the inset is not
>> > HIGHLY_EDITABLE (which is also the case when collapsables are
>> collapsed). > See attached patch #1.
>>
>> I like this
This patch also removes my crash. :-)
Helge Hafting
Jean-Marc Lasgouttes wrote:
> Juergen> AFAICS yes. The problem is, as far as I can see, the invalid
> Juergen> call of cursorPos, which should be prohibited in any case.
>
> I like the patch too, but what I do not like is that, as I feared
> earlier, autoOpen does interact with the rest of the
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote: Thanks for the explanation.
>> And does the patch work for you?
Juergen> Yes.
I committed it.
JMarc
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>> Can this go in? I have a good feeling about it.
Martin> Ping...
Oh, I thought it was already in. I think it can go in, but I have a
question first. Please pardon me if it has already be beaten to death,
I did not follow the various
Juergen Spitzmueller wrote:
Helge Hafting wrote:
Crash recipe 1:
1. insert->math panel
2. insert a matrix of default size using the panel
3. select the matrix using the mouse
4. insert delimiters around the matrix
5. Get this crash as you press ok in the delimiter dialog:
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>> If selectionEnd is resize to go oustside an inset, the pos at top
>> level has to be incremented, so that the inset is in the selection.
>> Look at the comment in the anchor() method.
Martin> OK, point taken. Better patch attached.
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> there's currently a small bug with ert labels: they don't
Juergen> show the ert's content if the cursor was inside the ert while
Juergen> closing it. I think this is a side-effect of the auto-open
Juergen> feature. The
On Mon, 2005-11-07 at 12:34 +0100, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> >> Can this go in? I have a good feeling about it.
>
> Martin> Ping...
>
> Oh, I thought it was already in. I think it can go in, but I have a
> question first.
On Mon, 2005-11-07 at 12:40 +0100, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> >> If selectionEnd is resize to go oustside an inset, the pos at top
> >> level has to be incremented, so that the inset is in the selection.
> >> Look at the comment
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> The patch is IMO good enough for 1.4 and we should not now
Martin> spend time on refinement, though your idea is actually very
Martin> good, I think.
Now, that's diplomacy! How could I say anything else than,
``apply it''? :)
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>> Also, could you update the code in drawSelection (both versions
>> just in case) to use directly selectionBegin/End?
Martin> Like this?
Exactly. If it actually works, please commit.
JMarc
[EMAIL PROTECTED] <[EMAIL PROTECTED]> writes:
>
> Dear Developers,
>
> LATEX/LYX is used very often in science to write publications. Most of the
> time there is not only one author, but two or more. Has anyone thought
> about a possibility of real-time collaborative editing in
On Mon, 2005-11-07 at 14:25 +0100, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> >> Also, could you update the code in drawSelection (both versions
> >> just in case) to use directly selectionBegin/End?
>
> Martin> Like this?
>
> Exactly. If it
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> In case you wondered, yes I did try it out ;-)
It was just in case :)
JMarc
On Mon, 2005-11-07 at 15:23 +0100, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> In case you wondered, yes I did try it out ;-)
>
> It was just in case :)
It's in now.
- Martin
signature.asc
Description: This is a digitally signed
On Mon, 2005-11-07 at 14:24 +0100, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> The patch is IMO good enough for 1.4 and we should not now
> Martin> spend time on refinement, though your idea is actually very
> Martin> good, I think.
>
>
On Thu, Nov 03, 2005 at 06:01:53PM +0200, Martin Vermeer wrote:
> On Thu, 2005-11-03 at 15:07 +0100, Jean-Marc Lasgouttes wrote:
> > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
> >
> > >> - do any font change (e.g. C-b) ==> crash
> >
> > Martin> No it doesn't. Not with this fix.
Juergen Spitzmueller wrote:
> > I think you should apply it.
>
> I'll do so.
Unfortunately, it turned out that the fix had some side-effects: it breaks
coord calculation for nested math insets (e.g. grid insets), because they are
not HIGHLY_EDITABLE (why actually?).
The attached patch fixes
On Mon, 2005-11-07 at 14:24 +0100, Jean-Marc Lasgouttes wrote:
> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> Martin> The patch is IMO good enough for 1.4 and we should not now
> Martin> spend time on refinement, though your idea is actually very
> Martin> good, I think.
>
>
Juergen Spitzmueller wrote:
> Unfortunately, it turned out that the fix had some side-effects: it breaks
> coord calculation for nested math insets (e.g. grid insets), because they
> are not HIGHLY_EDITABLE (why actually?).
>
> The attached patch fixes it.
>
> Can I apply it?
I'll be away until
On Mon, Nov 07, 2005 at 10:56:11AM +0200, Martin Vermeer wrote:
> Question: shouldn't the paragraph(s) inside a collapsed inset be absent
> from the paragraph cache?
In theory yes, in practice we somehow scan too often through collapsed
insets with all kind of fancy functions (setting cursor on
On Sat, Nov 05, 2005 at 08:10:39AM +0200, Martin Vermeer wrote:
> On Fri, Nov 04, 2005 at 11:11:06PM +0100, Jean-Marc Lasgouttes wrote:
> > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
> >
> > Martin> I don't understand this at all.
> >
> > You mean what I wrote above?
>
> I
Attached.
BTW I saw one more near-replica of the outerFont code in text2.C.
Shouldn't we unify this stuff? This reminds me of the human genome ;-)
- Martin
Index: text2.C
===
RCS file:
I'm back!
Bug 2124: When using a \frac, the cursor always appears to the left of
the environment.
Description: When using a \frac environment, regardless of whether
typing in the upper or lower box, the cursor always appears as if the
text were to be typed before the fraction. This behaviour has
60 matches
Mail list logo
