Re: Road to rc2 - fixIfBroken

2007-06-10 Thread Andre Poenitz
On Sat, Jun 09, 2007 at 12:49:09PM +0200, Stefan Schimanski wrote: > It works fine (as far as I can judge after 2 minutes testing). I > added some comments and pulled apart the loop to make the control > flow easier. Alfredo, can you check please? I would be happy if we > could get rid of the

Re: [patch] fixing segfault because of empty coord cache

2007-06-10 Thread Stefan Schimanski
I can't tell you. It is conceptionally sound, however, so close to 1.5.0 it might be more prudent to use something like The old behavior is simpler than I thought. A search for isActive basically shows that there is no math inset (other than the InsetMathMBox, which just return true, and I

Re: [patch] fixing segfault because of empty coord cache

2007-06-10 Thread Andre Poenitz
On Sat, Jun 09, 2007 at 09:37:31AM +0300, Martin Vermeer wrote: > On Fri, Jun 08, 2007 at 08:22:42PM +0200, Jean-Marc Lasgouttes wrote: > > > "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: > > > > Stefan> Critical bugs don't get less critical by ignorance. If anybody > > Stefan> wan

Re: Road to rc2

2007-06-10 Thread Andre Poenitz
On Fri, Jun 08, 2007 at 10:40:45PM +0200, [EMAIL PROTECTED] wrote: > On Fri, 8 Jun 2007, José Matos wrote: > > >On Friday 08 June 2007 16:59:35 [EMAIL PROTECTED] wrote: > >>In Sweden, June 22nd would be a bad choice because it's a big holiday - > >>everybody is off. I'll be in the archipelago for

Re: [PATCH] Add bypass validation checkboxes to dialogs that enter listings parameters

2007-06-10 Thread Bo Peng
- In the Listings dialog, the "Bypass validation" checkbox should go to the "Avanced" tab. Furthermore, it lacks an accelerator and a tooltip (in all three dialogs). Sorry, I know they are supposed to be easy, but I do not know qt well enough to add accelerator and tooltips. I guess you can add

Re: Suggested improvements for LyX macros

2007-06-10 Thread Jürgen Spitzmüller
Stefan Schimanski wrote: > http://www.youtube.com/watch?v=68Gys4rp3u4 This looks pretty impressing! Jürgen

Re: [PATCH] Add bypass validation checkboxes to dialogs that enter listings parameters

2007-06-10 Thread Jürgen Spitzmüller
I like the approach in general. Some comments: - In the Listings dialog, the "Bypass validation" checkbox should go to the "Avanced" tab. Furthermore, it lacks an accelerator and a tooltip (in all three dialogs). - toggling this checkbox doesn't have an immediate effect (in alle three dialogs)

Re: Suggested improvements for LyX macros

2007-06-10 Thread Stefan Schimanski
Please take a look at my new macro implementation: http://www.youtube.com/watch?v=68Gys4rp3u4 Make it fullscreen while watching to see what's going on. Some points you give should be solved by that. Stefan Am 11.06.2007 um 06:36 schrieb Mark Kortink: Hi Below are some suggestions for imp

Re: LyX document-build process

2007-06-10 Thread Angus Leeming
John Pye wrote: As I argued above, LyX contains *its own* build system: it defines tools and file transformations, dependency tracking and caching. Because it contains all of these things internally it makes using it within an external build system much more difficult that it should be. I think

Suggested improvements for LyX macros

2007-06-10 Thread Mark Kortink
Hi Below are some suggestions for improving macros in LyX. As a user it has taken many hours of going through the poor user documentation and various LaTeX manuals and editors trying to figure out how to get them working and then why they don't work, very frustrating! Hopefully these suggestions

Re: [PATCH] Bug 3711, add insets without valid ParConstIterator to TOC.

2007-06-10 Thread Angus Leeming
Abdelrazak Younes wrote: Bo Peng wrote: Per the use of exception, I think exception should be used more often in lyx. LyX's code base is not exception safe. The code hasn't been written with exception safety in mind, largely because we weren't proficient in the use of exceptions. (I certainl

Re: Window-independent dialogs

2007-06-10 Thread Angus Leeming
Stefan Schimanski wrote: Hi! Is there a reason that the non-modal dialogs (like to edit tables, change text styles etc.) depend on the LyX window? You can open another one for every window which is open. It's somehow strange and confusing to have a text style dialog, but it "doesn't work" bec

Crashing when pressing enter...

2007-06-10 Thread Alexander Streit
Hi Guys, I'm using the 1.5RC1 release (released May 31). On the Mac (PowerPC architecture) the table of contents pane simply doesn't show, so I'm using my windows machine instead. But that is not why I am writing. I am writing because I get a consistent crash when I try to press enter to insert a

Re: LyX document-build process

2007-06-10 Thread John Pye
Hi Andre, Thanks for these comments. More follows: Andre Poenitz wrote: > On Tue, Jun 05, 2007 at 09:52:49PM +1000, John Pye wrote: > >> Sorry for a bit of a delay on this one. I thought I would follow up with >> some comments though. >> >> Firstly, >> >> Jean-Marc Lasgouttes wrote: [...] >

Re: SV: [PATCH] Change default mathbg and add mathhoverbg.

2007-06-10 Thread Andre Poenitz
On Fri, Jun 08, 2007 at 06:25:16PM +0200, Leuven, E. wrote: > > I toss M$ Word because, among other overly clever features, it changes > > i to I all the time. > > (before we used the big nasty wolf to scare people, now it is the big nasty > M$) > > > I would object, in general, any *automatic

Re: [PATCH] Change default mathbg and add mathhoverbg.

2007-06-10 Thread Andre Poenitz
On Fri, Jun 08, 2007 at 10:38:05AM -0500, Bo Peng wrote: > > even if it's possible it doesn't mean it is advisable or even desirable > > I toss M$ Word because, among other overly clever features, it changes > i to I all the time. I would object, in general, any *automatic* > changes to what I ent

Re: [PATCH] Change default mathbg and add mathhoverbg.

2007-06-10 Thread Andre Poenitz
On Fri, Jun 08, 2007 at 10:23:21AM -0500, Bo Peng wrote: > > The objection to this was because it implied to another data member to > > the > >inset. Is there a solution that does not imply this? > > Only mathhull has this mouse_hover_ variable so it is less a problem > than the inset backgroun

Re: [patch] fixing segfault because of empty coord cache

2007-06-10 Thread Andre Poenitz
On Fri, Jun 08, 2007 at 05:03:55PM +0200, Stefan Schimanski wrote: > Critical bugs don't get less critical by ignorance. > > If anybody wants to know more: > > 1) CommandInset (used e.g. for references in mathed) has two cells to > hold information about where it points to. But it only draws a

Re: [PATCH] Change default mathbg and add mathhoverbg.

2007-06-10 Thread Andre Poenitz
On Fri, Jun 08, 2007 at 03:53:58PM +0100, José Matos wrote: > On Friday 08 June 2007 15:51:33 Leuven, E. wrote: > > so the inset should be dissolved when these are entered...? > > It seems more intuitive, no? And an ő on a line of its own doesn't make much sense either. Not even in Hungary. So I

Re: [PATCH] Change default mathbg and add mathhoverbg.

2007-06-10 Thread Andre Poenitz
On Fri, Jun 08, 2007 at 04:51:33PM +0200, Leuven, E. wrote: > Bo Peng wrote: > >> what is the point of $ $ and $\ $ ? > > > > A method to force extra spaces, and more likely, entered by accident > > (and then it is impossible to remove them). > > so the inset should be dissolved when these are en

Re: [PATCH] get rid of Inset::background_color_

2007-06-10 Thread Andre Poenitz
On Fri, Jun 08, 2007 at 11:16:49AM +0200, Jean-Marc Lasgouttes wrote: > > This rather straightforward patch gets rid of Inset::background_color_, > which adds 4 bytes to Inset for no good reason. > > If there is _really_ a need for setBackgroundColor, we could consider > moving it to InsetText in

Re: SV: [PATCH] Change default mathbg and add mathhoverbg.

2007-06-10 Thread Edwin Leuven
Jean-Marc Lasgouttes wrote: Edwin> sure, perhaps latex permits this but when would you want to Edwin> create an empty math inset? There are always people who have good reasons to do weird things. Which should not artificially forbid constructs. we wouldn't, there is ert ... signing off on th

Re: [PATCH] Add bypass validation checkboxes to dialogs that enter listings parameters

2007-06-10 Thread Bo Peng
I think we only need to support official releases, but if you insist, I will do something with lyx2lyx. Attached please find an updated patch with lyx2lyx support for RC1. OK to apply? Cheers, Bo Index: src/insets/InsetListingsParams.h =

Re: [patch] bug 3835: inset-toggle doesn't work for branch insets

2007-06-10 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> The attached patch fixes it for Bennett and me. Martin cannot Jürgen> remeber why he put the removed test there in the first place, Jürgen> but I didn't find any drawbacks. Looks good. JMarc

Re: SV: [PATCH] Change default mathbg and add mathhoverbg.

2007-06-10 Thread Jean-Marc Lasgouttes
> "Edwin" == Leuven, E <[EMAIL PROTECTED]> writes: Edwin> Jean-Marc Lasgouttes wrote: >> It is completely different: dEPM disallows things that have _no_ >> meaning to LaTeX (like double space). And empty math inset is >> acceptable, even if it is most of the times not wanted. Edwin> sure, pe

Re: [patch] bug 3835: inset-toggle doesn't work for branch insets

2007-06-10 Thread Martin Vermeer
On Sun, Jun 10, 2007 at 12:05:47PM +0200, Jürgen Spitzmüller wrote: > Martin Vermeer wrote: > > Did you try save/reload to see if only branch insets for > > the selected branch(es) are open? (vague recollection) > > Yes. This still works. Great. Then I suspect I did unthinking cut'n paste from so

Re: [PATCH] Add bypass validation checkboxes to dialogs that enter listings parameters

2007-06-10 Thread Bo Peng
> If some parameter is > acceptable by 1.5.2, but not 1.5.0, a user will be in trouble only > when he use GUI to edit the inset. In this case, he can use this > bypass button. What happens if he doesn't? An error message? Then the parameter will be used without problem because they are not vali

Re: [patch] Huge fonts do not set the row height, #3787

2007-06-10 Thread Alfredo Braunstein
Stefan Schimanski wrote: >> I would add a comment saying that the fontmetrics variable is >> outdated once >> you change 'font'. Otherwise there's the risk we hit this bug again >> and >> again... > > I make a copy now. So it should be clear. I think it's obvious that even better. > the fontmet

Re: [patch] Huge fonts do not set the row height, #3787

2007-06-10 Thread Stefan Schimanski
Am 10.06.2007 um 17:12 schrieb Alfredo Braunstein: Alfredo Braunstein wrote: if (maxsize > font.size()) { + // use standard paragraph font with the maximal size font.setSize(maxsize); - maxasc = max(maxasc, fontmetrics.maxAscent()); -

Re: [patch] Huge fonts do not set the row height, #3787

2007-06-10 Thread Alfredo Braunstein
Alfredo Braunstein wrote: if (maxsize > font.size()) { + // use standard paragraph font with the maximal size font.setSize(maxsize); - maxasc = max(maxasc, fontmetrics.maxAscent()); - maxdesc = max(maxdesc, fontmetrics.maxDescent(

Re: Road to rc2

2007-06-10 Thread Stefan Schimanski
- What are the patches submitted that you think deserve attention? I would like to give special attention to critical bugs and so on... I have posted several patches which are waiting to go in or a comment why not: * [patch] sometimes only paragraph of cursor is visible, #323

Re: Bug #3812: Comments on patch

2007-06-10 Thread Jürgen Spitzmüller
Alfredo Braunstein wrote: > This patch looks fine. committed now. Jürgen

Re: Bug #3812: Comments on patch

2007-06-10 Thread Alfredo Braunstein
Jürgen Spitzmüller wrote: > Jürgen Spitzmüller wrote: >> On a second thought, you might be right. The attached patch does what you >> propose and works for me. >> >> OK to apply? > > This patch also fixes bug 3160: > http://bugzilla.lyx.org/show_bug.cgi?id=3160 This patch looks fine. Regards,

Re: [PATCH] Add bypass validation checkboxes to dialogs that enter listings parameters

2007-06-10 Thread Jürgen Spitzmüller
Bo Peng wrote: > Parameters are *not* validated so the file can be compiled as long as > a user is using a capable listings package. That's a progress indeed. > If some parameter is > acceptable by 1.5.2, but not 1.5.0, a user will be in trouble only > when he use GUI to edit the inset. In this

Re: [patch] Huge fonts do not set the row height, #3787

2007-06-10 Thread Alfredo Braunstein
Jürgen Spitzmüller wrote: > Stefan Schimanski wrote: >> Bug: http://bugzilla.lyx.org/show_bug.cgi?id=3787 >> Problem: Changing the font does not change the fontmetrics variable. >> Patch: > > Looks good and works for me. The patch seems trivially correct. The only thing that bothers me is that t

Re: [PATCH] Add bypass validation checkboxes to dialogs that enter listings parameters

2007-06-10 Thread Bo Peng
This is not true. You need to change the file format, because if people open such a file with an older version that doesn't have this checkbox, LyX will crash. Let us just forget about RC1, which is meant to be experimental. 1.5.0 ==> 1.4.x Current lyx2lyx translate listings to ERT. No problem

Re: [patch] bug 3835: inset-toggle doesn't work for branch insets

2007-06-10 Thread Jürgen Spitzmüller
Martin Vermeer wrote: > Did you try save/reload to see if only branch insets for > the selected branch(es) are open? (vague recollection) Yes. This still works. Jürgen

Re: [patch] bug 3835: inset-toggle doesn't work for branch insets

2007-06-10 Thread Martin Vermeer
On Sun, Jun 10, 2007 at 09:31:19AM +0200, Jürgen Spitzmüller wrote: > The attached patch fixes it for Bennett and me. Martin cannot remeber why he > put the removed test there in the first place, but I didn't find any > drawbacks. > > OK? > > Jürgen Did you try save/reload to see if only branc

Re: Bug #3812: Comments on patch

2007-06-10 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > On a second thought, you might be right. The attached patch does what you > propose and works for me. > > OK to apply? This patch also fixes bug 3160: http://bugzilla.lyx.org/show_bug.cgi?id=3160 Jürgen

Re: invoices

2007-06-10 Thread Jürgen Spitzmüller
Ralph Boland wrote: > I am looking for a simple package to do a couple of invoices only. > One option is to use invoice.sty > I don't know latex but I do know lyx. > So, one option is to create an invoice.layout file. > But I don't know how to create a layout file. > > Is there documentation on how

Re: 1.5 RC1 crashes on show Outline

2007-06-10 Thread Jürgen Spitzmüller
Ramon Ramos wrote: > 1.5 RC1 crashes with the msg: > Assertion triggered in const lyx::docstring lyx::from_ascii(const char*) > by failing check "static_cast(*c) < >  0x80" in file docstring.cpp:32 > Abortado This bug 3793: http://bugzilla.lyx.org/show_bug.cgi?id=3793 It's fixed in the meantime.

Re: 1.5 RC1 crashes on show Outline

2007-06-10 Thread Stefan Schimanski
Am 10.06.2007 um 10:38 schrieb Ramon Ramos: Hi, 1.5 RC1 crashes with the msg: Assertion triggered in const lyx::docstring lyx::from_ascii(const char*) by failing check "static_cast(*c) < 0x80" in file docstring.cpp:32 Abortado always when I want to show the outline (TOC). Now I am using 1

1.5 RC1 crashes on show Outline

2007-06-10 Thread Ramon Ramos
Hi, 1.5 RC1 crashes with the msg: Assertion triggered in const lyx::docstring lyx::from_ascii(const char*) by failing check "static_cast(*c) < 0x80" in file docstring.cpp:32 Abortado always when I want to show the outline (TOC). Now I am using 1.5 beta3 again Regards, Ramón

Re: Bug #3812: Comments on patch

2007-06-10 Thread Jürgen Spitzmüller
Michael Gerz wrote: > Maybe I was talking nonsense. I just looked at the patch (without the > surrounding code). It looked like you check for the first character and > then match(...) tries to match the complete string. On a second thought, you might be right. The attached patch does what you pro

Re: [PATCH] Add bypass validation checkboxes to dialogs that enter listings parameters

2007-06-10 Thread Jürgen Spitzmüller
Bo Peng wrote: > In this patch, I add a check box 'bypass validation' that will allow > any listings parameters to be passed to lyx/latex if this checkboz is > checked. No file format is changed so no lyx2lyx is needed. This is not true. You need to change the file format, because if people open

[patch] bug 3835: inset-toggle doesn't work for branch insets

2007-06-10 Thread Jürgen Spitzmüller
The attached patch fixes it for Bennett and me. Martin cannot remeber why he put the removed test there in the first place, but I didn't find any drawbacks. OK? Jürgen Index: src/insets/InsetBranch.cpp === --- src/insets/InsetBranc

Re: r18728 - in /lyx-devel/trunk/src/insets: InsetListings.cp...

2007-06-10 Thread Jürgen Spitzmüller
Bo Peng wrote: > That is *too much* work! Hm, you only have to copy the Listings->ERT conversion you already have done to the 273->272 chain and add a check for @params. In the future, you will have to add a simple check that adds/removes @ for newly supported params (no ERT conversion necessar