Re: [patch] partial merging of CharStyle and InsetLayout handling

2007-08-18 Thread Richard Heck
Martin Vermeer wrote: On Sat, Aug 18, 2007 at 01:27:57AM -0400, Richard Heck wrote: Martin Vermeer wrote: Attached my attempt. I am a complete amateur with python and work with layout2layout also for the first time, so... does this make sense? FWIW it works. Well, I don't kn

Re: [Updated PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas

2007-08-18 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Abdelrazak Younes wrote: >> Abdelrazak Younes wrote: >>> Here is my most recent patch. What is not working yet: Btw, very nice design description. I think it is very useful. >>> - the close tab button: it is implemented but does not show up. >>> - the splash screen: it

Re: [PATCH-updated] Citation UI Improvements

2007-08-18 Thread Abdelrazak Younes
Richard Heck wrote: Attached is an updated patch. It's long, to be sure, but not really that complicated. A lot of it is really code re-organization that was made possible (and necessary) by the fact that we now have full-fledged classes where once there was just a collection of functions. So

Re: r19373 - in /lyx-devel/branches/personal/baum/BRANCH_1_4_...

2007-08-18 Thread Andre Poenitz
On Fri, Aug 17, 2007 at 09:41:08PM +0100, José Matos wrote: > On Thursday 09 August 2007 14:00:04 Georg Baum wrote: > > [EMAIL PROTECTED] wrote: > > > Author: baum > > > Date: Thu Aug 9 14:47:06 2007 > > > New Revision: 19373 > > > > > > URL: http://www.lyx.org/trac/changeset/19373 > > > Log: > >

Re: [patch] partial merging of CharStyle and InsetLayout handling

2007-08-18 Thread Andre Poenitz
On Sat, Aug 18, 2007 at 03:37:22AM -0400, Richard Heck wrote: > Martin Vermeer wrote: > >On Sat, Aug 18, 2007 at 01:27:57AM -0400, Richard Heck wrote: > > > >> Martin Vermeer wrote: > >> > >>>Attached my attempt. I am a complete amateur with python > >>>and work with layout2layout also for th

Re: [Updated PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas

2007-08-18 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: Abdelrazak Younes wrote: Abdelrazak Younes wrote: Here is my most recent patch. What is not working yet: Btw, very nice design description. I think it is very useful. Thanks. Don't hesitate to complement/modify it once it is in trunk. Ab

Re: [patch] remove bogust const semantics in DocIterator

2007-08-18 Thread Abdelrazak Younes
Alfredo Braunstein wrote: This the same concept as the previous post for CursorSlices. I personally agree with the two patches. Abdel.

Re: [patch] fix CursorSlice wrong const semantics

2007-08-18 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > // suppose we want the function to avoid touching the data > void somefun(CursorSlice const & a) > { > CursorSlice & b = a; Sorry, should be CursorSlice b = a; :-) > b.paragraph().erase(); > ... > } A/

make static linking default

2007-08-18 Thread Andre Poenitz
I guess, dynamic should be default on Linux, and static only default on Mac and Windows, but this way it compiles at least out-of-the-box. Andre' Index: configure.ac === --- configure.ac(revision 19626) +++ configure.ac

Re: [patch] remove bogust const semantics in DocIterator

2007-08-18 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Alfredo Braunstein wrote: >> This the same concept as the previous post for CursorSlices. > > I personally agree with the two patches. Thanks! I'll apply on monday if there are no objections. btw, we should implement good const semantics for CursorSlice, DocIterator a

build troubles (cmake)

2007-08-18 Thread Edwin Leuven
i am trying to compile lyx (cmake, msvc), but run into trouble. i don't do anything fancy (or different from before the summer) just run cmake in the standard way and point it to the gnuwin32 dir. but i get the messages below, someone got a clue what is going on here? thanks! ed. 2>-- B

Re: [Updated PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas

2007-08-18 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Here is a patch with this fix against latest trunk. > > Abdel. + void LyXView::setBuffer(Buffer * newBuffer) shouldn't this be called something like addBuffer ? A/

Re: [Updated PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas

2007-08-18 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: Here is a patch with this fix against latest trunk. Abdel. + void LyXView::setBuffer(Buffer * newBuffer) shouldn't this be called something like addBuffer ? It's between the two notions. It will indeed add a WorkArea if it does not curre

Re: [patch] partial merging of CharStyle and InsetLayout handling

2007-08-18 Thread Martin Vermeer
On Fri, Aug 17, 2007 at 09:28:44AM +0200, Jean-Marc Lasgouttes wrote: > > Err, this is not exactly what I wrote, is it? > > > InsetLayout const & TextClass::insetlayout(docstring const & name) const > > { > > - return insetlayoutlist_[name]; > > + docstring n = name; > > + while (!n.emp

Further inset configurability

2007-08-18 Thread Martin Vermeer
Steady progress, see patch. This would require a version bump in order to do properly: getting rid of InsetCharStyle's draw_label and use Collapsable's status_ for this purpose. I'll do this and commit later today if nobody objects (yes, everything still works ;-) - Martin

Re: build troubles (cmake)

2007-08-18 Thread Abdelrazak Younes
Edwin Leuven wrote: i am trying to compile lyx (cmake, msvc), but run into trouble. i don't do anything fancy (or different from before the summer) just run cmake in the standard way and point it to the gnuwin32 dir. but i get the messages below, someone got a clue what is going on here? tha

Re: build troubles (cmake)

2007-08-18 Thread Peter Kümmel
I assume a pch problem; try it again with the command line option -Dmerge=1. But there was a problem with version.cpp which is fixed now. You could also build without the IDE: devenv lyx-qt4.sln /build Release Now there is a simple batch file to rebuild a release version: call it from a build f

Re: build troubles (cmake)

2007-08-18 Thread Peter Kümmel
Abdelrazak Younes wrote: Edwin Leuven wrote: i am trying to compile lyx (cmake, msvc), but run into trouble. i don't do anything fancy (or different from before the summer) just run cmake in the standard way and point it to the gnuwin32 dir. but i get the messages below, someone got a clue w

Re: build troubles (cmake)

2007-08-18 Thread Peter Kümmel
Abdelrazak Younes wrote: Edwin Leuven wrote: i am trying to compile lyx (cmake, msvc), but run into trouble. i don't do anything fancy (or different from before the summer) just run cmake in the standard way and point it to the gnuwin32 dir. but i get the messages below, someone got a clue w

Re: build troubles (cmake)

2007-08-18 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Edwin Leuven wrote: i am trying to compile lyx (cmake, msvc), but run into trouble. i don't do anything fancy (or different from before the summer) just run cmake in the standard way and point it to the gnuwin32 dir. but i get the messages below,

Re: build troubles (cmake)

2007-08-18 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Edwin Leuven wrote: i am trying to compile lyx (cmake, msvc), but run into trouble. i don't do anything fancy (or different from before the summer) just run cmake in the standard way and point it to the gnuwin32 dir. but i get the messages below,

Re: r19631 - /lyx-devel/trunk/src/Paragraph.cpp

2007-08-18 Thread Alfredo Braunstein
[EMAIL PROTECTED] wrote: > +   Font * layoutfont; > if (pos < body_pos) > -   layoutfont = lout->labelfont; > +   layoutfont = &lout->labelfont; > else > -   layoutfont = lout->font; > +   layoutfont = &lout->font; > > Font font = getFontSetting

Re: r19631 - /lyx-devel/trunk/src/Paragraph.cpp

2007-08-18 Thread Abdelrazak Younes
Alfredo Braunstein wrote: [EMAIL PROTECTED] wrote: + Font * layoutfont; if (pos < body_pos) - layoutfont = lout->labelfont; + layoutfont = &lout->labelfont; else - layoutfont = lout->font; + layoutfont = &lout->font; Font font = get

Re: [Updated PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas

2007-08-18 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Alfredo Braunstein wrote: >> Abdelrazak Younes wrote: >> >>> Here is a patch with this fix against latest trunk. >>> >>> Abdel. >> >> + void LyXView::setBuffer(Buffer * newBuffer) >> >> shouldn't this be called something like addBuffer ? > > It's between the two noti

Re: [Updated PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas

2007-08-18 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: Alfredo Braunstein wrote: Abdelrazak Younes wrote: Here is a patch with this fix against latest trunk. Abdel. + void LyXView::setBuffer(Buffer * newBuffer) shouldn't this be called something like addBuffer ? It's between the two notions.

Re: Further inset configurability

2007-08-18 Thread Martin Vermeer
On Sat, Aug 18, 2007 at 03:09:30PM +0300, Martin Vermeer wrote: > Steady progress, see patch. > > This would require a version bump in order to do properly: > getting rid of InsetCharStyle's draw_label and use > Collapsable's status_ for this purpose. > > I'll do this and commit later today if no

Re: build troubles (cmake)

2007-08-18 Thread Andre Poenitz
On Sat, Aug 18, 2007 at 02:45:52PM +0200, Peter Kümmel wrote: > Abdelrazak Younes wrote: > >Edwin Leuven wrote: > >>i am trying to compile lyx (cmake, msvc), but run into trouble. > >> > >>i don't do anything fancy (or different from before the summer) just > >>run cmake in the standard way and po

Re: [Updated PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas

2007-08-18 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > I actually like this behavior. Why having a scrollbar if there is no > need for it? Exactly, but then the scrollbar pops up even if it is useless. ;-) A/

Re: [patch] remove bogust const semantics in DocIterator

2007-08-18 Thread Andre Poenitz
On Sat, Aug 18, 2007 at 12:54:56PM +0200, Alfredo Braunstein wrote: > Abdelrazak Younes wrote: > > > Alfredo Braunstein wrote: > >> This the same concept as the previous post for CursorSlices. > > > > I personally agree with the two patches. > > Thanks! I'll apply on monday if there are no objec

Re: build troubles (cmake)

2007-08-18 Thread Peter Kümmel
Andre Poenitz wrote: On Sat, Aug 18, 2007 at 02:45:52PM +0200, Peter Kümmel wrote: Abdelrazak Younes wrote: Edwin Leuven wrote: i am trying to compile lyx (cmake, msvc), but run into trouble. i don't do anything fancy (or different from before the summer) just run cmake in the standard way a

Re: [patch] remove bogust const semantics in DocIterator

2007-08-18 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Sat, Aug 18, 2007 at 12:54:56PM +0200, Alfredo Braunstein wrote: >> Abdelrazak Younes wrote: >> >> > Alfredo Braunstein wrote: >> >> This the same concept as the previous post for CursorSlices. >> > >> > I personally agree with the two patches. >> >> Thanks! I'll apply

Re: [Updated PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas

2007-08-18 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: I actually like this behavior. Why having a scrollbar if there is no need for it? Exactly, but then the scrollbar pops up even if it is useless. ;-) Year, that's the real bug :-) Abdel.

Re: build troubles (cmake)

2007-08-18 Thread Andre Poenitz
On Sat, Aug 18, 2007 at 04:02:23PM +0200, Peter Kümmel wrote: > In Modules/Platforms/UnixPaths.cmake I found this: > > SET(CMAKE_SYSTEM_PROGRAM_PATH ${CMAKE_SYSTEM_PROGRAM_PATH} > /bin /usr/bin /usr/local/bin /usr/pkg/bin /sbin > ) > > Maybe it helps to set CMAKE_SYSTEM_PROGRAM_PATH when call

Re: [patch] remove bogust const semantics in DocIterator

2007-08-18 Thread Andre Poenitz
On Sat, Aug 18, 2007 at 04:12:36PM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > On Sat, Aug 18, 2007 at 12:54:56PM +0200, Alfredo Braunstein wrote: > >> Abdelrazak Younes wrote: > >> > >> > Alfredo Braunstein wrote: > >> >> This the same concept as the previous post for CursorSli

Re: build troubles (cmake)

2007-08-18 Thread Edwin Leuven
Edwin Leuven wrote: but i get the messages below, someone got a clue what is going on here? great to go out for a stroll and find stuff fixed on my return. i still get this though: 1>c:\lyx\trunk\src\frontends\qt4\SearchAdv.h(17) : fatal error C1083: Cannot open include file: 'ui/SearchAdvUi

Re: build troubles (cmake)

2007-08-18 Thread Abdelrazak Younes
Edwin Leuven wrote: Edwin Leuven wrote: but i get the messages below, someone got a clue what is going on here? great to go out for a stroll and find stuff fixed on my return. i still get this though: These are not from trunk but on Tomaso's advanced search work. You should either revert y

Re: build troubles (cmake)

2007-08-18 Thread Andre Poenitz
On Sat, Aug 18, 2007 at 05:05:07PM +0200, Edwin Leuven wrote: > Edwin Leuven wrote: > >but i get the messages below, someone got a clue what is going on here? > > great to go out for a stroll and find stuff fixed on my return. > > i still get this though: > > 1>c:\lyx\trunk\src\frontends\qt4\Sea

Re: [patch] remove bogust const semantics in DocIterator

2007-08-18 Thread Alfredo Braunstein
Andre Poenitz wrote: > Okokok ;-) :-) A/

Re: Further inset configurability

2007-08-18 Thread Richard Heck
Martin Vermeer wrote: Steady progress, see patch. I tried but failed. rh -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ ==

Re: [PATCH-updated] Citation UI Improvements

2007-08-18 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: Attached is an updated patch. It's long, to be sure, but not really that complicated. A lot of it is really code re-organization that was made possible (and necessary) by the fact that we now have full-fledged classes where once there was just a col

Re: Further inset configurability

2007-08-18 Thread Martin Vermeer
On Sat, Aug 18, 2007 at 12:09:18PM -0400, Richard Heck wrote: > Martin Vermeer wrote: > > Steady progress, see patch. > > > I tried but failed. > > rh > Ok, let's try again ;-/ ("must have been good-looking cause he's so hard to see") - Martin Index: InsetCharStyle.h ==

Re: Further inset configurability

2007-08-18 Thread Martin Vermeer
On Sat, Aug 18, 2007 at 12:09:18PM -0400, Richard Heck wrote: > Martin Vermeer wrote: > > Steady progress, see patch. > > > I tried but failed. > > rh Here is the full, final patch of all parts. - Martin Index: development/FORMAT

Re: build troubles (cmake)

2007-08-18 Thread Edwin Leuven
Abdelrazak Younes wrote: These are not from trunk but on Tomaso's advanced search work. You should either revert your tree or update Tomaso's patch ;-) strangely the revert window in tortoisesvn was empty, but the files were trailing in the tree (and then cmake's globbing bit me in the bum)

Re: Further inset configurability

2007-08-18 Thread Richard Heck
This looks reasonable to me, though I haven't tested it. (I'm still obsessing over BibTeX stuff.) One suggestion: I think CharStyles should by default have an unobtrusive presentation, NOT with the label showing. The default presentation now (or previously?) gets particularly ugly if you try

layout2layout (Re: [patch] partial merging of CharStyle and InsetLayout handling)

2007-08-18 Thread Martin Vermeer
On Sat, Aug 18, 2007 at 12:19:20PM +0200, Andre Poenitz wrote: > On Sat, Aug 18, 2007 at 03:37:22AM -0400, Richard Heck wrote: > > Martin Vermeer wrote: > > >On Sat, Aug 18, 2007 at 01:27:57AM -0400, Richard Heck wrote: > > > > > >> Martin Vermeer wrote: > > >> > > >>>Attached my attempt. I a

Re: layout2layout (Re: [patch] partial merging of CharStyle and InsetLayout handling)

2007-08-18 Thread Richard Heck
Martin Vermeer wrote: I would surprise me if very old python versions would still work correctly for LyX. configure.ac seems to require 2.3, which definitely has +=. (But not i++, which would be even better) So, shall I replace all i = i + 1 by i += 1, and commit my layout2layout? Do any objec

Re: layout2layout (Re: [patch] partial merging of CharStyle and InsetLayout handling)

2007-08-18 Thread Bo Peng
> > So, shall I replace all i = i + 1 by i += 1, and commit > > my layout2layout? Do any objections come to mind? > > > Perhaps we should check with Bo. I'm sure he knows exactly what version > we require and what its capabilities are. So I'm adding him to the cc > list here. Lyx requires python 2

Re: How to use CharStyles

2007-08-18 Thread Martin Vermeer
On Sat, Aug 18, 2007 at 11:12:57PM +0300, Dov Feldstern wrote: > > > Hi! > > I know this sounds more like a question for the users' list, but anyhow ;) : > > How do you start using CharStyles? I don't see it anywhere in the menus, and > when I try "charstyle-insert" from the minibuffer I g

How to use CharStyles

2007-08-18 Thread Dov Feldstern
Hi! I know this sounds more like a question for the users' list, but anyhow ;) : How do you start using CharStyles? I don't see it anywhere in the menus, and when I try "charstyle-insert" from the minibuffer I get "command disabled"... Do I have to create styles, or are there some provided wit

Re: layout2layout (Re: [patch] partial merging of CharStyle and InsetLayout handling)

2007-08-18 Thread christian . ridderstrom
On Sat, 18 Aug 2007, Bo Peng wrote: So, shall I replace all i = i + 1 by i += 1, and commit my layout2layout? Do any objections come to mind? Perhaps we should check with Bo. I'm sure he knows exactly what version we require and what its capabilities are. So I'm adding him to the cc list here.

Re: layout2layout (Re: [patch] partial merging of CharStyle and InsetLayout handling)

2007-08-18 Thread Andre Poenitz
On Sat, Aug 18, 2007 at 09:47:29PM +0300, Martin Vermeer wrote: > I would surprise me if very old python versions would > still work correctly for LyX. configure.ac seems to require > 2.3, which definitely has +=. (But not i++, which would be > even better) > > So, shall I replace all i = i + 1 b

Windows uninstaller

2007-08-18 Thread Paul A. Rubin
Hi, Having been using 1.5.1-1 for a while now, I just uninstalled 1.5.0rc2. I noticed that the uninstaller told MikTeX to remove some fonts (?) that LyX apparently installed (including a chess font?). Hopefully I won't need them. Deleting LyX-installed fonts makes sense if you're removing

selective 'monolithic builds' for autotools

2007-08-18 Thread Andre Poenitz
The attached patch allows to ./configure --enable-monolithic-controllers which will at compile time create a file 'lyxcontrollers.cpp' #including all controller .cpp files. This will then be compiled in one go _without_ using precompiled headers (they slow the process down in this case) On my ma

Re: Further inset configurability

2007-08-18 Thread Martin Vermeer
On Sat, Aug 18, 2007 at 02:40:27PM -0400, Richard Heck wrote: > > This looks reasonable to me, though I haven't tested it. (I'm still > obsessing over BibTeX stuff.) > > One suggestion: I think CharStyles should by default have an unobtrusive > presentation, NOT with the label showing. OK