Re: [PATCH] InsetTabular: add a layoutName method

2013-09-29 Thread Jean-Marc Lasgouttes
Le 28/09/13 22:56, Scott Kostyshak a écrit : Ah, you mean that something could go wrong if someone tries to define an inset with a name that already exists? Do we check for this? Is inset-forall the only place where there could be such a problem? No, what happens now is that InsetLayout can

Re: Lyx2.1.0beta2 issues ?

2013-09-29 Thread Vincent van Ravesteijn
Op 27-9-2013 23:53, Stephan Witt schreef: Regarding the details: * BufferEncoding.cpp is a manual copy of Encoding.cpp - that's why the wrong comment - that's why the name of the file - that's why the superfluous includes * CharInfo was a private struct - I've made a class to make it more

Re: Make distclean failure

2013-09-29 Thread Vincent van Ravesteijn
Op 17-8-2013 11:38, Jürgen Spitzmüller schreef: It stops at .deps/AppleSpellChecker.Po and other .deps/*.Po which are unknown. Jürgen This still fails for me. Is anyone around who knows how to fix this ? Vincent

Re: Make distclean failure

2013-09-29 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: This still fails for me. Is anyone around who knows how to fix this ? Last time, removing subdir-objects from AM_INIT_AUTOMAKE in configure.ac helped. Jürgen

Re: [PATCH] InsetTabular: add a layoutName method

2013-09-29 Thread Richard Heck
On 09/29/2013 10:53 AM, Jean-Marc Lasgouttes wrote: Le 28/09/13 22:56, Scott Kostyshak a écrit : Ah, you mean that something could go wrong if someone tries to define an inset with a name that already exists? Do we check for this? Is inset-forall the only place where there could be such a

Re: trunk: Style Chunk

2013-09-29 Thread Richard Heck
On 09/25/2013 03:15 PM, Scott Kostyshak wrote: On Tue, Sep 10, 2013 at 6:26 PM, Scott Kostyshak skost...@lyx.org wrote: On Tue, Sep 10, 2013 at 3:09 PM, Richard Heck rgh...@lyx.org wrote: On 09/10/2013 11:51 AM, Scott Kostyshak wrote: On Tue, Aug 20, 2013 at 7:43 PM, Richard Heck

Re: Make distclean failure

2013-09-29 Thread Vincent van Ravesteijn
Op 29-9-2013 18:50, Jürgen Spitzmüller schreef: Vincent van Ravesteijn wrote: This still fails for me. Is anyone around who knows how to fix this ? Last time, removing subdir-objects from AM_INIT_AUTOMAKE in configure.ac helped. Jürgen Well, I just added this again. So.. does this mean we

Re: Make distclean failure

2013-09-29 Thread Vincent van Ravesteijn
Op 17-8-2013 11:38, Jürgen Spitzmüller schreef: It stops at .deps/AppleSpellChecker.Po and other .deps/*.Po which are unknown. Jürgen The culprit seems to be the following line in the output of make distclean: rm -rf ../.deps ../graphics/.deps ../insets/.deps .deps while being in the

[PATCH] Fix make distclean

2013-09-29 Thread Vincent van Ravesteijn
This only cleans the .deps directories that won't be needed later on. --- This fixes it for me. Any comments on this ? Vincent src/support/Makefile.am |4 src/tex2lyx/Makefile.am |4 2 files changed, 8 insertions(+) diff --git a/src/support/Makefile.am

Re: [PATCH] Fix make distclean

2013-09-29 Thread Stephan Witt
Am 29.09.2013 um 21:00 schrieb Vincent van Ravesteijn v...@lyx.org: This only cleans the .deps directories that won't be needed later on. --- This fixes it for me. Any comments on this ? This looks ok. Removing things outside the current directory isn't good, IMO. I cannot imagine how a rm

Re: [PATCH] Fix make distclean

2013-09-29 Thread Pavel Sanda
Stephan Witt wrote: I cannot imagine how a rm -f can fail, so the leading minus is not needed. If DEPDIR doesn't exists it will fail. P

Re: [PATCH] Fix make distclean

2013-09-29 Thread Stephan Witt
Am 29.09.2013 um 21:48 schrieb Pavel Sanda sa...@lyx.org: Stephan Witt wrote: I cannot imagine how a rm -f can fail, so the leading minus is not needed. If DEPDIR doesn't exists it will fail. P No. It will not fail. That's the effect of -f. Stephan

Re: [PATCH] Fix make distclean

2013-09-29 Thread Pavel Sanda
Stephan Witt wrote: No. It will not fail. That's the effect of -f. You are right, I used force flag for completely different reasons up to now ;) P

Re: [PATCH] Fix make distclean

2013-09-29 Thread Vincent van Ravesteijn
Op 29-9-2013 22:16, Stephan Witt schreef: Am 29.09.2013 um 21:48 schrieb Pavel Sanda sa...@lyx.org: Stephan Witt wrote: I cannot imagine how a rm -f can fail, so the leading minus is not needed. If DEPDIR doesn't exists it will fail. P No. It will not fail. That's the effect of -f. Stephan

Re: [PATCH] Fix make distclean

2013-09-29 Thread Stephan Witt
Am 29.09.2013 um 22:24 schrieb Vincent van Ravesteijn v...@lyx.org: Op 29-9-2013 22:16, Stephan Witt schreef: Am 29.09.2013 um 21:48 schrieb Pavel Sanda sa...@lyx.org: Stephan Witt wrote: I cannot imagine how a rm -f can fail, so the leading minus is not needed. If DEPDIR doesn't exists

Re: [PATCH] InsetTabular: add a layoutName method

2013-09-29 Thread Jean-Marc Lasgouttes
Le 28/09/13 22:56, Scott Kostyshak a écrit : Ah, you mean that something could go wrong if someone tries to define an inset with a name that already exists? Do we check for this? Is inset-forall the only place where there could be such a problem? No, what happens now is that InsetLayout can

Re: Lyx2.1.0beta2 issues ?

2013-09-29 Thread Vincent van Ravesteijn
Op 27-9-2013 23:53, Stephan Witt schreef: Regarding the details: * BufferEncoding.cpp is a manual copy of Encoding.cpp - that's why the wrong comment - that's why the name of the file - that's why the superfluous includes * CharInfo was a private struct - I've made a class to make it more

Re: Make distclean failure

2013-09-29 Thread Vincent van Ravesteijn
Op 17-8-2013 11:38, Jürgen Spitzmüller schreef: It stops at .deps/AppleSpellChecker.Po and other .deps/*.Po which are unknown. Jürgen This still fails for me. Is anyone around who knows how to fix this ? Vincent

Re: Make distclean failure

2013-09-29 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: > This still fails for me. > > Is anyone around who knows how to fix this ? Last time, removing subdir-objects from AM_INIT_AUTOMAKE in configure.ac helped. Jürgen

Re: [PATCH] InsetTabular: add a layoutName method

2013-09-29 Thread Richard Heck
On 09/29/2013 10:53 AM, Jean-Marc Lasgouttes wrote: Le 28/09/13 22:56, Scott Kostyshak a écrit : Ah, you mean that something could go wrong if someone tries to define an inset with a name that already exists? Do we check for this? Is inset-forall the only place where there could be such a

Re: trunk: Style Chunk

2013-09-29 Thread Richard Heck
On 09/25/2013 03:15 PM, Scott Kostyshak wrote: On Tue, Sep 10, 2013 at 6:26 PM, Scott Kostyshak wrote: On Tue, Sep 10, 2013 at 3:09 PM, Richard Heck wrote: On 09/10/2013 11:51 AM, Scott Kostyshak wrote: On Tue, Aug 20, 2013 at 7:43 PM, Richard Heck

Re: Make distclean failure

2013-09-29 Thread Vincent van Ravesteijn
Op 29-9-2013 18:50, Jürgen Spitzmüller schreef: Vincent van Ravesteijn wrote: This still fails for me. Is anyone around who knows how to fix this ? Last time, removing subdir-objects from AM_INIT_AUTOMAKE in configure.ac helped. Jürgen Well, I just added this again. So.. does this mean we

Re: Make distclean failure

2013-09-29 Thread Vincent van Ravesteijn
Op 17-8-2013 11:38, Jürgen Spitzmüller schreef: It stops at .deps/AppleSpellChecker.Po and other .deps/*.Po which are unknown. Jürgen The culprit seems to be the following line in the output of "make distclean": rm -rf ../.deps ../graphics/.deps ../insets/.deps .deps while being in the

[PATCH] Fix make distclean

2013-09-29 Thread Vincent van Ravesteijn
This only cleans the .deps directories that won't be needed later on. --- This fixes it for me. Any comments on this ? Vincent src/support/Makefile.am |4 src/tex2lyx/Makefile.am |4 2 files changed, 8 insertions(+) diff --git a/src/support/Makefile.am

Re: [PATCH] Fix make distclean

2013-09-29 Thread Stephan Witt
Am 29.09.2013 um 21:00 schrieb Vincent van Ravesteijn : > This only cleans the .deps directories that won't be needed later on. > --- > > This fixes it for me. Any comments on this ? This looks ok. Removing things outside the current directory isn't good, IMO. I cannot imagine

Re: [PATCH] Fix make distclean

2013-09-29 Thread Pavel Sanda
Stephan Witt wrote: > I cannot imagine how a "rm -f" can fail, so the leading minus is not needed. If DEPDIR doesn't exists it will fail. P

Re: [PATCH] Fix make distclean

2013-09-29 Thread Stephan Witt
Am 29.09.2013 um 21:48 schrieb Pavel Sanda : > Stephan Witt wrote: >> I cannot imagine how a "rm -f" can fail, so the leading minus is not needed. > > If DEPDIR doesn't exists it will fail. P No. It will not fail. That's the effect of "-f". Stephan

Re: [PATCH] Fix make distclean

2013-09-29 Thread Pavel Sanda
Stephan Witt wrote: > No. It will not fail. That's the effect of "-f". You are right, I used force flag for completely different reasons up to now ;) P

Re: [PATCH] Fix make distclean

2013-09-29 Thread Vincent van Ravesteijn
Op 29-9-2013 22:16, Stephan Witt schreef: Am 29.09.2013 um 21:48 schrieb Pavel Sanda : Stephan Witt wrote: I cannot imagine how a "rm -f" can fail, so the leading minus is not needed. If DEPDIR doesn't exists it will fail. P No. It will not fail. That's the effect of "-f".

Re: [PATCH] Fix make distclean

2013-09-29 Thread Stephan Witt
Am 29.09.2013 um 22:24 schrieb Vincent van Ravesteijn : > Op 29-9-2013 22:16, Stephan Witt schreef: >> Am 29.09.2013 um 21:48 schrieb Pavel Sanda : >> >>> Stephan Witt wrote: I cannot imagine how a "rm -f" can fail, so the leading minus is not needed. >>>