Re: my first commit to the Git repository

2015-07-08 Thread Georg Baum
Welcome Günter on board, I really like that you took this step! If you did not do it already please read lib/doc/Development.lyx for some guidelines. The general rule for committing can be summarized as "commit if the fix is obvious and uncontroversal, for bigger changes or if in doubt first as

Re: Build questions for OS X

2015-07-08 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > I have seen that too. I did not think about enforcing c++98. Shall I try > that? I think that would be a good idea at least for newer compilers (e.g. for gcc version 5 and newer, for clang probably always). > The alternative would be to enforce c++11 for 2.2, but I

Re: Build questions for OS X

2015-07-08 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > I have seen that too. I did not think about enforcing c++98. Shall I try > that? I think that would be a good idea at least for newer compilers (e.g. for gcc version 5 and newer, for clang probably always). > The alternative would be to enforce c++11 for 2.2, but I

Re: Build questions for OS X

2015-07-07 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 07/07/2015 01:07, Jerry a écrit : >>CXX CutAndPaste.o >> CutAndPaste.cpp:390:15: error: call to 'next' is ambiguous >> pars.insert(next(pars.begin(), pit), >> ^~~~ >> /Applications/Xcode.app/Contents/Developer

Re: false positive in test for unencodable preamble

2015-07-05 Thread Georg Baum
Guenter Milde wrote: > I want a concise comment in the LyX file, in order to explain what the > code is about. > > In the document, I have the option to change the comment into a LyX-note. > Fine. > > In the preamble, there is no way to make a "LyX-only" comment. :-( You have a point. Unfortuna

Re: false positive in test for unencodable preamble

2015-06-30 Thread Georg Baum
Guenter Milde wrote: > On 2015-06-26, Jürgen Spitzmüller wrote: >> 2015-06-26 16:44 GMT+02:00 Guenter Milde : > >>> Please don't check for unencodable characters in comments. > >> It's still invalid encoding, since the output file contains invalid >> glyphs (no matter if this line is processed b

Re: Unable to enter custom negative spaces

2015-06-30 Thread Georg Baum
Jürgen Spitzmüller wrote: > The method formatFPNumber in lstrings.h does not work properly with > negative doubles. It seems to round them (-1.5 is output as -2). > > The problem seems to be in this code. Georg? I simply forgot to think about negative numbers. I slightly changed the current fix

Re: What should $\delta$ be exported as for plain text?

2015-06-23 Thread Georg Baum
Guenter Milde wrote: > On 2015-06-21, Georg Baum wrote: > >> If the user entered \delta in a math formula, then this is a small >> mathematical delta. If he rather needs a text greek delta, he should >> use δ U+03b4 in the first place. > > This is not as

Re: test of math previews

2015-06-23 Thread Georg Baum
Enrico Forestieri wrote: > I don't know, maybe this is a case of a race condition. Most probably, > with preview on, updateMacros() is not called (or is called later) and > the MacroData:sym_ pointer is not updated at the time MacroData::xlmname() > is called so that it contains bogus values. This

Re: Re: 2.2

2015-06-21 Thread Georg Baum
José Matos wrote: > It would be nice to have this ready before the beta to improve the test, > but this should not delay the 2.2 release. The solution will be always > better than what we have now. > > In order to improve the reading of the different lyx files and to make the > process more robus

Re: test of math previews

2015-06-21 Thread Georg Baum
Guillaume M-M wrote: > Thank you very much, this is really quick now. Thanks also for the timer > for generating previews. Also I only had 1 segmentation error, which I > could not reproduce unfortunately. It happened after changing from > "Instant preview: On" to "No maths" and zooming. But proba

Re: What should $\delta$ be exported as for plain text?

2015-06-21 Thread Georg Baum
Guenter Milde wrote: > On 2015-06-19, Scott Kostyshak wrote: >> We have all of the information/patches needed to resolve the following >> ticket: http://www.lyx.org/trac/ticket/2342 > >> What should we export for plain text for math? For example, if we have a >> math inset with $\delta$ what shou

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-15 Thread Georg Baum
Uwe Stöhr wrote: > Am 09.06.2015 um 20:38 schrieb Georg Baum: > >>> Attached is a better patch that does this. It also extends the fix to >>> for libreoffice. >> >> It still has this complicated quoting. I still do not understand why it >> has to be don

Re: [patch] check for uncodbale characters in user preamble (bug #9599)

2015-06-15 Thread Georg Baum
Jürgen Spitzmüller wrote: > The attached patch checks for uncodable glyphs in the user preamble and > issues a warning if such glyphs are found (like we do in many other > situations). > > Comments? Looks good. Ideally I'd prefer to unify the handling of uncodable symbols a bit more (currently

Re: consider tex2lyx + tests locked in master

2015-06-11 Thread Georg Baum
Kornel Benko wrote: > I checked re-exported box-color-size-space-align.tex against exported > box-color-size-space-align.lyx.lyx. The difference is: > #diff box-color-size-space-align.lyx.tex box-color-size-space-align.tex > 217c217 > < \centering www% > --- > > \centering www% > 438c438 > < %set

Re: Warnings With Automake

2015-06-11 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 09/06/2015 15:00, Richard Heck a écrit : >> >> Using automake 1.15 (though I think I also saw this earlier), I get a >> ton of warnings like: >> >> src/tex2lyx/Makefile.am:71: warning: source file '../version.cpp' is in >> a subdirectory, >> src/tex2lyx/Makefile.am

Re: Merging features/fix-tex2lyx-tests to master

2015-06-09 Thread Georg Baum
Uwe Stöhr wrote: > Am 31.05.2015 um 22:01 schrieb Georg Baum: > >> I tested that the old LyX file produced correct .tex results, now I see >> that it creates correct .tex results with the new version as well. It did >> not occur to me that both hor_pos "c&q

Re: Merging features/fix-tex2lyx-tests to master

2015-06-09 Thread Georg Baum
Uwe Stöhr wrote: > Am 02.06.2015 um 20:27 schrieb Georg Baum: > >>> tex2lyx -f -roundtrip test-insets.tex >> >> This command looks good. Again, please answer my question: Did you copy >> test-insets.tex somewhere, or did you run this command on the .tex file

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-09 Thread Georg Baum
Uwe Stöhr wrote: > Am 04.06.2015 um 18:17 schrieb Georg Baum: > >>> Could some pythionist please review this? >> >> First you need to explain why you use this complicated quoting, and what >> problem it solves. >> If such a quoting is really needed, >

Re: [LyX/2.1.x] layouttranslations: Arabic update by Hatim

2015-06-09 Thread Georg Baum
Uwe Stöhr wrote: > Why do we have a single pt_BR translation in layouttranslations in the > 2.1.x branch if a modification is not allowed. > pt_BR is new in branch for LyX 2.1.4 so there was definitely a change of > the file. No. The last change was at bdc1271c3905, which was before the 2.1.0 rel

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-04 Thread Georg Baum
Uwe Stöhr wrote: > The attached patch fixes > http://www.lyx.org/trac/ticket/7657 > for me. > > Could some pythionist please review this? First you need to explain why you use this complicated quoting, and what problem it solves. If such a quoting is really needed, then it needs to be wrapped

Re: [LyX/2.1.x] layouttranslations: Arabic update by Hatim

2015-06-04 Thread Georg Baum
Uwe Stöhr wrote: > commit 407d5bf228a8fd297aedc933b396a10e976df09b > Author: Uwe Stöhr > Date: Thu Jun 4 01:12:12 2015 +0200 > > layouttranslations: Arabic update by Hatim It is forbidden to update layouttranslations in a stable release, and if an update is done in master it must not be

Re: consider tex2lyx + tests locked in master

2015-06-03 Thread Georg Baum
Kornel Benko wrote: > OK, now: 4 tests failed out of 14 > The following tests FAILED: > 10 - tex2lyx/roundtrip/box-color-size-space-align.tex (Failed) > 16 - tex2lyx/roundtrip/test-insets-basic.tex (Failed) > 18 - tex2lyx/roundtrip/test-insets.tex (Failed) > 28 - tex2lyx/roundtrip/test-structure.t

Re: consider tex2lyx + tests locked in master

2015-06-02 Thread Georg Baum
Georg Baum wrote: > Please do not submit anything in tex2lyx source code and tests for ca. two > days (I'll send a message when the lock is over). Sorry, I forgot to tell that yesterday: I am now finished. Georg

Re: Merging features/fix-tex2lyx-tests to master

2015-06-02 Thread Georg Baum
Uwe Stöhr wrote: > Am 31.05.2015 um 19:06 schrieb Uwe Stöhr: > >>> This might be a tex2lyx bug as well, depending how the reference was >>> created. This is not in 1) since I can reproduce the results in 1) with >>> current tex2lyx but not this one. Uwe, how did you create the reference >>> which

Re: 2.2

2015-06-01 Thread Georg Baum
Jürgen Spitzmüller wrote: > On Linux and Mac, you can certainly also use symlinks. Don't know about > Windows. Some time ago I learned that the NTFS file system used on all modern windows versions supports true symlinks as well (I am not talking about the .lnk substitute). If the installer can

Re: Merging features/fix-tex2lyx-tests to master

2015-05-31 Thread Georg Baum
Uwe Stöhr wrote: > Am 31.05.2015 um 15:24 schrieb Georg Baum: > >> 1) tex2lyx bugs >> These are changes which should have never gone into the test references, >> since they hide recently introduced bugs. Uwe, please have a look at the >> diffs and fix the bugs.

Re: [LyX/master] configure.py: elyxer is not provided as executable

2015-05-31 Thread Georg Baum
Uwe Stöhr wrote: > Am 31.05.2015 um 16:01 schrieb Georg Baum: > >> It definitely _is_ available as an executable if you use the debian >> package, so detection of elyxer on debian is now broken. > > OK, reverting now. Thanks. >> IMO we had too many changes

Re: Failing tex2lyx tests

2015-05-31 Thread Georg Baum
Uwe Stöhr wrote: > Yes, that is because of the git mess. I think that I am not too stupid > but git is nothing for me. Now after years it is still a mystery why > e.g. often some files are not committed despite I selected them to be > committed. Also often an older version from my tree is committe

Re: [LyX/master] configure.py: elyxer is not provided as executable

2015-05-31 Thread Georg Baum
Richard Heck wrote: > On 05/30/2015 09:11 PM, Uwe Stöhr wrote: >> commit ee5760ef8ce0291fbfada33901ed110f51cf5a91 >> Author: Uwe Stöhr >> Date: Sun May 31 03:11:13 2015 +0200 >> >> configure.py: elyxer is not provided as executable > > I think we should check both. On some platforms, it m

Merging features/fix-tex2lyx-tests to master

2015-05-31 Thread Georg Baum
Hi, I am now finished with fixing the tex2lyx tests. Unfortunately it took much more time than initially thought. The diffs to current master are attached. The differences can be divided into several categories: 1) tex2lyx bugs These are changes which should have never gone into the test refe

Re: [LyX features/features/fix-tex2lyx-tests] Re-add box and color tests

2015-05-31 Thread Georg Baum
Georg Baum wrote: > The branch, features/fix-tex2lyx-tests, has been updated. > discards 17b29b7fcbe770ed1b69aa3bfaa6e99d4276dd8e (commit) > discards 1ddbb9005db7806d1f8dff8aadd53ea2c3bf0416 (commit) > discards 974810bac025ef7ea82404c54ac741b19f7ddf3d (commit)

Re: about the tex2lyx tests and proposal for a better method

2015-05-29 Thread Georg Baum
Guenter Milde wrote: > However, whenever a reference changes (to adapt to a new file version or > other changes) or a new test file + reference is added, one must also > check if the new reference is really a *good* one. Yes, this is the key point. > In the case of LyX, this includes checking wh

Re: about the tex2lyx tests and proposal for a better method

2015-05-29 Thread Georg Baum
Uwe Stöhr wrote: > Am 27.05.2015 um 16:53 schrieb Georg Baum: > >> It is_not_ a requirement that test cases always contain sensible data. >> In many cases, it is more effective to design test cases with contents >> which would never occur in practice, for example becaus

Re: [LyX features/master] Fix test for urwclassico font (bug #9576)

2015-05-29 Thread Georg Baum
Richard Heck wrote: > Oh, sorry, I see. This was updating features/master. and it was me, not Jürgen. The commit-hook can sometimes be quite confusing ;-( Georg

Re: LyX banner has strange bottom line for me

2015-05-28 Thread Georg Baum
Stephan Witt wrote: > Am 27.05.2015 um 19:40 schrieb Enrico Forestieri : > > > PS: Thanks for doing this! >From me as well! Also for the origin preference setting and the many SVG images you created. Georg

consider tex2lyx + tests locked in master

2015-05-27 Thread Georg Baum
Please do not submit anything in tex2lyx source code and tests for ca. two days (I'll send a message when the lock is over). One tex2lyx test is still failing, and I am going to work on the tests to show what is currently broken. Unfortunately the test references where updated with errornous co

Re: Failing tex2lyx tests

2015-05-27 Thread Georg Baum
Scott Kostyshak wrote: > On Mon, May 25, 2015 at 7:24 PM, Uwe Stöhr wrote: >> Am 24.05.2015 um 20:01 schrieb Kornel Benko: >> >>> It seems like tex2lyx from input like >>> \include{\string"Dummy Document\string".tex} >>> creates a lyx file which contains >>> filename "DummyDocumen

Re: about the tex2lyx tests and proposal for a better method

2015-05-27 Thread Georg Baum
Uwe Stöhr wrote: > Hi Georg and Kornel, > > (I start a new thread to collect all infos about this topic.) > > Today I had a closer look and found out that our current test routines > do not test the reality: tex2lyx's aim is to import TeX files to LyX > resulting in compilable LyX files. No. Th

Re: Compilation failure un c++11 mode with gcc 4.6

2015-05-21 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 19/05/2015 20:34, Georg Baum a écrit : >> >> Maybe some of them, but at least the one in tex2lyx should be converted >> to LYX_USE_CXX11. > > For me it tests against C++98, and I think this is a given these days. > But since I do no

Re: [LyX/master] tex2lyx/text.cpp: support for the commands \fboxsep etc.

2015-05-21 Thread Georg Baum
Uwe Stöhr wrote: > Am 18.05.2015 um 22:13 schrieb Georg Baum: > >> Please explain how you think the test reference will be updated. > > I don't understand. > I only added some cases which can now be imported to the text TeX file. > isn't that the reference

Re: Failing tex2lyx tests

2015-05-21 Thread Georg Baum
Uwe Stöhr wrote: > Nevertheless I knew that I will add example by examply to the TeX file > and therefore did not update the reference at every step. As I explained in my other message updating them step by step is important, so please do this in the future. > However, now everything should be

Re: Failing tex2lyx tests

2015-05-21 Thread Georg Baum
Uwe Stöhr wrote: > Am 19.05.2015 um 21:20 schrieb Georg Baum: > >> unfortunately the tex2lyx test failures increased (see attachment). Are >> you aware that this wastes time of developers? Did you see the questions >> Scott ansd I asked about the failing tests? > &g

Re: Understanding the /origin parameter

2015-05-19 Thread Georg Baum
Enrico Forestieri wrote: > On Tue, May 19, 2015 at 08:42:45PM +0200, Georg Baum wrote: >> >> I understand the use case for the origin parameter, and I think there >> will be users who appreciate it, but if I don't need it (e.g. because I >> always store relative

Failing tex2lyx tests

2015-05-19 Thread Georg Baum
Dear Uwe, unfortunately the tex2lyx test failures increased (see attachment). Are you aware that this wastes time of developers? Did you see the questions Scott ansd I asked about the failing tests? The tests are there to help you, they are not a burden if used correctly. If everybody takes ca

Re: check_layout for modules

2015-05-19 Thread Georg Baum
Kornel Benko wrote: > Hi, ATM the command check_layout checks implicitly (through 'Input') only > a subset of modules. Therefore check_layout cannot be used to test them > all. IIRC the limitation is not in the test, but in the LyX layout machinery, since a module is not a complete document clas

Re: Understanding the /origin parameter

2015-05-19 Thread Georg Baum
Enrico Forestieri wrote: > On Tue, May 19, 2015 at 11:09:26AM +0200, Jean-Marc Lasgouttes wrote: >> Le 18/05/2015 20:15, Enrico Forestieri a écrit : >> >>Something with less magic and more predictability? >> > >> >It's magic and it's very predictable. An alternative to reverting >> >would be intro

Re: Compilation failure un c++11 mode with gcc 4.6

2015-05-19 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Georg, would the following commit suit you? With it, I am able to > compile with gcc 4.6 in C++11 mode. I would prefer testing for __cplusplus, since it is defined by the C++ standard. However, since this does not work I do not know of a better way than you propose

Re: boost update?

2015-05-18 Thread Georg Baum
Vincent van Ravesteijn wrote: > Last time I tried (not so long ago), I hit a lot of new compiler errors, > which I didn't know how to fix. > > Thank you for fixing those.. It was easy, it was only one: b596330093d. Maybe our code has some self- healing capabilities:-) Georg

Re: [LyX/master] tex2lyx/text.cpp: support for the commands \fboxsep etc.

2015-05-18 Thread Georg Baum
Uwe Stöhr wrote: > diff --git a/src/tex2lyx/test/box-color-size-space-align.tex > b/src/tex2lyx/test/box-color-size-space-align.tex index ab658c6..b004eed > 100644 --- a/src/tex2lyx/test/box-color-size-space-align.tex > +++ b/src/tex2lyx/test/box-color-size-space-align.tex > @@ -157,6 +157,18 @@ b

Re: Make RELEASE-NOTES accessible from GUI (#8616)

2015-05-18 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 18/05/2015 12:04, Jürgen Spitzmüller a écrit : >> If you prefer this approach, go ahead. > > I don't know, what do other people think? As I filed the bug I am very glad that it is being worked on, and I don't need to do it myself;-) Concerning the format and lo

Re: [LyX/master] tex2lyx/text.cpp: a fix for the horizontal box position

2015-05-17 Thread Georg Baum
Uwe Stöhr wrote: > commit 76b579ed3774fd6612e6172df67a7b83c344cc2d > Author: Uwe Stöhr > Date: Sun May 17 18:12:20 2015 +0200 > > tex2lyx/text.cpp: a fix for the horizontal box position > > - if nothing is specified, the box content is left aligned, except > for \makebox whe

Re: [LyX/master] tex2lyx: support the command \colorbox

2015-05-17 Thread Georg Baum
Uwe Stöhr wrote: > diff --git a/src/tex2lyx/test/box-color-size-space-align.tex > b/src/tex2lyx/test/box-color-size-space-align.tex index 338a269..ab658c6 > 100644 --- a/src/tex2lyx/test/box-color-size-space-align.tex > +++ b/src/tex2lyx/test/box-color-size-space-align.tex > @@ -157,6 +157,18 @@ b

RE: lyx2lyx script failed

2015-05-17 Thread Georg Baum
hatim ali wrote: > Dear Uwe Stoehr > > not work, this the msg: > > Traceback (most recent call last): > File "/usr/local/share/lyx/lyx2lyx/lyx2lyx", line 86, in > main() > File "/usr/local/share/lyx/lyx2lyx/lyx2lyx", line 81, in main > doc.write() > File "/usr/local/share/lyx/lyx2

Re: [patch] support for \fcolorbox and \colorbox

2015-05-17 Thread Georg Baum
Uwe Stöhr wrote: > Am 16.05.2015 um 11:17 schrieb Georg Baum: > >> tex2lyx produces broken documents now. Running the tests gives lots of >> >> Lexer.cpp (936): Missing 'framecolor'-tag in InsetBoxParams::read. Got >> status instead. Line: 4026 >>

Re: [LyX/master] tex2lyx testfiles: update to latest fileformat

2015-05-17 Thread Georg Baum
Kornel Benko wrote: > Am Samstag, 16. Mai 2015 um 10:43:04, schrieb Georg Baum > >> To make it very clear: The automatic update is _not_ meant to be run by >> default for any build or test target. It is not meant either to be run >> without looking at the results. Manu

Re: [patch] support for \fcolorbox and \colorbox

2015-05-16 Thread Georg Baum
Uwe Stöhr wrote: > OK. > I have put the patch in with static. tex2lyx produces broken documents now. Running the tests gives lots of Lexer.cpp (936): Missing 'framecolor'-tag in InsetBoxParams::read. Got status instead. Line: 4026 Lexer.cpp (936): Missing 'backgroundcolor'-tag in InsetBoxParam

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-16 Thread Georg Baum
Enrico Forestieri wrote: > I have not investigated, but I think this is due to some script assuming > that /bin/sh is really /bin/bash, and this is not true on solaris. In fact I did not know that ! is bash specific. It should work now. > Incidentally, for this same reason I cannot simply run ./

Re: [LyX/master] tex2lyx testfiles: update to latest fileformat

2015-05-16 Thread Georg Baum
Kornel Benko wrote: > This is, what I wrote to Scott privately (sorry) >> The usage of such a target I rather do not recommend. It hides too easily >> eventual errors. >> I think the goal here is to have easy conversion of test files. Yes. >> In error case (in cmake) we would anyway check each t

boost update?

2015-05-16 Thread Georg Baum
Hi, I tested LyX with boost 1.58, and it compiles and runs fine. Shall I update the included boost? This would get rid of some compiler warnings, and since 2.2 will live for a while I guess it is good to start with a recent boost, since a boost update for a stable release is more risky. Georg

Re: [LyX/master] tex2lyx testfiles: update to latest fileformat

2015-05-16 Thread Georg Baum
Uwe Stöhr wrote: > Thanks for taking care and adding the note. However, the huge diff shows > that tex2lyx is not yet producing the same as LyX. Can#t we do anything > or shouldn't we do anything here? Some time ago the whitespace differences were even larger, and I already reduced them a bit. I

Re: math macro crashes again (bug 9490)

2015-05-15 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 14/05/2015 21:00, Georg Baum a écrit : >> Jean-Marc Lasgouttes wrote: >> >> It is a dummy inset that can be used like a MathInset from outside, but >> forwards every work to the math macro cell that it represents. This >> allows

Re: math macro crashes again (bug 9490)

2015-05-15 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 14/05/15 22:31, Guillaume M-M a écrit : >> My typical use case is to change the macro while keeping the same >> arguments. In the absolute, it is easy to see that this can be useful >> occasionally at least. Indeed, in the absence of macro-unfolding, the >> alterna

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-15 Thread Georg Baum
Kornel Benko wrote: > Am Donnerstag, 14. Mai 2015 um 21:05:23, schrieb Georg Baum > >> Kornel Benko wrote: >> >> > This does not cover all tex2lyx tests used under cmake. >> >> IMHO calling these tests tex2lyx tests is confusing. They test nothing in >

Re: [LyX/master] tex2lyx testfiles: update to latest fileformat

2015-05-15 Thread Georg Baum
Am 14.05.2015 um 23:13 schrieb Uwe Stöhr: commit afdfc3cf43501a0728cef79385b31afe6f4cf877 Author: Uwe Stöhr Date: Thu May 14 23:13:14 2015 +0200 tex2lyx testfiles: update to latest fileformat Uwe, I appreciate your effort to update the tests, but unfortunately it does not work like th

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-15 Thread Georg Baum
Enrico Forestieri wrote: > Sure. This is on Solaris: > > g++ -fPIC -O2-L/usr/local/lib -Wl,-R/usr/local/lib -L/opt/lib > -Wl,-R/opt/lib -L/usr/X11/lib -Wl,-R/usr/X11/lib -o check_trivstring > check_trivstring.o dummy_functions.o boost.o liblyxsupport.a -liconv > ../../boost/liblyxboost.a -L/

Re: layout tests are failing

2015-05-15 Thread Georg Baum
Enrico Forestieri wrote: > Sorry, I cannot run the tests so I could not see this but I know why it > happens. Now addLocalLayout() returns a full path if a local layout file > is found. Hence, it has to be stripped before being used as an index. > Should be fixed now. Thanks, works fine now. Ge

Re: [LyX/master] Shut up compiler warning

2015-05-15 Thread Georg Baum
Stephan Witt wrote: > Thanks. I'm using clang and the only way to get this warning is > -Wconversion, AFAIK. With these warnings enabled I'm getting tons of > warnings for boost and Qt headers. So, I'll let it disabled then. With -Wfloat-conversion you'll also get some in qt and boost, but not as

layout tests are failing

2015-05-14 Thread Georg Baum
The reason is that LayoutFile const & f = l[i]; in check_layout.cpp asserts. This is strange, since directly above a test is made whether i is valid. Does anybody else see this? Georg

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-14 Thread Georg Baum
Enrico Forestieri wrote: > $ cd build > $ make alltests > ... > CXXLD check_trivstring > Undefined first referenced > symbol in file > _ZNK3lyx14trivial_stringIcE5c_strEv check_trivstring.o > _ZNK3lyx14trivial_stringIwE5c_strEv check_trivstring

Re: [LyX/master] Update tex2lyx and tests after 306b136c

2015-05-14 Thread Georg Baum
Kornel Benko wrote: > Am Donnerstag, 14. Mai 2015 um 12:25:01, schrieb Enrico Forestieri > >> On Thu, May 14, 2015 at 10:37:17AM +0200, Kornel Benko wrote: >> > Am Donnerstag, 14. Mai 2015 um 01:03:17, schrieb Enrico Forestieri >> > >> > > commit 7144f8dad84b5b321f7c87143efec9eb2b6195dc >> > > A

Re: math macro crashes again (bug 9490)

2015-05-14 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > I think I do not understand yet what an argumentproxy really is. Could > you explain that to me (again??)? It is a dummy inset that can be used like a MathInset from outside, but forwards every work to the math macro cell that it represents. This allows to store th

Re: math macro crashes again (bug 9490)

2015-05-14 Thread Georg Baum
Guillaume M-M wrote: > Thank you for looking at these bugs. I reported 9418 and 9490, and I use > macro unfolding quite often. Before discovering this feature, I would > occasionally edit the lyx file externally (!) to change certain macros. > Given that the original bug was about a crash occurrin

Re: [LyX/master] Fix LaTeX length export of big numbers (bug 9416)

2015-05-14 Thread Georg Baum
Uwe Stöhr wrote: > this commit makes LyX uncompilable for me: > >..\..\..\src\support\lstrings.cpp(1399): error C2780: 'const _Ty > &std::max(const _Ty &,const _Ty &,_Pr)': expects 3 arguments - 2 > supported [D:\LyXGit\Master\compile-result\src\support\support.vcxproj] >..\..\..\src\supp

Re: [LyX/master] Shut up compiler warning

2015-05-14 Thread Georg Baum
Stephan Witt wrote: > Please, what's the compiler switch to enable these warnings? > I don't see them. Neither with the settings of automake nor > with the settings of cmake builds. autoconf with --enable-warnings and gcc 4.9 (this enables -Wall -Wextra - Wfloat-conversion, I guess the last one i

math macro crashes again (bug 9490)

2015-05-13 Thread Georg Baum
Hi, after a lot of debugging I understand now what happens in http://www.lyx.org/trac/ticket/9490. As you may recall, the last math macro crash I fixed (9418) was caused by a broken ArgumentProxy::mathMacro_ pointer. At that time, I assumed that the only place where an ArgumentProxy can occur

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-12 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 10/05/2015 18:29, Georg Baum a écrit : >> Sorry, I should have tried before asking. Of course there were not all >> needed backports done yet. The attached version is the minimal I could >> find. >> >> I had include the removal

Re: [patch] support to set box features in the box dialog

2015-05-11 Thread Georg Baum
Uwe Stöhr wrote: > Am 10.05.2015 um 16:52 schrieb Uwe Stöhr: > >> If you insist in having the new feature not to be truncated, I have to >> output ERT. > > The attached better patch does this. It also addresses now tex2lyx. > >> In general we should think about dropping the support to revert >>

Re: [LyX/master] GuiBox.cpp: fix button logic (fixes bug #9543)

2015-05-11 Thread Georg Baum
Uwe Stöhr wrote: > (Git drives me crazy. It is so complicated on Windows. I wished that > there would be a lecture to learn how it is used on Windows. For example > the merging fails so often for me so that I have to edit files manually.) This is not windows related. In almost all non-trivial cas

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-10 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 10/05/2015 10:24, Georg Baum a écrit : >> Richard Heck wrote: >> >>> This is fine for branch if the people who understand this stuff (not me) >>> think it is. >> >> Jean-Marc, Kornel, do I have your OK? > > I ca

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-10 Thread Georg Baum
Richard Heck wrote: > This is fine for branch if the people who understand this stuff (not me) > think it is. Jean-Marc, Kornel, do I have your OK? > I'm sure we need it there, since people will want to build LyX with > these tools. Yes. Georg

Re: Failure to compile lyx with gcc 5.1 with the new ABI

2015-05-10 Thread Georg Baum
Abdelrazak Younes wrote: > IIRC, the idea at the time with strfwd.h (done by André) was to reduce > compile time and it worked like a charm with the compilers at that time. > Now with modern compilers and STL, is much cheaper... For my taste LyX does still compile too slowly. However, I do not k

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-10 Thread Georg Baum
Kornel Benko wrote: > I am excited! I was about to make the needed changes for cmake, but you > already have done it. Nice. If possible I try to adapt cmake, but I have to admit that I do not succeed very often. The syntax looks so strange to my eyes. Georg

Re: C++ question about auto_ptr

2015-05-08 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > With C++11, auto_ptr is deprecated and we get warnings. > > I am trying to see how we can get rid of it. unique_ptr is new to C++11, > so I'd rather avoid that. Why not use unique_ptr fpr C++11 and auto_ptr else? The difference is in the copying semantics, which do

Re: Failure to compile lyx with gcc 5.1 with the new ABI

2015-05-08 Thread Georg Baum
José Matos wrote: > While testing what packages failed with the new ABI one of the cases is > LyX (2.1.3), the first builder to fail was the x86_64 one and this is why > this message refers to it: > > https://kojipkgs.fedoraproject.org//work/tasks/1267/9651267/build.log > > The failures start at

Re: Failure to compile lyx with gcc 5.1 with the new ABI

2015-05-07 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 04/05/2015 18:27, José Matos a écrit : >> The failures start at the begin, so there is no need to go down to find >> the culprit. >> >> Any idea about what is wrong here? > > What happens if you remove the following: > > ./../support/strfwd.h:59:59: note: candida

Re: [LyX/master] pdfform.module: repair whitespace

2015-05-05 Thread Georg Baum
Uwe Stöhr wrote: > Now I see, your tabs have a width of 8 characters instead of 4. > Therefore you thought that the alignment was broken. Please do not treat a tab as if it was a shortcut for 8 or 4 spaces (or any other number). A tab is a symbol on its own, and every decent editor (including t

Re: Bundling SumatraPDF with LyX on Windows

2015-05-05 Thread Georg Baum
Scott Kostyshak wrote: > My motivation for this proposal is that in so many cases I have seen > "LyX doesn't open/update my PDF" and when SumatraPDF is proposed, I > see responses of "that works" and "wow I like this PDF reader". Here > are some examples: +1 > A final advantage of bundling Sumat

Re: [LyX/master] Support item argument in linguistic examples

2015-05-05 Thread Georg Baum
Kornel Benko wrote: > After this change, 100% of tex2lyx tests passed. > Someone has to verify though, that no other changes were needed > for this new format. There is a simple algorithm for this: Is the lyx2lyx conversion empty? => no change needed in tex2lyx. Otherwise, look at the lyx2lyx co

Re: cannot compile tex2lyx in current master

2015-04-08 Thread Georg Baum
Kornel Benko wrote: > Am Montag, 6. April 2015 um 02:22:24, schrieb Uwe Stöhr >> Tex2lyx cannot be compiled and the problem is commit: >> >> http://www.lyx.org/trac/changeset/66fa801e74e1775b31008df548332436ce79e2e1/lyxgit >> >> by JMarc. Reverting this commit makes LyX compilable for me. >>

Re: [ugly patch] fix bug 9418

2015-04-05 Thread Georg Baum
Georg Baum wrote: > All ArgumentProxy instances are contained in MathMacro::expanded_, which > means that there is always a unique parent-child like relationship between > MathMacro and ArgumentProxy. Therefore, a single place exists where > ArgumentProxy::mathMacro_ can become invali

Re: Math.lyx export to latex

2015-04-01 Thread Georg Baum
Guenter Milde wrote: > On 2015-03-31, Kornel Benko wrote: > > >> What is a good name for the subdir? > > Similar to the behaviour of web browsers when downloading HTML+images, I'd > name it "-files/" i.e. for "math.tex" it > would becomd "math-files/" This looks good. I have a vague memory th

Re: [ugly patch] fix bug 9418

2015-04-01 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 31/03/2015 21:38, Georg Baum a écrit : >>> BTW updateMacros is quite heavy on big documents (#5973) and I have >>> medium-term plans for making the update lazy. This may become >>> unnecessary if you can do another kind of miracle. My

Re: Text::autoBreakRow_ , is it dead code???

2015-03-31 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > One is supposed to use inset-toggle to put a math inset (e.g. a fraction > in a formula) in a closed state, where the cursor cannot eenter in the > inset. This state is saved in the .lyx file. Thanks for the explanation. > Actually, I am not sure anymore that it is

Re: Compiling the new europasscv.lyx with ps2pdf or dvipdfmx or dviluatex?

2015-03-31 Thread Georg Baum
Scott Kostyshak wrote: > Is it possible to compile europasscv.lyx using ps2pdf or dvipdfmx or > dviluatex? When I try it, I get an error "cannot determine size of > graphic..." > > Stefan (the author of europasscv.lyx) was kind enough to take a look, > reproduce the errors I got, and give a detai

Re: what does "..." mean in our GUI menus/buttons?

2015-03-31 Thread Georg Baum
Scott Kostyshak wrote: > In the LaTeX Errors dialog, what doe the "..." mean in "View Complete > Log..." ? Does it have anything to do with signalling to the user that > another menu will follow? In some of the menu entries with following > dialogs I see "..." but in others I do not. For example,

Re: [ugly patch] fix bug 9418

2015-03-31 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Could you tell us a little bit about ArgumentProxy and what is is good > for? It is used for macros with arguments. Each argument of a math macro is one cell of the macro. An ArgumentProxy is the expanded representation of such a cell. It has basically no own data

Re: Math.lyx export to latex

2015-03-30 Thread Georg Baum
Kornel Benko wrote: > Am Montag, 30. März 2015 um 22:23:38, schrieb Georg Baum > >> Unfortunately I don't have time to investigate now, but I'd guess that >> neither Exporter.cpp nor TempFile is the culprit. It is normal for the >> conversion process to use tem

Re: [ugly patch] fix bug 9418

2015-03-30 Thread Georg Baum
Richard Heck wrote: > On 03/22/2015 09:14 AM, Georg Baum wrote: >> Jean-Marc Lasgouttes wrote: >> >>> Le 20/03/15 21:53, Georg Baum a écrit : >>>> The real cause for the bug is that ArgumentProxy::mathMacro_ is a >>>> reference to an object wh

Re: Math.lyx export to latex

2015-03-30 Thread Georg Baum
Kornel Benko wrote: > This is a recipe to observe creation of files in lyx-source > > 1.) copy {lyx-source}/lib/doc/Math.lyx to a local directory, say > ~/lyx/test/. This is not needed, but shows that the behaviour does not > depend on the path of Math.lyx > 2.) use your lyx from the build direct

<    3   4   5   6   7   8   9   10   11   12   >