Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-06 Thread Pavel Sanda
Scott Kostyshak wrote: > On Mon, Aug 5, 2013 at 3:10 PM, Pavel Sanda wrote: > > Kornel Benko wrote: > >> I do not agree. We should check attic too IMHO (or else do not provide it). > >> Therefore I prefer you to commit :) > > > > We "provide it" :) > > Have you ever looked at the junk in developme

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-06 Thread Kornel Benko
Am Montag, 5. August 2013 um 19:42:25, schrieb Scott Kostyshak > On Mon, Aug 5, 2013 at 3:10 PM, Pavel Sanda wrote: > > Kornel Benko wrote: > >> I do not agree. We should check attic too IMHO (or else do not provide it). > >> Therefore I prefer you to commit :) > > > > We "provide it" :) > > Hav

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Scott Kostyshak
On Mon, Aug 5, 2013 at 3:10 PM, Pavel Sanda wrote: > Kornel Benko wrote: >> I do not agree. We should check attic too IMHO (or else do not provide it). >> Therefore I prefer you to commit :) > > We "provide it" :) > Have you ever looked at the junk in development/attic? It's almost definition > th

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Scott Kostyshak
On Mon, Aug 5, 2013 at 7:48 AM, Kornel Benko wrote: > Am Montag, 5. August 2013 um 07:41:31, schrieb Scott Kostyshak > > >> On Mon, Aug 5, 2013 at 7:34 AM, Kornel Benko wrote: > >> > Am Montag, 5. August 2013 um 07:07:58, schrieb Scott Kostyshak > >> > > >> > > >> >> On Mon, Aug 5, 2013 at 6:02

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Pavel Sanda
Kornel Benko wrote: > I do not agree. We should check attic too IMHO (or else do not provide it). > Therefore I prefer you to commit :) We "provide it" :) Have you ever looked at the junk in development/attic? It's almost definition that we put files there if they are no more functional. The only

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Kornel Benko
Am Montag, 5. August 2013 um 14:50:19, schrieb Vincent van Ravesteijn > Op 5-8-2013 14:37, Kornel Benko schreef: > > > > Am Montag, 5. August 2013 um 08:22:19, schrieb Scott Kostyshak > > > > > > > On Mon, Aug 5, 2013 at 8:09 AM, Kornel Benko wrote: > > > > > > Am Montag, 5. August 2013 um 08:

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Scott Kostyshak
On Mon, Aug 5, 2013 at 8:53 AM, Vincent van Ravesteijn wrote: > Op 3-8-2013 9:54, Scott Kostyshak schreef: > >> On Fri, Aug 2, 2013 at 2:36 PM, Kornel Benko wrote: >>> >>> Am Freitag, 2. August 2013 um 20:06:40, schrieb Vincent van Ravesteijn >>> >>> > Why should we update? This is also the

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Scott Kostyshak
On Mon, Aug 5, 2013 at 8:50 AM, Vincent van Ravesteijn wrote: > Op 5-8-2013 14:37, Kornel Benko schreef: > > Am Montag, 5. August 2013 um 08:22:19, schrieb Scott Kostyshak > > >> On Mon, Aug 5, 2013 at 8:09 AM, Kornel Benko wrote: > >> > Am Montag, 5. August 2013 um 08:01:08, schrieb Scott Kosty

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Vincent van Ravesteijn
Op 3-8-2013 9:54, Scott Kostyshak schreef: On Fri, Aug 2, 2013 at 2:36 PM, Kornel Benko wrote: Am Freitag, 2. August 2013 um 20:06:40, schrieb Vincent van Ravesteijn Why should we update? This is also the test for lyx2lyx, isn't it? No, this is not the way to test lyx2lyx. Vincent Sorry,

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Kornel Benko
Am Montag, 5. August 2013 um 14:40:12, schrieb Vincent van Ravesteijn > Op 5-8-2013 13:07, Scott Kostyshak schreef: > > On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn wrote: > >> Op 4-8-2013 22:23, Scott Kostyshak schreef: > >> > >>> On Sat, Aug 3, 2013 at 3:54 AM, Scott Kostyshak wrote

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Vincent van Ravesteijn
Op 5-8-2013 14:37, Kornel Benko schreef: Am Montag, 5. August 2013 um 08:22:19, schrieb Scott Kostyshak > On Mon, Aug 5, 2013 at 8:09 AM, Kornel Benko wrote: > > Am Montag, 5. August 2013 um 08:01:08, schrieb Scott Kostyshak > > > > > >> On Mon, Aug 5, 2013 at 5:56 AM, Pavel Sanda wro

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Vincent van Ravesteijn
Op 5-8-2013 13:07, Scott Kostyshak schreef: On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn wrote: Op 4-8-2013 22:23, Scott Kostyshak schreef: On Sat, Aug 3, 2013 at 3:54 AM, Scott Kostyshak wrote: On Fri, Aug 2, 2013 at 5:58 AM, Vincent van Ravesteijn wrote: On Fri, Aug 2, 2013 at

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Kornel Benko
Am Montag, 5. August 2013 um 08:22:19, schrieb Scott Kostyshak > On Mon, Aug 5, 2013 at 8:09 AM, Kornel Benko wrote: > > Am Montag, 5. August 2013 um 08:01:08, schrieb Scott Kostyshak > > > > > >> On Mon, Aug 5, 2013 at 5:56 AM, Pavel Sanda wrote: > > > >> > Scott Kostyshak wrote: > > > >> >>

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Scott Kostyshak
On Mon, Aug 5, 2013 at 8:09 AM, Kornel Benko wrote: > Am Montag, 5. August 2013 um 08:01:08, schrieb Scott Kostyshak > > >> On Mon, Aug 5, 2013 at 5:56 AM, Pavel Sanda wrote: > >> > Scott Kostyshak wrote: > >> >> > Sorry, I meant "This is also a test for lyx2lyx, isn't it?" > >> >> > >> >> My op

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Kornel Benko
Am Montag, 5. August 2013 um 08:01:08, schrieb Scott Kostyshak > On Mon, Aug 5, 2013 at 5:56 AM, Pavel Sanda wrote: > > Scott Kostyshak wrote: > >> > Sorry, I meant "This is also a test for lyx2lyx, isn't it?" > >> > >> My opinion is that we should update those documents. I agree that it > > > >

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Scott Kostyshak
On Mon, Aug 5, 2013 at 5:56 AM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> > Sorry, I meant "This is also a test for lyx2lyx, isn't it?" >> >> My opinion is that we should update those documents. I agree that it > > attic is just garbage and it is somewhat absurd that test should fail > becaus

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Kornel Benko
Am Montag, 5. August 2013 um 07:41:31, schrieb Scott Kostyshak > On Mon, Aug 5, 2013 at 7:34 AM, Kornel Benko wrote: > > Am Montag, 5. August 2013 um 07:07:58, schrieb Scott Kostyshak > > > > > >> On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn > >> wrote: > > > > [snip] > > > >> > As f

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Scott Kostyshak
On Mon, Aug 5, 2013 at 7:34 AM, Kornel Benko wrote: > Am Montag, 5. August 2013 um 07:07:58, schrieb Scott Kostyshak > > >> On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn >> wrote: > > [snip] > >> > As far as I see it, it cannot happen that there is no >> > default_output_format. > >> >

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Kornel Benko
Am Montag, 5. August 2013 um 07:07:58, schrieb Scott Kostyshak > On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn wrote: [snip] > > As far as I see it, it cannot happen that there is no default_output_format. > > > Only if there are lyx files with an old file format. In that case: > > > >

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Kornel Benko
Am Montag, 5. August 2013 um 12:02:00, schrieb Vincent van Ravesteijn > Op 4-8-2013 22:23, Scott Kostyshak schreef: > > On Sat, Aug 3, 2013 at 3:54 AM, Scott Kostyshak wrote: > >> On Fri, Aug 2, 2013 at 5:58 AM, Vincent van Ravesteijn > >> wrote: > >>> On Fri, Aug 2, 2013 at 11:45 AM, Kornel B

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Pavel Sanda
Scott Kostyshak wrote: > > Sorry, I meant "This is also a test for lyx2lyx, isn't it?" > > My opinion is that we should update those documents. I agree that it attic is just garbage and it is somewhat absurd that test should fail because of some contents in there. Please create proper tests for t

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Vincent van Ravesteijn
Op 4-8-2013 22:23, Scott Kostyshak schreef: On Sat, Aug 3, 2013 at 3:54 AM, Scott Kostyshak wrote: On Fri, Aug 2, 2013 at 5:58 AM, Vincent van Ravesteijn wrote: On Fri, Aug 2, 2013 at 11:45 AM, Kornel Benko wrote: About the patch... why do we care about malformed LyX documents ? How can thi

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-05 Thread Scott Kostyshak
On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn wrote: > Op 4-8-2013 22:23, Scott Kostyshak schreef: > >> On Sat, Aug 3, 2013 at 3:54 AM, Scott Kostyshak wrote: >>> >>> On Fri, Aug 2, 2013 at 5:58 AM, Vincent van Ravesteijn >>> wrote: On Fri, Aug 2, 2013 at 11:45 AM, Kornel Benk

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-04 Thread Scott Kostyshak
On Sat, Aug 3, 2013 at 3:54 AM, Scott Kostyshak wrote: > On Fri, Aug 2, 2013 at 5:58 AM, Vincent van Ravesteijn wrote: >> >> On Fri, Aug 2, 2013 at 11:45 AM, Kornel Benko wrote: >>> >>> > About the patch... why do we care about malformed LyX documents ? How >>> > can >>> >>> > this happen ? Are

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-03 Thread Scott Kostyshak
On Fri, Aug 2, 2013 at 5:58 AM, Vincent van Ravesteijn wrote: > > On Fri, Aug 2, 2013 at 11:45 AM, Kornel Benko wrote: >> >> > About the patch... why do we care about malformed LyX documents ? How >> > can >> >> > this happen ? Are there some documents in a very old fileformat. Then we >> >> > sh

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-03 Thread Scott Kostyshak
On Fri, Aug 2, 2013 at 2:36 PM, Kornel Benko wrote: > Am Freitag, 2. August 2013 um 20:06:40, schrieb Vincent van Ravesteijn > > >> > Why should we update? This is also the test for lyx2lyx, isn't it? > >> > > >> > >> No, this is not the way to test lyx2lyx. > >> > >> Vincent > > > > Sorry, I mea

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-02 Thread Kornel Benko
Am Freitag, 2. August 2013 um 20:06:40, schrieb Vincent van Ravesteijn > > Why should we update? This is also the test for lyx2lyx, isn't it? > > > > No, this is not the way to test lyx2lyx. > > Vincent Sorry, I meant "This is also a test for lyx2lyx, isn't it?" Kornel signature.asc

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-02 Thread Vincent van Ravesteijn
Op 2-8-2013 18:18, Kornel Benko schreef: Am Freitag, 2. August 2013 um 11:58:46, schrieb Vincent van Ravesteijn > On Fri, Aug 2, 2013 at 11:45 AM, Kornel Benko wrote: > > > ** > > > > > > > About the patch... why do we care about malformed LyX documents ? How can > > > > > this hap

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-02 Thread Kornel Benko
Am Freitag, 2. August 2013 um 11:58:46, schrieb Vincent van Ravesteijn > On Fri, Aug 2, 2013 at 11:45 AM, Kornel Benko wrote: > > > ** > > > > > > > About the patch... why do we care about malformed LyX documents ? How can > > > > > this happen ? Are there some documents in a very old fileforma

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-02 Thread Vincent van Ravesteijn
On Fri, Aug 2, 2013 at 11:45 AM, Kornel Benko wrote: > ** > > > > About the patch... why do we care about malformed LyX documents ? How can > > > this happen ? Are there some documents in a very old fileformat. Then we > > > should update those. > > > > At least now the tests will show it. > If

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-02 Thread Kornel Benko
Am Freitag, 2. August 2013 um 11:06:36, schrieb Vincent van Ravesteijn > On Fri, Aug 2, 2013 at 10:39 AM, Scott Kostyshak wrote: > > > On Fri, Aug 2, 2013 at 4:25 AM, Vincent van Ravesteijn > > wrote: > > > > > > > > > > > > On Fri, Aug 2, 2013 at 2:00 AM, Scott Kostyshak > > wrote: > > >> >

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-02 Thread Vincent van Ravesteijn
On Fri, Aug 2, 2013 at 10:39 AM, Scott Kostyshak wrote: > On Fri, Aug 2, 2013 at 4:25 AM, Vincent van Ravesteijn > wrote: > > > > > > > > On Fri, Aug 2, 2013 at 2:00 AM, Scott Kostyshak > wrote: > >> > >> If a .lyx file has no 'default_output_format' property > >> (that is, not even 'default'),

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-02 Thread Scott Kostyshak
On Fri, Aug 2, 2013 at 4:25 AM, Vincent van Ravesteijn wrote: > > > > On Fri, Aug 2, 2013 at 2:00 AM, Scott Kostyshak wrote: >> >> If a .lyx file has no 'default_output_format' property >> (that is, not even 'default'), then it is malformed and >> the test should fail. >> >> Before this patch, we

Re: [PATCH] CMake: tests now fail if no default_output_format

2013-08-02 Thread Vincent van Ravesteijn
On Fri, Aug 2, 2013 at 2:00 AM, Scott Kostyshak wrote: > If a .lyx file has no 'default_output_format' property > (that is, not even 'default'), then it is malformed and > the test should fail. > > Before this patch, we guess that the correct format to test with is 'pdf'. > > Comments? > > I do

[PATCH] CMake: tests now fail if no default_output_format

2013-08-01 Thread Scott Kostyshak
If a .lyx file has no 'default_output_format' property (that is, not even 'default'), then it is malformed and the test should fail. Before this patch, we guess that the correct format to test with is 'pdf'. Comments? Scott From 9ec76ee7f68037f900c458b25fc3510ec8b78e3f Mon Sep 17 00:00:00 2001 F