Re: [patch] - GIT - version control for LyX documents not detected

2016-01-19 Thread Stephan Witt
> Am 19.01.2016 um 08:09 schrieb Stephan Witt : > > Am 19.01.2016 um 07:56 schrieb Peter Kümmel : >> >> Am 18. Januar 2016 23:25:03 MEZ, schrieb Pavel Sanda : >> Stephan Witt wrote: >> The attached patch fixes the broken detection of GIT

Re: [patch] - GIT - version control for LyX documents not detected

2016-01-18 Thread Peter Kümmel
Am 18. Januar 2016 23:25:03 MEZ, schrieb Pavel Sanda : >Stephan Witt wrote: >> The attached patch fixes the broken detection of GIT version control. >> It seems so that Qt is caching the file meta data and fools the test >> of file emptiness. Perhaps this has changed with Qt5 and

Re: [patch] - GIT - version control for LyX documents not detected

2016-01-18 Thread Stephan Witt
Am 19.01.2016 um 07:56 schrieb Peter Kümmel : > > Am 18. Januar 2016 23:25:03 MEZ, schrieb Pavel Sanda : > Stephan Witt wrote: > The attached patch fixes the broken detection of GIT version control. > It seems so that Qt is caching the file meta data and

Re: [patch] - GIT - version control for LyX documents not detected

2016-01-18 Thread Pavel Sanda
Stephan Witt wrote: > The attached patch fixes the broken detection of GIT version control. > It seems so that Qt is caching the file meta data and fools the test > of file emptiness. Perhaps this has changed with Qt5 and didn???t happen > with Qt4??? Bad news, if your analysis is correct, we

Re: [patch] - GIT - version control for LyX documents not detected

2016-01-18 Thread Pavel Sanda
Richard Heck wrote: > And, as I think is said there, we've seen issues with this, when using > filesystems with > significant latency, e.g., over NFS. It'd be worth adding a comment to > isFileEmpty() so > this question doesn't keep arising. Committed. P

[patch] - GIT - version control for LyX documents not detected

2016-01-16 Thread Stephan Witt
The attached patch fixes the broken detection of GIT version control. It seems so that Qt is caching the file meta data and fools the test of file emptiness. Perhaps this has changed with Qt5 and didn’t happen with Qt4… A proper solution for VCS would move doVCCommandWithOutput to

Re: [patch] - GIT - version control for LyX documents not detected

2016-01-16 Thread Scott Kostyshak
On Sat, Jan 16, 2016 at 11:13:23PM +0100, Stephan Witt wrote: > The attached patch fixes the broken detection of GIT version control. > It seems so that Qt is caching the file meta data and fools the test > of file emptiness. Perhaps this has changed with Qt5 and didn’t happen > with Qt4… A proper

Re: [patch] - GIT - version control for LyX documents not detected

2016-01-16 Thread Richard Heck
On 01/16/2016 05:27 PM, Scott Kostyshak wrote: On Sat, Jan 16, 2016 at 11:13:23PM +0100, Stephan Witt wrote: Perhaps a better fix is to disable QFileInfo caching or to call fi.refresh() every time in FileName::isFileEmpty()? Is anybody aware of other places having this kind of problem? Yes, I