On Tue, 3 Oct 2000, Angus Leeming wrote:
[...virtual keyword...]
At least that much is settled.
> If I were you, I'd make the FormBase methods ok(), apply(), cancel() and
> restore() non-virtual.
No. If I were me, and I'm pretty sure I still am, I wouldn't.
These functions are precisely th
> Ok I understand that but you then would need some support functions to not
> make the input() function a monster function, wouldn't you?
Lord, no. More like:
void FormBase::InputCB(FL_OBJECT * ob, long data)
{
FormDocument * pre = static_cast(ob->form->u_vdata);
pre->bc_.valid(pre->inp
On 03-Oct-2000 Angus Leeming wrote:
> So that I have a pointer to a (say) button AND a long argument telling me
> that this callback is from that button?
>
Yes!
> The only thing we'd gain by having a single InputCB() function that calls a
> single input() function is code consistency. All t
> Well Lars this isn't casting pointer, he just uses the long argument
> of the callback and redo the input() function with the long argument
> insed of the object pointer (IMO we should send both, the object pointer
> AND the long argument!) and then uses this long argument!
So that I have a poi
Angus Leeming <[EMAIL PROTECTED]> writes:
| On Tue, 03 Oct 2000, Lars Gullik Bjønnes wrote:
| > Angus Leeming <[EMAIL PROTECTED]> writes:
| > | 3. We could lose all of those extra CB functions in FormDocument by
| > | making use of the "long" variable that is returned. We'd end up with
| > |
| >
On 03-Oct-2000 Lars Gullik Bjønnes wrote:
>| 3. We could lose all of those extra CB functions in FormDocument by making
>| use of the "long" variable that is returned. We'd end up with
>|
>| void FormBase::InputCB(FL_OBJECT * ob, long data )
>| {
>| FormBase * pre = static_cast(ob->form->u
Angus Leeming <[EMAIL PROTECTED]> writes:
| 3. We could lose all of those extra CB functions in FormDocument by making
| use of the "long" variable that is returned. We'd end up with
|
| void FormBase::InputCB(FL_OBJECT * ob, long data )
| {
| FormBase * pre = static_cast(ob->form->u_vda
Allan Rae <[EMAIL PROTECTED]> writes:
| On Mon, 2 Oct 2000, Angus Leeming wrote:
|
| > Attached are 3 patches
| >
| > patch-insets cleans up the use of Buffer * by InsetBibtex and InsetInclude
| >
| > patch-redundant removes some functions/variables from mathed that are
| > declared but not u
> I'm wondering if we should remove all those "virtual"s I added in the
> classes derived from FormBase since they are declared private in the
> derived classes whereas they are protected in FormBase. We don't want to
> derive from the derived classes (apart from perhaps FormCommand) so we
> shou
On 02-Oct-2000 Angus Leeming wrote:
> Attached are 3 patches
>
> patch-insets cleans up the use of Buffer * by InsetBibtex and InsetInclude
>
I'll apply this one! Good move!
> patch-redundant removes some functions/variables from mathed that are
> declared but not used. The result of compili
On Tue, 3 Oct 2000, Allan Rae wrote:
[ Adding virtual tags in derived classes ]
> The functions in the parent are virtual and usually when you define a
> derived class you make the derived functions virtual also (unless you
> don't want anyone deriving from your derived class). Adding virtual t
On Tue, 3 Oct 2000, Andre Poenitz wrote:
> > But the picky compiler is more likely to complain about taking a protected
> > function private I think.
>
> If Picky Compiler complains with an error, Picky Compiler is broken.
> If it gives a diagnostic - fair enough, compilers are free to give
> di
> But the picky compiler is more likely to complain about taking a protected
> function private I think.
If Picky Compiler complains with an error, Picky Compiler is broken.
If it gives a diagnostic - fair enough, compilers are free to give
diagnostics if they think there is something "unusual" b
On Mon, 2 Oct 2000, Angus Leeming wrote:
> Attached are 3 patches
>
> patch-insets cleans up the use of Buffer * by InsetBibtex and InsetInclude
>
> patch-redundant removes some functions/variables from mathed that are
> declared but not used. The result of compiling extra-picky!
haven't look
Attached are 3 patches
patch-insets cleans up the use of Buffer * by InsetBibtex and InsetInclude
patch-redundant removes some functions/variables from mathed that are
declared but not used. The result of compiling extra-picky!
patch-xforms cleans up the frontend/xforms directory in some small
15 matches
Mail list logo
