Re: About bug 3118: editing first row of long math insets is impossible

2007-01-21 Thread Abdelrazak Younes
Andre Poenitz wrote: On Fri, Jan 19, 2007 at 12:18:35PM +0100, Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: Indeed but first we have to make sure that the CoordCache is properly filled in for all insets. We can do that recursively as is done in the rowpainter. One have

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-21 Thread Abdelrazak Younes
Andre Poenitz wrote: On Fri, Jan 19, 2007 at 11:39:40AM +0100, Georg Baum wrote: If we make sure that the coord cache is always set in the metrics method as Abdel suggests, There must be a misunderstanding somewhere. The metrics phase only determines _sizes_. The coord cache records

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-21 Thread Georg Baum
Andre Poenitz wrote: On Fri, Jan 19, 2007 at 11:39:40AM +0100, Georg Baum wrote: If we make sure that the coord cache is always set in the metrics method as Abdel suggests, There must be a misunderstanding somewhere. The metrics phase only determines _sizes_. The coord cache records

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-21 Thread Abdelrazak Younes
Andre Poenitz wrote: On Fri, Jan 19, 2007 at 12:18:35PM +0100, Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: Indeed but first we have to make sure that the CoordCache is properly filled in for all insets. We can do that recursively as is done in the rowpainter. One have

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-21 Thread Abdelrazak Younes
Andre Poenitz wrote: On Fri, Jan 19, 2007 at 11:39:40AM +0100, Georg Baum wrote: If we make sure that the coord cache is always set in the metrics method as Abdel suggests, There must be a misunderstanding somewhere. The metrics phase only determines _sizes_. The coord cache records

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-21 Thread Georg Baum
Andre Poenitz wrote: > On Fri, Jan 19, 2007 at 11:39:40AM +0100, Georg Baum wrote: >> If we make sure that the coord cache is always >> set in the metrics method as Abdel suggests, > > There must be a misunderstanding somewhere. The metrics phase only > determines _sizes_. The coord cache

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-20 Thread Georg Baum
Abdelrazak Younes wrote: Georg Baum wrote: I am not going to rip the draw machinery apart right now, because I don't know enough about it and I also think that now is not the right moment to do so. Well, your patch is much riskier believe me. I don't think so: I added the

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-20 Thread Andre Poenitz
On Fri, Jan 19, 2007 at 11:39:40AM +0100, Georg Baum wrote: If we make sure that the coord cache is always set in the metrics method as Abdel suggests, There must be a misunderstanding somewhere. The metrics phase only determines _sizes_. The coord cache records _positions_. Andre'

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-20 Thread Andre Poenitz
On Fri, Jan 19, 2007 at 12:18:35PM +0100, Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: Indeed but first we have to make sure that the CoordCache is properly filled in for all insets. We can do that recursively as is done in the rowpainter. One have to extract the part

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-20 Thread Georg Baum
Abdelrazak Younes wrote: > Georg Baum wrote: > > I am not going to rip the draw machinery apart right now, because I don't > > know enough about it and I also think that now is not the right moment to > > do so. > > Well, your patch is much riskier believe me. I don't think so: I added the

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-20 Thread Andre Poenitz
On Fri, Jan 19, 2007 at 11:39:40AM +0100, Georg Baum wrote: > If we make sure that the coord cache is always > set in the metrics method as Abdel suggests, There must be a misunderstanding somewhere. The metrics phase only determines _sizes_. The coord cache records _positions_. Andre'

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-20 Thread Andre Poenitz
On Fri, Jan 19, 2007 at 12:18:35PM +0100, Abdelrazak Younes wrote: > Georg Baum wrote: > >Abdelrazak Younes wrote: > > > >>Indeed but first we have to make sure that the CoordCache is properly > >>filled in for all insets. We can do that recursively as is done in the > >>rowpainter. One have to

About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Georg Baum
This bug is driving me mad currently. Abdel gave some explanation: http://bugzilla.lyx.org/show_bug.cgi?id=3118#c3 Unfortunately I don't understand it. AFAIK the coord cache is set by calling setPosCache(pi, x, y); in an inset. I did not check all insets, but in those I checked (including

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Abdelrazak Younes
Georg Baum wrote: This bug is driving me mad currently. Abdel gave some explanation: http://bugzilla.lyx.org/show_bug.cgi?id=3118#c3 Unfortunately I don't understand it. AFAIK the coord cache is set by calling setPosCache(pi, x, y); in an inset. I did not check all insets, but in those I

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Edwin Leuven
not really related i guess but will we get rid one day of the blinking cursor at the beginning of the math inset when we click inside the inset? it is very annoying i think... Abdelrazak Younes wrote: Georg Baum wrote: This bug is driving me mad currently. Abdel gave some explanation:

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Georg Baum
Abdelrazak Younes wrote: Indeed but first we have to make sure that the CoordCache is properly filled in for all insets. We can do that recursively as is done in the rowpainter. One have to extract the part that calls setPosCache() and transfer that in BufferView::updateMetris(). setPoscache

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Abdelrazak Younes
Edwin Leuven wrote: not really related i guess but will we get rid one day of the blinking cursor at the beginning of the math inset when we click inside the inset? it is very annoying i think... This is related. See my comment in InsetMathNest::lfunMousePress(): // FIXME: we have to

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Indeed but first we have to make sure that the CoordCache is properly filled in for all insets. We can do that recursively as is done in the rowpainter. One have to extract the part that calls setPosCache() and transfer that in

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Georg Baum
Abdelrazak Younes wrote: Georg Baum wrote: So it looks to me that there is a conceptual problem regarding the coord cache. Indeed. OK, but we are no going to change that for 1.5.0 I guess. If you can live without the corners, uncommenting the last line for each of the LFUN would solve

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: As I said, there is way to solved that issue differently by painting the corners independently from the text. I am not going to rip the draw machinery apart right now, because I don't know enough about it and I also think that now is not the right

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: As I said, there is way to solved that issue differently by painting the corners independently from the text. I am not going to rip the draw machinery apart right now, because I don't know enough about it and I also think

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: As I said, there is way to solved that issue differently by painting the corners independently from the text. I am not going to rip the draw machinery apart right now, because I don't know enough

About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Georg Baum
This bug is driving me mad currently. Abdel gave some explanation: http://bugzilla.lyx.org/show_bug.cgi?id=3118#c3 Unfortunately I don't understand it. AFAIK the coord cache is set by calling setPosCache(pi, x, y); in an inset. I did not check all insets, but in those I checked (including

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Abdelrazak Younes
Georg Baum wrote: This bug is driving me mad currently. Abdel gave some explanation: http://bugzilla.lyx.org/show_bug.cgi?id=3118#c3 Unfortunately I don't understand it. AFAIK the coord cache is set by calling setPosCache(pi, x, y); in an inset. I did not check all insets, but in those I

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Edwin Leuven
not really related i guess but will we get rid one day of the blinking cursor at the beginning of the math inset when we click inside the inset? it is very annoying i think... Abdelrazak Younes wrote: Georg Baum wrote: This bug is driving me mad currently. Abdel gave some explanation:

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Georg Baum
Abdelrazak Younes wrote: > Indeed but first we have to make sure that the CoordCache is properly > filled in for all insets. We can do that recursively as is done in the > rowpainter. One have to extract the part that calls setPosCache() and > transfer that in BufferView::updateMetris().

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Abdelrazak Younes
Edwin Leuven wrote: not really related i guess but will we get rid one day of the blinking cursor at the beginning of the math inset when we click inside the inset? it is very annoying i think... This is related. See my comment in InsetMathNest::lfunMousePress(): // FIXME: we have to

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: Indeed but first we have to make sure that the CoordCache is properly filled in for all insets. We can do that recursively as is done in the rowpainter. One have to extract the part that calls setPosCache() and transfer that in

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Georg Baum
Abdelrazak Younes wrote: > Georg Baum wrote: >> So it >> looks to me that there is a conceptual problem regarding the coord cache. > > Indeed. OK, but we are no going to change that for 1.5.0 I guess. >>> If you can live without the corners, uncommenting the last line for each >>> of the >>>

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: As I said, there is way to solved that issue differently by painting the corners independently from the text. I am not going to rip the draw machinery apart right now, because I don't know enough about it and I also think that now is not the right

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: As I said, there is way to solved that issue differently by painting the corners independently from the text. I am not going to rip the draw machinery apart right now, because I don't know enough about it and I also think

Re: About bug 3118: editing first row of long math insets is impossible

2007-01-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: As I said, there is way to solved that issue differently by painting the corners independently from the text. I am not going to rip the draw machinery apart right now, because I don't know enough