Re: Fix for vertical table border for added column

Am Freitag, 25. August 2017 um 08:48:23, schrieb racoon > On 24.08.2017 16:16, Kornel Benko wrote: > > Am Donnerstag, 24. August 2017 um 12:34:47, schrieb racoon > > ... > >> I am selecting (row 3, column 1) to (row 4, column 4). > >> > >>> 3.) add the bottom of

Re: Fix for vertical table border for added column

On 24.08.2017 16:16, Kornel Benko wrote: Am Donnerstag, 24. August 2017 um 12:34:47, schrieb racoon ... I am selecting (row 3, column 1) to (row 4, column 4). 3.) add the bottom of the row In the dialog I click on the bottom of the previewed cell. 4.) use apply ==> the

Re: Fix for vertical table border for added column

Am Donnerstag, 24. August 2017 um 12:34:47, schrieb racoon ... > I am selecting (row 3, column 1) to (row 4, column 4). > > > 3.) add the bottom of the row > > In the dialog I click on the bottom of the previewed cell. > > > 4.) use apply ==> the bottom line disappears > >

Re: Fix for vertical table border for added column

On 23.08.2017 20:39, Kornel Benko wrote: Am Mittwoch, 23. August 2017 um 20:20:46, schrieb racoon On 22.08.2017 18:20, Kornel Benko wrote: Am Dienstag, 22. August 2017 um 09:30:48, schrieb racoon On 21.08.2017 23:32, Kornel Benko wrote: Am Montag, 21.

Re: Fix for vertical table border for added column

Am Mittwoch, 23. August 2017 um 20:20:46, schrieb racoon > On 22.08.2017 18:20, Kornel Benko wrote: > > Am Dienstag, 22. August 2017 um 09:30:48, schrieb racoon > >> On 21.08.2017 23:32, Kornel Benko wrote: > >>> Am Montag, 21. August 2017 um 22:24:10, schrieb

Re: Fix for vertical table border for added column

On 22.08.2017 18:20, Kornel Benko wrote: Am Dienstag, 22. August 2017 um 09:30:48, schrieb racoon On 21.08.2017 23:32, Kornel Benko wrote: Am Montag, 21. August 2017 um 22:24:10, schrieb racoon Playing with the new settings now ... It is somehow requiring

Re: Fix for vertical table border for added column

Am Dienstag, 22. August 2017 um 09:30:48, schrieb racoon > On 21.08.2017 23:32, Kornel Benko wrote: > > Am Montag, 21. August 2017 um 22:24:10, schrieb racoon > >>> Playing with the new settings now ... > >>> It is somehow requiring getting used to ... but I

Re: Fix for vertical table border for added column

Le 22/08/2017 à 01:29, racoon a écrit : Thanks! I did a "git pull -- rebase" on the master. But it seems neither to affect the branch I created for the table fixes, nor the patches I create relative to master. When I do a "git pull" on my branch I get the following message: You need to

Re: Fix for vertical table border for added column

On 21.08.2017 23:32, Kornel Benko wrote: Am Montag, 21. August 2017 um 22:24:10, schrieb racoon Playing with the new settings now ... It is somehow requiring getting used to ... but I like it. I am not sure I follow. What "new settings"? Daniel I am able to set arbitrary

Re: Fix for vertical table border for added column

On 21.08.2017 22:31, Jean-Marc Lasgouttes wrote: Le 21/08/2017 à 14:54, racoon a écrit : I manually applied the second patch now. There was a missing line in your patch ...     -    // fall through Sorry for the inconvenience. I don't know how the comment got missing. The was changed

Re: Fix for vertical table border for added column

Am Montag, 21. August 2017 um 22:24:10, schrieb racoon > > Playing with the new settings now ... > > It is somehow requiring getting used to ... but I like it. > > I am not sure I follow. What "new settings"? > > Daniel I am able to set arbitrary borders with the table

Re: Fix for vertical table border for added column

Le 21/08/2017 à 14:54, racoon a écrit : I manually applied the second patch now. There was a missing line in your patch ... -// fall through Sorry for the inconvenience. I don't know how the comment got missing. The was changed recently by Juergen. You should update your tree

Re: Fix for vertical table border for added column

On 20.08.2017 20:17, Kornel Benko wrote: Am Sonntag, 20. August 2017 um 16:20:15, schrieb racoon On 20.08.2017 04:13, Jean-Marc Lasgouttes wrote: Le 19/08/2017 à 20:30, Kornel Benko a écrit : Am Samstag, 19. August 2017 um 19:52:18, schrieb Jean-Marc Lasgouttes

Re: Fix for vertical table border for added column

Am Sonntag, 20. August 2017 um 16:20:15, schrieb racoon > On 20.08.2017 04:13, Jean-Marc Lasgouttes wrote: > > Le 19/08/2017 à 20:30, Kornel Benko a écrit : > >> Am Samstag, 19. August 2017 um 19:52:18, schrieb Jean-Marc Lasgouttes > >> > >>> Le 19 août 2017

Re: Fix for vertical table border for added column

On 20.08.2017 04:13, Jean-Marc Lasgouttes wrote: Le 19/08/2017 à 20:30, Kornel Benko a écrit : Am Samstag, 19. August 2017 um 19:52:18, schrieb Jean-Marc Lasgouttes Le 19 août 2017 19:44:01 GMT+02:00, Kornel Benko a écrit : I prefer to wait for a new

Re: Fix for vertical table border for added column

Le 19/08/2017 à 20:30, Kornel Benko a écrit : Am Samstag, 19. August 2017 um 19:52:18, schrieb Jean-Marc Lasgouttes Le 19 août 2017 19:44:01 GMT+02:00, Kornel Benko a écrit : I prefer to wait for a new patch. Did you apply the 0001 patch first? JMarc

Re: Fix for vertical table border for added column

Am Samstag, 19. August 2017 um 19:52:18, schrieb Jean-Marc Lasgouttes > Le 19 août 2017 19:44:01 GMT+02:00, Kornel Benko a écrit : > >I prefer to wait for a new patch. > > Did you apply the 0001 patch first? > > JMarc With 0001 or without, the patch 0002

Re: Fix for vertical table border for added column

Le 19 août 2017 19:44:01 GMT+02:00, Kornel Benko a écrit : >I prefer to wait for a new patch. Did you apply the 0001 patch first? JMarc

Re: Fix for vertical table border for added column

Am Samstag, 19. August 2017 um 13:14:26, schrieb Jean-Marc Lasgouttes > Le 19 août 2017 10:31:25 GMT+02:00, Kornel Benko a écrit : > > > >Thanks for the hint Jean-Marc. > > > >Using "git am", I get: > > Applying: Fix for double lines created by "set all

Re: Fix for vertical table border for added column

Le 19 août 2017 10:31:25 GMT+02:00, Kornel Benko a écrit : > >Thanks for the hint Jean-Marc. > >Using "git am", I get: > Applying: Fix for double lines created by "set all lines" and "set >border lines". > error: patch failed: src/insets/InsetTabular.cpp:5781 >

Re: Fix for vertical table border for added column

Am Samstag, 19. August 2017 um 10:14:18, schrieb Jean-Marc Lasgouttes > Le 18 août 2017 14:01:05 GMT+02:00, Kornel Benko a écrit : > >The patch > >0002-Fix-for-double-lines-created-by-set-all-lines-and-se.patch does > >not apply cleanly. > > > >patching file

Re: Fix for vertical table border for added column

Le 18 août 2017 14:01:05 GMT+02:00, Kornel Benko a écrit : >The patch >0002-Fix-for-double-lines-created-by-set-all-lines-and-se.patch does >not apply cleanly. > >patching file src/insets/InsetTabular.cpp >Hunk #1 succeeded at 5443 (offset 6 lines). >Hunk #2 FAILED at 5780. >1 out

Re: Fix for vertical table border for added column

Am Samstag, 19. August 2017 um 13:00:06, schrieb racoon > On 18.08.2017 21:31, Kornel Benko wrote: > > Am Freitag, 18. August 2017 um 20:48:07, schrieb racoon > >> On 18.08.2017 02:22, Scott Kostyshak wrote: > >>> On Thu, Aug 17, 2017 at 02:03:45PM +0930, racoon

Re: Fix for vertical table border for added column

On 18.08.2017 21:31, Kornel Benko wrote: Am Freitag, 18. August 2017 um 20:48:07, schrieb racoon On 18.08.2017 02:22, Scott Kostyshak wrote: On Thu, Aug 17, 2017 at 02:03:45PM +0930, racoon wrote: Attached is a patch that Thanks for the patches, racoon! I have other stuff

Re: Fix for vertical table border for added column

On 19.08.2017 04:16, Scott Kostyshak wrote: On Fri, Aug 18, 2017 at 08:48:07PM +0930, racoon wrote: On 18.08.2017 02:22, Scott Kostyshak wrote: On Thu, Aug 17, 2017 at 02:03:45PM +0930, racoon wrote: Attached is a patch that Thanks for the patches, racoon! I have other stuff on my plate so

Re: Fix for vertical table border for added column

On Fri, Aug 18, 2017 at 08:48:07PM +0930, racoon wrote: > On 18.08.2017 02:22, Scott Kostyshak wrote: > > On Thu, Aug 17, 2017 at 02:03:45PM +0930, racoon wrote: > > > > > Attached is a patch that > > > > Thanks for the patches, racoon! I have other stuff on my plate so I > > won't take a look

Re: Fix for vertical table border for added column

Am Freitag, 18. August 2017 um 20:48:07, schrieb racoon > On 18.08.2017 02:22, Scott Kostyshak wrote: > > On Thu, Aug 17, 2017 at 02:03:45PM +0930, racoon wrote: > > > >> Attached is a patch that > > > > Thanks for the patches, racoon! I have other stuff on my plate so I > >

Re: Fix for vertical table border for added column

On 18.08.2017 02:22, Scott Kostyshak wrote: On Thu, Aug 17, 2017 at 02:03:45PM +0930, racoon wrote: Attached is a patch that Thanks for the patches, racoon! I have other stuff on my plate so I won't take a look at them for a while. If no other developer takes a look at them, can you please

Re: Fix for vertical table border for added column

On Thu, Aug 17, 2017 at 02:03:45PM +0930, racoon wrote: > Attached is a patch that Thanks for the patches, racoon! I have other stuff on my plate so I won't take a look at them for a while. If no other developer takes a look at them, can you please ping me at some point after 2.3.0 is released?

Re: Fix for vertical table border for added column

On 17.08.2017 14:03, racoon wrote: However, I think ultimately double lines and single lines should be separate functions such that one gets double lines only when explicitly required. (See also writer apps like Libre, etc.) Yes, the more I think about it the more sense it makes to go for a

Re: Fix for vertical table border for added column

On 17.08.2017 12:47, racoon wrote: On 17.08.2017 12:11, racoon wrote: On 05.06.2017 05:32, Scott Kostyshak wrote: On Thu, May 25, 2017 at 09:45:52AM -0400, Scott Kostyshak wrote: On Wed, May 24, 2017 at 08:07:52AM +0200, racoon wrote: Thanks. Yes, it is still not patched in latest master so

Re: Fix for vertical table border for added column

On Wed, Aug 16, 2017 at 8:41 PM, racoon wrote: > > I suggest that instead it turns on all left and top lines plus the right > and bottom lines in the last row and column, respectively. > > I could look at that too, if desired. > This user would be quite happy if the described

Re: Fix for vertical table border for added column

On 05.06.2017 05:32, Scott Kostyshak wrote: On Thu, May 25, 2017 at 09:45:52AM -0400, Scott Kostyshak wrote: On Wed, May 24, 2017 at 08:07:52AM +0200, racoon wrote: Thanks. Yes, it is still not patched in latest master so I guess it is pending. Feel free to take a look. OK I'll put this on

Re: Fix for vertical table border for added column

On Thu, May 25, 2017 at 09:45:52AM -0400, Scott Kostyshak wrote: > On Wed, May 24, 2017 at 08:07:52AM +0200, racoon wrote: > > > Thanks. Yes, it is still not patched in latest master so I guess it is > > pending. > > > > Feel free to take a look. > > OK I'll put this on my list of things to

Re: Fix for vertical table border for added column

On Wed, May 24, 2017 at 08:07:52AM +0200, racoon wrote: > Thanks. Yes, it is still not patched in latest master so I guess it is > pending. > > Feel free to take a look. OK I'll put this on my list of things to look at. Scott signature.asc Description: PGP signature

Re: Fix for vertical table border for added column

On 24.05.2017 04:53, Scott Kostyshak wrote: On Sun, May 07, 2017 at 03:31:30PM +0200, Guillaume MM wrote: Le 15/02/2017 à 04:24, Scott Kostyshak a écrit : On Tue, Oct 18, 2016 at 11:03:21PM +0200, racoon wrote: On 18.10.2016 21:35, racoon wrote: I think the attached fix leads to more

Re: Fix for vertical table border for added column

On Sun, May 07, 2017 at 03:31:30PM +0200, Guillaume MM wrote: > Le 15/02/2017 à 04:24, Scott Kostyshak a écrit : > > On Tue, Oct 18, 2016 at 11:03:21PM +0200, racoon wrote: > > > On 18.10.2016 21:35, racoon wrote: > > > > I think the attached fix leads to more intuitive results for added table > >

Re: Fix for vertical table border for added column

Le 15/02/2017 à 04:24, Scott Kostyshak a écrit : On Tue, Oct 18, 2016 at 11:03:21PM +0200, racoon wrote: On 18.10.2016 21:35, racoon wrote: I think the attached fix leads to more intuitive results for added table borders. This solves one strange case: 1. create a new table (with the default

Re: Fix for vertical table border for added column

On Tue, Oct 18, 2016 at 11:03:21PM +0200, racoon wrote: > On 18.10.2016 21:35, racoon wrote: > > I think the attached fix leads to more intuitive results for added table > > borders. > > > > This solves one strange case: > > 1. create a new table (with the default borders, in particular the last

Re: Fix for vertical table border for added column

On 18.10.2016 21:35, racoon wrote: I think the attached fix leads to more intuitive results for added table borders. This solves one strange case: 1. create a new table (with the default borders, in particular the last row has the borders |c|) column not row I meant. 2. add a column after

Re: Fix for vertical table border for added column

On 18.10.2016 21:35, racoon wrote: I think the attached fix leads to more intuitive results for added table borders. This solves one strange case: 1. create a new table (with the default borders, in particular the last row has the borders |c|) 2. add a column after the last most right) column

Fix for vertical table border for added column

I think the attached fix leads to more intuitive results for added table borders. This solves one strange case: 1. create a new table (with the default borders, in particular the last row has the borders |c|) 2. add a column after the last most right) column Actual result: - The last two