Re: Scrolling lag in 1.5svn again, more details.

2007-06-04 Thread Helge Hafting
Peter Kümmel wrote: I've applied attached patch which only eats page up/down keys on x11 and fixes the scrollbar scrolling bug. This is a conservative approach. And because we really need more testing until the release it is now in svn (I know, I know, I know,... but somehow this thread must fin

Re: Scrolling lag in 1.5svn again, more details.

2007-06-03 Thread Peter Kümmel
Dov Feldstern wrote: > Peter Kümmel wrote: >> I've applied attached patch which only eats page up/down keys on x11 >> and fixes the scrollbar scrolling bug. This is a conservative approach. >> >> And because we really need more testing until the release it >> is now in svn (I know, I know, I know,.

Re: Scrolling lag in 1.5svn again, more details.

2007-06-02 Thread Dov Feldstern
Peter Kümmel wrote: I've applied attached patch which only eats page up/down keys on x11 and fixes the scrollbar scrolling bug. This is a conservative approach. And because we really need more testing until the release it is now in svn (I know, I know, I know,... but somehow this thread must fin

Re: Scrolling lag in 1.5svn again, more details.

2007-06-02 Thread Peter Kümmel
I've applied attached patch which only eats page up/down keys on x11 and fixes the scrollbar scrolling bug. This is a conservative approach. And because we really need more testing until the release it is now in svn (I know, I know, I know,... but somehow this thread must find an end, and we could

Re: Scrolling lag in 1.5svn again, more details.

2007-06-01 Thread Martin Vermeer
On Fri, Jun 01, 2007 at 01:44:32PM +0300, Martin Vermeer wrote: > On Thu, May 31, 2007 at 11:22:56PM +0200, Lars Gullik Bjønnes wrote: ... > > | keys, and Martin had a counter-argument, 'word completion': > > > > then put my queue of events back in and we can controll the events > > ourselves. q

Re: Scrolling lag in 1.5svn again, more details.

2007-06-01 Thread Martin Vermeer
On Thu, May 31, 2007 at 11:22:56PM +0200, Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Peter Kümmel wrote: > | >> | Or happens the dropping only to auto repeated keys? > | >> > | >> Only auto-repeated keys. > | > > | > OK, if you are really sure only auto-repeated k

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Peter Kümmel wrote: > | >> | Or happens the dropping only to auto repeated keys? > | >> > | >> Only auto-repeated keys. > | > > | > OK, if you are really sure only auto-repeated keys will be dropped, > | > I think your pa

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread José Matos
On Thursday 31 May 2007 22:05:31 Lars Gullik Bjønnes wrote: > Yes, quite sure > > + if (e->isAutoRepeat()) { > +  ... > + } Could you shove it in, please? > -- > Lgb -- José Abílio

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Peter Kümmel wrote: | >> | Or happens the dropping only to auto repeated keys? | >> | >> Only auto-repeated keys. | > | > OK, if you are really sure only auto-repeated keys will be dropped, | > I think your patch should go into RC1. | | BUT, I also had

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Lars Gullik Bjønnes wrote: > | > Peter Kümmel <[EMAIL PROTECTED]> writes: > | > > | > | > If you go aab > | > | > then the b, might be dropped. I have not tested. > | > | > > | > | > B

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Peter Kümmel wrote: >> | Or happens the dropping only to auto repeated keys? >> >> Only auto-repeated keys. > > OK, if you are really sure only auto-repeated keys will be dropped, > I think your patch should go into RC1. BUT, I also had a Qt based patch which only discards auto repeated keys, and

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Peter Kümmel <[EMAIL PROTECTED]> writes: | > | > | > If you go aab | > | > then the b, might be dropped. I have not tested. | > | > | > | > But sure, quite a few will be dropped. (w

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | > If you go aab > | > then the b, might be dropped. I have not tested. > | > > | > But sure, quite a few will be dropped. (which is just what we > | > want if we are too slow to ge

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | > If you go aab | > then the b, might be dropped. I have not tested. | > | > But sure, quite a few will be dropped. (which is just what we | > want if we are too slow to get them in.) | > | | What if you have a

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Peter Kümmel wrote: > | > > | > And no keys will be dropped? > | > > | > We could also put in your patch, as it is only a problem on Linux. > | > Do you think we could use QApplication::synxX() instead of the X11 > | > c

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Lars Gullik Bjønnes wrote: > | > Peter Kümmel <[EMAIL PROTECTED]> writes: > | > > | > | José Matos wrote: > | > | > On Thursday 24 May 2007 18:17:37 Peter Kümmel wrote: > | > | >> The event_1 patch gives better results

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Peter Kümmel wrote: | > | > And no keys will be dropped? | > | > We could also put in your patch, as it is only a problem on Linux. | > Do you think we could use QApplication::synxX() instead of the X11 | > call? | | The Qt code: | http://websvn.kde.o

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Peter Kümmel <[EMAIL PROTECTED]> writes: | > | > | José Matos wrote: | > | > On Thursday 24 May 2007 18:17:37 Peter Kümmel wrote: | > | >> The event_1 patch gives better results on systems | > | >> with a fast enough grap

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Peter Kümmel wrote: > > And no keys will be dropped? > > We could also put in your patch, as it is only a problem on Linux. > Do you think we could use QApplication::synxX() instead of the X11 > call? The Qt code: http://websvn.kde.org/*checkout*/trunk/qt-copy/src/gui/kernel/qapplication_x11.cpp

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
José Matos <[EMAIL PROTECTED]> writes: | On Thursday 31 May 2007 20:50:54 Lars Gullik Bjønnes wrote: | > My patch works for all "key" variants. that is entered through | > auto-keying. Basically all key events that we failt to handle because | > auto-repeat is too fast are dropped. | | What is

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | José Matos wrote: > | > On Thursday 24 May 2007 18:17:37 Peter Kümmel wrote: > | >> The event_1 patch gives better results on systems > | >> with a fast enough graphic card(?) but does not work > | >> an older systems. >

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread José Matos
On Thursday 31 May 2007 20:50:54 Lars Gullik Bjønnes wrote: > My patch works for all "key" variants. that is entered through > auto-keying. Basically all key events that we failt to handle because > auto-repeat is too fast are dropped. What is the drawback then? > -- > Lgb -- José Abí

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | José Matos wrote: | > On Thursday 24 May 2007 18:17:37 Peter Kümmel wrote: | >> The event_1 patch gives better results on systems | >> with a fast enough graphic card(?) but does not work | >> an older systems. | >> | >> Jose feel free to do what you wa

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread José Matos
On Thursday 31 May 2007 20:35:06 Peter Kümmel wrote: > But one patch which at least fixes the pageup/down-key scrolling > should go in before RC1. I intend to release RC1 really soon now, so this patch must wait for RC2. > Peter -- José Abílio

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread Peter Kümmel
José Matos wrote: > On Thursday 24 May 2007 18:17:37 Peter Kümmel wrote: >> The event_1 patch gives better results on systems >> with a fast enough graphic card(?) but does not work >> an older systems. >> >> Jose feel free to do what you want. > > What is the outcome of your email exchange with

Re: Scrolling lag in 1.5svn again, more details.

2007-05-31 Thread José Matos
On Thursday 24 May 2007 18:17:37 Peter Kümmel wrote: > The event_1 patch gives better results on systems > with a fast enough graphic card(?) but does not work > an older systems. > > Jose feel free to do what you want. What is the outcome of your email exchange with Helge and Lars on this subj

Re: Scrolling lag in 1.5svn again, more details.

2007-05-24 Thread Peter Kümmel
No ideas any more--also the last patch does not work (Helge's private reply). I've reverted the first patch, http://www.lyx.org/trac/changeset/18376 because it introduces this bug, http://marc.info/?l=lyx-devel&m=117944188219722&w=2 detected by Dov. The event_1 patch gives better results on syste

Re: Scrolling lag in 1.5svn again, more details.

2007-05-23 Thread Andre Poenitz
On Wed, May 23, 2007 at 12:13:16PM +0200, Helge Hafting wrote: > Dov Feldstern wrote: > >Peter Kümmel wrote: > >> > >>I'm running out of ideas... > >>Is this patch better (the flush call is new)? > >>Or with processEvents instead of flush? > >> > > > >event_2.patch works for me --- but then again e

Re: Scrolling lag in 1.5svn again, more details.

2007-05-23 Thread Helge Hafting
Dov Feldstern wrote: Peter Kümmel wrote: I'm running out of ideas... Is this patch better (the flush call is new)? Or with processEvents instead of flush? event_2.patch works for me --- but then again event_1 did, too. Again, this is on linux. Scrolling appears to be fine (both with arrow k

Re: Scrolling lag in 1.5svn again, more details.

2007-05-22 Thread Peter Kümmel
José Matos wrote: > On Tuesday 22 May 2007 7:26:37 pm Peter Kümmel wrote: >> The current svn code is not correct, even when this patch isn't perfect, >> should I apply it? > > Could you get more people to test it, please? > > This is a sensitive area, just like walking on thin glass. :-) > >

Re: Scrolling lag in 1.5svn again, more details.

2007-05-22 Thread José Matos
On Tuesday 22 May 2007 7:26:37 pm Peter Kümmel wrote: > The current svn code is not correct, even when this patch isn't perfect, > should I apply it? Could you get more people to test it, please? This is a sensitive area, just like walking on thin glass. :-) If by Friday you don't have any

Re: Scrolling lag in 1.5svn again, more details.

2007-05-22 Thread Peter Kümmel
Dov Feldstern wrote: > Peter Kümmel wrote: >> >> I'm running out of ideas... >> Is this patch better (the flush call is new)? >> Or with processEvents instead of flush? >> > > event_2.patch works for me --- but then again event_1 did, too. Again, > this is on linux. Scrolling appears to be fine (b

Re: Scrolling lag in 1.5svn again, more details.

2007-05-21 Thread Dov Feldstern
Peter Kümmel wrote: I'm running out of ideas... Is this patch better (the flush call is new)? Or with processEvents instead of flush? event_2.patch works for me --- but then again event_1 did, too. Again, this is on linux. Scrolling appears to be fine (both with arrow keys and page-up and p

Re: Scrolling lag in 1.5svn again, more details.

2007-05-21 Thread Peter Kümmel
Helge Hafting wrote: > Peter Kümmel wrote: >> Abdelrazak Younes wrote: >> Is this your only comment? >>> Yes. Sorry, don't have the time to do much more. I thought I'd share my >>> opinion ;-) >>> >> >> Sorry, too - for my harsh reply. >> >> Anyway I don't think there

Re: Scrolling lag in 1.5svn again, more details.

2007-05-21 Thread Peter Kümmel
Helge Hafting wrote: > Peter Kümmel wrote: >> Abdelrazak Younes wrote: >> Is this your only comment? >>> Yes. Sorry, don't have the time to do much more. I thought I'd share my >>> opinion ;-) >>> >> >> Sorry, too - for my harsh reply. >> >> Anyway I don't think there

Re: Scrolling lag in 1.5svn again, more details.

2007-05-21 Thread Koji Yokota
Abdelrazak Younes wrote: Martin Vermeer wrote: BTW what do you mean by 'input methods? Here I have a choice of virtual keyboard and handwriting recognition. How is that relevant? Input methods are used in the CJK world to help the writing. The technique is very similar to autocompletion metho

Re: Scrolling lag in 1.5svn again, more details.

2007-05-21 Thread Helge Hafting
Peter Kümmel wrote: Abdelrazak Younes wrote: Is this your only comment? Yes. Sorry, don't have the time to do much more. I thought I'd share my opinion ;-) Sorry, too - for my harsh reply. Anyway I don't think there is a simpler solution, at least I will not look for it, t

Re: Scrolling lag in 1.5svn again, more details.

2007-05-21 Thread Abdelrazak Younes
Martin Vermeer wrote: On Sun, May 20, 2007 at 07:08:59PM +0200, Peter Kümmel wrote: Abdelrazak Younes wrote: ... OK, I've found a better solution ;) I had to test if it was worth to upgrade to 1GB ram. I can understand that. I was thinking of collecting the scroll events and cancelling th

Re: Scrolling lag in 1.5svn again, more details.

2007-05-20 Thread Martin Vermeer
On Sun, May 20, 2007 at 07:08:59PM +0200, Peter Kümmel wrote: > Abdelrazak Younes wrote: ... > OK, I've found a better solution ;) > I had to test if it was worth to upgrade to 1GB ram. > > > > > I can understand that. I was thinking of collecting the scroll events > > and cancelling them if a

Re: Scrolling lag in 1.5svn again, more details.

2007-05-20 Thread Dov Feldstern
Peter Kümmel wrote: Dov Feldstern wrote: Peter Kümmel wrote: On slow/loaded systems the last patch floods the event queue with timer events instead of key/scroll events. I hope attached patch will now really fix the problem. Peter This works for me (timer_scroll_4.patch) --- at least for wha

Re: Scrolling lag in 1.5svn again, more details.

2007-05-20 Thread Peter Kümmel
Dov Feldstern wrote: > Peter Kümmel wrote: >> >> On slow/loaded systems the last patch floods the >> event queue with timer events instead of key/scroll events. >> I hope attached patch will now really fix the problem. >> >> Peter >> > > This works for me (timer_scroll_4.patch) --- at least for wh

Re: Scrolling lag in 1.5svn again, more details.

2007-05-20 Thread Peter Kümmel
Abdelrazak Younes wrote: >> Is this your only comment? > > Yes. Sorry, don't have the time to do much more. I thought I'd share my > opinion ;-) Sorry, too - for my harsh reply. > >> >> Anyway I don't think there is a simpler solution, at least I will >> not look for it, this bug has cost me al

Re: Scrolling lag in 1.5svn again, more details.

2007-05-20 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Peter Kümmel wrote: Next try. To see how it works change the event_delay_ms variable in the constructor to 3000 and use -dbg 12. This looks way too complicated Peter. There must be a simpler solution. Abdel. Is this your only comment? Yes. Sor

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Dov Feldstern
Peter Kümmel wrote: On slow/loaded systems the last patch floods the event queue with timer events instead of key/scroll events. I hope attached patch will now really fix the problem. Peter This works for me (timer_scroll_4.patch) --- at least for what I'm testing, namely, cursor movement b

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Dov Feldstern
Peter Kümmel wrote: Dov Feldstern wrote: The truth is, I don't know that this is directly related to the machine on which it's running. My machine is quite powerful --- it's a Pentium IV 3.0 GHz; and I don't see any jump in the system load when I start scrolling, either: not when I start and the

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Peter Kümmel
Abdelrazak Younes wrote: > Peter Kümmel wrote: >> Next try. To see how it works change the event_delay_ms >> variable in the constructor to 3000 and use -dbg 12. > > This looks way too complicated Peter. There must be a simpler solution. > > Abdel. > You could start with some like the attached

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Peter Kümmel
Abdelrazak Younes wrote: > Peter Kümmel wrote: >> Next try. To see how it works change the event_delay_ms >> variable in the constructor to 3000 and use -dbg 12. > > This looks way too complicated Peter. There must be a simpler solution. > > Abdel. > Is this your only comment? Anyway I don't t

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Abdelrazak Younes
Peter Kümmel wrote: Next try. To see how it works change the event_delay_ms variable in the constructor to 3000 and use -dbg 12. This looks way too complicated Peter. There must be a simpler solution. Abdel.

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Andre Poenitz
On Sat, May 19, 2007 at 10:53:39AM +0200, Peter Kümmel wrote: > > > +#include > > > > not needed will remove it > > > class QWidget; > > > + /// > > + QTimer delayed_scrollbar_sync; > > + /// > > + QTimer delayed_key_event; > > + struct key_info { QKeySymbol* sym; Qt::KeyboardModi

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Peter Kümmel
Peter Kümmel wrote: > Next try. To see how it works change the event_delay_ms > variable in the constructor to 3000 and use -dbg 12. > > > Please test if scrolling works when > > - moving the slider with the mouse > - clicking in the scroll bar > - pressing page up/down keys > - arrow keys > - a

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Peter Kümmel
> +#include > not needed will remove it > class QWidget; > + /// > + QTimer delayed_scrollbar_sync; > + /// > + QTimer delayed_key_event; > + struct key_info { QKeySymbol* sym; Qt::KeyboardModifiers mod; }; > + std::vector delayed_keys; > }; Andre, any tips how to

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Peter Kümmel
Next try. To see how it works change the event_delay_ms variable in the constructor to 3000 and use -dbg 12. Please test if scrolling works when - moving the slider with the mouse - clicking in the scroll bar - pressing page up/down keys - arrow keys - arrow buttons on the scroll bar - using the

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Peter Kümmel
Andre Poenitz wrote: > On Fri, May 18, 2007 at 08:43:12AM +0200, Peter Kümmel wrote: >> Andre Poenitz wrote: === --- src/frontends/qt4/GuiWorkArea.cpp (revision 18380) +++ src/frontends/qt4/GuiWorkArea.cpp (wor

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Peter Kümmel
Andre Poenitz wrote: > On Fri, May 18, 2007 at 08:12:33AM +0200, Peter Kümmel wrote: >> I also realized this while working on this bug. So I dropped my first >> patches and now use isAutoRepeated in the committed patch, by this >> a keystroke produced by a user will never get lost. >> All typed key

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Andre Poenitz
On Fri, May 18, 2007 at 08:43:12AM +0200, Peter Kümmel wrote: > Andre Poenitz wrote: > >> === > >> --- src/frontends/qt4/GuiWorkArea.cpp (revision 18380) > >> +++ src/frontends/qt4/GuiWorkArea.cpp (working copy) > >> @@ -161,

Re: Scrolling lag in 1.5svn again, more details.

2007-05-19 Thread Andre Poenitz
On Fri, May 18, 2007 at 08:12:33AM +0200, Peter Kümmel wrote: > I also realized this while working on this bug. So I dropped my first > patches and now use isAutoRepeated in the committed patch, by this > a keystroke produced by a user will never get lost. > All typed keystrokes are in the event qu

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Richard Heck
Peter Kümmel wrote: > What hasPendingEvents returns makes no sense to me. > Isn't it that there is a queue for all events, and when one > is handled (event-accept()) it is done and removed from the > queue? The truth isin the Qt source code, but who could > read it? > Could this be part of the p

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Martin Vermeer
On Fri, May 18, 2007 at 03:56:30PM +0300, Martin Vermeer wrote: > On Fri, May 18, 2007 at 01:51:40PM +0200, Peter Kümmel wrote: > > > Yes, maybe I could... instead, I used '-dbg key' and entered > > > the strings 'appropriate' and 'laboratories' into an empty file. > > > by typing 'app' and

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Abdelrazak Younes wrote: > Peter Kümmel wrote: >> >> So we can't use isAutoRepeat also not hasPendingEvents. Best idea >> I have is to revert. > > I think so too :-( But that was a nice idea ;-) isAutoRepeat doesn't work because of the word completion, it only returns true for the repeated letter

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Dov Feldstern wrote: > > The truth is, I don't know that this is directly related to the machine > on which it's running. My machine is quite powerful --- it's a Pentium > IV 3.0 GHz; and I don't see any jump in the system load when I start > scrolling, either: not when I start and the cursor is s

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Martin Vermeer
On Fri, May 18, 2007 at 01:51:40PM +0200, Peter Kümmel wrote: > Martin Vermeer wrote: > > On Fri, May 18, 2007 at 12:38:19PM +0200, Abdelrazak Younes wrote: > >> Martin Vermeer wrote: > >>> On Fri, May 18, 2007 at 09:58:59AM +0200, Abdelrazak Younes wrote: > Martin Vermeer wrote: > >>> ... > >

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Abdelrazak Younes
Peter Kümmel wrote: So we can't use isAutoRepeat also not hasPendingEvents. Best idea I have is to revert. I think so too :-( But that was a nice idea ;-) The keyReleaseEvent() solution in bugzilla is probably the best solution. The scrollbar events could be filtered out. Abdel.

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Dov Feldstern
Peter Kümmel wrote: Peter Kümmel wrote: Dov Feldstern wrote: Peter Kümmel wrote: Dov Feldstern wrote: Peter Kümmel wrote: Dov Feldstern wrote: Again, to reproduce, just hold down any of the arrow keys, and keep holding it down. At some point it will just stop moving --- I assume this will h

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Martin Vermeer wrote: > On Fri, May 18, 2007 at 12:38:19PM +0200, Abdelrazak Younes wrote: >> Martin Vermeer wrote: >>> On Fri, May 18, 2007 at 09:58:59AM +0200, Abdelrazak Younes wrote: Martin Vermeer wrote: >>> ... >>> >>> Another scenario: I am typing on my Nokia 770 Internet tablet >>

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Martin Vermeer
On Fri, May 18, 2007 at 12:38:19PM +0200, Abdelrazak Younes wrote: > Martin Vermeer wrote: > >On Fri, May 18, 2007 at 09:58:59AM +0200, Abdelrazak Younes wrote: > >>Martin Vermeer wrote: > > > >... > > > >Another scenario: I am typing on my Nokia 770 Internet tablet > >over a > >vnc co

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Peter Kümmel wrote: >> No :(, if anything it's worse: now holding a key is *always* processed >> as only a single keypress, there's not even an initial period when the >> cursor zooms along... >> > > Seems we could not use QCoreApplication::hasPendingEvents() to check if > the system is busy. Is

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Peter Kümmel wrote: > Dov Feldstern wrote: >> Peter Kümmel wrote: >>> Dov Feldstern wrote: Peter Kümmel wrote: > Dov Feldstern wrote: Again, to reproduce, just hold down any of the arrow keys, and keep holding it down. At some point it will just stop moving --- I assume this

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Helge Hafting wrote: > Peter Kümmel wrote: >> Andre Poenitz wrote: >> +/// +QTimer& delayed_scrollbar_sync; >>> A _reference_? Why? >>> >>> Andre' >>> >>> >> >> Here a updated patch. >> >> > I checked out todays svn and applied this. > > It does *not* help >

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Helge Hafting
Peter Kümmel wrote: Andre Poenitz wrote: + /// + QTimer& delayed_scrollbar_sync; A _reference_? Why? Andre' Here a updated patch. I checked out todays svn and applied this. It does *not* help when holding the mouse down in the jump-scroll area of the scrollb

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Dov Feldstern wrote: > Peter Kümmel wrote: >> Dov Feldstern wrote: >>> Peter Kümmel wrote: Dov Feldstern wrote: > >>> Again, to reproduce, just hold down any of the arrow keys, and keep >>> holding it down. At some point it will just stop moving --- I assume >>> this will happen on any machin

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Dov Feldstern
Peter Kümmel wrote: Dov Feldstern wrote: Peter Kümmel wrote: Dov Feldstern wrote: Again, to reproduce, just hold down any of the arrow keys, and keep holding it down. At some point it will just stop moving --- I assume this will happen on any machine if you hold the key long enough. From the

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Abdelrazak Younes
Martin Vermeer wrote: On Fri, May 18, 2007 at 09:58:59AM +0200, Abdelrazak Younes wrote: Martin Vermeer wrote: ... Another scenario: I am typing on my Nokia 770 Internet tablet over a vnc connection. It does 'word completion', which is like very fast typing... and indeed, in LyX 1.4 charact

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Dov Feldstern wrote: > Peter Kümmel wrote: >> Dov Feldstern wrote: >>> Try navigating by holding down one of the arrow keys. The cursor zooms >>> along (which is what we usually want), until at some point the mechanism >>> added here kicks in, and then the cursor suddenly stops moving. From >>> thi

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Martin Vermeer
On Fri, May 18, 2007 at 09:58:59AM +0200, Abdelrazak Younes wrote: > Martin Vermeer wrote: ... > >>>Another scenario: I am typing on my Nokia 770 Internet tablet > >>>over a > >>>vnc connection. It does 'word completion', which is like very > >>>fast typing... and indeed, in LyX 1.4 characters

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Dov Feldstern
I'll try, but how do I do this? Is there some svn command for reverting to a specific version? i'm not aware of any direct revert command of svn. however you can checkout particular revision of the svn tree (i.e. the 18265 revision). svn up -r VERSION In order to revert a spe

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Abdelrazak Younes wrote: > Helge Hafting wrote: >> Abdelrazak Younes wrote: >>> Helge Hafting wrote: >>> I did this, and recompiled. It did not help, the resulting LyX still have that horrible lagging problem. >>> >>> It is true that LyX has lost some performance lately. The UserGuide >>

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Dov Feldstern
Peter Kümmel wrote: Dov Feldstern wrote: Try navigating by holding down one of the arrow keys. The cursor zooms along (which is what we usually want), until at some point the mechanism added here kicks in, and then the cursor suddenly stops moving. From this point on, key press events are only h

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Abdelrazak Younes
Helge Hafting wrote: Abdelrazak Younes wrote: Helge Hafting wrote: I did this, and recompiled. It did not help, the resulting LyX still have that horrible lagging problem. It is true that LyX has lost some performance lately. The UserGuide PageDown scrolling test is 30 seconds for me right

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Helge Hafting
Abdelrazak Younes wrote: Helge Hafting wrote: I did this, and recompiled. It did not help, the resulting LyX still have that horrible lagging problem. It is true that LyX has lost some performance lately. The UserGuide PageDown scrolling test is 30 seconds for me right now while it was 15

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Jean-Marc Lasgouttes
> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> I also realized this while working on this bug. So I dropped my Peter> first patches and now use isAutoRepeated in the committed Peter> patch, by this a keystroke produced by a user will never get Peter> lost. All typed keystrokes ar

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Andre Poenitz wrote: >> +/// >> +QTimer& delayed_scrollbar_sync; > > A _reference_? Why? > > Andre' > Here a updated patch. -- Peter Kümmel Index: src/frontends/qt4/GuiWorkArea.cpp === --- src/frontends/qt4/GuiWorkArea.c

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Dov Feldstern wrote: > Try navigating by holding down one of the arrow keys. The cursor zooms > along (which is what we usually want), until at some point the mechanism > added here kicks in, and then the cursor suddenly stops moving. From > this point on, key press events are only handled one at a

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Dov Feldstern wrote: > Peter Kümmel wrote: >> Now I have found the best solution: >> >> Full control to the user, means all key events >> produced by the user are processed but generated >> ones are ignored if the system is busy. >> >> Could it go into beta3? >> >> Peter >> > > It's good this is i

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Peter Kümmel
Peter Kümmel wrote: > Andre Poenitz wrote: >>> === >>> --- src/frontends/qt4/GuiWorkArea.cpp (revision 18380) >>> +++ src/frontends/qt4/GuiWorkArea.cpp (working copy) >>> @@ -161,7 +161,7 @@ >>> >>> GuiWorkArea::GuiWorkA

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Abdelrazak Younes
Martin Vermeer wrote: On Fri, May 18, 2007 at 08:55:15AM +0200, Peter Kümmel wrote: Martin Vermeer wrote: On Thu, May 17, 2007 at 10:41:56PM +0200, Andre Poenitz wrote: On Thu, May 17, 2007 at 12:57:29PM +0200, Peter Kümmel wrote: I would feel more comfortable is this were restricted to scrol

Re: Scrolling lag in 1.5svn again, more details.

2007-05-18 Thread Martin Vermeer
On Fri, May 18, 2007 at 08:55:15AM +0200, Peter Kümmel wrote: > Martin Vermeer wrote: > > On Thu, May 17, 2007 at 10:41:56PM +0200, Andre Poenitz wrote: > >> On Thu, May 17, 2007 at 12:57:29PM +0200, Peter Kümmel wrote: > I would feel more comfortable is this were restricted to scrolling, > >>

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Peter Kümmel
Martin Vermeer wrote: > On Thu, May 17, 2007 at 10:41:56PM +0200, Andre Poenitz wrote: >> On Thu, May 17, 2007 at 12:57:29PM +0200, Peter Kümmel wrote: I would feel more comfortable is this were restricted to scrolling, but I take it you extensively tested it with 'usual typing' >>> Curre

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Martin Vermeer
On Thu, May 17, 2007 at 10:41:56PM +0200, Andre Poenitz wrote: > On Thu, May 17, 2007 at 12:57:29PM +0200, Peter Kümmel wrote: > > > I would feel more comfortable is this were restricted to scrolling, > > > but I take it you extensively tested it with 'usual typing' > > > > Currently all generated

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Peter Kümmel
Andre Poenitz wrote: >> === >> --- src/frontends/qt4/GuiWorkArea.cpp(revision 18380) >> +++ src/frontends/qt4/GuiWorkArea.cpp(working copy) >> @@ -161,7 +161,7 @@ >> >> GuiWorkArea::GuiWorkArea(int w, int h, int id,

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Peter Kümmel
Andre Poenitz wrote: > On Thu, May 17, 2007 at 12:57:29PM +0200, Peter Kümmel wrote: >>> I would feel more comfortable is this were restricted to scrolling, >>> but I take it you extensively tested it with 'usual typing' >> Currently all generated events are dropped which couldn't become >> visible

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Dov Feldstern
Peter Kümmel wrote: Now I have found the best solution: Full control to the user, means all key events produced by the user are processed but generated ones are ignored if the system is busy. Could it go into beta3? Peter It's good this is in beta-3 ;) , because I've just found a very annoy

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, May 17, 2007 at 10:53:16PM +0200, Abdelrazak Younes wrote: Abdelrazak Younes wrote: Andre Poenitz wrote: On Thu, May 17, 2007 at 12:57:29PM +0200, Peter Kümmel wrote: I would feel more comfortable is this were restricted to scrolling, but I take it you extensively

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Andre Poenitz
On Thu, May 17, 2007 at 10:53:16PM +0200, Abdelrazak Younes wrote: > Abdelrazak Younes wrote: > >Andre Poenitz wrote: > >>On Thu, May 17, 2007 at 12:57:29PM +0200, Peter Kümmel wrote: > I would feel more comfortable is this were restricted to scrolling, > but I take it you extensively teste

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Andre Poenitz wrote: On Thu, May 17, 2007 at 12:57:29PM +0200, Peter Kümmel wrote: I would feel more comfortable is this were restricted to scrolling, but I take it you extensively tested it with 'usual typing' Currently all generated events are dropped which couldn't

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, May 17, 2007 at 12:57:29PM +0200, Peter Kümmel wrote: I would feel more comfortable is this were restricted to scrolling, but I take it you extensively tested it with 'usual typing' Currently all generated events are dropped which couldn't become visible immediately

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Andre Poenitz
On Thu, May 17, 2007 at 02:03:55PM +0200, Peter Kümmel wrote: > Here a new patch to address Helge's scrolling bug. > The important comment: > > "We circumvent the event queue for scrolling events. > This avoids scrolling after the user has stopped > scrolling, but scrolling proceeds because the >

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Andre Poenitz
On Thu, May 17, 2007 at 12:57:29PM +0200, Peter Kümmel wrote: > > I would feel more comfortable is this were restricted to scrolling, > > but I take it you extensively tested it with 'usual typing' > > Currently all generated events are dropped which couldn't become > visible immediately. But coul

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread José Matos
On Thursday 17 May 2007 13:03:55 Peter Kümmel wrote: > I've found no problems on Win and Linux, but it > should be tested more intensively, so it would be > good to ship it with beta 3, but I assume I'm too > late. You are right on both accounts. :-) If this works and after independent confir

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Peter Kümmel
Here a new patch to address Helge's scrolling bug. The important comment: "We circumvent the event queue for scrolling events. This avoids scrolling after the user has stopped scrolling, but scrolling proceeds because the event queue is full of scroll events. We trigger the scrolling by a timer wh

Re: Scrolling lag in 1.5svn again, more details.

2007-05-17 Thread Peter Kümmel
Andre Poenitz wrote: > On Thu, May 17, 2007 at 09:37:53AM +0200, Peter Kümmel wrote: >> Now I have found the best solution: >> >> Full control to the user, means all key events >> produced by the user are processed but generated >> ones are ignored if the system is busy. >> >> Could it go into beta

  1   2   >