Re: Some work on tex2lyx and Modules

2009-02-12 Thread rgheck
Jean-Marc Lasgouttes wrote: rgheck writes: Well, sort of. But if you remove the #ifdef from ModuleList, then you run into include problems. In particular, we'd have to include LatexFeatures.h in the tex2lyx build, because ModuleList::isAvailable() calls LatexFeatures::isAvailable(). And then

Re: Some work on tex2lyx and Modules

2009-02-12 Thread Jean-Marc Lasgouttes
rgheck writes: > Well, sort of. But if you remove the #ifdef from ModuleList, then you > run into include problems. In particular, we'd have to include > LatexFeatures.h in the tex2lyx build, because > ModuleList::isAvailable() calls LatexFeatures::isAvailable(). And then > LatexFeatures.cpp pulls

Re: Some work on tex2lyx and Modules

2009-02-12 Thread rgheck
Jean-Marc Lasgouttes wrote: rgheck writes: I'm assuming the other test against TEX2LYX is OK (ModuleList.cpp, line 48). In this case, the point is that tex2lyx doesn't care whether the packages needed by various modules are available. It's just converting. If I'm wrong about that, let me kno

Re: Some work on tex2lyx and Modules

2009-02-12 Thread Jean-Marc Lasgouttes
rgheck writes: > I'm assuming the other test against TEX2LYX is OK (ModuleList.cpp, > line 48). In this case, the point is that tex2lyx doesn't care whether > the packages needed by various modules are available. It's just > converting. If I'm wrong about that, let me know. I'd rather pass a bool

Re: Some work on tex2lyx and Modules

2009-02-11 Thread rgheck
Jean-Marc Lasgouttes wrote: Index: src/LayoutModuleList.h +/// +typedef std::list LayoutModuleList; +} Why not support/string_list.h (see docstring_list.h)? Missed this comment This is a temporary measure. As I mentioned in the previous note, this will be a real class shortly. rh

Re: Some work on tex2lyx and Modules

2009-02-11 Thread rgheck
Jean-Marc Lasgouttes wrote: Index: src/LayoutModuleList.h +/// +typedef std::list LayoutModuleList; +} Why not support/string_list.h (see docstring_list.h)? +#ifndef TEX2LYX + if (!lm) { + docstring const msg = + bformat(_("The module %1$s has been requested by\n" + "this document but has

Re: Some work on tex2lyx and Modules

2009-02-11 Thread Jean-Marc Lasgouttes
Index: src/LayoutModuleList.h +/// +typedef std::list LayoutModuleList; +} Why not support/string_list.h (see docstring_list.h)? +#ifndef TEX2LYX + if (!lm) { + docstring const msg = + bformat(_("The module %1

Re: Some work on tex2lyx and Modules

2009-02-11 Thread Richard Heck
Richard Heck wrote: The attached patch moves some things around, so that module info can be made available to tex2lyx. Comments welcome. I think the only other thing that needs doing is for moduleCanBeAdded to be moved. Maybe some other routines could be moved, too, but they don't need to b

Re: Some work on tex2lyx and Modules

2009-02-11 Thread Jean-Marc Lasgouttes
Richard Heck writes: > The attached patch moves some things around, so that module info can > be made available to tex2lyx. Comments welcome. Short and sweet. JMarc

Re: Some work on tex2lyx and Modules

2009-02-11 Thread Jean-Marc Lasgouttes
Richard Heck writes: > The attached patch moves some things around, so that module info can > be made available to tex2lyx. Comments welcome. > > I think the only other thing that needs doing is for moduleCanBeAdded > to be moved. Maybe some other routines could be moved, too, but they > don't ne

Some work on tex2lyx and Modules

2009-02-11 Thread Richard Heck
The attached patch moves some things around, so that module info can be made available to tex2lyx. Comments welcome. I think the only other thing that needs doing is for moduleCanBeAdded to be moved. Maybe some other routines could be moved, too, but they don't need to be, I don't think, for