What's wrong here?

2001-09-19 Thread Juergen Spitzmueller
Hi, While working on the Document Dialog I detected a bug which seems to be there for a long time (it's in 1.1.6 too). It's very easy to reproduce: Go to the Document Dialog and change the class. The nasty popup pops up. Confirm the question: the class options will be reset to default. Now ch

Re: What's wrong here?

2001-09-19 Thread Angus Leeming
On Wednesday 19 September 2001 17:15, Juergen Spitzmueller wrote: > Hi, > > While working on the Document Dialog I detected a bug which seems to be > there for a long time (it's in 1.1.6 too). It's very easy to reproduce: > > Go to the Document Dialog and change the class. The nasty popup pops

Re: What's wrong here?

2001-09-20 Thread Allan Rae
On Wed, 19 Sep 2001, Juergen Spitzmueller wrote: > Hi, > > While working on the Document Dialog I detected a bug which seems to be > there for a long time (it's in 1.1.6 too). It's very easy to reproduce: > > Go to the Document Dialog and change the class. The nasty popup pops > up. Confirm the q

Re: What's wrong here?

2001-09-20 Thread Allan Rae
On 20 Sep 2001, Jean-Marc Lasgouttes wrote: > > "Allan" == Allan Rae <[EMAIL PROTECTED]> writes: > > Allan> On Wed, 19 Sep 2001, Juergen Spitzmueller wrote: > >> Hi, > >> > >> While working on the Document Dialog I detected a bug which seems > >> to be there for a long time (it's in 1.1.6 too

Re: What's wrong here?

2001-09-21 Thread Juergen Spitzmueller
Allan Rae wrote: > Just because a user can't see the changes wouldn't make it > misleading. Changing to a different class in my experience has always > involved saying "yes" to the question -- when you take a paper for a > conference and want to turn it into a journal article you have to > comply

Re: What's wrong here?

2001-09-21 Thread Allan Rae
On Fri, 21 Sep 2001, Juergen Spitzmueller wrote: > Allan Rae wrote: > > Just because a user can't see the changes wouldn't make it > > misleading. Changing to a different class in my experience has always > > involved saying "yes" to the question -- when you take a paper for a > > conference and

Re: What's wrong here?

2001-09-21 Thread Juergen Spitzmueller
Am Freitag, 21. September 2001 10:12 schrieb Allan Rae: > So the user might notice something changed by a flash of a text input > changing or a radio button toggling and wonder: "Did I really see > something change? If so, which one was it?" > > With a warning message or some other feedback they

Re: What's wrong here?

2001-09-21 Thread Juergen Spitzmueller
Am Freitag, 21. September 2001 11:54 schrieb Jean-Marc Lasgouttes: > Juergen> Not always. E.g. in Germany Separation is "Indent" by > Juergen> Default. If I write a doc and want to have it "Skip" instead > Juergen> for some reason, I differ from default settings. If I decide > Juergen> to use scra

Re: What's wrong here?

2001-09-23 Thread Allan Rae
On 21 Sep 2001, Jean-Marc Lasgouttes wrote: > > "Allan" == Allan Rae <[EMAIL PROTECTED]> writes: > > Allan> but think about a newbie and how they will react and how they > Allan> use software. They/we/I usually don't read manuals until all > Allan> else fails. They/we/I push buttons blindly h

Re: What's wrong here?

2001-09-24 Thread Juergen Vigna
On 21-Sep-2001 Jean-Marc Lasgouttes wrote: >> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: > > Juergen> Yes. And I have already moved the save button outside the > Juergen> tabs. I will send you a small patch with this and other few > Juergen> changes, but I can't make a pro

Re: What's wrong here?

2001-09-24 Thread Juergen Spitzmueller
Am Montag, 24. September 2001 11:33 schrieb Juergen Vigna: > Well here some commets: > > 1. the "Save as default" button is over the text-warning (label) > field it should be moved! Oh, yes :-( I will do this. I have seen the field but was not shure what it's about ;-) Thanks. > 2. IMO the Auto

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Spitzmueller
Am Donnerstag, 20. September 2001 07:08 schrieb Allan Rae: > IMO, if the silly class change dialog had been shifted to be > handled when Okay/Apply were pressed this bug also would have been > fixed. > > > I suspect that one of the first lines of the following part of > > FormDocument.C is to blam

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Angus Leeming
On Thursday 20 September 2001 11:21, Juergen Spitzmueller wrote: > Question: do we need this comparision at all? I deleted it and now all > works like a charm. Will there be any unwanted sideeffects, apart from > the case that the class options will be reset to default even if the > user choses

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Angus Leeming
On Thursday 20 September 2001 11:33, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> Is that not an unwanted side-effect? Why not post a message > Angus> rather than a question and only when the params are applied, > Angus> not input, as Allan s

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Spitzmueller
Am Donnerstag, 20. September 2001 12:35 schrieb Angus Leeming: > On Thursday 20 September 2001 11:21, Juergen Spitzmueller wrote: > > Question: do we need this comparision at all? I deleted it and now > > all works like a charm. Will there be any unwanted sideeffects, > > apart from the case that

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Vigna
On 20-Sep-2001 Juergen Spitzmueller wrote: > Auto Reset means that the settings will be reset on any action with the > class choice, and I think the LyX users are intelligent enough to get > this ;-). Personally, I was always annoyed by that question. It > reminded me a little bit on a silly

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Spitzmueller
Am Donnerstag, 20. September 2001 14:00 schrieb Juergen Vigna: > IMO we should still check if there was no change! It's easy enough > and it needs only a private class variable in the FormDocument. So we > won't do anything if we didn't really do anything. But it should work (not like the previou

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Vigna
On 20-Sep-2001 Juergen Spitzmueller wrote: > Am Donnerstag, 20. September 2001 14:00 schrieb Juergen Vigna: >> IMO we should still check if there was no change! It's easy enough >> and it needs only a private class variable in the FormDocument. So we >> won't do anything if we didn't really do an

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Spitzmueller
Am Donnerstag, 20. September 2001 12:29 schrieb Jean-Marc Lasgouttes: > Juergen, is there something special about this patch? I get: > > patch: malformed patch at line 183: + * FormPreferences.C: > Handle that button Oups... sorry. Here's a (hopefully) better one. Jürgen > JMarc doc

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Allan Rae
On Thu, 20 Sep 2001, Juergen Spitzmueller wrote: [...] > Auto Reset means that the settings will be reset on any action with the > class choice, and I think the LyX users are intelligent enough to get > this ;-). [...] > IMHO the new approach is much better than the old one. But of course > you ca

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Allan Rae
On 20 Sep 2001, Jean-Marc Lasgouttes wrote: > > "Garst" == Garst R Reese <[EMAIL PROTECTED]> writes: > > Garst> I do that when I am making a new template or just a new file > Garst> that I want set up like some old file. Open old.lyx and > Garst> new.lyx, look at the comboxes in old, set up n

Re: What's wrong here? [w/ PATCH]

2001-09-21 Thread Juergen Spitzmueller
Am Freitag, 21. September 2001 09:14 schrieb Allan Rae: > Document it. In NEWS and in whichever user manual Mike thinks fits > best (User Guide? but certainly in the Reference manual). Good idea. I will do (after it is decided that this approach will go in and how). Maybe Mike can tell me wher

Re: What's wrong here? [w/ PATCH]

2001-09-20 Thread Juergen Spitzmueller
Am Donnerstag, 20. September 2001 17:20 schrieb Jean-Marc Lasgouttes: > I took a quick look at it and have two remarks: > > 1/ the save button is too small for its label > > 2/ it should not be in a frame together with "reset", since the list > of arguments afected by this is different. Actually,

Re: What's wrong here? [w/ PATCH] (+ Reference manual comment)

2001-09-21 Thread Mike Ressler
Mike weighs in :-) On Fri, 21 Sep 2001, Juergen Spitzmueller wrote: > Am Freitag, 21. September 2001 09:14 schrieb Allan Rae: > > Document it. In NEWS and in whichever user manual Mike thinks fits > > best (User Guide? but certainly in the Reference manual). > > Good idea. I will do (after it i