On Mon, Mar 10, 2003 at 01:30:04PM +, Angus Leeming wrote:
> Incidentally, does the xforms frontend work for you?
No, I have currently 1.3.0 running ("real work" ;-})
But I'll have a look.
Andre'
--
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they d
On Monday 10 March 2003 1:17 pm, Andre Poenitz wrote:
> On Mon, Mar 10, 2003 at 01:11:29PM +, Angus Leeming wrote:
> > To do this I had to move these into InsetBase. Ok with this?
>
> Yes.
Incidentally, does the xforms frontend work for you? I get an instant crash
when I try to load a buffer
On Mon, Mar 10, 2003 at 01:11:29PM +, Angus Leeming wrote:
> To do this I had to move these into InsetBase. Ok with this?
Yes.
Andre'
--
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)
Andre Poenitz wrote:
> class MailInset {
> [...]
> protected:
> ///
> virtual Inset & inset() const = 0;
> [...]
>
> Ideally, I don't have Insets, only InsetBases.
To do this I had to move these into InsetBase. Ok with this?
/// Methods to cache and retrieve a cached BufferView.
On Mon, Mar 10, 2003 at 12:56:59PM +, Angus Leeming wrote:
> I'm not suggesting actually creating a separate process to run the dialogs,
> but it does help clarify the rationale.
Yes, keeping in mind that we just have a pipe between Gui and Kernel is a
good aid to decide where things belong..
On Monday 10 March 2003 12:48 pm, Andre Poenitz wrote:
> On Mon, Mar 10, 2003 at 12:47:34PM +, Angus Leeming wrote:
> > A. I remember now. The bulk of the work is actually done in the
> > _static_ methods params2string and string2params. If I did as you
> > suggest, then I'd have to create
On Monday 10 March 2003 12:13 pm, Andre Poenitz wrote:
> On Mon, Mar 10, 2003 at 11:53:30AM +, Angus Leeming wrote:
> > That's what I have now. I think of class Dialogs as part of the lyx
> > kernel and it is this that stores the InsetBase* in just such a map. The
> > dialogs themselves derive
On Mon, Mar 10, 2003 at 12:47:34PM +, Angus Leeming wrote:
> A. I remember now. The bulk of the work is actually done in the _static_
> methods params2string and string2params. If I did as you suggest, then I'd
> have to create a temporary MailInset just to extract the name.
The name fun
On Mon, Mar 10, 2003 at 01:45:35PM +0100, Jean-Marc Lasgouttes wrote:
> It would work if the name is always the same char array, defined once
> in the inset .C file. And the addresses can be used as inset codes
> too.
But the cicumstances where this is guaranteed to work are rather
fragile... Lars
Andre Poenitz wrote:
> What's the benefit of
>
> virtual string const & name() const { return name_; }
> ///
> static string const name_;
> ...
> string const InsetTabularMailer:: name_("tabular");
>
> over
>
> virtual string const & name() const { return "tabular"; }
A. I remember now. T
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> Andre Poenitz <[EMAIL PROTECTED]> writes:
Lars> | On Mon, Mar 10, 2003 at 12:32:46PM +0100, Lars Gullik Bjønnes wrote:
Lars> | > Angus Leeming <[EMAIL PROTECTED]> writes:
Lars> | >
Lars> | > | > Uh, no. But returning by value s
On Mon, Mar 10, 2003 at 11:53:30AM +, Angus Leeming wrote:
> That's what I have now. I think of class Dialogs as part of the lyx
> kernel and it is this that stores the InsetBase* in just such a map. The
> dialogs themselves derive from class Dialog (note, no 's'). I think of
> them as separate
On Monday 10 March 2003 11:30 am, Andre Poenitz wrote:
> On Mon, Mar 10, 2003 at 11:25:52AM +, Angus Leeming wrote:
> > > Ideally, I don't have Insets, only InsetBases.
> >
> > Sure. That would work too.
>
> So can you change that to InsetBase?
I'll try and make this change and the name one th
On Mon, Mar 10, 2003 at 12:43:08PM +0100, Lars Gullik Bjønnes wrote:
> One reason:
>
> inset1->name() == inset2->name()
>
> Would that work with char const *?
I am aware of the pitfalls.
I suggested to use your preference to avoid this kind of discussion ;-)
Andre'
--
Those who desi
Andre Poenitz <[EMAIL PROTECTED]> writes:
| On Mon, Mar 10, 2003 at 12:32:46PM +0100, Lars Gullik Bjønnes wrote:
| > Angus Leeming <[EMAIL PROTECTED]> writes:
| >
| > | > Uh, no. But returning by value should do no harm.
| > |
| > | I agree that it would simplify things. Would you return a strin
On Mon, Mar 10, 2003 at 12:32:46PM +0100, Lars Gullik Bjønnes wrote:
> Angus Leeming <[EMAIL PROTECTED]> writes:
>
> | > Uh, no. But returning by value should do no harm.
> |
> | I agree that it would simplify things. Would you return a string or a
> | char const* ?
>
> A string.
>
> A const s
On Mon, Mar 10, 2003 at 11:29:25AM +, Angus Leeming wrote:
> > Uh, no. But returning by value should do no harm.
>
> I agree that it would simplify things. Would you return a string or a
> char const* ?
_I_ would return a char const *. But Lars would return a string.
To keep the speed of th
On Mon, Mar 10, 2003 at 11:25:52AM +, Angus Leeming wrote:
> > Ideally, I don't have Insets, only InsetBases.
>
> Sure. That would work too.
So can you change that to InsetBase?
And the rest now is idle talk:
> > The reason of using these MailInsets instead of LFUNs directed to the
> > som
Angus Leeming <[EMAIL PROTECTED]> writes:
| > Uh, no. But returning by value should do no harm.
|
| I agree that it would simplify things. Would you return a string or a
| char const* ?
A string.
A const string even...
--
Lgb
On Monday 10 March 2003 11:13 am, Andre Poenitz wrote:
> On Mon, Mar 10, 2003 at 11:14:33AM +, Angus Leeming wrote:
> > > ///
> > > static string const name_;
> > > ...
> > > string const InsetTabularMailer:: name_("tabular");
> > >
> > > over
> > >
> > > virtual string const & name()
On Monday 10 March 2003 11:11 am, Andre Poenitz wrote:
> On Mon, Mar 10, 2003 at 10:01:38AM +, Angus Leeming wrote:
> > Incidentally, the Tabular dialog now expects a string so you should now
> > be able to have a woking dialog for math arrays. See insettabular.C for
> > the details, but basica
On Mon, Mar 10, 2003 at 11:14:33AM +, Angus Leeming wrote:
> > ///
> > static string const name_;
> > ...
> > string const InsetTabularMailer:: name_("tabular");
> >
> > over
> >
> > virtual string const & name() const { return "tabular"; }
>
> Can you return a reference to t
On Mon, Mar 10, 2003 at 10:01:38AM +, Angus Leeming wrote:
> Incidentally, the Tabular dialog now expects a string so you should now be
> able to have a woking dialog for math arrays. See insettabular.C for the
> details, but basically it expects to extract the current active cell and
> stuf
On Monday 10 March 2003 11:04 am, Andre Poenitz wrote:
> On Mon, Mar 10, 2003 at 10:01:38AM +, Angus Leeming wrote:
> > Incidentally, the Tabular dialog now expects a string so you should now
> > be able to have a woking dialog for math arrays. See insettabular.C for
> > the details, but basica
On Mon, Mar 10, 2003 at 10:01:38AM +, Angus Leeming wrote:
> Incidentally, the Tabular dialog now expects a string so you should now be
> able to have a woking dialog for math arrays. See insettabular.C for the
> details, but basically it expects to extract the current active cell and
> stuf
Andre Poenitz wrote:
> On Mon, Mar 10, 2003 at 09:41:10AM +, Angus Leeming wrote:
>> > > >> We have two sorts of insets.
>> > > >> 1. Insets which can contain data that can be entered in the LyX
>> > > >> screen. 2. Insets whose data can be input only from a dialog.
>>
>> [...]
>>
>> > So do m
On Mon, Mar 10, 2003 at 09:41:10AM +, Angus Leeming wrote:
> > > >> We have two sorts of insets.
> > > >> 1. Insets which can contain data that can be entered in the LyX
> > > >> screen. 2. Insets whose data can be input only from a dialog.
>
> [...]
>
> > So do most MathNestInsets.
>
> Sure.
On Monday 10 March 2003 9:31 am, Andre Poenitz wrote:
> SCNR,
I don't know this one. What's it mean?
Angus
On Monday 10 March 2003 9:29 am, Andre Poenitz wrote:
> On Mon, Mar 10, 2003 at 09:20:58AM +, Angus Leeming wrote:
> > >> We have two sorts of insets.
> > >> 1. Insets which can contain data that can be entered in the LyX
> > >> screen. 2. Insets whose data can be input only from a dialog.
> >
On Mon, Mar 10, 2003 at 10:32:12AM +0100, Jean-Marc Lasgouttes wrote:
> A hint. Stare very intensely at the two following lines from
> LyXAction.C. Do you see something weird?
>
> { LFUN_DIALOG_SHOW_NEW_INSET, "dialog-show-new-inset",
> N_("Show the inset's dialog"),
On Mon, Mar 10, 2003 at 09:20:58AM +, Angus Leeming wrote:
> >> We have two sorts of insets.
> >> 1. Insets which can contain data that can be entered in the LyX screen.
> >> 2. Insets whose data can be input only from a dialog.
> >
> > Which Inset belong to which group?
>
> A little thought
On Monday 10 March 2003 9:32 am, Jean-Marc Lasgouttes wrote:
> A hint. Stare very intensely at the two following lines from
> LyXAction.C. Do you see something weird?
>
> { LFUN_DIALOG_SHOW_NEW_INSET, "dialog-show-new-inset",
> N_("Show the inset's dialog"), Noop },
>
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> That being said, it might indeed make sense to have a single
Angus> insert-inset "name" lfun although at present the code for these
Angus> different lfuns is very different.
That's what I mean. As long as only one of the lfuns make
Andre Poenitz wrote:
> On Mon, Mar 10, 2003 at 09:08:12AM +, Angus Leeming wrote:
>> We have two sorts of insets.
>> 1. Insets which can contain data that can be entered in the LyX screen.
>> 2. Insets whose data can be input only from a dialog.
>
> Which Inset belong to which group?
A littl
On Mon, Mar 10, 2003 at 09:08:12AM +, Angus Leeming wrote:
> We have two sorts of insets.
> 1. Insets which can contain data that can be entered in the LyX screen.
> 2. Insets whose data can be input only from a dialog.
Which Inset belong to which group?
[I think this division is arbitrary an
Jean-Marc Lasgouttes wrote:
>> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]>
>> writes:
>
>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
> Icon "dialog-show-new-inset graphics" "graphics.xpm"
Why ?
>
> Angus> Because it's three lines of code and it's done
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Icon "dialog-show-new-inset graphics" "graphics.xpm"
>>> Why ?
Angus> Because it's three lines of code and it's done in
Angus> ToolbarDefaults.C (which, as you not
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
>>> Icon "dialog-show-new-inset graphics" "graphics.xpm"
>> Why ?
Angus> Because it's three lines of code and it's done in
Angus> ToolbarDefaults.C (which, as you note, is where this code
Angus> should be). Shall I do it?
Thqt does not
On Fri, Mar 07, 2003 at 07:24:50PM +, Angus Leeming wrote:
> This is totally unnecessary jiggery-pokery. Moreover, it leads to a pixmap
Jiggery-pokery, sure. Guesswork .. nope.
> Because it's three lines of code and it's done in ToolbarDefaults.C (which,
> as you note, is where this code s
John Levon wrote:
> On Fri, Mar 07, 2003 at 07:05:05PM +, Angus Leeming wrote:
>
>> Actually, why do we perform this guess-work at all? Why not
>
> It's not guesswork.
Bullshit.
string const name = lyxaction.getActionName(ev.action);
if (!ev.argument.empty())
On Fri, Mar 07, 2003 at 07:05:05PM +, Angus Leeming wrote:
> Actually, why do we perform this guess-work at all? Why not
It's not guesswork.
> Icon "dialog-show-new-inset graphics" "graphics.xpm"
Why ?
john
John Levon wrote:
> On Fri, Mar 07, 2003 at 06:51:23PM +, Angus Leeming wrote:
>
>> Could someone in the know tell me where to find the mapping
>> lfun->pixmap file name
>
> Qt: getIconPixmap
>
> xforms: setPixmap
>
> both in Toolbar_pimpl
>
> Of course, they should both be in the backend
On Fri, Mar 07, 2003 at 06:51:23PM +, Angus Leeming wrote:
> Could someone in the know tell me where to find the mapping
> lfun->pixmap file name
Qt: getIconPixmap
xforms: setPixmap
both in Toolbar_pimpl
Of course, they should both be in the backend ;)
john
Patch attached for info.
Actually, that's a little disingenuous ;-) This patch breaks the Toolbar
graphics icon.
@@ -433,6 +433,6 @@ Toolbar
Icon "marginalnote-insert"
Icon "depth-increment"
Separator
-Icon "graphics-insert"
+Icon "dialog-show-new-inset graphics"
Icon
Patch attached for info.
Angus
On Wednesday 05 March 2003 3:59 pm, [EMAIL PROTECTED] wrote:
> CVSROOT: /usr/local/lyx/cvsroot
> Module name: lyx-devel
> Repository: lyx-devel/src/insets/
> Changes by: [EMAIL PROTECTED] 03/03/05 15:59:38
>
> Modified files:
> lyx-devel/lib/: C
45 matches
Mail list logo