Re: simple [patch] support for verbatim*

2015-12-05 Thread Scott Kostyshak
On Sun, Dec 06, 2015 at 04:56:07AM +0100, Uwe Stöhr wrote: > Am 06.12.2015 um 01:05 schrieb Scott Kostyshak: > > >>I will try to do the tex2lyx part ASAP. The bug that you see is probably > >>because there is some ugly stuff in the environment. I am not sure there is > >>something to fix besides a

Re: simple [patch] support for verbatim*

2015-12-05 Thread Uwe Stöhr
Am 06.12.2015 um 01:05 schrieb Scott Kostyshak: I will try to do the tex2lyx part ASAP. The bug that you see is probably because there is some ugly stuff in the environment. I am not sure there is something to fix besides adding support for verbatim*. Did we fix the tex2lyx part? I committed

Re: simple [patch] support for verbatim*

2015-12-05 Thread Scott Kostyshak
On Sat, Dec 05, 2015 at 07:19:55PM -0500, Richard Heck wrote: > > Did we fix the tex2lyx part? If not, should we make a trac ticket to > > make sure we don't forget about this? > > I think JMarc did it. OK thanks for confirming. Scott signature.asc Description: PGP signature

Re: simple [patch] support for verbatim*

2015-12-05 Thread Richard Heck
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 12/05/2015 07:05 PM, Scott Kostyshak wrote: > On Tue, Nov 24, 2015 at 07:16:02PM +0100, Jean-Marc Lasgouttes wrote: >> Le 24/11/2015 18:57, Richard Heck a écrit : >>> I was mostly thinking that (a) if we're going to add this for 2.2, the >>> tex2

Re: simple [patch] support for verbatim*

2015-12-05 Thread Scott Kostyshak
On Tue, Nov 24, 2015 at 07:16:02PM +0100, Jean-Marc Lasgouttes wrote: > Le 24/11/2015 18:57, Richard Heck a écrit : > >I was mostly thinking that (a) if we're going to add this for 2.2, the > >tex2lyx part should also be done---the rule you quoted applies to > >mid-cycle commits and doesn't say any

Re: simple [patch] support for verbatim*

2015-11-24 Thread Scott Kostyshak
On Tue, Nov 24, 2015 at 03:13:12PM -0500, Richard Heck wrote: > On 11/24/2015 03:05 PM, Georg Baum wrote: > > Of course tex2lyx should either do a perfect roundtrip, or create > > proper ERT for the new feature. If it does not, then this has to be > > fixed. However, if there is a bug in tex2lyx th

Re: simple [patch] support for verbatim*

2015-11-24 Thread Uwe Stöhr
Am 24.11.2015 um 03:10 schrieb Richard Heck: Uwe, please test that this new patch does what you want it to do. I've tested it, but only minimally. Many thanks. It did not work because you output "verbatim" no matter if it was the starred version or not. I corrected this and put it in. Anot

Re: simple [patch] support for verbatim*

2015-11-24 Thread Richard Heck
On 11/24/2015 03:05 PM, Georg Baum wrote: > Of course tex2lyx should either do a perfect roundtrip, or create > proper ERT for the new feature. If it does not, then this has to be > fixed. However, if there is a bug in tex2lyx that makes it produce > invalid output for the new feature, which can al

Re: simple [patch] support for verbatim*

2015-11-24 Thread Georg Baum
Richard Heck wrote: > I was mostly thinking that (a) if we're going to add this for 2.2, the > tex2lyx part should also be done---the rule you quoted applies to > mid-cycle commits and doesn't say anything about what should be done for > a major release---and (b) that the test file I attached (a m

Re: simple [patch] support for verbatim*

2015-11-24 Thread Georg Baum
Uwe Stöhr wrote: > Why do you want to see the obvious changes to the FORMATS file and the > changed digits of the version? They are obvious and only cost you time > to test the patch because you are then forced to a complete > recompilation. (This takes here 15 min). This is indeed too slow. Doe

Re: simple [patch] support for verbatim*

2015-11-24 Thread Jean-Marc Lasgouttes
Le 24/11/2015 18:57, Richard Heck a écrit : I was mostly thinking that (a) if we're going to add this for 2.2, the tex2lyx part should also be done---the rule you quoted applies to mid-cycle commits and doesn't say anything about what should be done for a major release---and (b) that the test fil

Re: simple [patch] support for verbatim*

2015-11-24 Thread Richard Heck
On 11/23/2015 10:33 PM, Scott Kostyshak wrote: > On Mon, Nov 23, 2015 at 09:10:23PM -0500, Richard Heck wrote: > >> Uwe, please test that this new patch does what you want it to do. I've >> tested it, but only minimally. >> >> Another issue is that \verbatim* is not presently handled properly by >>

Re: simple [patch] support for verbatim*

2015-11-23 Thread Scott Kostyshak
On Mon, Nov 23, 2015 at 09:10:23PM -0500, Richard Heck wrote: > Uwe, please test that this new patch does what you want it to do. I've > tested it, but only minimally. > > Another issue is that \verbatim* is not presently handled properly by > tex2lyx. If we are going to add verbatim* support for

Re: simple [patch] support for verbatim*

2015-11-23 Thread Richard Heck
On 11/23/2015 08:23 PM, Scott Kostyshak wrote: > On Tue, Nov 24, 2015 at 02:01:04AM +0100, Uwe Stöhr wrote: >> Am 24.11.2015 um 01:44 schrieb Scott Kostyshak: >> >>> Do you think 'revert_verbatim_star' would be a better name? >> Fine, it is in the attached patch. >> >> Besides these, the new patch

Re: simple [patch] support for verbatim*

2015-11-23 Thread Scott Kostyshak
On Tue, Nov 24, 2015 at 02:01:04AM +0100, Uwe Stöhr wrote: > Am 24.11.2015 um 01:44 schrieb Scott Kostyshak: > > >typo: "einvironments" -> "environments" > > Thanks, fixed in the attached patch. > > >>+ [502, [revert_verbatim]], > > > >Do you think 'revert_verbatim_star' would be a bet

Re: simple [patch] support for verbatim*

2015-11-23 Thread Uwe Stöhr
Am 24.11.2015 um 01:44 schrieb Scott Kostyshak: typo: "einvironments" -> "environments" Thanks, fixed in the attached patch. + [502, [revert_verbatim]], Do you think 'revert_verbatim_star' would be a better name? Fine, it is in the attached patch. Besides these, the new patch

Re: simple [patch] support for verbatim*

2015-11-23 Thread Scott Kostyshak
On Tue, Nov 24, 2015 at 01:28:41AM +0100, Uwe Stöhr wrote: > OK, so we are going to support verbatim* > > >It's possible. If Uwe can post a complete patch, I can try doing it. > > Here it is. > > I don't think it is worth it to create a new function but I am not the > Python expert. If Richard

Re: simple [patch] support for verbatim*

2015-11-23 Thread Uwe Stöhr
OK, so we are going to support verbatim* It's possible. If Uwe can post a complete patch, I can try doing it. Here it is. I don't think it is worth it to create a new function but I am not the Python expert. thanks and regards Uwe development/FORMAT | 5 ++

Re: simple [patch] support for verbatim*

2015-11-23 Thread Richard Heck
On 11/23/2015 02:23 PM, Scott Kostyshak wrote: > On Mon, Nov 23, 2015 at 01:04:56PM -0500, Richard Heck wrote: >> On > 11/23/2015 11:41 AM, Scott Kostyshak wrote: >>> On Mon, Nov 23, 2015 at 11:35:24AM +0100, Jean-Marc Lasgouttes wrote: >> Le 23/11/2015 01:59, Uwe Stöhr a écrit : >>> Am 23.11.2015

Re: simple [patch] support for verbatim*

2015-11-23 Thread Scott Kostyshak
On Mon, Nov 23, 2015 at 01:04:56PM -0500, Richard Heck wrote: > On 11/23/2015 11:41 AM, Scott Kostyshak wrote: > > On Mon, Nov 23, 2015 at 11:35:24AM +0100, Jean-Marc Lasgouttes wrote: >> Le > > 23/11/2015 01:59, Uwe Stöhr a écrit : >>> Am 23.11.2015 um 00:07 > schrieb Scott Kostyshak: >>> I

Re: simple [patch] support for verbatim*

2015-11-23 Thread Richard Heck
On 11/23/2015 11:41 AM, Scott Kostyshak wrote: > On Mon, Nov 23, 2015 at 11:35:24AM +0100, Jean-Marc Lasgouttes wrote: >> Le > 23/11/2015 01:59, Uwe Stöhr a écrit : >>> Am 23.11.2015 um 00:07 schrieb Scott Kostyshak: >>> I wish I had the knowledge to review the patch but I do not >>> >>> I do

Re: simple [patch] support for verbatim*

2015-11-23 Thread Scott Kostyshak
On Mon, Nov 23, 2015 at 11:35:24AM +0100, Jean-Marc Lasgouttes wrote: > Le 23/11/2015 01:59, Uwe Stöhr a écrit : > >Am 23.11.2015 um 00:07 schrieb Scott Kostyshak: > > > >>I wish I had the knowledge to review the patch but I do not > > > >I don't understand why. It is a simple decision if we want s

Re: simple [patch] support for verbatim*

2015-11-23 Thread Jean-Marc Lasgouttes
Le 23/11/2015 01:59, Uwe Stöhr a écrit : Am 23.11.2015 um 00:07 schrieb Scott Kostyshak: I wish I had the knowledge to review the patch but I do not I don't understand why. It is a simple decision if we want support for the verbatim* environment in LyX or not. This environment is in basic LaT

Re: simple [patch] support for verbatim*

2015-11-22 Thread Uwe Stöhr
Am 20.11.2015 um 19:00 schrieb Scott Kostyshak: Yes, it will be a fileformat change. When I commit I of course do this. It would be nice if you always try to post complete patches. It is not obvious to others what "of course" you will change. It is easy to make a typo or mistake and not notice

Re: simple [patch] support for verbatim*

2015-11-22 Thread Uwe Stöhr
Am 23.11.2015 um 00:07 schrieb Scott Kostyshak: I wish I had the knowledge to review the patch but I do not I don't understand why. It is a simple decision if we want support for the verbatim* environment in LyX or not. This environment is in basic LaTeX like verbatim. I am not inventing any

Re: simple [patch] support for verbatim*

2015-11-22 Thread Scott Kostyshak
On Sun, Nov 22, 2015 at 06:30:37PM +0100, Uwe Stöhr wrote: > Am 20.11.2015 um 00:20 schrieb Uwe Stöhr: > > >OK to go in... > > No opinions? I wish I had the knowledge to review the patch but I do not (and even if I did I would still prefer you post the complete patch you plan on committing, as I

Re: simple [patch] support for verbatim*

2015-11-22 Thread Uwe Stöhr
Am 20.11.2015 um 00:20 schrieb Uwe Stöhr: OK to go in... No opinions? regards Uwe

Re: simple [patch] support for verbatim*

2015-11-20 Thread Scott Kostyshak
On Fri, Nov 20, 2015 at 12:33:15AM +0100, Uwe Stöhr wrote: > Am 20.11.2015 um 00:25 schrieb Richard Heck: > > >On 11/19/2015 06:20 PM, Uwe Stöhr wrote: > >What is the difference between verbatim and verbatim*? > > The only difference is that every space in verbatim* is output as visible > space.

Re: simple [patch] support for verbatim*

2015-11-19 Thread Uwe Stöhr
Am 20.11.2015 um 00:25 schrieb Richard Heck: On 11/19/2015 06:20 PM, Uwe Stöhr wrote: What is the difference between verbatim and verbatim*? The only difference is that every space in verbatim* is output as visible space. The effect is the same as if you use the "space as symbol" option in l

Re: simple [patch] support for verbatim*

2015-11-19 Thread Richard Heck
On 11/19/2015 06:20 PM, Uwe Stöhr wrote: > Attached is a simple patch that adds support for the verbatim* > environment. Simple, because we already have all we need, even the > lyx2lyx routine (I took it from LyX 2.1) > > When we implemented support for verbatim, I simply forgot that there > is als

simple [patch] support for verbatim*

2015-11-19 Thread Uwe Stöhr
Attached is a simple patch that adds support for the verbatim* environment. Simple, because we already have all we need, even the lyx2lyx routine (I took it from LyX 2.1) When we implemented support for verbatim, I simply forgot that there is also a starred version: http://www.lyx.org/trac/ti