Re: Instructions for creating patches

2018-05-06 Thread Ken Cunningham
Yeah, I suppose a more accurate phrase there would have been "in the index". Thanks. K Sent from my iPhone > On May 5, 2018, at 3:32 PM, G A wrote: > > step 5 is misleading and technically incorrect. a clone is a clone, > exact copy, there is only one repo. > > unless they have credentials, t

Re: Instructions for creating patches

2018-05-06 Thread Ryan Schmidt
On May 4, 2018, at 17:33, Rainer Müller wrote: > On 2018-05-03 09:14, Zero King wrote: >> On Thu, May 03, 2018 at 08:51:49AM +0200, Mojca Miklavec wrote: >>> On 1 May 2018 at 16:11, Rainer Müller wrote: The guide uses "Portfile-rrdtool.diff" as an example filename [1]. Some users

Re: Instructions for creating patches

2018-05-05 Thread G A
step 5 is misleading and technically incorrect. a clone is a clone, exact copy, there is only one repo. unless they have credentials, they will not be able to push changes back to the master/origin even if they choose not to branch and work on master it should say something like build your branch

Re: Instructions for creating patches

2018-05-05 Thread Ken Cunningham
> On May 4, 2018, at 3:33 PM, Rainer Müller wrote: > > > Maybe the instructions on how to create a local ports tree should come > first and then the next section should show how to create a diff against > the official ports tree? > > Instructions on how to create a pull request would overlap

Re: Instructions for creating patches

2018-05-04 Thread Rainer Müller
On 2018-05-03 09:14, Zero King wrote: > On Thu, May 03, 2018 at 08:51:49AM +0200, Mojca Miklavec wrote: >> On 1 May 2018 at 16:11, Rainer Müller wrote: >>> >>> The guide uses "Portfile-rrdtool.diff" as an example filename [1]. Some >>> users seem to take that literally and submit patches with that

Re: Instructions for creating patches (Re: trac rrdtool)

2018-05-03 Thread Zero King
On Thu, May 03, 2018 at 08:51:49AM +0200, Mojca Miklavec wrote: On 1 May 2018 at 16:11, Rainer Müller wrote: The guide uses "Portfile-rrdtool.diff" as an example filename [1]. Some users seem to take that literally and submit patches with that name. [1] https://guide.macports.org/#development.

Instructions for creating patches (Re: trac rrdtool)

2018-05-02 Thread Mojca Miklavec
On 1 May 2018 at 16:11, Rainer Müller wrote: > > The guide uses "Portfile-rrdtool.diff" as an example filename [1]. Some > users seem to take that literally and submit patches with that name. > > [1] https://guide.macports.org/#development.patches.portfile Looking at this part of the guide, I woul